)]}'
{"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c486719be33bf1d93c71b9c0b48ae748e2cbbeb0","unresolved":false,"context_lines":[{"line_number":364,"context_line":"            self.disable_dhcp_helper(network.id)"},{"line_number":365,"context_line":"            return"},{"line_number":366,"context_line":"        # NOTE(kevinbenton): we don\u0027t exclude dhcp disabled subnets because"},{"line_number":367,"context_line":"        # they still change the indexes used for tags"},{"line_number":368,"context_line":"        old_non_local_subnets \u003d getattr(old_network, \u0027non_local_subnets\u0027, [])"},{"line_number":369,"context_line":"        new_non_local_subnets \u003d getattr(network, \u0027non_local_subnets\u0027, [])"},{"line_number":370,"context_line":"        old_cidrs \u003d [s.cidr for s in (old_network.subnets +"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4e67ed24","line":367,"updated":"2018-12-03 22:02:49.000000000","message":"This note was added when this bug was fixed:\n\nhttps://bugs.launchpad.net/neutron/+bug/1581918\n\nThis change will un-do that, so something else will have to be done.","commit_id":"752a051ec6eac17845dd999b1cfe7b0e6b030e11"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"494281be777e28553687482fac76d46b8e3ae53e","unresolved":false,"context_lines":[{"line_number":364,"context_line":"            self.disable_dhcp_helper(network.id)"},{"line_number":365,"context_line":"            return"},{"line_number":366,"context_line":"        # NOTE(kevinbenton): we don\u0027t exclude dhcp disabled subnets because"},{"line_number":367,"context_line":"        # they still change the indexes used for tags"},{"line_number":368,"context_line":"        old_non_local_subnets \u003d getattr(old_network, \u0027non_local_subnets\u0027, [])"},{"line_number":369,"context_line":"        new_non_local_subnets \u003d getattr(network, \u0027non_local_subnets\u0027, [])"},{"line_number":370,"context_line":"        old_cidrs \u003d [s.cidr for s in (old_network.subnets +"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_cbdd246f","line":367,"in_reply_to":"3f79a3b5_4e67ed24","updated":"2018-12-04 07:20:59.000000000","message":"I read the bug and its fixed patch. For current code, In the subsequent processing, whether generate ‘dnsmasp cmdline’ or generate ‘opts file’, the subnets for which enable_dhcp is False will be excluded. And in my patch, the dhcp helper will be restart as long as the enable_dhcp of subnet has changed. So, I think current code won\u0027t result in the mix about dhcp opt tag.\nI think we just need to delete the note.","commit_id":"752a051ec6eac17845dd999b1cfe7b0e6b030e11"}]}