)]}'
{"neutron/tests/fullstack/test_l3_agent.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"5ee0a2f4c61b134b47aceb308f5821f180221347","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _test_gateway_ip_changed(self):"},{"line_number":84,"context_line":"        tenant_id \u003d uuidutils.generate_uuid()"},{"line_number":85,"context_line":"        ext_net, ext_sub \u003d self._create_external_network_and_subnet(tenant_id)"},{"line_number":86,"context_line":"        external_vm \u003d self.useFixture("},{"line_number":87,"context_line":"            machine_fixtures.FakeMachine("},{"line_number":88,"context_line":"                self.environment.central_bridge,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d86df868","line":85,"range":{"start_line":85,"start_character":32,"end_line":85,"end_character":67},"updated":"2018-12-16 12:37:10.000000000","message":"Or we use another CIDR for this case?","commit_id":"3a772e465d2874bfe3525269af3ced5b2c0007e4"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"e69529eb3b069aa028e0aba57dd06208e42fad6c","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _test_gateway_ip_changed(self):"},{"line_number":84,"context_line":"        tenant_id \u003d uuidutils.generate_uuid()"},{"line_number":85,"context_line":"        ext_net, ext_sub \u003d self._create_external_network_and_subnet(tenant_id)"},{"line_number":86,"context_line":"        external_vm \u003d self.useFixture("},{"line_number":87,"context_line":"            machine_fixtures.FakeMachine("},{"line_number":88,"context_line":"                self.environment.central_bridge,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0b60ce0b","line":85,"range":{"start_line":85,"start_character":32,"end_line":85,"end_character":67},"in_reply_to":"3f79a3b5_4d9a6161","updated":"2018-12-18 18:32:00.000000000","message":"It seems what \u0027_create_external_network_and_subnet\u0027 does is to create a new network and subnet? I can change the CIDR of the subnet but I am not sure how it will help to resolve the IP collision problem. You want to explain the idea further?","commit_id":"3a772e465d2874bfe3525269af3ced5b2c0007e4"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"8fdd6cd696e5b157144d4cbf1463e00de872e3a8","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _test_gateway_ip_changed(self):"},{"line_number":84,"context_line":"        tenant_id \u003d uuidutils.generate_uuid()"},{"line_number":85,"context_line":"        ext_net, ext_sub \u003d self._create_external_network_and_subnet(tenant_id)"},{"line_number":86,"context_line":"        external_vm \u003d self.useFixture("},{"line_number":87,"context_line":"            machine_fixtures.FakeMachine("},{"line_number":88,"context_line":"                self.environment.central_bridge,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ec4d8470","line":85,"range":{"start_line":85,"start_character":32,"end_line":85,"end_character":67},"in_reply_to":"3f79a3b5_d86df868","updated":"2018-12-17 20:11:21.000000000","message":"Sorry, I don\u0027t quite understand your suggestion. Could you elaborate?","commit_id":"3a772e465d2874bfe3525269af3ced5b2c0007e4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"272f531cbad17c1fcd26bccf956058493b515f16","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _test_gateway_ip_changed(self):"},{"line_number":84,"context_line":"        tenant_id \u003d uuidutils.generate_uuid()"},{"line_number":85,"context_line":"        ext_net, ext_sub \u003d self._create_external_network_and_subnet(tenant_id)"},{"line_number":86,"context_line":"        external_vm \u003d self.useFixture("},{"line_number":87,"context_line":"            machine_fixtures.FakeMachine("},{"line_number":88,"context_line":"                self.environment.central_bridge,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4d9a6161","line":85,"range":{"start_line":85,"start_character":32,"end_line":85,"end_character":67},"in_reply_to":"3f79a3b5_ec4d8470","updated":"2018-12-18 14:29:42.000000000","message":"I mean create a new subnet for this test case to avoid IP collision.","commit_id":"3a772e465d2874bfe3525269af3ced5b2c0007e4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"5ee0a2f4c61b134b47aceb308f5821f180221347","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            device_owner\u003dconstants.DEVICE_OWNER_ROUTER_GW)[0]"},{"line_number":113,"context_line":"        for attempt in (1, 2, 3):"},{"line_number":114,"context_line":"            ip_1 \u003d str(netaddr.IPNetwork("},{"line_number":115,"context_line":"                ext_sub[\u0027gateway_ip\u0027]).next(50 * attempt)).split(\u0027/\u0027)[0]"},{"line_number":116,"context_line":"            ip_2 \u003d str(netaddr.IPNetwork("},{"line_number":117,"context_line":"                ext_sub[\u0027gateway_ip\u0027]).next(51 * attempt)).split(\u0027/\u0027)[0]"},{"line_number":118,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_787dc41b","line":115,"range":{"start_line":115,"start_character":44,"end_line":115,"end_character":56},"updated":"2018-12-16 12:37:10.000000000","message":"What about random range here from 50 - 100, and next line 100 - 150?","commit_id":"3a772e465d2874bfe3525269af3ced5b2c0007e4"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"8fdd6cd696e5b157144d4cbf1463e00de872e3a8","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            device_owner\u003dconstants.DEVICE_OWNER_ROUTER_GW)[0]"},{"line_number":113,"context_line":"        for attempt in (1, 2, 3):"},{"line_number":114,"context_line":"            ip_1 \u003d str(netaddr.IPNetwork("},{"line_number":115,"context_line":"                ext_sub[\u0027gateway_ip\u0027]).next(50 * attempt)).split(\u0027/\u0027)[0]"},{"line_number":116,"context_line":"            ip_2 \u003d str(netaddr.IPNetwork("},{"line_number":117,"context_line":"                ext_sub[\u0027gateway_ip\u0027]).next(51 * attempt)).split(\u0027/\u0027)[0]"},{"line_number":118,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4c7038a7","line":115,"range":{"start_line":115,"start_character":44,"end_line":115,"end_character":56},"in_reply_to":"3f79a3b5_787dc41b","updated":"2018-12-17 20:11:21.000000000","message":"Done. Use a similar approach as you suggested.","commit_id":"3a772e465d2874bfe3525269af3ced5b2c0007e4"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"64af3175005a9d9cadedab6204889f7fcfe775d8","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            device_id\u003drouter[\u0027id\u0027],"},{"line_number":112,"context_line":"            device_owner\u003dconstants.DEVICE_OWNER_ROUTER_GW)[0]"},{"line_number":113,"context_line":"        for attempt in (1, 2, 3):"},{"line_number":114,"context_line":"            ip_1 \u003d str(netaddr.IPNetwork("},{"line_number":115,"context_line":"                ext_sub[\u0027gateway_ip\u0027]).next(50 * attempt)).split(\u0027/\u0027)[0]"},{"line_number":116,"context_line":"            ip_2 \u003d str(netaddr.IPNetwork("},{"line_number":117,"context_line":"                ext_sub[\u0027gateway_ip\u0027]).next(51 * attempt)).split(\u0027/\u0027)[0]"},{"line_number":118,"context_line":"            try:"},{"line_number":119,"context_line":"                LOG.debug(\"Attempt (%s) to update port IP address\", attempt)"},{"line_number":120,"context_line":"                self.safe_client.update_port(gateway_port[\u0027id\u0027], fixed_ips\u003d["}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f7a48808","line":117,"range":{"start_line":114,"start_character":11,"end_line":117,"end_character":71},"updated":"2018-12-15 01:15:34.000000000","message":"so what ip_1 is a success in first iteration and ip_2 is a failure ? so in next iteration it will again overwrite ip_1 even though it succeeded last time ?","commit_id":"3a772e465d2874bfe3525269af3ced5b2c0007e4"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"f43ba6647b4dd18154433ec0f6768a6031f6c47b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            device_id\u003drouter[\u0027id\u0027],"},{"line_number":112,"context_line":"            device_owner\u003dconstants.DEVICE_OWNER_ROUTER_GW)[0]"},{"line_number":113,"context_line":"        for attempt in (1, 2, 3):"},{"line_number":114,"context_line":"            ip_1 \u003d str(netaddr.IPNetwork("},{"line_number":115,"context_line":"                ext_sub[\u0027gateway_ip\u0027]).next(50 * attempt)).split(\u0027/\u0027)[0]"},{"line_number":116,"context_line":"            ip_2 \u003d str(netaddr.IPNetwork("},{"line_number":117,"context_line":"                ext_sub[\u0027gateway_ip\u0027]).next(51 * attempt)).split(\u0027/\u0027)[0]"},{"line_number":118,"context_line":"            try:"},{"line_number":119,"context_line":"                LOG.debug(\"Attempt (%s) to update port IP address\", attempt)"},{"line_number":120,"context_line":"                self.safe_client.update_port(gateway_port[\u0027id\u0027], fixed_ips\u003d["}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_6ea95024","line":117,"range":{"start_line":114,"start_character":11,"end_line":117,"end_character":71},"in_reply_to":"3f79a3b5_2c929cad","updated":"2018-12-18 19:22:04.000000000","message":"why not decouple ip_1 and ip2 calculations then ? so that overwriting and recalculations can be avoided if ip_1 is a success ?","commit_id":"3a772e465d2874bfe3525269af3ced5b2c0007e4"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"8fdd6cd696e5b157144d4cbf1463e00de872e3a8","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            device_id\u003drouter[\u0027id\u0027],"},{"line_number":112,"context_line":"            device_owner\u003dconstants.DEVICE_OWNER_ROUTER_GW)[0]"},{"line_number":113,"context_line":"        for attempt in (1, 2, 3):"},{"line_number":114,"context_line":"            ip_1 \u003d str(netaddr.IPNetwork("},{"line_number":115,"context_line":"                ext_sub[\u0027gateway_ip\u0027]).next(50 * attempt)).split(\u0027/\u0027)[0]"},{"line_number":116,"context_line":"            ip_2 \u003d str(netaddr.IPNetwork("},{"line_number":117,"context_line":"                ext_sub[\u0027gateway_ip\u0027]).next(51 * attempt)).split(\u0027/\u0027)[0]"},{"line_number":118,"context_line":"            try:"},{"line_number":119,"context_line":"                LOG.debug(\"Attempt (%s) to update port IP address\", attempt)"},{"line_number":120,"context_line":"                self.safe_client.update_port(gateway_port[\u0027id\u0027], fixed_ips\u003d["}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_2c929cad","line":117,"range":{"start_line":114,"start_character":11,"end_line":117,"end_character":71},"in_reply_to":"3f79a3b5_f7a48808","updated":"2018-12-17 20:11:21.000000000","message":"Yes. This approach is not optimized but I think it is good enough for testing.","commit_id":"3a772e465d2874bfe3525269af3ced5b2c0007e4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"963ca1d5231ba834d07d64a3380bc1427259813b","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        for attempt in (1, 2, 3):"},{"line_number":115,"context_line":"            step \u003d random.randint(1, 50 * attempt)"},{"line_number":116,"context_line":"            ip_1 \u003d str(netaddr.IPNetwork("},{"line_number":117,"context_line":"                ext_sub[\u0027gateway_ip\u0027]).next(step)).split(\u0027/\u0027)[0]"},{"line_number":118,"context_line":"            ip_2 \u003d str(netaddr.IPNetwork("},{"line_number":119,"context_line":"                ext_sub[\u0027gateway_ip\u0027]).next(step + 1)).split(\u0027/\u0027)[0]"},{"line_number":120,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_1482fe4b","line":117,"range":{"start_line":117,"start_character":44,"end_line":117,"end_character":48},"updated":"2018-12-20 14:26:21.000000000","message":"After some log search, IMO the root cause of this collision is because of this:\nhttps://review.openstack.org/#/c/592164/16/neutron/ipam/drivers/neutrondb_ipam/driver.py@185\n\nBefore this, the IP range of allocation is about 30. So I gave next 100 and 101 IP address. But now the floating IP address will be allocated totally random among the entire CIDR IPs. So we can still meet the IP collision here.","commit_id":"0863b85b0368f98acc798eee7e69b4b3fc99ce59"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"1eb4ce665d8630786cd19f5f8195be70881ac7c2","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        for attempt in (1, 2, 3):"},{"line_number":115,"context_line":"            step \u003d random.randint(1, 50 * attempt)"},{"line_number":116,"context_line":"            ip_1 \u003d str(netaddr.IPNetwork("},{"line_number":117,"context_line":"                ext_sub[\u0027gateway_ip\u0027]).next(step)).split(\u0027/\u0027)[0]"},{"line_number":118,"context_line":"            ip_2 \u003d str(netaddr.IPNetwork("},{"line_number":119,"context_line":"                ext_sub[\u0027gateway_ip\u0027]).next(step + 1)).split(\u0027/\u0027)[0]"},{"line_number":120,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_17643d4d","line":117,"range":{"start_line":117,"start_character":44,"end_line":117,"end_character":48},"in_reply_to":"3f79a3b5_1482fe4b","updated":"2018-12-20 17:59:20.000000000","message":"ACK","commit_id":"0863b85b0368f98acc798eee7e69b4b3fc99ce59"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"963ca1d5231ba834d07d64a3380bc1427259813b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            ip_1 \u003d str(netaddr.IPNetwork("},{"line_number":117,"context_line":"                ext_sub[\u0027gateway_ip\u0027]).next(step)).split(\u0027/\u0027)[0]"},{"line_number":118,"context_line":"            ip_2 \u003d str(netaddr.IPNetwork("},{"line_number":119,"context_line":"                ext_sub[\u0027gateway_ip\u0027]).next(step + 1)).split(\u0027/\u0027)[0]"},{"line_number":120,"context_line":"            try:"},{"line_number":121,"context_line":"                LOG.debug(\"Attempt (%s) to update port IP address\", attempt)"},{"line_number":122,"context_line":"                self.safe_client.update_port(gateway_port[\u0027id\u0027], fixed_ips\u003d["}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_f447421b","line":119,"range":{"start_line":119,"start_character":44,"end_line":119,"end_character":52},"updated":"2018-12-20 14:26:21.000000000","message":"ditto","commit_id":"0863b85b0368f98acc798eee7e69b4b3fc99ce59"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"321c98e2a5175694bb456c5a84cfac6aeb7f00af","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            except exceptions.IpAddressAlreadyAllocatedClient:"},{"line_number":127,"context_line":"                LOG.debug(\"The IP address(es) are already allocated\")"},{"line_number":128,"context_line":"        else:"},{"line_number":129,"context_line":"            self.fail(\"Cannot find IP addresses for updating the port\")"},{"line_number":130,"context_line":"        # ping router gateway new IPs"},{"line_number":131,"context_line":"        external_vm.block_until_ping(ip_1)"},{"line_number":132,"context_line":"        external_vm.block_until_ping(ip_2)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_3a64cb4d","line":129,"updated":"2018-12-20 09:31:31.000000000","message":"this ext_sub is used only in this one test so I think that it can be only allocated for DHCP port (if it\u0027s enabled in this case) or for FIP which is created in L101.\nIf so, I think that You could be more \"deterministic\" here and for example list ports from this network and simply find IP address which isn\u0027t used yet.","commit_id":"0863b85b0368f98acc798eee7e69b4b3fc99ce59"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"1eb4ce665d8630786cd19f5f8195be70881ac7c2","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            except exceptions.IpAddressAlreadyAllocatedClient:"},{"line_number":127,"context_line":"                LOG.debug(\"The IP address(es) are already allocated\")"},{"line_number":128,"context_line":"        else:"},{"line_number":129,"context_line":"            self.fail(\"Cannot find IP addresses for updating the port\")"},{"line_number":130,"context_line":"        # ping router gateway new IPs"},{"line_number":131,"context_line":"        external_vm.block_until_ping(ip_1)"},{"line_number":132,"context_line":"        external_vm.block_until_ping(ip_2)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_174d1dc5","line":129,"in_reply_to":"3f79a3b5_34429a0f","updated":"2018-12-20 17:59:20.000000000","message":"I took Slawek\u0027s approach because it looks feasible to implement.","commit_id":"0863b85b0368f98acc798eee7e69b4b3fc99ce59"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"1eb4ce665d8630786cd19f5f8195be70881ac7c2","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            except exceptions.IpAddressAlreadyAllocatedClient:"},{"line_number":127,"context_line":"                LOG.debug(\"The IP address(es) are already allocated\")"},{"line_number":128,"context_line":"        else:"},{"line_number":129,"context_line":"            self.fail(\"Cannot find IP addresses for updating the port\")"},{"line_number":130,"context_line":"        # ping router gateway new IPs"},{"line_number":131,"context_line":"        external_vm.block_until_ping(ip_1)"},{"line_number":132,"context_line":"        external_vm.block_until_ping(ip_2)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_d769e523","line":129,"in_reply_to":"3f79a3b5_3a64cb4d","updated":"2018-12-20 17:59:20.000000000","message":"Done","commit_id":"0863b85b0368f98acc798eee7e69b4b3fc99ce59"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"963ca1d5231ba834d07d64a3380bc1427259813b","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            except exceptions.IpAddressAlreadyAllocatedClient:"},{"line_number":127,"context_line":"                LOG.debug(\"The IP address(es) are already allocated\")"},{"line_number":128,"context_line":"        else:"},{"line_number":129,"context_line":"            self.fail(\"Cannot find IP addresses for updating the port\")"},{"line_number":130,"context_line":"        # ping router gateway new IPs"},{"line_number":131,"context_line":"        external_vm.block_until_ping(ip_1)"},{"line_number":132,"context_line":"        external_vm.block_until_ping(ip_2)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_34429a0f","line":129,"in_reply_to":"3f79a3b5_3a64cb4d","updated":"2018-12-20 14:26:21.000000000","message":"Yes, this can be the right way. Or manually set one specific IP address for floating IP, and DHCP port now set the \u0027prefer_next\u0027 param, so we can set the IPs like this:\n1. old gateway IP 240.x.x.1\n2. DHCP port  240.x.x.2\n3. floating IP 240.x.x.3\n4. new gateway IPs 240.x.x.100, and 101","commit_id":"0863b85b0368f98acc798eee7e69b4b3fc99ce59"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"747ea9f4c773e5f9092a01514e17531c1cd84b26","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        # ping router old gateway IP, should fail now"},{"line_number":120,"context_line":"        external_vm.block_until_no_ping(old_gw_ip)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def _find_available_ips(self, network, subnet, num):"},{"line_number":123,"context_line":"        ports \u003d self.safe_client.list_ports(network_id\u003dnetwork[\u0027id\u0027])"},{"line_number":124,"context_line":"        used_ips \u003d [fip[\u0027ip_address\u0027]"},{"line_number":125,"context_line":"                    for port in ports for fip in port[\u0027fixed_ips\u0027]]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_ab33a4c2","line":122,"updated":"2018-12-20 21:00:33.000000000","message":"maybe it would be worth to move this method to base.BaseFullStackTestCase as it could be reused in other tests later. What You think about it?","commit_id":"3c2a146aaaa588cd7fb4bfa7ca9c560c3f770632"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"3bf0462f34bf08224607603a91de1700bbf81dbf","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        # ping router old gateway IP, should fail now"},{"line_number":120,"context_line":"        external_vm.block_until_no_ping(old_gw_ip)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def _find_available_ips(self, network, subnet, num):"},{"line_number":123,"context_line":"        ports \u003d self.safe_client.list_ports(network_id\u003dnetwork[\u0027id\u0027])"},{"line_number":124,"context_line":"        used_ips \u003d [fip[\u0027ip_address\u0027]"},{"line_number":125,"context_line":"                    for port in ports for fip in port[\u0027fixed_ips\u0027]]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_783f8eb2","line":122,"in_reply_to":"3f79a3b5_ab33a4c2","updated":"2018-12-21 16:37:59.000000000","message":"Done","commit_id":"3c2a146aaaa588cd7fb4bfa7ca9c560c3f770632"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e84b45aebed660579a416340c13715a29e57fddf","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    def _find_available_ips(self, network, subnet, num):"},{"line_number":123,"context_line":"        ports \u003d self.safe_client.list_ports(network_id\u003dnetwork[\u0027id\u0027])"},{"line_number":124,"context_line":"        used_ips \u003d [fip[\u0027ip_address\u0027]"},{"line_number":125,"context_line":"                    for port in ports for fip in port[\u0027fixed_ips\u0027]]"},{"line_number":126,"context_line":"        used_ips.append(subnet[\u0027gateway_ip\u0027])"},{"line_number":127,"context_line":"        available_ips \u003d []"},{"line_number":128,"context_line":"        for ip in netaddr.IPNetwork(subnet[\u0027cidr\u0027]).iter_hosts():"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_a68d1237","line":125,"range":{"start_line":125,"start_character":42,"end_line":125,"end_character":45},"updated":"2018-12-21 08:08:03.000000000","message":"nit: \"fip\" is usually used as abbrev of floating IP, so \"ip\" or other words would be better.","commit_id":"3c2a146aaaa588cd7fb4bfa7ca9c560c3f770632"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"3bf0462f34bf08224607603a91de1700bbf81dbf","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    def _find_available_ips(self, network, subnet, num):"},{"line_number":123,"context_line":"        ports \u003d self.safe_client.list_ports(network_id\u003dnetwork[\u0027id\u0027])"},{"line_number":124,"context_line":"        used_ips \u003d [fip[\u0027ip_address\u0027]"},{"line_number":125,"context_line":"                    for port in ports for fip in port[\u0027fixed_ips\u0027]]"},{"line_number":126,"context_line":"        used_ips.append(subnet[\u0027gateway_ip\u0027])"},{"line_number":127,"context_line":"        available_ips \u003d []"},{"line_number":128,"context_line":"        for ip in netaddr.IPNetwork(subnet[\u0027cidr\u0027]).iter_hosts():"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_983aaabf","line":125,"range":{"start_line":125,"start_character":42,"end_line":125,"end_character":45},"in_reply_to":"3f79a3b5_a68d1237","updated":"2018-12-21 16:37:59.000000000","message":"Done","commit_id":"3c2a146aaaa588cd7fb4bfa7ca9c560c3f770632"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"747ea9f4c773e5f9092a01514e17531c1cd84b26","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            if ip not in used_ips:"},{"line_number":131,"context_line":"                available_ips.append(ip)"},{"line_number":132,"context_line":"                if len(available_ips) \u003e\u003d num:"},{"line_number":133,"context_line":"                    break"},{"line_number":134,"context_line":"        else:"},{"line_number":135,"context_line":"            self.fail(\"Cannot find enough free IP addresses.\")"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_4bbf70fe","line":133,"range":{"start_line":133,"start_character":20,"end_line":133,"end_character":25},"updated":"2018-12-20 21:00:33.000000000","message":"nit: You can do here simple \"return available_ips\" and then You wouldn\u0027t need \"else\" in L134","commit_id":"3c2a146aaaa588cd7fb4bfa7ca9c560c3f770632"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e84b45aebed660579a416340c13715a29e57fddf","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            if ip not in used_ips:"},{"line_number":131,"context_line":"                available_ips.append(ip)"},{"line_number":132,"context_line":"                if len(available_ips) \u003e\u003d num:"},{"line_number":133,"context_line":"                    break"},{"line_number":134,"context_line":"        else:"},{"line_number":135,"context_line":"            self.fail(\"Cannot find enough free IP addresses.\")"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_c6328e5b","line":133,"range":{"start_line":133,"start_character":20,"end_line":133,"end_character":25},"in_reply_to":"3f79a3b5_4bbf70fe","updated":"2018-12-21 08:08:03.000000000","message":"+1 it sounds simpler.\n\n  for ip in ....:\n    ip \u003d str(ip)\n    if ip in used_ips:\n      continue\n     available_ips.append(ip)\n     if len(available_ips) \u003e\u003d num:\n       return available_ips\n  self.fail(\"Cannot find enough free IP addresses.\")","commit_id":"3c2a146aaaa588cd7fb4bfa7ca9c560c3f770632"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"3bf0462f34bf08224607603a91de1700bbf81dbf","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            if ip not in used_ips:"},{"line_number":131,"context_line":"                available_ips.append(ip)"},{"line_number":132,"context_line":"                if len(available_ips) \u003e\u003d num:"},{"line_number":133,"context_line":"                    break"},{"line_number":134,"context_line":"        else:"},{"line_number":135,"context_line":"            self.fail(\"Cannot find enough free IP addresses.\")"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_5872d2b0","line":133,"range":{"start_line":133,"start_character":20,"end_line":133,"end_character":25},"in_reply_to":"3f79a3b5_4bbf70fe","updated":"2018-12-21 16:37:59.000000000","message":"Done","commit_id":"3c2a146aaaa588cd7fb4bfa7ca9c560c3f770632"}]}
