)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"6f39ab83a08ddd0f74aa6982449f28285e00e6e4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"prints output to stdout, lets use oslo_log logger to log"},{"line_number":11,"context_line":"all such commands."},{"line_number":12,"context_line":"This is needed to limit amount of output on stdout during"},{"line_number":13,"context_line":"functional tests running on python3.5."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I20327bd1d5f784e021e9e1f1cbba1ef654271bfb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_76a2a142","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":16},"updated":"2018-12-17 18:48:53.000000000","message":"So this patch is for optimizing the output for functional tests but I am not sure if it is still good for users who are using the CLI interactively. If all the warnings/messages/errors are removed from standard output, CLI users might miss some message which might be significant? I am not sure about that.","commit_id":"e9276c8f4d9003da0496856eb821693fd4c63a2b"}],"neutron/db/migration/cli.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"73e92d96f27fdff35bd52028c63d5b12f786e62f","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    project \u003d config.get_main_option(\u0027neutron_project\u0027)"},{"line_number":69,"context_line":"    if desc:"},{"line_number":70,"context_line":"        alembic_util.msg(_(\u0027Running %(cmd)s (%(desc)s) for %(project)s ...\u0027) %"},{"line_number":71,"context_line":"                         {\u0027cmd\u0027: cmd, \u0027desc\u0027: desc, \u0027project\u0027: project})"},{"line_number":72,"context_line":"    else:"},{"line_number":73,"context_line":"        alembic_util.msg(_(\u0027Running %(cmd)s for %(project)s ...\u0027) %"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_56e3e539","side":"PARENT","line":70,"range":{"start_line":70,"start_character":25,"end_line":70,"end_character":26},"updated":"2018-12-17 18:06:29.000000000","message":"It looks the translation is removed. Is it intentional?","commit_id":"17c6cf7abee08d4037c60cbbd171f925fdf4aa99"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"6f39ab83a08ddd0f74aa6982449f28285e00e6e4","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    project \u003d config.get_main_option(\u0027neutron_project\u0027)"},{"line_number":69,"context_line":"    if desc:"},{"line_number":70,"context_line":"        alembic_util.msg(_(\u0027Running %(cmd)s (%(desc)s) for %(project)s ...\u0027) %"},{"line_number":71,"context_line":"                         {\u0027cmd\u0027: cmd, \u0027desc\u0027: desc, \u0027project\u0027: project})"},{"line_number":72,"context_line":"    else:"},{"line_number":73,"context_line":"        alembic_util.msg(_(\u0027Running %(cmd)s for %(project)s ...\u0027) %"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d66855f2","side":"PARENT","line":70,"range":{"start_line":70,"start_character":25,"end_line":70,"end_character":26},"in_reply_to":"3f79a3b5_56e3e539","updated":"2018-12-17 18:48:53.000000000","message":"Never mind. If the message is printed to logging. It is not end-user facing and the translation should be removed.","commit_id":"17c6cf7abee08d4037c60cbbd171f925fdf4aa99"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"6f39ab83a08ddd0f74aa6982449f28285e00e6e4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"migration_cli.register_db_cli_opts(CONF)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def log_error(msg):"},{"line_number":67,"context_line":"    LOG.error(\"FAILED: %s\", msg)"},{"line_number":68,"context_line":"    sys.exit(-1)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f6631117","line":66,"range":{"start_line":66,"start_character":4,"end_line":66,"end_character":13},"updated":"2018-12-17 18:48:53.000000000","message":"I think the error message is critical enough so that we should print the message to stdout/stderr as well.","commit_id":"e9276c8f4d9003da0496856eb821693fd4c63a2b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2cbde5544ec5c95e43e878cdba495a4900119ddb","unresolved":false,"context_lines":[{"line_number":63,"context_line":"migration_cli.register_db_cli_opts(CONF)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def log_error(msg):"},{"line_number":67,"context_line":"    LOG.error(\"FAILED: %s\", msg)"},{"line_number":68,"context_line":"    sys.exit(-1)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_631e53be","line":66,"range":{"start_line":66,"start_character":4,"end_line":66,"end_character":13},"in_reply_to":"3f79a3b5_f6631117","updated":"2018-12-18 10:46:42.000000000","message":"You\u0027re right. I restored using alembic_util.err() for such messages.","commit_id":"e9276c8f4d9003da0496856eb821693fd4c63a2b"}]}