)]}'
{"neutron/tests/functional/base.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"85ec627fdc4dbb13b2eba4264dd6dade542f8c26","unresolved":false,"context_lines":[{"line_number":32,"context_line":"class BaseLoggingTestCase(base.BaseTestCase):"},{"line_number":33,"context_line":"    def setUp(self):"},{"line_number":34,"context_line":"        super(BaseLoggingTestCase, self).setUp()"},{"line_number":35,"context_line":"        warnings.simplefilter(\"ignore\")"},{"line_number":36,"context_line":"        base.setup_test_logging("},{"line_number":37,"context_line":"            cfg.CONF, DEFAULT_LOG_DIR, \"%s.txt\" % self.id())"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_cf8be520","line":35,"updated":"2018-12-17 13:25:03.000000000","message":"Let me ask you: if we have the tox env variable, isn\u0027t this line redundant? Do we need this filter?","commit_id":"d80589808cec6b111dd875d4131ab2e0961fb43e"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"4164cf2eb9ca460a099de79f3bbe79df25ede361","unresolved":false,"context_lines":[{"line_number":32,"context_line":"class BaseLoggingTestCase(base.BaseTestCase):"},{"line_number":33,"context_line":"    def setUp(self):"},{"line_number":34,"context_line":"        super(BaseLoggingTestCase, self).setUp()"},{"line_number":35,"context_line":"        warnings.simplefilter(\"ignore\")"},{"line_number":36,"context_line":"        base.setup_test_logging("},{"line_number":37,"context_line":"            cfg.CONF, DEFAULT_LOG_DIR, \"%s.txt\" % self.id())"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6f84110e","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":39},"updated":"2018-12-17 13:26:09.000000000","message":"May be worth adding the same comment as in tox.ini here?","commit_id":"d80589808cec6b111dd875d4131ab2e0961fb43e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"178ef34788d4e5ab43eb0b9547613187b05d9d27","unresolved":false,"context_lines":[{"line_number":32,"context_line":"class BaseLoggingTestCase(base.BaseTestCase):"},{"line_number":33,"context_line":"    def setUp(self):"},{"line_number":34,"context_line":"        super(BaseLoggingTestCase, self).setUp()"},{"line_number":35,"context_line":"        warnings.simplefilter(\"ignore\")"},{"line_number":36,"context_line":"        base.setup_test_logging("},{"line_number":37,"context_line":"            cfg.CONF, DEFAULT_LOG_DIR, \"%s.txt\" % self.id())"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f29ebab4","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":39},"in_reply_to":"3f79a3b5_6f84110e","updated":"2018-12-17 20:48:35.000000000","message":"Done","commit_id":"d80589808cec6b111dd875d4131ab2e0961fb43e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"178ef34788d4e5ab43eb0b9547613187b05d9d27","unresolved":false,"context_lines":[{"line_number":32,"context_line":"class BaseLoggingTestCase(base.BaseTestCase):"},{"line_number":33,"context_line":"    def setUp(self):"},{"line_number":34,"context_line":"        super(BaseLoggingTestCase, self).setUp()"},{"line_number":35,"context_line":"        warnings.simplefilter(\"ignore\")"},{"line_number":36,"context_line":"        base.setup_test_logging("},{"line_number":37,"context_line":"            cfg.CONF, DEFAULT_LOG_DIR, \"%s.txt\" % self.id())"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7a460d80","line":35,"in_reply_to":"3f79a3b5_cf8be520","updated":"2018-12-17 20:48:35.000000000","message":"I though that too but for some reason it isn\u0027t like that. Adding env variable in tox ini file disabled warnings which comes from test code directly, but this disabled warnings which comes from tested code, something like e.g.:\n\nCaptured stderr:\n~~~~~~~~~~~~~~~~\n    /opt/stack/neutron/.tox/dsvm-functional/local/lib/python2.7/site-packages/oslo_context/context.py:108: DeprecationWarning: Policy enforcement is depending on the value of tenant_id. This key is deprecated. Please update your policy file to use the standard policy values.\n      DeprecationWarning)","commit_id":"d80589808cec6b111dd875d4131ab2e0961fb43e"}],"tox.ini":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"85ec627fdc4dbb13b2eba4264dd6dade542f8c26","unresolved":false,"context_lines":[{"line_number":51,"context_line":"         OS_LOG_PATH\u003d{env:OS_LOG_PATH:/opt/stack/logs}"},{"line_number":52,"context_line":"# Because of issue with stestr and Python3, we need to avoid too much output"},{"line_number":53,"context_line":"# to be produced during tests, so we will ignore python warnings here"},{"line_number":54,"context_line":"        PYTHONWARNINGS\u003dignore"},{"line_number":55,"context_line":"deps \u003d"},{"line_number":56,"context_line":"  {[testenv]deps}"},{"line_number":57,"context_line":"  -r{toxinidir}/neutron/tests/functional/requirements.txt"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f79a3b5_8ff96dc7","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":9},"updated":"2018-12-17 13:25:03.000000000","message":"trivial nit: indent 1 char more","commit_id":"d80589808cec6b111dd875d4131ab2e0961fb43e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"178ef34788d4e5ab43eb0b9547613187b05d9d27","unresolved":false,"context_lines":[{"line_number":51,"context_line":"         OS_LOG_PATH\u003d{env:OS_LOG_PATH:/opt/stack/logs}"},{"line_number":52,"context_line":"# Because of issue with stestr and Python3, we need to avoid too much output"},{"line_number":53,"context_line":"# to be produced during tests, so we will ignore python warnings here"},{"line_number":54,"context_line":"        PYTHONWARNINGS\u003dignore"},{"line_number":55,"context_line":"deps \u003d"},{"line_number":56,"context_line":"  {[testenv]deps}"},{"line_number":57,"context_line":"  -r{toxinidir}/neutron/tests/functional/requirements.txt"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f79a3b5_52af6ee0","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":9},"in_reply_to":"3f79a3b5_8ff96dc7","updated":"2018-12-17 20:48:35.000000000","message":"done, thx for catching this :)","commit_id":"d80589808cec6b111dd875d4131ab2e0961fb43e"}]}