)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3e8340cd7bb5c71db38b452c3f7adbcc8ee497a4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"particular order of dependency. This patch just raises"},{"line_number":12,"context_line":"an exception during port forwarding plugin initiating."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related-Bug: #1809238"},{"line_number":15,"context_line":"Change-Id: I53fdaee0cd96a5315a7abc39799657d613eb3a2e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f769fc5_24bbbb0e","line":14,"updated":"2019-01-02 16:38:59.000000000","message":"This should be Closes-bug as it fixes the issue.","commit_id":"feb414eafdc987363743435dd0ef198c3186b4f4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"92d195544d5b7d07a4481e21f466dcaccce282a0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"particular order of dependency. This patch just raises"},{"line_number":12,"context_line":"an exception during port forwarding plugin initiating."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related-Bug: #1809238"},{"line_number":15,"context_line":"Change-Id: I53fdaee0cd96a5315a7abc39799657d613eb3a2e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ffd0ebdf_1be9877f","line":14,"in_reply_to":"1f769fc5_24bbbb0e","updated":"2019-01-03 15:29:12.000000000","message":"Done","commit_id":"feb414eafdc987363743435dd0ef198c3186b4f4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"74e254932d890654641a81fd3a9a2ab7ce7af7b9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add a required list \u0027required_service_plugin\u0027 to each service plugin,"},{"line_number":10,"context_line":"then we can initialize the service plugin require dependency."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1809238"},{"line_number":13,"context_line":"Change-Id: I53fdaee0cd96a5315a7abc39799657d613eb3a2e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bfdaf3ff_f34f918f","line":12,"updated":"2019-01-17 08:43:21.000000000","message":"IMO You should add to commit message that this patch also adds dependencies for port_forwarding service plugin because in fact this fixes mentioned bug :)","commit_id":"bf490af6b421d5001306b3c3bf98551f165c9c3e"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"319902f6838bc80f98240340bb2281e527e1c421","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add a required list \u0027required_service_plugin\u0027 to each service plugin,"},{"line_number":10,"context_line":"then we can initialize the service plugin require dependency."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1809238"},{"line_number":13,"context_line":"Change-Id: I53fdaee0cd96a5315a7abc39799657d613eb3a2e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bfdaf3ff_36c5075c","line":12,"in_reply_to":"bfdaf3ff_f34f918f","updated":"2019-01-17 09:13:02.000000000","message":"Done","commit_id":"bf490af6b421d5001306b3c3bf98551f165c9c3e"}],"neutron/manager.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"74e254932d890654641a81fd3a9a2ab7ce7af7b9","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            required_plugin \u003d getattr("},{"line_number":208,"context_line":"                plugin_class, \"required_service_plugin\", [])"},{"line_number":209,"context_line":"            for req_plugin in required_plugin:"},{"line_number":210,"context_line":"                self._create_and_add_service_plugin(req_plugin)"},{"line_number":211,"context_line":"            # NOTE(liuyulong): adding one plugin multiple times does not have"},{"line_number":212,"context_line":"            # bad effect for it. Since all the plugin has its own specific"},{"line_number":213,"context_line":"            # unique name."}],"source_content_type":"text/x-python","patch_set":7,"id":"bfdaf3ff_f33471fd","line":210,"updated":"2019-01-17 08:43:21.000000000","message":"So IIUC You will \"silently\" load all required plugins even if they aren\u0027t mentioned in config file.\nI don\u0027t think it is bad solution but IMHO You should at least add some log message about that (maybe WARNING level would be good)","commit_id":"bf490af6b421d5001306b3c3bf98551f165c9c3e"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"319902f6838bc80f98240340bb2281e527e1c421","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            required_plugin \u003d getattr("},{"line_number":208,"context_line":"                plugin_class, \"required_service_plugin\", [])"},{"line_number":209,"context_line":"            for req_plugin in required_plugin:"},{"line_number":210,"context_line":"                self._create_and_add_service_plugin(req_plugin)"},{"line_number":211,"context_line":"            # NOTE(liuyulong): adding one plugin multiple times does not have"},{"line_number":212,"context_line":"            # bad effect for it. Since all the plugin has its own specific"},{"line_number":213,"context_line":"            # unique name."}],"source_content_type":"text/x-python","patch_set":7,"id":"bfdaf3ff_d6d27b5c","line":210,"in_reply_to":"bfdaf3ff_f33471fd","updated":"2019-01-17 09:13:02.000000000","message":"Yes, we load one service plugin, here will load their required plugins first, event they are not in the config file.\n\nDone","commit_id":"bf490af6b421d5001306b3c3bf98551f165c9c3e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"32d78adc3551b427e36f54a14d7feceac72dbac6","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            LOG.info(\"Loading Plugin: %s\", provider)"},{"line_number":205,"context_line":"            plugin_class \u003d self._get_plugin_class("},{"line_number":206,"context_line":"                \u0027neutron.service_plugins\u0027, provider)"},{"line_number":207,"context_line":"            required_plugin \u003d getattr("},{"line_number":208,"context_line":"                plugin_class, \"required_service_plugins\", [])"},{"line_number":209,"context_line":"            for req_plugin in required_plugin:"},{"line_number":210,"context_line":"                LOG.warning(\"Loading service plugins %s, it is required by %s\","}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_f5183e76","line":207,"range":{"start_line":207,"start_character":12,"end_line":207,"end_character":27},"updated":"2019-01-21 09:12:48.000000000","message":"required_plugins","commit_id":"2afc60a91390bbc81b473d4efb75735cb9e0e062"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"12a4d31bdc9b1098c0b7cc3628f29318b7515af1","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            LOG.info(\"Loading Plugin: %s\", provider)"},{"line_number":205,"context_line":"            plugin_class \u003d self._get_plugin_class("},{"line_number":206,"context_line":"                \u0027neutron.service_plugins\u0027, provider)"},{"line_number":207,"context_line":"            required_plugin \u003d getattr("},{"line_number":208,"context_line":"                plugin_class, \"required_service_plugins\", [])"},{"line_number":209,"context_line":"            for req_plugin in required_plugin:"},{"line_number":210,"context_line":"                LOG.warning(\"Loading service plugins %s, it is required by %s\","}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_faa019a8","line":207,"range":{"start_line":207,"start_character":12,"end_line":207,"end_character":27},"in_reply_to":"9fdfeff1_f5183e76","updated":"2019-01-22 05:16:34.000000000","message":"Done","commit_id":"2afc60a91390bbc81b473d4efb75735cb9e0e062"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"32d78adc3551b427e36f54a14d7feceac72dbac6","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            required_plugin \u003d getattr("},{"line_number":208,"context_line":"                plugin_class, \"required_service_plugins\", [])"},{"line_number":209,"context_line":"            for req_plugin in required_plugin:"},{"line_number":210,"context_line":"                LOG.warning(\"Loading service plugins %s, it is required by %s\","},{"line_number":211,"context_line":"                            req_plugin, provider)"},{"line_number":212,"context_line":"                self._create_and_add_service_plugin(req_plugin)"},{"line_number":213,"context_line":"            # NOTE(liuyulong): adding one plugin multiple times does not have"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_0a04c116","line":210,"range":{"start_line":210,"start_character":45,"end_line":210,"end_character":52},"updated":"2019-01-21 09:12:48.000000000","message":"nit: singular for \"plugin\" is better IMHO\nAlso I think that You should log this warning only for plugins which were not configured by user. For plugins configured by user we don\u0027t need such warning.","commit_id":"2afc60a91390bbc81b473d4efb75735cb9e0e062"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"12a4d31bdc9b1098c0b7cc3628f29318b7515af1","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            required_plugin \u003d getattr("},{"line_number":208,"context_line":"                plugin_class, \"required_service_plugins\", [])"},{"line_number":209,"context_line":"            for req_plugin in required_plugin:"},{"line_number":210,"context_line":"                LOG.warning(\"Loading service plugins %s, it is required by %s\","},{"line_number":211,"context_line":"                            req_plugin, provider)"},{"line_number":212,"context_line":"                self._create_and_add_service_plugin(req_plugin)"},{"line_number":213,"context_line":"            # NOTE(liuyulong): adding one plugin multiple times does not have"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_1aa63dc3","line":210,"range":{"start_line":210,"start_character":45,"end_line":210,"end_character":52},"in_reply_to":"9fdfeff1_0a04c116","updated":"2019-01-22 05:16:34.000000000","message":"Done for change to \u0027plugin\u0027.","commit_id":"2afc60a91390bbc81b473d4efb75735cb9e0e062"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f0d509a77ec7c23c6e67da4a0c8952bc64513fbe","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            required_plugin \u003d getattr("},{"line_number":208,"context_line":"                plugin_class, \"required_service_plugins\", [])"},{"line_number":209,"context_line":"            for req_plugin in required_plugin:"},{"line_number":210,"context_line":"                LOG.warning(\"Loading service plugins %s, it is required by %s\","},{"line_number":211,"context_line":"                            req_plugin, provider)"},{"line_number":212,"context_line":"                self._create_and_add_service_plugin(req_plugin)"},{"line_number":213,"context_line":"            # NOTE(liuyulong): adding one plugin multiple times does not have"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_14c376ef","line":210,"range":{"start_line":210,"start_character":45,"end_line":210,"end_character":52},"in_reply_to":"9fdfeff1_0a04c116","updated":"2019-01-22 02:29:25.000000000","message":"Due to the vary configuration names, something like \u0027router\u0027 can be set  as \u0027neutron.services.l3_router.l3_router_plugin.L3RouterPlugin\u0027, \u0027qos\u0027 can be set as \u0027neutron.services.qos.qos_plugin.QoSPlugin. So here we need to translate the configration first, then we can check if the required_service_plugins is in the list or not. That costs too much for a LOG.","commit_id":"2afc60a91390bbc81b473d4efb75735cb9e0e062"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"32d78adc3551b427e36f54a14d7feceac72dbac6","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                self._create_and_add_service_plugin(req_plugin)"},{"line_number":213,"context_line":"            # NOTE(liuyulong): adding one plugin multiple times does not have"},{"line_number":214,"context_line":"            # bad effect for it. Since all the plugin has its own specific"},{"line_number":215,"context_line":"            # unique name."},{"line_number":216,"context_line":"            self._create_and_add_service_plugin(provider)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def _create_and_add_service_plugin(self, provider):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_153b82d1","line":215,"updated":"2019-01-21 09:12:48.000000000","message":"but do we need to add plugins multiple times? Maybe it\u0027s not necessary?","commit_id":"2afc60a91390bbc81b473d4efb75735cb9e0e062"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f0d509a77ec7c23c6e67da4a0c8952bc64513fbe","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                self._create_and_add_service_plugin(req_plugin)"},{"line_number":213,"context_line":"            # NOTE(liuyulong): adding one plugin multiple times does not have"},{"line_number":214,"context_line":"            # bad effect for it. Since all the plugin has its own specific"},{"line_number":215,"context_line":"            # unique name."},{"line_number":216,"context_line":"            self._create_and_add_service_plugin(provider)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def _create_and_add_service_plugin(self, provider):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_b46cea08","line":215,"in_reply_to":"9fdfeff1_153b82d1","updated":"2019-01-22 02:29:25.000000000","message":"This note is the answer : ). And this is the simple way to achive the purpose. But I can try to add a check to that _create_and_add_service_plugin function.","commit_id":"2afc60a91390bbc81b473d4efb75735cb9e0e062"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"93a850bb4ca0a98b8e325c87fda708b2ea38ab96","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"            # only one implementation of svc_type allowed"},{"line_number":207,"context_line":"            # specifying more than one plugin"},{"line_number":208,"context_line":"            # for the same type is a fatal exception"},{"line_number":209,"context_line":"            # TODO(armax): simplify this by moving the conditional into the"},{"line_number":210,"context_line":"            # directory itself."},{"line_number":211,"context_line":"            plugin_type \u003d plugin_inst.get_plugin_type()"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_2a3cf7bd","side":"PARENT","line":208,"updated":"2019-01-23 08:00:43.000000000","message":"why this comment was removed?","commit_id":"e788d294584add2407f601a46f90b08082cccc5f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8e6f3b32d3dc1caba2d82eaf36f443cdc624e498","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"            # only one implementation of svc_type allowed"},{"line_number":207,"context_line":"            # specifying more than one plugin"},{"line_number":208,"context_line":"            # for the same type is a fatal exception"},{"line_number":209,"context_line":"            # TODO(armax): simplify this by moving the conditional into the"},{"line_number":210,"context_line":"            # directory itself."},{"line_number":211,"context_line":"            plugin_type \u003d plugin_inst.get_plugin_type()"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_ea682f88","side":"PARENT","line":208,"in_reply_to":"9fdfeff1_2a3cf7bd","updated":"2019-01-23 08:19:30.000000000","message":"Since we removed that ValueError.","commit_id":"e788d294584add2407f601a46f90b08082cccc5f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"08ee28880ff9d06acf51763f9d6b0fa355166e91","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"            # only one implementation of svc_type allowed"},{"line_number":207,"context_line":"            # specifying more than one plugin"},{"line_number":208,"context_line":"            # for the same type is a fatal exception"},{"line_number":209,"context_line":"            # TODO(armax): simplify this by moving the conditional into the"},{"line_number":210,"context_line":"            # directory itself."},{"line_number":211,"context_line":"            plugin_type \u003d plugin_inst.get_plugin_type()"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_42b26de8","side":"PARENT","line":208,"in_reply_to":"9fdfeff1_4a35bb45","updated":"2019-01-24 08:27:05.000000000","message":"I\u0027m not sure about that. This exception was raised here for some reason :/ I think that people who are longer in this project need to take a look at it too.","commit_id":"e788d294584add2407f601a46f90b08082cccc5f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f4798f5519566d8e31e8ac1b57f17d94e9bb6e5b","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"            # only one implementation of svc_type allowed"},{"line_number":207,"context_line":"            # specifying more than one plugin"},{"line_number":208,"context_line":"            # for the same type is a fatal exception"},{"line_number":209,"context_line":"            # TODO(armax): simplify this by moving the conditional into the"},{"line_number":210,"context_line":"            # directory itself."},{"line_number":211,"context_line":"            plugin_type \u003d plugin_inst.get_plugin_type()"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_4a35bb45","side":"PARENT","line":208,"in_reply_to":"9fdfeff1_aae0e7cd","updated":"2019-01-23 08:37:12.000000000","message":"We will allow that now, but the last one take effect.","commit_id":"e788d294584add2407f601a46f90b08082cccc5f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cab9c6db3bb260ba6dac1dd0318a82790fd9eb95","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"            # only one implementation of svc_type allowed"},{"line_number":207,"context_line":"            # specifying more than one plugin"},{"line_number":208,"context_line":"            # for the same type is a fatal exception"},{"line_number":209,"context_line":"            # TODO(armax): simplify this by moving the conditional into the"},{"line_number":210,"context_line":"            # directory itself."},{"line_number":211,"context_line":"            plugin_type \u003d plugin_inst.get_plugin_type()"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_aae0e7cd","side":"PARENT","line":208,"in_reply_to":"9fdfeff1_ea682f88","updated":"2019-01-23 08:32:46.000000000","message":"ok, but why You removed this check? DO we now allow to have more than one service plugin for same service type? IMHO it shouldn\u0027t be like that, no?","commit_id":"e788d294584add2407f601a46f90b08082cccc5f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"93a850bb4ca0a98b8e325c87fda708b2ea38ab96","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            # specifying more than one plugin"},{"line_number":208,"context_line":"            # for the same type is a fatal exception"},{"line_number":209,"context_line":"            # TODO(armax): simplify this by moving the conditional into the"},{"line_number":210,"context_line":"            # directory itself."},{"line_number":211,"context_line":"            plugin_type \u003d plugin_inst.get_plugin_type()"},{"line_number":212,"context_line":"            if directory.get_plugin(plugin_type):"},{"line_number":213,"context_line":"                raise ValueError(_(\"Multiple plugins for service \""}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_0a6a53b2","side":"PARENT","line":210,"updated":"2019-01-23 08:00:43.000000000","message":"and this TODO?","commit_id":"e788d294584add2407f601a46f90b08082cccc5f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8e6f3b32d3dc1caba2d82eaf36f443cdc624e498","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            # specifying more than one plugin"},{"line_number":208,"context_line":"            # for the same type is a fatal exception"},{"line_number":209,"context_line":"            # TODO(armax): simplify this by moving the conditional into the"},{"line_number":210,"context_line":"            # directory itself."},{"line_number":211,"context_line":"            plugin_type \u003d plugin_inst.get_plugin_type()"},{"line_number":212,"context_line":"            if directory.get_plugin(plugin_type):"},{"line_number":213,"context_line":"                raise ValueError(_(\"Multiple plugins for service \""}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_8a05e3c4","side":"PARENT","line":210,"in_reply_to":"9fdfeff1_0a6a53b2","updated":"2019-01-23 08:19:30.000000000","message":"ditto","commit_id":"e788d294584add2407f601a46f90b08082cccc5f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"93a850bb4ca0a98b8e325c87fda708b2ea38ab96","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            required_plugins \u003d getattr("},{"line_number":208,"context_line":"                plugin_class, \"required_service_plugins\", [])"},{"line_number":209,"context_line":"            for req_plugin in required_plugins:"},{"line_number":210,"context_line":"                LOG.warning(\"Loading service plugin %s, it is required by %s\","},{"line_number":211,"context_line":"                            req_plugin, provider)"},{"line_number":212,"context_line":"                self._create_and_add_service_plugin(req_plugin)"},{"line_number":213,"context_line":"            # NOTE(liuyulong): adding one plugin multiple times does not have"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_6a0c3f3b","line":210,"range":{"start_line":210,"start_character":20,"end_line":210,"end_character":27},"updated":"2019-01-23 08:00:43.000000000","message":"according to You last comment in PS9, I agree that maybe it would be a bit too expensive to make such checks only for logging purpose. But I think that You should at least change log level to INFO now as it is just information about loaded plugins and it\u0027s not a warning.","commit_id":"88a418e32a79d4c2da67eccb5884129fb3912065"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c50e11b966f350d866aed9d258b4abaecb3f6881","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            required_plugins \u003d getattr("},{"line_number":208,"context_line":"                plugin_class, \"required_service_plugins\", [])"},{"line_number":209,"context_line":"            for req_plugin in required_plugins:"},{"line_number":210,"context_line":"                LOG.warning(\"Loading service plugin %s, it is required by %s\","},{"line_number":211,"context_line":"                            req_plugin, provider)"},{"line_number":212,"context_line":"                self._create_and_add_service_plugin(req_plugin)"},{"line_number":213,"context_line":"            # NOTE(liuyulong): adding one plugin multiple times does not have"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_905aed27","line":210,"range":{"start_line":210,"start_character":20,"end_line":210,"end_character":27},"in_reply_to":"9fdfeff1_6a0c3f3b","updated":"2019-01-23 14:47:24.000000000","message":"Done","commit_id":"88a418e32a79d4c2da67eccb5884129fb3912065"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"138cb890e1cb25c0fe2543cc320fd2109ea5a6da","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            # NOTE(liuyulong): adding one plugin multiple times does not have"},{"line_number":214,"context_line":"            # bad effect for it. Since all the plugin has its own specific"},{"line_number":215,"context_line":"            # unique name."},{"line_number":216,"context_line":"            self._create_and_add_service_plugin(provider)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def _create_and_add_service_plugin(self, provider):"},{"line_number":219,"context_line":"        plugin_inst \u003d self._get_plugin_instance(\u0027neutron.service_plugins\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9fdfeff1_c98aac62","line":216,"updated":"2019-02-13 17:32:28.000000000","message":"I know Slawek raised the issue of this changing from a ValueError to not, and I don\u0027t know enough of the history to say this is wrong.  And there is no history as it was this way when Neutron was created from Quantum.  I am surprised this was done here and not neutron-lib since it\u0027s not really enforceable otherwiser, for that reason maybe this is fine given we document it in the release note.","commit_id":"ffaf09540a4ddcf1ba8b49cda76c7ca834d54512"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6b765b303061ac943fda3df2130c541b889666e9","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            # NOTE(liuyulong): adding one plugin multiple times does not have"},{"line_number":214,"context_line":"            # bad effect for it. Since all the plugin has its own specific"},{"line_number":215,"context_line":"            # unique name."},{"line_number":216,"context_line":"            self._create_and_add_service_plugin(provider)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def _create_and_add_service_plugin(self, provider):"},{"line_number":219,"context_line":"        plugin_inst \u003d self._get_plugin_instance(\u0027neutron.service_plugins\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9fdfeff1_5024e10c","line":216,"in_reply_to":"9fdfeff1_c98aac62","updated":"2019-02-16 14:22:43.000000000","message":"Will add a release note.","commit_id":"ffaf09540a4ddcf1ba8b49cda76c7ca834d54512"}],"neutron/services/portforwarding/common/exceptions.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3e8340cd7bb5c71db38b452c3f7adbcc8ee497a4","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class L3RouterServicePluginRequired(n_exc.NeutronException):"},{"line_number":25,"context_line":"    message \u003d _(\"Error initiating Port Forwarding plugin, L3 router service \""},{"line_number":26,"context_line":"                \"plugin not set or \u0027port_forwarding\u0027 is set before \u0027router\u0027 \""},{"line_number":27,"context_line":"                \"in config.\")"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_57bf15fe","line":25,"range":{"start_line":25,"start_character":23,"end_line":25,"end_character":33},"updated":"2019-01-02 16:38:59.000000000","message":"s/initializing","commit_id":"9b5e63c257f0584ee0fa25b3f5f7b832bbed5922"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3e8340cd7bb5c71db38b452c3f7adbcc8ee497a4","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class L3RouterServicePluginRequired(n_exc.NeutronException):"},{"line_number":25,"context_line":"    message \u003d _(\"Error initiating Port Forwarding plugin, L3 router service \""},{"line_number":26,"context_line":"                \"plugin not set or \u0027port_forwarding\u0027 is set before \u0027router\u0027 \""},{"line_number":27,"context_line":"                \"in config.\")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class PortForwardingNotSupportFilterField(n_exc.BadRequest):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_04555fc6","line":27,"updated":"2019-01-02 16:38:59.000000000","message":"Just a nit here.  By \"in config\" you\u0027re talking about in the service plugin list in the config file correct?  Maybe add that bit of information.","commit_id":"feb414eafdc987363743435dd0ef198c3186b4f4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"92d195544d5b7d07a4481e21f466dcaccce282a0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class L3RouterServicePluginRequired(n_exc.NeutronException):"},{"line_number":25,"context_line":"    message \u003d _(\"Error initiating Port Forwarding plugin, L3 router service \""},{"line_number":26,"context_line":"                \"plugin not set or \u0027port_forwarding\u0027 is set before \u0027router\u0027 \""},{"line_number":27,"context_line":"                \"in config.\")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class PortForwardingNotSupportFilterField(n_exc.BadRequest):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffd0ebdf_3beecb88","line":27,"in_reply_to":"1f769fc5_04555fc6","updated":"2019-01-03 15:29:12.000000000","message":"Done","commit_id":"feb414eafdc987363743435dd0ef198c3186b4f4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d859f7e6c8325e40e5d3707d6f0e3330f869e5b0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class L3RouterServicePluginRequired(n_exc.NeutronException):"},{"line_number":25,"context_line":"    message \u003d _(\"Error initiating Port Forwarding plugin, L3 router service \""},{"line_number":26,"context_line":"                \"plugin not set or \u0027port_forwarding\u0027 is set before \u0027router\u0027 \""},{"line_number":27,"context_line":"                \"in \u0027service_plugins\u0027 list config.\")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class PortForwardingNotSupportFilterField(n_exc.BadRequest):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffd0ebdf_cceca3f5","line":27,"updated":"2019-01-03 09:33:32.000000000","message":"I\u0027m not sure if we should raise exception because of order of service plugins in config file. Maybe instead of doing so, we should add some mechanism of priorities for service plugins and sort them before loading?\nOr at least we should update our docs to say that order of loaded service plugins is important.","commit_id":"1b88a756f45aca61063a25b9a5f8b3927d4adf15"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ec7a5178b21635a7febe6b67eaa4cbf67d89d139","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class L3RouterServicePluginRequired(n_exc.NeutronException):"},{"line_number":25,"context_line":"    message \u003d _(\"Error initiating Port Forwarding plugin, L3 router service \""},{"line_number":26,"context_line":"                \"plugin not set or \u0027port_forwarding\u0027 is set before \u0027router\u0027 \""},{"line_number":27,"context_line":"                \"in \u0027service_plugins\u0027 list config.\")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class PortForwardingNotSupportFilterField(n_exc.BadRequest):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffd0ebdf_e8a86c78","line":27,"in_reply_to":"ffd0ebdf_08405035","updated":"2019-01-03 15:48:37.000000000","message":"Hi Liu, we talked about this in the l3 meeting just now.  We think the best solution would be to make this a generic message and document the ordering requirement.  Then separately work on an internal mechanism to better force an ordering for plugins that need it.  That design is TBD but could be made simple by maybe just having a list of ones that do require it like [\u0027router\u0027, \u0027port_forwarding\u0027] for now.  Does that sound good?","commit_id":"1b88a756f45aca61063a25b9a5f8b3927d4adf15"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"92d195544d5b7d07a4481e21f466dcaccce282a0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class L3RouterServicePluginRequired(n_exc.NeutronException):"},{"line_number":25,"context_line":"    message \u003d _(\"Error initiating Port Forwarding plugin, L3 router service \""},{"line_number":26,"context_line":"                \"plugin not set or \u0027port_forwarding\u0027 is set before \u0027router\u0027 \""},{"line_number":27,"context_line":"                \"in \u0027service_plugins\u0027 list config.\")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class PortForwardingNotSupportFilterField(n_exc.BadRequest):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffd0ebdf_08405035","line":27,"in_reply_to":"ffd0ebdf_cceca3f5","updated":"2019-01-03 15:29:12.000000000","message":"Yes, it can be more genric. But IMO we can have a quick fix here.","commit_id":"1b88a756f45aca61063a25b9a5f8b3927d4adf15"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"5ec2b2705eaac947df85d3443be704cdc854eb55","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class L3RouterServicePluginRequired(n_exc.NeutronException):"},{"line_number":25,"context_line":"    message \u003d _(\"Error initiating Port Forwarding plugin, L3 router service \""},{"line_number":26,"context_line":"                \"plugin not set or \u0027port_forwarding\u0027 is set before \u0027router\u0027 \""},{"line_number":27,"context_line":"                \"in \u0027service_plugins\u0027 list config.\")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class PortForwardingNotSupportFilterField(n_exc.BadRequest):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffd0ebdf_cc3b2a9a","line":27,"in_reply_to":"ffd0ebdf_e8a86c78","updated":"2019-01-04 11:35:19.000000000","message":"Yes, make sense. I will rework this.\n\nAnd for that general proposal, I already have a candidate, we can add a required list to each plugin, something like this \u0027supported_extension_aliases\u0027:\nhttps://github.com/openstack/neutron/blob/master/neutron/services/portforwarding/pf_plugin.py#L74\nmaybe we can name the new list as \u0027required_service_plugin\u0027.\nThen the proper way to init the service plugin in specific order can be here:\nhttps://github.com/openstack/neutron/blob/master/neutron/manager.py#L189-L231\nAnd the method there should take care some LOOP-required case. IIRC, it will look like the python MRO C3 algorithm.","commit_id":"1b88a756f45aca61063a25b9a5f8b3927d4adf15"}],"neutron/services/portforwarding/pf_plugin.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"74e254932d890654641a81fd3a9a2ab7ce7af7b9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    This class implements a Port Forwarding plugin."},{"line_number":72,"context_line":"    \"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    required_service_plugin \u003d [\u0027router\u0027]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    supported_extension_aliases \u003d [\u0027floating-ip-port-forwarding\u0027,"},{"line_number":77,"context_line":"                                   \u0027expose-port-forwarding-in-fip\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"bfdaf3ff_b3bb4970","line":74,"range":{"start_line":74,"start_character":4,"end_line":74,"end_character":27},"updated":"2019-01-17 08:43:21.000000000","message":"IMO better would be plural form, so \"required_service_plugins\".","commit_id":"bf490af6b421d5001306b3c3bf98551f165c9c3e"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"319902f6838bc80f98240340bb2281e527e1c421","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    This class implements a Port Forwarding plugin."},{"line_number":72,"context_line":"    \"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    required_service_plugin \u003d [\u0027router\u0027]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    supported_extension_aliases \u003d [\u0027floating-ip-port-forwarding\u0027,"},{"line_number":77,"context_line":"                                   \u0027expose-port-forwarding-in-fip\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"bfdaf3ff_d6a11bab","line":74,"range":{"start_line":74,"start_character":4,"end_line":74,"end_character":27},"in_reply_to":"bfdaf3ff_b3bb4970","updated":"2019-01-17 09:13:02.000000000","message":"Done","commit_id":"bf490af6b421d5001306b3c3bf98551f165c9c3e"}],"neutron/tests/unit/extensions/test_expose_port_forwarding_in_fip.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1526ae005afa11586c33a0a155f604c8378ca681","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def setUp(self):"},{"line_number":75,"context_line":"        mock.patch(\u0027neutron.api.rpc.handlers.resources_rpc.\u0027"},{"line_number":76,"context_line":"                   \u0027ResourcesPushRpcApi\u0027).start()"},{"line_number":77,"context_line":"        svc_plugins \u003d (PF_PLUGIN_NAME, L3_PLUGIN,"},{"line_number":78,"context_line":"                       \u0027neutron.services.qos.qos_plugin.QoSPlugin\u0027)"},{"line_number":79,"context_line":"        ext_mgr \u003d ExtendFipPortForwardingExtensionManager()"},{"line_number":80,"context_line":"        super(TestExtendFipPortForwardingExtension, self).setUp("}],"source_content_type":"text/x-python","patch_set":7,"id":"bfdaf3ff_e5634e19","line":77,"updated":"2019-01-17 02:30:11.000000000","message":"Disorder it to see if the requirements works.","commit_id":"bf490af6b421d5001306b3c3bf98551f165c9c3e"}],"releasenotes/notes/service-plugin-dependency-c8bf620b2526b869.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"266967353aff2dd4f79e50c4693249df54531d3d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"other:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Neutron now has some service plugins require other plugin(s) as"},{"line_number":8,"context_line":"    dependency. For instance, ``port_forwarding`` service plugin requires"},{"line_number":9,"context_line":"    ``router`` to achieve relevant functionalities. Adds a required list"},{"line_number":10,"context_line":"    ``required_service_plugins`` to each service plugin, then we can initialize"},{"line_number":11,"context_line":"    the service plugin with required dependency. During the dependency"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9fdfeff1_18e429e0","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":14},"updated":"2019-02-18 17:15:58.000000000","message":"s/dependencies","commit_id":"8e984b1b8d32190cc40fd4e9074a81dec6cc60e6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"266967353aff2dd4f79e50c4693249df54531d3d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    ``router`` to achieve relevant functionalities. Adds a required list"},{"line_number":10,"context_line":"    ``required_service_plugins`` to each service plugin, then we can initialize"},{"line_number":11,"context_line":"    the service plugin with required dependency. During the dependency"},{"line_number":12,"context_line":"    resolving procedure, we refactor the ``service_plugins`` to not"},{"line_number":13,"context_line":"    raise Exception if one plugin is configured multiple times. And in"},{"line_number":14,"context_line":"    such situation, the last one will finally take effect. And if one"},{"line_number":15,"context_line":"    plugin requires another, and the requirement does not set in the config"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9fdfeff1_3837ad50","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":13},"updated":"2019-02-18 17:15:58.000000000","message":"s/resolution","commit_id":"8e984b1b8d32190cc40fd4e9074a81dec6cc60e6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"266967353aff2dd4f79e50c4693249df54531d3d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    the service plugin with required dependency. During the dependency"},{"line_number":12,"context_line":"    resolving procedure, we refactor the ``service_plugins`` to not"},{"line_number":13,"context_line":"    raise Exception if one plugin is configured multiple times. And in"},{"line_number":14,"context_line":"    such situation, the last one will finally take effect. And if one"},{"line_number":15,"context_line":"    plugin requires another, and the requirement does not set in the config"},{"line_number":16,"context_line":"    file, neutron will also initialize it to the plugin directory."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9fdfeff1_f84fe5bb","line":14,"updated":"2019-02-18 17:15:58.000000000","message":"I can\u0027t remember if there is an \u0027upgrades\u0027 section to a release note, let me take a look.\n\nThere are also some other grammatical things I\u0027d like to correct, it\u0027s probably easiest if I just send out an update to this patch instead of trying to describe them.","commit_id":"8e984b1b8d32190cc40fd4e9074a81dec6cc60e6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"29d6d0d93da6679c5fd5279378bc7932ec37d306","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    dependencies. For example, the ``port_forwarding`` service plugin"},{"line_number":11,"context_line":"    requires the ``router`` service plugin to achieve full functionality. A"},{"line_number":12,"context_line":"    new list, ``required_service_plugins``, was added to each service"},{"line_number":13,"context_line":"    plugin so we can initialize the required depencies of each service plugin."},{"line_number":14,"context_line":"    If one plugin requires another, and the requirement is not set in the"},{"line_number":15,"context_line":"    config file, neutron will now initialize it to the plugin directory."},{"line_number":16,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9fdfeff1_0c01463a","line":13,"range":{"start_line":13,"start_character":45,"end_line":13,"end_character":54},"updated":"2019-02-19 03:40:05.000000000","message":"I can\u0027t spell","commit_id":"6deb009bd950e9d28aa44327acb6c11b42a99398"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"29d6d0d93da6679c5fd5279378bc7932ec37d306","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    requires the ``router`` service plugin to achieve full functionality. A"},{"line_number":12,"context_line":"    new list, ``required_service_plugins``, was added to each service"},{"line_number":13,"context_line":"    plugin so we can initialize the required depencies of each service plugin."},{"line_number":14,"context_line":"    If one plugin requires another, and the requirement is not set in the"},{"line_number":15,"context_line":"    config file, neutron will now initialize it to the plugin directory."},{"line_number":16,"context_line":"upgrade:"},{"line_number":17,"context_line":"  - |"},{"line_number":18,"context_line":"    During the dependency resolution procedure, the code that loads service"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9fdfeff1_8cbbf673","line":15,"range":{"start_line":14,"start_character":4,"end_line":15,"end_character":71},"updated":"2019-02-19 03:40:05.000000000","message":"Also, re-reading this I\u0027m not sure it exactly makes sense to me, I\u0027m thinking it can be removed?","commit_id":"6deb009bd950e9d28aa44327acb6c11b42a99398"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f4d8fadde3a9b7da1831f0ea893d13bcbed60c04","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    requires the ``router`` service plugin to achieve full functionality. A"},{"line_number":12,"context_line":"    new list, ``required_service_plugins``, was added to each service"},{"line_number":13,"context_line":"    plugin so the required dependencies of each service plugin can be"},{"line_number":14,"context_line":"    initialized.  If one service plugin requires another, but the requirement"},{"line_number":15,"context_line":"    is not set in the config file, neutron will now initialize it to the"},{"line_number":16,"context_line":"    plugin directory."},{"line_number":17,"context_line":"upgrade:"},{"line_number":18,"context_line":"  - |"},{"line_number":19,"context_line":"    During the dependency resolution procedure, the code that loads service"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fdfeff1_8c60d60f","line":16,"range":{"start_line":14,"start_character":18,"end_line":16,"end_character":20},"updated":"2019-02-19 03:42:17.000000000","message":"Liu - can you let me know if this should be deleted?  It doesn\u0027t exactly make sense to me now.  Maybe we wanted to say there will be an issue if not specified?  Thanks.","commit_id":"807e0615d36a18099a97f9dc063f42eee8fcc9a4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3da2a23e9fa8f9646105b9625d8759fd4a54ff29","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    requires the ``router`` service plugin to achieve full functionality. A"},{"line_number":12,"context_line":"    new list, ``required_service_plugins``, was added to each service"},{"line_number":13,"context_line":"    plugin so the required dependencies of each service plugin can be"},{"line_number":14,"context_line":"    initialized.  If one service plugin requires another, but the requirement"},{"line_number":15,"context_line":"    is not set in the config file, neutron will now initialize it to the"},{"line_number":16,"context_line":"    plugin directory."},{"line_number":17,"context_line":"upgrade:"},{"line_number":18,"context_line":"  - |"},{"line_number":19,"context_line":"    During the dependency resolution procedure, the code that loads service"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fdfeff1_5d24d6af","line":16,"range":{"start_line":14,"start_character":18,"end_line":16,"end_character":20},"in_reply_to":"9fdfeff1_02926f59","updated":"2019-02-19 06:29:39.000000000","message":"Added a UT case for this:\nhttps://review.openstack.org/#/c/626561/17/neutron/tests/unit/test_manager.py@164","commit_id":"807e0615d36a18099a97f9dc063f42eee8fcc9a4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"89ff01647ec87ad5b5b197ccc8b26d379b3234ad","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    requires the ``router`` service plugin to achieve full functionality. A"},{"line_number":12,"context_line":"    new list, ``required_service_plugins``, was added to each service"},{"line_number":13,"context_line":"    plugin so the required dependencies of each service plugin can be"},{"line_number":14,"context_line":"    initialized.  If one service plugin requires another, but the requirement"},{"line_number":15,"context_line":"    is not set in the config file, neutron will now initialize it to the"},{"line_number":16,"context_line":"    plugin directory."},{"line_number":17,"context_line":"upgrade:"},{"line_number":18,"context_line":"  - |"},{"line_number":19,"context_line":"    During the dependency resolution procedure, the code that loads service"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fdfeff1_1d364ee9","line":16,"range":{"start_line":14,"start_character":18,"end_line":16,"end_character":20},"in_reply_to":"9fdfeff1_5d24d6af","updated":"2019-02-19 06:32:10.000000000","message":"... it has been there already.................. https://review.openstack.org/#/c/626561/17/neutron/tests/unit/test_manager.py@130","commit_id":"807e0615d36a18099a97f9dc063f42eee8fcc9a4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b39c0baca8c9455cec23ad3ac07a9bae569b9d1f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    requires the ``router`` service plugin to achieve full functionality. A"},{"line_number":12,"context_line":"    new list, ``required_service_plugins``, was added to each service"},{"line_number":13,"context_line":"    plugin so the required dependencies of each service plugin can be"},{"line_number":14,"context_line":"    initialized.  If one service plugin requires another, but the requirement"},{"line_number":15,"context_line":"    is not set in the config file, neutron will now initialize it to the"},{"line_number":16,"context_line":"    plugin directory."},{"line_number":17,"context_line":"upgrade:"},{"line_number":18,"context_line":"  - |"},{"line_number":19,"context_line":"    During the dependency resolution procedure, the code that loads service"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fdfeff1_02926f59","line":16,"range":{"start_line":14,"start_character":18,"end_line":16,"end_character":20},"in_reply_to":"9fdfeff1_8c60d60f","updated":"2019-02-19 05:52:23.000000000","message":"We should make this remain, let me give an example:\nplugin A requires B as dependency, but the service_plugins only set A, for instance: service_plugins\u003d A. After this change, B will be implicitly initialized.","commit_id":"807e0615d36a18099a97f9dc063f42eee8fcc9a4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b39c0baca8c9455cec23ad3ac07a9bae569b9d1f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    initialized.  If one service plugin requires another, but the requirement"},{"line_number":15,"context_line":"    is not set in the config file, neutron will now initialize it to the"},{"line_number":16,"context_line":"    plugin directory."},{"line_number":17,"context_line":"upgrade:"},{"line_number":18,"context_line":"  - |"},{"line_number":19,"context_line":"    During the dependency resolution procedure, the code that loads service"},{"line_number":20,"context_line":"    plugins was refactored to not raise an exception if one plugin is"},{"line_number":21,"context_line":"    configured multiple times, with the last one taking effect. This is a"},{"line_number":22,"context_line":"    change from the previous behavior."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fdfeff1_027b4f29","line":22,"range":{"start_line":17,"start_character":0,"end_line":22,"end_character":38},"updated":"2019-02-19 05:52:23.000000000","message":"Actually we do not bring a upgrade issue, we are free the cloud operators activities. But it\u0027s also fine to add this as a note.","commit_id":"807e0615d36a18099a97f9dc063f42eee8fcc9a4"}]}
