)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"28d40167301b7e1cba957eeffbea52dadde146de","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     hyunsun \u003chyunsun.moon@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-18 18:13:35 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix port binding host is set None when port update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027binding:host_id\u0027 in port update request message is set None when"},{"line_number":10,"context_line":"port update for other than binding host is called. Correct binding"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F89lo%3D","line":7,"updated":"2013-12-18 11:41:01.000000000","message":"is set to None","commit_id":"01bee065663578dd1a952c17d7e870f50de1ba19"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"28d40167301b7e1cba957eeffbea52dadde146de","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix port binding host is set None when port update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027binding:host_id\u0027 in port update request message is set None when"},{"line_number":10,"context_line":"port update for other than binding host is called. Correct binding"},{"line_number":11,"context_line":"host value must be set whether there is changes on binding host"},{"line_number":12,"context_line":"or not so that the agents uses the value on port update can work"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F89lk%3D","line":9,"updated":"2013-12-18 11:41:01.000000000","message":"same","commit_id":"01bee065663578dd1a952c17d7e870f50de1ba19"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"01794320a5f27619163de507885501f8a3b0a2da","unresolved":false,"context_lines":[{"line_number":10,"context_line":"port update for other than binding host is called. Correct binding"},{"line_number":11,"context_line":"host value must be set whether there is changes on binding host"},{"line_number":12,"context_line":"or not so that the agents uses the value on port update can work"},{"line_number":13,"context_line":"properly."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1245310"},{"line_number":16,"context_line":"Change-Id: Icfb5179940cca9f8a705eb36bdbfcbc8a421a272"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F89Z8%3D","line":13,"updated":"2013-12-18 12:01:30.000000000","message":"If the following express correctly your thought consider rephrasing the whole commit message in a similar way:\n\nwhen updating a port \u0027binding:host_id\u0027 is reset if not specified among the parameter to be updated.\nAs a result, a None value for \u0027binding:host_id\u0027 is sent from the notifier which might potentially cause consumers to not work properly.","commit_id":"01bee065663578dd1a952c17d7e870f50de1ba19"}],"neutron/db/portbindings_db.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"01794320a5f27619163de507885501f8a3b0a2da","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                if not bind_port:"},{"line_number":83,"context_line":"                    context.session.add(PortBindingPort(port_id\u003dport[\u0027id\u0027],"},{"line_number":84,"context_line":"                                                        host\u003dhost))"},{"line_number":85,"context_line":"                else:"},{"line_number":86,"context_line":"                    bind_port.host \u003d host"},{"line_number":87,"context_line":"        self._extend_port_dict_binding_host(port, host)"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F89Vc%3D","line":85,"updated":"2013-12-18 12:01:30.000000000","message":"consider this alternative:\nremove code for get_port_host, and after querying for bind_port\n\nif not bind_port:\n     context.session.add(PortBindingPort(port_id\u003dport[\u0027id\u0027],host\u003dhost)\nelif host_set:\n     bind_port.host \u003d host\nself._extend_port_dict_binding_host(port, host)","commit_id":"01bee065663578dd1a952c17d7e870f50de1ba19"},{"author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"change_message_id":"adeede64cc12abec8689ac71a97e302d0bd3b44c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                if not bind_port:"},{"line_number":83,"context_line":"                    context.session.add(PortBindingPort(port_id\u003dport[\u0027id\u0027],"},{"line_number":84,"context_line":"                                                        host\u003dhost))"},{"line_number":85,"context_line":"                else:"},{"line_number":86,"context_line":"                    bind_port.host \u003d host"},{"line_number":87,"context_line":"        self._extend_port_dict_binding_host(port, host)"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F85B8%3D","line":85,"in_reply_to":"AAAATn%2F89Vc%3D","updated":"2013-12-19 04:36:26.000000000","message":"Thanks! \n\n\u0027host\u0027 value here is only set when \u0027portbindings.HOST_ID\u0027 is included in update parameter. There should be a case if host_set is false, which means portbinding is not updated, then use existing host_id.\n\nI\u0027ll make it more clear.","commit_id":"01bee065663578dd1a952c17d7e870f50de1ba19"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d77c73df30d304002723c5fcd0fba714a2b1cd93","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                else:"},{"line_number":84,"context_line":"                    bind_port.host \u003d host"},{"line_number":85,"context_line":"            else:"},{"line_number":86,"context_line":"                host \u003d (bind_port and bind_port.host or None)"},{"line_number":87,"context_line":"        self._extend_port_dict_binding_host(port, host)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def get_port_host(self, context, port_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F9aNo%3D","line":86,"updated":"2014-02-07 04:19:07.000000000","message":"If host_set is true then the code uses \"if not bind_port: ... else\".\nIf it is false, then it uses this ternary operator.\n\nThe code would read better if it used these operators consistently.","commit_id":"10c5af3987e1af6bf913675432122c7142617d1a"}],"neutron/tests/unit/_test_extension_portbindings.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2b662010161a3cd82961c3fb648d61f81ee89c5d","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            self.assertEqual(\u0027testhosttemp\u0027, port[portbindings.HOST_ID])"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def test_ports_vif_non_host_update(self):"},{"line_number":251,"context_line":"        cfg.CONF.set_default(\u0027allow_overlapping_ips\u0027, True)"},{"line_number":252,"context_line":"        host_arg \u003d {portbindings.HOST_ID: self.hostname}"},{"line_number":253,"context_line":"        with contextlib.nested("},{"line_number":254,"context_line":"            self.port(name\u003d\u0027name1\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F9Rc%3D","line":251,"updated":"2014-01-06 08:18:21.000000000","message":"it\u0027s non strictly necessary to override this configuration variable; you could just created both ports on the same network","commit_id":"c22c1d5f957e8858ff917fd93476c515ef961754"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2b662010161a3cd82961c3fb648d61f81ee89c5d","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, data, port1[\u0027port\u0027][\u0027id\u0027])"},{"line_number":260,"context_line":"            res \u003d self.deserialize(self.fmt, req.get_response(self.api))"},{"line_number":261,"context_line":"            self.assertEqual(port1[\u0027port\u0027][portbindings.HOST_ID],"},{"line_number":262,"context_line":"                             res[\u0027port\u0027][portbindings.HOST_ID])"},{"line_number":263,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, data, port2[\u0027port\u0027][\u0027id\u0027])"},{"line_number":264,"context_line":"            res \u003d self.deserialize(self.fmt, req.get_response(self.api))"},{"line_number":265,"context_line":"            self.assertEqual(port2[\u0027port\u0027][portbindings.HOST_ID],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F9Q4%3D","line":262,"updated":"2014-01-06 08:18:21.000000000","message":"the above check should cover the case when host is not set in the request","commit_id":"c22c1d5f957e8858ff917fd93476c515ef961754"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2b662010161a3cd82961c3fb648d61f81ee89c5d","unresolved":false,"context_lines":[{"line_number":263,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, data, port2[\u0027port\u0027][\u0027id\u0027])"},{"line_number":264,"context_line":"            res \u003d self.deserialize(self.fmt, req.get_response(self.api))"},{"line_number":265,"context_line":"            self.assertEqual(port2[\u0027port\u0027][portbindings.HOST_ID],"},{"line_number":266,"context_line":"                             res[\u0027port\u0027][portbindings.HOST_ID])"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def test_ports_vif_host_list(self):"},{"line_number":269,"context_line":"        cfg.CONF.set_default(\u0027allow_overlapping_ips\u0027, True)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F9Q0%3D","line":266,"updated":"2014-01-06 08:18:21.000000000","message":"the above check should cover the case when host is not set in the request and the db entry exists.\nThis is good, but they could be two distinct unit tests.\nThis is a minor point, even if I find a bit hard then finding suitable names for these tests!","commit_id":"c22c1d5f957e8858ff917fd93476c515ef961754"}]}