)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2c6a7ca1283abd639f5059784dca0ce3b5fba56a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"was already set on the deivce, and still process next step."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I324f6b96baa0520a0f7ef62a83d81864d7b27999"},{"line_number":17,"context_line":"Related-Bug: #1811213"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bfdaf3ff_a07c3f1f","line":17,"updated":"2019-01-17 21:39:28.000000000","message":"Should this be Closes-bug ?","commit_id":"d22ed7241ef69c0c8514ceab17488e08f20daaa2"},{"author":{"_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"},"change_message_id":"a4cb816a8b48265b57638481b7cf0505d45acba6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"multiple IP addr adding action: HA router _add_vip() and"},{"line_number":12,"context_line":"Edge router add_ip_address()."},{"line_number":13,"context_line":"This patch catches the IpAddressAlreadyExists error if fip"},{"line_number":14,"context_line":"was already set on the deivce, and still process next step."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I324f6b96baa0520a0f7ef62a83d81864d7b27999"},{"line_number":17,"context_line":"Closes-Bug: #1811213"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9fdfeff1_aad0fe51","line":14,"range":{"start_line":14,"start_character":23,"end_line":14,"end_character":29},"updated":"2019-01-22 09:57:19.000000000","message":"device","commit_id":"2e8abc9747e3ce2638c5390ff80ec127cbfe2a78"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"cfdaca13e89ee6aeec2328b8e83432004bb72f35","unresolved":false,"context_lines":[{"line_number":11,"context_line":"multiple IP addr adding action: HA router _add_vip() and"},{"line_number":12,"context_line":"Edge router add_ip_address()."},{"line_number":13,"context_line":"This patch catches the IpAddressAlreadyExists error if fip"},{"line_number":14,"context_line":"was already set on the deivce, and still process next step."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I324f6b96baa0520a0f7ef62a83d81864d7b27999"},{"line_number":17,"context_line":"Closes-Bug: #1811213"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9fdfeff1_a3402909","line":14,"range":{"start_line":14,"start_character":23,"end_line":14,"end_character":29},"in_reply_to":"9fdfeff1_aad0fe51","updated":"2019-01-22 12:33:38.000000000","message":"Done","commit_id":"2e8abc9747e3ce2638c5390ff80ec127cbfe2a78"}],"neutron/agent/l3/dvr_edge_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f8bc5d3f08a19669a041ba9c9a4915e6ba3464ae","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        device \u003d ip_lib.IPDevice("},{"line_number":319,"context_line":"            interface_name, namespace\u003dself.snat_namespace.name)"},{"line_number":320,"context_line":"        try:"},{"line_number":321,"context_line":"            device.addr.add(fip_cidr)"},{"line_number":322,"context_line":"        except RuntimeError as e:"},{"line_number":323,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dFalse):"},{"line_number":324,"context_line":"                if \u0027File exists\u0027 not in str(e):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_09fdac39","line":321,"updated":"2019-01-11 17:24:15.000000000","message":"Looks like a candidate to use ip_lib.add_ip_address() directly as we don\u0027t use \u0027device\u0027 other than this call.  I\u0027ll create another change for that.","commit_id":"cfd327e96879f0b523f4fcc1f483041f96b97443"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"adcdade1a2ecf903b26af8717e027cb6e25be553","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        device \u003d ip_lib.IPDevice("},{"line_number":319,"context_line":"            interface_name, namespace\u003dself.snat_namespace.name)"},{"line_number":320,"context_line":"        try:"},{"line_number":321,"context_line":"            device.addr.add(fip_cidr)"},{"line_number":322,"context_line":"        except RuntimeError as e:"},{"line_number":323,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dFalse):"},{"line_number":324,"context_line":"                if \u0027File exists\u0027 not in str(e):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_6e8236cb","line":321,"in_reply_to":"bfdaf3ff_09fdac39","updated":"2019-01-12 01:07:03.000000000","message":"Looks good. Will rebase on that change.","commit_id":"cfd327e96879f0b523f4fcc1f483041f96b97443"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f8bc5d3f08a19669a041ba9c9a4915e6ba3464ae","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        try:"},{"line_number":321,"context_line":"            device.addr.add(fip_cidr)"},{"line_number":322,"context_line":"        except RuntimeError as e:"},{"line_number":323,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dFalse):"},{"line_number":324,"context_line":"                if \u0027File exists\u0027 not in str(e):"},{"line_number":325,"context_line":"                    LOG.warning(\"Unable to configure IP address for \""},{"line_number":326,"context_line":"                                \"centralized floating IP: %s\", fip[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_0977ec3c","line":323,"updated":"2019-01-11 17:24:15.000000000","message":"So there is a specific exception for this in neutron.privileged.agent.linux.ip_lib called IpAddressAlreadyExists().  You should add a reference in neutron.agent.linux.ip_lib right below where NetworkInterfaceNotFound() is and catch it here (above this) instead.","commit_id":"cfd327e96879f0b523f4fcc1f483041f96b97443"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3ab30ac858acaf87dbfd68bd0919d72a97f0b557","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        try:"},{"line_number":321,"context_line":"            device.addr.add(fip_cidr)"},{"line_number":322,"context_line":"        except RuntimeError as e:"},{"line_number":323,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dFalse):"},{"line_number":324,"context_line":"                if \u0027File exists\u0027 not in str(e):"},{"line_number":325,"context_line":"                    LOG.warning(\"Unable to configure IP address for \""},{"line_number":326,"context_line":"                                \"centralized floating IP: %s\", fip[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_ecfe2f04","line":323,"in_reply_to":"bfdaf3ff_0977ec3c","updated":"2019-01-12 01:44:16.000000000","message":"IpAddressAlreadyExists will be slightly ignore.\nNetworkInterfaceNotFound and InterfaceOperationNotSupported will still be caught by the original \u0027RuntimeError\u0027 here.\nAny other exception like OSError, NetlinkError, NetworkNamespaceNotFound will still be raised.","commit_id":"cfd327e96879f0b523f4fcc1f483041f96b97443"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0466e89d80185b3835dbcde6abac7ce6bc52d282","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        try:"},{"line_number":321,"context_line":"            device.addr.add(fip_cidr)"},{"line_number":322,"context_line":"        except RuntimeError as e:"},{"line_number":323,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dFalse):"},{"line_number":324,"context_line":"                if \u0027File exists\u0027 not in str(e):"},{"line_number":325,"context_line":"                    LOG.warning(\"Unable to configure IP address for \""},{"line_number":326,"context_line":"                                \"centralized floating IP: %s\", fip[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_58527f15","line":323,"in_reply_to":"bfdaf3ff_ecfe2f04","updated":"2019-01-14 13:36:10.000000000","message":"I guess I figured we\u0027d catch and \"pass\" on things that shouldn\u0027t be an error, but still catch RuntimeError and set \"error\" in that case.  Looks like you did that in PS3.  Does that make sense?  I don\u0027t think checking for a string in the error message is the best thing.","commit_id":"cfd327e96879f0b523f4fcc1f483041f96b97443"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0466e89d80185b3835dbcde6abac7ce6bc52d282","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        try:"},{"line_number":318,"context_line":"            ip_lib.add_ip_address(fip_cidr, interface_name,"},{"line_number":319,"context_line":"                                  namespace\u003dself.snat_namespace.name)"},{"line_number":320,"context_line":"        except ip_lib.IpAddressAlreadyExists:"},{"line_number":321,"context_line":"            pass"},{"line_number":322,"context_line":"        except RuntimeError:"},{"line_number":323,"context_line":"            LOG.warning(\"Unable to configure IP address for centralized \""}],"source_content_type":"text/x-python","patch_set":3,"id":"bfdaf3ff_f8a4930a","line":320,"updated":"2019-01-14 13:36:10.000000000","message":"You\u0027ll need to make the reference in ip_lib to this from the priv code.","commit_id":"0c98464473ae76aa26f4d7a3d96ee3ded5009eca"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7145b19edd76d8584f088eb38d59a07d9d03f487","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        try:"},{"line_number":318,"context_line":"            ip_lib.add_ip_address(fip_cidr, interface_name,"},{"line_number":319,"context_line":"                                  namespace\u003dself.snat_namespace.name)"},{"line_number":320,"context_line":"        except ip_lib.IpAddressAlreadyExists:"},{"line_number":321,"context_line":"            pass"},{"line_number":322,"context_line":"        except RuntimeError:"},{"line_number":323,"context_line":"            LOG.warning(\"Unable to configure IP address for centralized \""}],"source_content_type":"text/x-python","patch_set":3,"id":"bfdaf3ff_a527c312","line":320,"in_reply_to":"bfdaf3ff_f8a4930a","updated":"2019-01-14 15:26:02.000000000","message":"Done","commit_id":"0c98464473ae76aa26f4d7a3d96ee3ded5009eca"}]}
