)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"39f333ed5489e63dd96c1a24d77e41924485ed9c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Catch OVSFWTagNotFound in firewall.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVSFWTagNotFound raised many times in neutron-openvswitch-agent logs,"},{"line_number":10,"context_line":"catch and log it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I584d867f0e1c47447cb8790fd715fa01ec902438"},{"line_number":13,"context_line":"Closes-Bug: #1811405"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_949f024f","line":10,"updated":"2019-02-25 15:31:40.000000000","message":"OVS agent is trying to apply port filters by iterating through the requested ports [1] i.e\n\n            for device in devices.values():\n                if update_filter:\n                    LOG.debug(\"Update port filter for %s\", device[\u0027device\u0027])\n                    self.firewall.update_port_filter(device)\n\nIf applying filter for a port is failed with OVSFWTagNotFound exception or any other exception, filters for other ports not applied as well. But we need to skip filter for this port and continue with other ports.\n\nCan you please update the commit message with these details (and the details from comments) so that reviewers can avoid thinking that this patch is only for logging? \n\nhttps://github.com/openstack/neutron/blob/master/neutron/agent/securitygroups_rpc.py#L150","commit_id":"c3500a9b382b639731954543f2ddf005a65c6907"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1d78ffb7faeeca6909a2102023cce0e437d659dd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Catch OVSFWTagNotFound in firewall.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVSFWTagNotFound raised many times in neutron-openvswitch-agent logs,"},{"line_number":10,"context_line":"catch and log it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I584d867f0e1c47447cb8790fd715fa01ec902438"},{"line_number":13,"context_line":"Closes-Bug: #1811405"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_f46ce036","line":10,"in_reply_to":"9fdfeff1_949f024f","updated":"2019-03-01 12:34:32.000000000","message":"I removed the try except block from prepare port filter, so I mention only the update_port_filter method that catches OVSFWTagNotFound exception","commit_id":"c3500a9b382b639731954543f2ddf005a65c6907"}],"neutron/agent/linux/openvswitch_firewall/firewall.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c7952ced73b2bfcbca758b51a7c6bda0add8644f","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        except exceptions.OVSFWTagNotFound as not_found_error:"},{"line_number":558,"context_line":"            LOG.info(\"port %(port_id)s does not exist in ovsdb: %(err)s.\","},{"line_number":559,"context_line":"                     {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":560,"context_line":"                      \u0027err\u0027: not_found_error})"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    def update_port_filter(self, port):"},{"line_number":563,"context_line":"        \"\"\"Update rules for given port"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_ca2d4247","line":560,"updated":"2019-01-22 10:04:43.000000000","message":"Isn\u0027t this gonna just leave the port without security group rules?","commit_id":"c3500a9b382b639731954543f2ddf005a65c6907"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1d78ffb7faeeca6909a2102023cce0e437d659dd","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        except exceptions.OVSFWTagNotFound as not_found_error:"},{"line_number":558,"context_line":"            LOG.info(\"port %(port_id)s does not exist in ovsdb: %(err)s.\","},{"line_number":559,"context_line":"                     {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":560,"context_line":"                      \u0027err\u0027: not_found_error})"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    def update_port_filter(self, port):"},{"line_number":563,"context_line":"        \"\"\"Update rules for given port"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_d46d1c2f","line":560,"in_reply_to":"9fdfeff1_6ed08ff8","updated":"2019-03-01 12:34:32.000000000","message":"Done","commit_id":"c3500a9b382b639731954543f2ddf005a65c6907"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"39f333ed5489e63dd96c1a24d77e41924485ed9c","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        except exceptions.OVSFWTagNotFound as not_found_error:"},{"line_number":558,"context_line":"            LOG.info(\"port %(port_id)s does not exist in ovsdb: %(err)s.\","},{"line_number":559,"context_line":"                     {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":560,"context_line":"                      \u0027err\u0027: not_found_error})"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    def update_port_filter(self, port):"},{"line_number":563,"context_line":"        \"\"\"Update rules for given port"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_6ed08ff8","line":560,"in_reply_to":"9fdfeff1_ca2d4247","updated":"2019-02-25 15:31:40.000000000","message":"We shouldn\u0027t add try block here as prepare_port_filter is called only when port is properly plugged in. Kindly remove it.\nhttps://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L1798\nhttps://github.com/openstack/neutron/blob/master/neutron/agent/securitygroups_rpc.py#L247","commit_id":"c3500a9b382b639731954543f2ddf005a65c6907"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c7952ced73b2bfcbca758b51a7c6bda0add8644f","unresolved":false,"context_lines":[{"line_number":590,"context_line":"                self._set_port_filters(of_port)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        except (exceptions.OVSFWPortNotFound,"},{"line_number":593,"context_line":"                exceptions.OVSFWTagNotFound) as not_found_error:"},{"line_number":594,"context_line":"            LOG.info(\"port %(port_id)s does not exist in ovsdb: %(err)s.\","},{"line_number":595,"context_line":"                     {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":596,"context_line":"                      \u0027err\u0027: not_found_error})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_aa2c7e47","line":593,"updated":"2019-01-22 10:04:43.000000000","message":"When tag is not present on port then this logs message that port doesn\u0027t exist on ovsdb which is a misleading message for the operators.","commit_id":"c3500a9b382b639731954543f2ddf005a65c6907"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"39f333ed5489e63dd96c1a24d77e41924485ed9c","unresolved":false,"context_lines":[{"line_number":590,"context_line":"                self._set_port_filters(of_port)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        except (exceptions.OVSFWPortNotFound,"},{"line_number":593,"context_line":"                exceptions.OVSFWTagNotFound) as not_found_error:"},{"line_number":594,"context_line":"            LOG.info(\"port %(port_id)s does not exist in ovsdb: %(err)s.\","},{"line_number":595,"context_line":"                     {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":596,"context_line":"                      \u0027err\u0027: not_found_error})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_ae419765","line":593,"in_reply_to":"9fdfeff1_a3aa6982","updated":"2019-02-25 15:31:40.000000000","message":"We got this situation as security group RPC triggered adding port filters for a port before this port plugging detected/finished by ovs agent.\n\nIf we see http://paste.openstack.org/show/746024/ , when we got this error \n\n1) port not detected by ovs agent i.e\n2019-02-20 04:33:45.513 52673 INFO neutron.agent.common.ovs_lib [req-95fbf6fa-625c-4278-833f-dbb19110458c - - - - -] Port 181f9a01-9205-43e1-8e68-e97230b8a8e8 not present in bridge br-int\n\n2) trying to apply security group rule as security group RPC agent requested it i.e\n27552:2019-02-20 04:33:45.515 52673 INFO neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent [req-95fbf6fa-625c-4278-833f-dbb19110458c - - - - -] Port 181f9a01-9205-43e1-8e68-e97230b8a8e8 was not found on the integration bridge and will therefore not be processed\n27558:2019-02-20 04:33:55.693 52673 ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent [req-9cd20baa-d94d-4b7e-803b-7f02ba029959 - - - - -] Error while processing VIF ports: OVSFWTagNotFound: Cannot get tag for port tpi-181f9a01-92 from its other_config: {}\n\n3) Later port detected by ovs agent and properly applying security group rule.\n\nTo answer tenant isolation comment, when tag is not properly added, then ovs agent won\u0027t plugin the port and tarffic can\u0027t pass through br-int.","commit_id":"c3500a9b382b639731954543f2ddf005a65c6907"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"39f333ed5489e63dd96c1a24d77e41924485ed9c","unresolved":false,"context_lines":[{"line_number":590,"context_line":"                self._set_port_filters(of_port)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        except (exceptions.OVSFWPortNotFound,"},{"line_number":593,"context_line":"                exceptions.OVSFWTagNotFound) as not_found_error:"},{"line_number":594,"context_line":"            LOG.info(\"port %(port_id)s does not exist in ovsdb: %(err)s.\","},{"line_number":595,"context_line":"                     {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":596,"context_line":"                      \u0027err\u0027: not_found_error})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_aecc3734","line":593,"in_reply_to":"9fdfeff1_aa2c7e47","updated":"2019-02-25 15:31:40.000000000","message":"Agree. Please add a seperate exception.","commit_id":"c3500a9b382b639731954543f2ddf005a65c6907"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"da29c9c0555ad90c39d384eabdf683f05aa6b7e8","unresolved":false,"context_lines":[{"line_number":590,"context_line":"                self._set_port_filters(of_port)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        except (exceptions.OVSFWPortNotFound,"},{"line_number":593,"context_line":"                exceptions.OVSFWTagNotFound) as not_found_error:"},{"line_number":594,"context_line":"            LOG.info(\"port %(port_id)s does not exist in ovsdb: %(err)s.\","},{"line_number":595,"context_line":"                     {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":596,"context_line":"                      \u0027err\u0027: not_found_error})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_a3aa6982","line":593,"in_reply_to":"9fdfeff1_aa2c7e47","updated":"2019-01-22 12:44:16.000000000","message":"if a vm port is ever on the br-int without a tag applied its a sequity issue as the teant could bypass teanat isolation by transmiting vlan tagged packets.","commit_id":"c3500a9b382b639731954543f2ddf005a65c6907"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1d78ffb7faeeca6909a2102023cce0e437d659dd","unresolved":false,"context_lines":[{"line_number":590,"context_line":"                self._set_port_filters(of_port)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        except (exceptions.OVSFWPortNotFound,"},{"line_number":593,"context_line":"                exceptions.OVSFWTagNotFound) as not_found_error:"},{"line_number":594,"context_line":"            LOG.info(\"port %(port_id)s does not exist in ovsdb: %(err)s.\","},{"line_number":595,"context_line":"                     {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":596,"context_line":"                      \u0027err\u0027: not_found_error})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_74623040","line":593,"in_reply_to":"9fdfeff1_aecc3734","updated":"2019-03-01 12:34:32.000000000","message":"Done","commit_id":"c3500a9b382b639731954543f2ddf005a65c6907"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e3bcd446de05326170be720f1b6462bd273737e7","unresolved":false,"context_lines":[{"line_number":589,"context_line":"                     {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":590,"context_line":"                      \u0027err\u0027: not_found_error})"},{"line_number":591,"context_line":"        except exceptions.OVSFWTagNotFound as tag_not_found:"},{"line_number":592,"context_line":"            LOG.info(\"Tag is not found for port %(port_id)s: %(err)s.\","},{"line_number":593,"context_line":"                     {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":594,"context_line":"                      \u0027err\u0027: tag_not_found})"},{"line_number":595,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_ea4db899","line":592,"range":{"start_line":592,"start_character":16,"end_line":592,"end_character":20},"updated":"2019-03-04 11:52:14.000000000","message":"Should this be set to error level? If we update a security group on a port that has no tag, then something is really wrong in Neutron and a bug should be reported.","commit_id":"c8b6ee1e484d44e3b6d027308a1fbf4b1fa7f6ab"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"97ecd5571cb717c7cc07729316f3f584dc6b401d","unresolved":false,"context_lines":[{"line_number":589,"context_line":"                     {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":590,"context_line":"                      \u0027err\u0027: not_found_error})"},{"line_number":591,"context_line":"        except exceptions.OVSFWTagNotFound as tag_not_found:"},{"line_number":592,"context_line":"            LOG.info(\"Tag is not found for port %(port_id)s: %(err)s.\","},{"line_number":593,"context_line":"                     {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":594,"context_line":"                      \u0027err\u0027: tag_not_found})"},{"line_number":595,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_73923d4d","line":592,"range":{"start_line":592,"start_character":26,"end_line":592,"end_character":28},"updated":"2019-03-01 18:59:42.000000000","message":"nit: was","commit_id":"c8b6ee1e484d44e3b6d027308a1fbf4b1fa7f6ab"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"cd365b595e8d1b12ddd13da21719fd210f61f0ee","unresolved":false,"context_lines":[{"line_number":589,"context_line":"                     {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":590,"context_line":"                      \u0027err\u0027: not_found_error})"},{"line_number":591,"context_line":"        except exceptions.OVSFWTagNotFound as tag_not_found:"},{"line_number":592,"context_line":"            LOG.info(\"Tag is not found for port %(port_id)s: %(err)s.\","},{"line_number":593,"context_line":"                     {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":594,"context_line":"                      \u0027err\u0027: tag_not_found})"},{"line_number":595,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_af757a02","line":592,"range":{"start_line":592,"start_character":26,"end_line":592,"end_character":28},"in_reply_to":"9fdfeff1_73923d4d","updated":"2019-03-04 16:29:01.000000000","message":"Done","commit_id":"c8b6ee1e484d44e3b6d027308a1fbf4b1fa7f6ab"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"cd365b595e8d1b12ddd13da21719fd210f61f0ee","unresolved":false,"context_lines":[{"line_number":589,"context_line":"                     {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":590,"context_line":"                      \u0027err\u0027: not_found_error})"},{"line_number":591,"context_line":"        except exceptions.OVSFWTagNotFound as tag_not_found:"},{"line_number":592,"context_line":"            LOG.info(\"Tag is not found for port %(port_id)s: %(err)s.\","},{"line_number":593,"context_line":"                     {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":594,"context_line":"                      \u0027err\u0027: tag_not_found})"},{"line_number":595,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_cf7a3eef","line":592,"range":{"start_line":592,"start_character":16,"end_line":592,"end_character":20},"in_reply_to":"9fdfeff1_ea4db899","updated":"2019-03-04 16:29:01.000000000","message":"Done","commit_id":"c8b6ee1e484d44e3b6d027308a1fbf4b1fa7f6ab"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d9e4b65c2e406f929c1186d34ece785e2fa1126e","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        except exceptions.OVSFWTagNotFound as tag_not_found:"},{"line_number":592,"context_line":"            LOG.error(\"Tag was not found for port %(port_id)s: %(err)s.\","},{"line_number":593,"context_line":"                      {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":594,"context_line":"                       \u0027err\u0027: tag_not_found})"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    def _set_port_filters(self, of_port):"},{"line_number":597,"context_line":"        self.initialize_port_flows(of_port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_dd2185fe","line":594,"updated":"2019-03-05 08:55:53.000000000","message":"I still have some doubt about it. Do we know why and when such case can happen?If so, is it really an error?\nLooking at logs from one of multinode jobs run on this patch it happens at least 8 times in http://logs.openstack.org/10/630910/4/check/tempest-multinode-full-py3/5c95e28/controller/logs/screen-q-agt.txt.gz#_Mar_04_20_51_21_142689 - so if it\u0027s really error than IMO we have some problem and should focus on fix reason of this problem rather than logging it only as error.\nIf it\u0027s \"normal\" and expected case, maybe we shouldn\u0027t log it as error?","commit_id":"39c5996eab6613213d68daeffaaa3478990fc3dc"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"145fb0256d4c23a0e90e8f1a015b916a3ce1cba7","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        except exceptions.OVSFWTagNotFound as tag_not_found:"},{"line_number":592,"context_line":"            LOG.error(\"Tag was not found for port %(port_id)s: %(err)s.\","},{"line_number":593,"context_line":"                      {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":594,"context_line":"                       \u0027err\u0027: tag_not_found})"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    def _set_port_filters(self, of_port):"},{"line_number":597,"context_line":"        self.initialize_port_flows(of_port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_e5c86c56","line":594,"in_reply_to":"5fc1f717_1a308556","updated":"2019-03-07 13:44:34.000000000","message":"in my last comment in ps2 I have explained the root cause\nhttps://review.openstack.org/#/c/630910/2/neutron/agent/linux/openvswitch_firewall/firewall.py@593\n\nAs I explained there, OVS agent will try to apply filters for a port when\n1) agent gets security groups RPC from neutron-server about that port\n2) otherwise when ovs agent detected that port is plugged (from ovsdb monitor)\nIn this case, server has requested the agent (through RPC) to apply filters though the port wiring and plugging has not happend by the agent. We can log it as info, as later plugging the port by agent(because of ovsdb monitor events) will apply the filters properly. \n\nIts not an error, we have to log it as info.","commit_id":"39c5996eab6613213d68daeffaaa3478990fc3dc"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"76b0356f2f45641811332324da5440906a461a59","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        except exceptions.OVSFWTagNotFound as tag_not_found:"},{"line_number":592,"context_line":"            LOG.error(\"Tag was not found for port %(port_id)s: %(err)s.\","},{"line_number":593,"context_line":"                      {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":594,"context_line":"                       \u0027err\u0027: tag_not_found})"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    def _set_port_filters(self, of_port):"},{"line_number":597,"context_line":"        self.initialize_port_flows(of_port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_1fd0531f","line":594,"in_reply_to":"5fc1f717_2e1ad17c","updated":"2019-03-08 06:44:29.000000000","message":"Thanks for everybody for the help.","commit_id":"39c5996eab6613213d68daeffaaa3478990fc3dc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ef0ec21deb62f79320a06249831dbb1d3baa3987","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        except exceptions.OVSFWTagNotFound as tag_not_found:"},{"line_number":592,"context_line":"            LOG.error(\"Tag was not found for port %(port_id)s: %(err)s.\","},{"line_number":593,"context_line":"                      {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":594,"context_line":"                       \u0027err\u0027: tag_not_found})"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    def _set_port_filters(self, of_port):"},{"line_number":597,"context_line":"        self.initialize_port_flows(of_port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_d0474cbc","line":594,"in_reply_to":"5fc1f717_56d12a57","updated":"2019-03-06 14:14:23.000000000","message":"Lajos: See my comment in PS2. The bug is not that there is a trace in the logs but that ports don\u0027t have a vlan tag. It should not be happening.","commit_id":"39c5996eab6613213d68daeffaaa3478990fc3dc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2f4f2e32ca34d5dc5702d5ff248e207696b9df21","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        except exceptions.OVSFWTagNotFound as tag_not_found:"},{"line_number":592,"context_line":"            LOG.error(\"Tag was not found for port %(port_id)s: %(err)s.\","},{"line_number":593,"context_line":"                      {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":594,"context_line":"                       \u0027err\u0027: tag_not_found})"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    def _set_port_filters(self, of_port):"},{"line_number":597,"context_line":"        self.initialize_port_flows(of_port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_1a308556","line":594,"in_reply_to":"5fc1f717_d0474cbc","updated":"2019-03-06 21:52:11.000000000","message":"Yes, it\u0027s exactly what I wanted to suggest :)\nAnd as I saw in our ci logs it happened at least couple of times there. So we should maybe try to check during what operations it happens and try to understand and fix real culprit of this issue.","commit_id":"39c5996eab6613213d68daeffaaa3478990fc3dc"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"e1273066f34c7a0a7047087d15bdcae1d04ac528","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        except exceptions.OVSFWTagNotFound as tag_not_found:"},{"line_number":592,"context_line":"            LOG.error(\"Tag was not found for port %(port_id)s: %(err)s.\","},{"line_number":593,"context_line":"                      {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":594,"context_line":"                       \u0027err\u0027: tag_not_found})"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    def _set_port_filters(self, of_port):"},{"line_number":597,"context_line":"        self.initialize_port_flows(of_port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_2e1ad17c","line":594,"in_reply_to":"5fc1f717_d373bae6","updated":"2019-03-07 15:54:20.000000000","message":"Thanks Slawek. @Lajos, can you kindly update it to info.\nMay be you can add a comment here saying why we may hit this exception (like explained here).\n\nSorry for giving the trouble :)","commit_id":"39c5996eab6613213d68daeffaaa3478990fc3dc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c5fc0cdbd78b1f982c7e1f5109629577c07cba75","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        except exceptions.OVSFWTagNotFound as tag_not_found:"},{"line_number":592,"context_line":"            LOG.error(\"Tag was not found for port %(port_id)s: %(err)s.\","},{"line_number":593,"context_line":"                      {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":594,"context_line":"                       \u0027err\u0027: tag_not_found})"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    def _set_port_filters(self, of_port):"},{"line_number":597,"context_line":"        self.initialize_port_flows(of_port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_d373bae6","line":594,"in_reply_to":"5fc1f717_e5c86c56","updated":"2019-03-07 15:09:58.000000000","message":"thx Anil. If we know the reason of why this may happen than I\u0027m fine with log it as INFO instead of error.","commit_id":"39c5996eab6613213d68daeffaaa3478990fc3dc"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8b216d627b78e2097ae6d570b81b0de67fd2aa63","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        except exceptions.OVSFWTagNotFound as tag_not_found:"},{"line_number":592,"context_line":"            LOG.error(\"Tag was not found for port %(port_id)s: %(err)s.\","},{"line_number":593,"context_line":"                      {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":594,"context_line":"                       \u0027err\u0027: tag_not_found})"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    def _set_port_filters(self, of_port):"},{"line_number":597,"context_line":"        self.initialize_port_flows(of_port)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_56d12a57","line":594,"in_reply_to":"9fdfeff1_dd2185fe","updated":"2019-03-05 19:37:15.000000000","message":"Slawek: If I understand well the original bug report the ovs-agent log was polluted with stacktraces  for OVSFWTagNotFound, this patch \"converts\" the stacktrace to error log, so the problem can be tracked and we can collect logs/statistics to decide if this is a normal or not.","commit_id":"39c5996eab6613213d68daeffaaa3478990fc3dc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c5cf926fcaba62390f88257bdca71d95336b6599","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        except exceptions.OVSFWTagNotFound as tag_not_found:"},{"line_number":592,"context_line":"            LOG.info(\"Tag was not found for port %(port_id)s: %(err)s.\","},{"line_number":593,"context_line":"                     {\u0027port_id\u0027: port[\u0027device\u0027],"},{"line_number":594,"context_line":"                      \u0027err\u0027: tag_not_found})"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    def _set_port_filters(self, of_port):"},{"line_number":597,"context_line":"        self.initialize_port_flows(of_port)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_bec76a96","line":594,"updated":"2019-03-13 12:00:48.000000000","message":"I still think we should not leave port semi-configured.","commit_id":"22f55822aab17c758f5f723c304b1acaf3179ec1"}]}
