)]}'
{"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9c9e22b5cc2d032e52742a63263fbc48a0888550","unresolved":false,"context_lines":[{"line_number":640,"context_line":"            timestamp \u003d int(time.time()) + self.conf.dhcp_lease_duration"},{"line_number":641,"context_line":"        dhcp_enabled_subnet_ids \u003d [s.id for s in"},{"line_number":642,"context_line":"                                   self._get_all_subnets(self.network)"},{"line_number":643,"context_line":"                                   if s.enable_dhcp]"},{"line_number":644,"context_line":"        for host_tuple in self._iter_hosts():"},{"line_number":645,"context_line":"            port, alloc, hostname, name, no_dhcp, no_opts \u003d host_tuple"},{"line_number":646,"context_line":"            # don\u0027t write ip address which belongs to a dhcp disabled subnet"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_5dbc95db","line":643,"updated":"2019-01-15 15:26:54.000000000","message":"could also check s.ip_version \u003d\u003d 6 here to filter all the IPv6 subnets out, does overload the meaning of the variable name though.","commit_id":"062447b78a13552f798c9321abf5b2826fe22b9a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa75c8d0da13afb47893ebf1ed0df65d09c33534","unresolved":false,"context_lines":[{"line_number":640,"context_line":"            timestamp \u003d int(time.time()) + self.conf.dhcp_lease_duration"},{"line_number":641,"context_line":"        dhcp_enabled_subnet_ids \u003d [s.id for s in"},{"line_number":642,"context_line":"                                   self._get_all_subnets(self.network)"},{"line_number":643,"context_line":"                                   if s.enable_dhcp]"},{"line_number":644,"context_line":"        for host_tuple in self._iter_hosts():"},{"line_number":645,"context_line":"            port, alloc, hostname, name, no_dhcp, no_opts \u003d host_tuple"},{"line_number":646,"context_line":"            # don\u0027t write ip address which belongs to a dhcp disabled subnet"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_afc0a02b","line":643,"in_reply_to":"bfdaf3ff_1d14cd4d","updated":"2019-01-18 16:08:46.000000000","message":"Done","commit_id":"062447b78a13552f798c9321abf5b2826fe22b9a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa75c8d0da13afb47893ebf1ed0df65d09c33534","unresolved":false,"context_lines":[{"line_number":640,"context_line":"            timestamp \u003d int(time.time()) + self.conf.dhcp_lease_duration"},{"line_number":641,"context_line":"        dhcp_enabled_subnet_ids \u003d [s.id for s in"},{"line_number":642,"context_line":"                                   self._get_all_subnets(self.network)"},{"line_number":643,"context_line":"                                   if s.enable_dhcp]"},{"line_number":644,"context_line":"        for host_tuple in self._iter_hosts():"},{"line_number":645,"context_line":"            port, alloc, hostname, name, no_dhcp, no_opts \u003d host_tuple"},{"line_number":646,"context_line":"            # don\u0027t write ip address which belongs to a dhcp disabled subnet"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_8fc35c38","line":643,"in_reply_to":"bfdaf3ff_5dbc95db","updated":"2019-01-18 16:08:46.000000000","message":"Done","commit_id":"062447b78a13552f798c9321abf5b2826fe22b9a"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"1c29f455a8e3756d16d1e7f336d3f2f97c5b8d5a","unresolved":false,"context_lines":[{"line_number":640,"context_line":"            timestamp \u003d int(time.time()) + self.conf.dhcp_lease_duration"},{"line_number":641,"context_line":"        dhcp_enabled_subnet_ids \u003d [s.id for s in"},{"line_number":642,"context_line":"                                   self._get_all_subnets(self.network)"},{"line_number":643,"context_line":"                                   if s.enable_dhcp]"},{"line_number":644,"context_line":"        for host_tuple in self._iter_hosts():"},{"line_number":645,"context_line":"            port, alloc, hostname, name, no_dhcp, no_opts \u003d host_tuple"},{"line_number":646,"context_line":"            # don\u0027t write ip address which belongs to a dhcp disabled subnet"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_1d14cd4d","line":643,"in_reply_to":"bfdaf3ff_5dbc95db","updated":"2019-01-15 15:48:42.000000000","message":"I like that, sounds better to filter the subnets, than checking ip version on each host","commit_id":"062447b78a13552f798c9321abf5b2826fe22b9a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9c9e22b5cc2d032e52742a63263fbc48a0888550","unresolved":false,"context_lines":[{"line_number":644,"context_line":"        for host_tuple in self._iter_hosts():"},{"line_number":645,"context_line":"            port, alloc, hostname, name, no_dhcp, no_opts \u003d host_tuple"},{"line_number":646,"context_line":"            # don\u0027t write ip address which belongs to a dhcp disabled subnet"},{"line_number":647,"context_line":"            # or an IPv6 SLAAC/stateless subnet"},{"line_number":648,"context_line":"            if (no_dhcp or alloc.subnet_id not in dhcp_enabled_subnet_ids or"},{"line_number":649,"context_line":"                    common_utils.get_ip_version(alloc.ip_address) \u003d\u003d"},{"line_number":650,"context_line":"                    constants.IP_VERSION_6):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_1db60dfc","line":647,"updated":"2019-01-15 15:26:54.000000000","message":"nit: or any IPv6 address","commit_id":"062447b78a13552f798c9321abf5b2826fe22b9a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa75c8d0da13afb47893ebf1ed0df65d09c33534","unresolved":false,"context_lines":[{"line_number":644,"context_line":"        for host_tuple in self._iter_hosts():"},{"line_number":645,"context_line":"            port, alloc, hostname, name, no_dhcp, no_opts \u003d host_tuple"},{"line_number":646,"context_line":"            # don\u0027t write ip address which belongs to a dhcp disabled subnet"},{"line_number":647,"context_line":"            # or an IPv6 SLAAC/stateless subnet"},{"line_number":648,"context_line":"            if (no_dhcp or alloc.subnet_id not in dhcp_enabled_subnet_ids or"},{"line_number":649,"context_line":"                    common_utils.get_ip_version(alloc.ip_address) \u003d\u003d"},{"line_number":650,"context_line":"                    constants.IP_VERSION_6):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_4fdfb40c","line":647,"in_reply_to":"bfdaf3ff_1db60dfc","updated":"2019-01-18 16:08:46.000000000","message":"Done","commit_id":"062447b78a13552f798c9321abf5b2826fe22b9a"}]}
