)]}'
{"neutron/tests/fullstack/test_agent_bandwidth_report.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f4a36a31b794fd873fd211e247fef0f0d9147940","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            self._change_agent_config(l2_agent_config[\u0027sriov_nic\u0027], l2_agent,"},{"line_number":124,"context_line":"                                      \u0027physical_device_mappings\u0027, new_dev)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # TODO(lajoskatona): Check with SIG_HUP"},{"line_number":127,"context_line":"        l2_agent.restart()"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        report_interval \u003d l2_agent.neutron_config[\u0027agent\u0027][\u0027report_interval\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_9e517365","line":126,"range":{"start_line":126,"start_character":8,"end_line":126,"end_character":47},"updated":"2019-01-25 13:04:18.000000000","message":"I tried with l2_agent.stop(signal.SIGHUP) but that is not working.","commit_id":"36a32ae15bc815d24c19751086b5f5d17ec10b9d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6f7a2f8e0049af9ee169906684862c2a7eaa33ae","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        # Note(lajoskatona): to see if the agent restart was succesfull wait"},{"line_number":132,"context_line":"        # report_interval time and a \"little\"."},{"line_number":133,"context_line":"        # TODO(lajoskatona): Make this wait more intelligent."},{"line_number":134,"context_line":"        time.sleep(float(report_interval) + 5.0)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_agent_configuration_change(self):"},{"line_number":137,"context_line":"        self._add_new_bridge_and_restart_agent(self.environment.hosts[0])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_ad31e1a4","line":134,"updated":"2019-01-23 09:20:28.000000000","message":"I don\u0027t think it is necessary really.\nYou can instead use neutron.common.utils.wait_until_true() function instead of simple assert functions in _check_agent_configurations() method - it should be changed after some time :)","commit_id":"36a32ae15bc815d24c19751086b5f5d17ec10b9d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7f062c5df2ccea27fbdc3fd7e4ec5d2feec4103d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        # Note(lajoskatona): to see if the agent restart was succesfull wait"},{"line_number":132,"context_line":"        # report_interval time and a \"little\"."},{"line_number":133,"context_line":"        # TODO(lajoskatona): Make this wait more intelligent."},{"line_number":134,"context_line":"        time.sleep(float(report_interval) + 5.0)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_agent_configuration_change(self):"},{"line_number":137,"context_line":"        self._add_new_bridge_and_restart_agent(self.environment.hosts[0])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_868e20ce","line":134,"in_reply_to":"9fdfeff1_ad31e1a4","updated":"2019-01-24 16:59:11.000000000","message":"Thanks, good tip.\nI started to play with wait_until_true, and it\u0027s tricky:\nAfter agent restart, I can GET agent, and it will still have the same field values, so I can\u0027t assert for the config change.\nIt seems that I have to add anyway a timeout after restart and call wait_until_true after.\n\nI think on it, how to come over this....","commit_id":"36a32ae15bc815d24c19751086b5f5d17ec10b9d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f4a36a31b794fd873fd211e247fef0f0d9147940","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        # Note(lajoskatona): to see if the agent restart was succesfull wait"},{"line_number":132,"context_line":"        # report_interval time and a \"little\"."},{"line_number":133,"context_line":"        # TODO(lajoskatona): Make this wait more intelligent."},{"line_number":134,"context_line":"        time.sleep(float(report_interval) + 5.0)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_agent_configuration_change(self):"},{"line_number":137,"context_line":"        self._add_new_bridge_and_restart_agent(self.environment.hosts[0])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_7e6daf30","line":134,"in_reply_to":"9fdfeff1_ad31e1a4","updated":"2019-01-25 13:04:18.000000000","message":"thanks, with this wait_until_true it\u0027s much failsafer I think.","commit_id":"36a32ae15bc815d24c19751086b5f5d17ec10b9d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6f7a2f8e0049af9ee169906684862c2a7eaa33ae","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        self._add_new_bridge_and_restart_agent(self.environment.hosts[0])"},{"line_number":138,"context_line":"        agents \u003d self.client.list_agents()"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        self.assertEqual(1, len(agents[\u0027agents\u0027]))"},{"line_number":141,"context_line":"        self.assertTrue(agents[\u0027agents\u0027][0][\u0027alive\u0027], \u0027Agent is not alive!\u0027)"},{"line_number":142,"context_line":"        self._check_agent_configurations(agents[\u0027agents\u0027][0])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_8dbc1ddd","line":141,"range":{"start_line":140,"start_character":0,"end_line":141,"end_character":76},"updated":"2019-01-23 09:20:28.000000000","message":"I\u0027m not sure if You really need those assertions.","commit_id":"36a32ae15bc815d24c19751086b5f5d17ec10b9d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f4a36a31b794fd873fd211e247fef0f0d9147940","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        self._add_new_bridge_and_restart_agent(self.environment.hosts[0])"},{"line_number":138,"context_line":"        agents \u003d self.client.list_agents()"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        self.assertEqual(1, len(agents[\u0027agents\u0027]))"},{"line_number":141,"context_line":"        self.assertTrue(agents[\u0027agents\u0027][0][\u0027alive\u0027], \u0027Agent is not alive!\u0027)"},{"line_number":142,"context_line":"        self._check_agent_configurations(agents[\u0027agents\u0027][0])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_fe62ff3d","line":141,"range":{"start_line":140,"start_character":0,"end_line":141,"end_character":76},"in_reply_to":"9fdfeff1_8dbc1ddd","updated":"2019-01-25 13:04:18.000000000","message":"removed","commit_id":"36a32ae15bc815d24c19751086b5f5d17ec10b9d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2354db9d9a3a60f3d0669ec172659daa174ebb1d","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        utils.wait_until_true("},{"line_number":168,"context_line":"            predicate\u003dcheck_agent_alive,"},{"line_number":169,"context_line":"            timeout\u003dfloat(report_interval) + 10,"},{"line_number":170,"context_line":"            sleep\u003d5)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_b6069bcd","line":170,"updated":"2019-01-30 10:27:01.000000000","message":"one more thing, maybe You can merge those two tests into one? It will then require spawning less processes which will be simply faster a bit :)\nI think that You can update physnets and restart agent just after line 71 and then wait until this new config is set and reported","commit_id":"a8b85d0e7a0662d84aa790d7058b297afb5417a1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a312d071775283e61dd0e9e40a629ce0c7582538","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        utils.wait_until_true("},{"line_number":168,"context_line":"            predicate\u003dcheck_agent_alive,"},{"line_number":169,"context_line":"            timeout\u003dfloat(report_interval) + 10,"},{"line_number":170,"context_line":"            sleep\u003d5)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_5c20809b","line":170,"in_reply_to":"9fdfeff1_b6069bcd","updated":"2019-02-01 13:34:17.000000000","message":"I merged the two testcases.","commit_id":"a8b85d0e7a0662d84aa790d7058b297afb5417a1"}]}
