)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"465943151bb14add3c049d10d3ec57c9abd988d8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since the ML2 plugin can concurrently support different L2 agents (or"},{"line_number":10,"context_line":"other mechanisms) with different configurations, it is recommended to set"},{"line_number":11,"context_line":"firewall_driver flag in ml2 configuration."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I970fbc545d6970dacd520865aa33cd774643263a"},{"line_number":14,"context_line":"Closes-bug: #1262678"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F8wZk%3D","line":11,"updated":"2013-12-20 16:32:13.000000000","message":"I suggest clarifying this a bit:\n\nSince the ML2 plugin can concurrently support different L2 agents (or other mechanisms) with different configuration files, the actual firewall_driver value does not matter in the server, but firewall_driver must be set to a non-default value in the ml2 configuration to enable the securitygroup extension.","commit_id":"cf6a590c591a1964e4cf84f1ee6c760832d7fd25"}],"etc/neutron/plugins/ml2/ml2_conf.ini":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"d8e2c72e5a650fa9e6d51bd8fc44bd4bfe5ffeb4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"# Example: vxlan_group \u003d 239.1.1.1"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[securitygroup]"},{"line_number":57,"context_line":"# Enable neutron security group function by setting something."},{"line_number":58,"context_line":"# firewall_driver \u003d neutron.agent.firewall.NoopFirewallDriver"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAATn%2F8xMo%3D","line":57,"updated":"2013-12-20 14:30:04.000000000","message":"I would re-phrase the comment, how about that?\n(StrOpt) Firewall driver. Default is NoopFirewallDriver, that disables the firewall functionalities","commit_id":"cf6a590c591a1964e4cf84f1ee6c760832d7fd25"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"465943151bb14add3c049d10d3ec57c9abd988d8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"# Example: vxlan_group \u003d 239.1.1.1"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[securitygroup]"},{"line_number":57,"context_line":"# Enable neutron security group function by setting something."},{"line_number":58,"context_line":"# firewall_driver \u003d neutron.agent.firewall.NoopFirewallDriver"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAATn%2F8wcQ%3D","line":57,"in_reply_to":"AAAATn%2F8xMo%3D","updated":"2013-12-20 16:32:13.000000000","message":"I suggest:\n\n(StrOpt) Firewall driver. Default value (neutron.agent.firewall.NoopFirewallDriver) disables the securitygroup extension in the server. Set to any other value to enable the securitygroup extension.","commit_id":"cf6a590c591a1964e4cf84f1ee6c760832d7fd25"},{"author":{"_account_id":6670,"name":"Amir Sadoughi","email":"amir.sadoughi@rackspace.com","username":"amir-sadoughi"},"change_message_id":"a45a69dab6f0954f026c584b5b9f9833edfbca07","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[securitygroup]"},{"line_number":57,"context_line":"# Enable neutron security group function by setting something."},{"line_number":58,"context_line":"# firewall_driver \u003d neutron.agent.firewall.NoopFirewallDriver"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAATn%2F80Ew%3D","line":58,"updated":"2013-12-20 02:06:16.000000000","message":"Setting it to neutron.agent.firewall.NoopFirewallDriver will actually still disable security groups from my reading of neutron/agent/securitygroups_rpc.disable_security_group_extension_if_noop_driver.\nI liked Bob\u0027s suggestion in his bug comment: dummy_value_to_enable_security_groups_in_server.","commit_id":"cf6a590c591a1964e4cf84f1ee6c760832d7fd25"},{"author":{"_account_id":6670,"name":"Amir Sadoughi","email":"amir.sadoughi@rackspace.com","username":"amir-sadoughi"},"change_message_id":"b2df79e0f75a07f0b57964b41ae6103016c702dd","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[securitygroup]"},{"line_number":57,"context_line":"# Enable neutron security group function by setting something."},{"line_number":58,"context_line":"# firewall_driver \u003d neutron.agent.firewall.NoopFirewallDriver"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAATn%2F80D0%3D","line":58,"in_reply_to":"AAAATn%2F80Ew%3D","updated":"2013-12-20 02:10:23.000000000","message":"Oh, nevermind, I see this is the default.","commit_id":"cf6a590c591a1964e4cf84f1ee6c760832d7fd25"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"a8f0a9123418d03d461c88162bc08f3ca51ecbb4","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# (StrOpt) Firewall driver. Default value (neutron.agent.firewall.NoopFirewallDriver) disables the securitygroup extension in the server."},{"line_number":58,"context_line":"# Set to any other value to enable the securitygroup extension."},{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"# firewall_driver \u003d"},{"line_number":61,"context_line":"# Example: firewall_driver \u003d neutron.agent.firewall.NoopFirewallDriver"}],"source_content_type":"text/x-properties","patch_set":2,"id":"AAAATn%2F8vkA%3D","line":60,"updated":"2013-12-20 19:36:52.000000000","message":"This indicates that the default value is a blank string. But you have set the default to neutron.agent.firewall.NoopFirewallDriver in ml2/config.py","commit_id":"b1e41e25c7af00ecea39e06c37c12d802d750ff8"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"7dd8e75b3d32599b8851c20f661c7142d3caecc5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"# Example: vxlan_group \u003d 239.1.1.1"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[securitygroup]"},{"line_number":57,"context_line":"# (StrOpt) Firewall driver. Default value (neutron.agent.firewall.NoopFirewallDriver) disables the securitygroup extension in the server."},{"line_number":58,"context_line":"# Set to any other value to enable the securitygroup extension."},{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"# firewall_driver \u003d neutron.agent.firewall.NoopFirewallDriver"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAATn%2F8vX0%3D","line":57,"updated":"2013-12-20 20:32:04.000000000","message":"nit: Maybe this should wrap at ~70 chars (or whatever line 50 is at) to made it more tidy.","commit_id":"bba5a4c0376ee6fc8772461bf381140352d8637d"}],"neutron/plugins/ml2/config.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"d8e2c72e5a650fa9e6d51bd8fc44bd4bfe5ffeb4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    cfg.StrOpt("},{"line_number":40,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":41,"context_line":"        default\u003d\u0027neutron.agent.firewall.NoopFirewallDriver\u0027,"},{"line_number":42,"context_line":"        help\u003d_(\u0027Enable neutron security group function by setting something\u0027))"},{"line_number":43,"context_line":"]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F8xMA%3D","line":42,"updated":"2013-12-20 14:30:04.000000000","message":"Same here. I\u0027d rephrase. \"Firewall driver, default is NoopFirewallDriver, that means no firewall functionalities\"","commit_id":"cf6a590c591a1964e4cf84f1ee6c760832d7fd25"}]}