)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f57932eeaa68bb9f31b14a0e1a50fe835eb89e95","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     liuchengqian90 \u003cxieling1990.happy@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-02-01 00:38:07 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update the processing of assigned addresses when assigning addresses"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It is best not to use \u0027netaddr.IPSet.add\u0027,"},{"line_number":10,"context_line":"because _compact_single_network in \u0027IPSet.add\u0027 is quite time consuming"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fdfeff1_551aa516","line":7,"updated":"2019-01-31 18:20:41.000000000","message":"This is a bit different from the bug description. I\u0027m not saying the code is wrong, not at all.\n\nCould you explain just in a single paragraph what you are doing? Iterating over the subnet pools to \"collect\" IPs.\n\nThanks!","commit_id":"dfe5dfb4a2008dee973bc0b174e1ee64931fa9f0"}],"neutron/ipam/drivers/neutrondb_ipam/driver.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"eb38404bf797ee0cabd2806678a6b55112686f36","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    def _generate_ips(self, context, prefer_next\u003dFalse, num_addresses\u003d1):"},{"line_number":161,"context_line":"        \"\"\"Generate a set of IPs from the set of available addresses.\"\"\""},{"line_number":162,"context_line":"        allocated_ips \u003d []"},{"line_number":163,"context_line":"        # Note that it is best to set the debug for db (connection_debug)"},{"line_number":164,"context_line":"        # in the configuration file to 0 (default value),"},{"line_number":165,"context_line":"        # because when there are too many records in the DB,"},{"line_number":166,"context_line":"        # printing the log will take a long time."}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_443eb08b","line":163,"range":{"start_line":163,"start_character":26,"end_line":163,"end_character":30},"updated":"2019-01-29 13:10:52.000000000","message":"nit: better","commit_id":"3fd3eca7953de962bdec2d64b8636af0765a214f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"eb38404bf797ee0cabd2806678a6b55112686f36","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    def _generate_ips(self, context, prefer_next\u003dFalse, num_addresses\u003d1):"},{"line_number":161,"context_line":"        \"\"\"Generate a set of IPs from the set of available addresses.\"\"\""},{"line_number":162,"context_line":"        allocated_ips \u003d []"},{"line_number":163,"context_line":"        # Note that it is best to set the debug for db (connection_debug)"},{"line_number":164,"context_line":"        # in the configuration file to 0 (default value),"},{"line_number":165,"context_line":"        # because when there are too many records in the DB,"},{"line_number":166,"context_line":"        # printing the log will take a long time."},{"line_number":167,"context_line":"        allocations \u003d self.subnet_manager.list_allocations(context)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_a4343c94","line":164,"range":{"start_line":163,"start_character":34,"end_line":164,"end_character":56},"updated":"2019-01-29 13:10:52.000000000","message":"remain database connection_debug to 0 (default value) in the configuration for production environment.","commit_id":"3fd3eca7953de962bdec2d64b8636af0765a214f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"eb38404bf797ee0cabd2806678a6b55112686f36","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        # because when there are too many records in the DB,"},{"line_number":166,"context_line":"        # printing the log will take a long time."},{"line_number":167,"context_line":"        allocations \u003d self.subnet_manager.list_allocations(context)"},{"line_number":168,"context_line":"        # It is best not to use \u0027netaddr.IPSet.add\u0027,"},{"line_number":169,"context_line":"        # because _compact_single_network in \u0027IPSet.add\u0027"},{"line_number":170,"context_line":"        # is quite time consuming."},{"line_number":171,"context_line":"        ip_allocations \u003d netaddr.IPSet("}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_7524bcaf","line":168,"range":{"start_line":168,"start_character":16,"end_line":168,"end_character":20},"updated":"2019-01-29 13:10:52.000000000","message":"nit: better","commit_id":"3fd3eca7953de962bdec2d64b8636af0765a214f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"eb38404bf797ee0cabd2806678a6b55112686f36","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            if av_set.size \u003d\u003d 0:"},{"line_number":180,"context_line":"                continue"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"            pool_num_addresses \u003d num_addresses"},{"line_number":183,"context_line":"            if av_set.size \u003c num_addresses:"},{"line_number":184,"context_line":"                # Allocate enough addresses first,"},{"line_number":185,"context_line":"                # and the remaining addresses will be allocated"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_55a2d8fd","line":182,"range":{"start_line":182,"start_character":12,"end_line":182,"end_character":30},"updated":"2019-01-29 13:10:52.000000000","message":"\"num_addresses\" is the needed IP quantity, so this should be \"allocated_address_num\" ? And starts with:\nallocated_address_num \u003d 0 ?","commit_id":"3fd3eca7953de962bdec2d64b8636af0765a214f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"eb38404bf797ee0cabd2806678a6b55112686f36","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"            pool_num_addresses \u003d num_addresses"},{"line_number":183,"context_line":"            if av_set.size \u003c num_addresses:"},{"line_number":184,"context_line":"                # Allocate enough addresses first,"},{"line_number":185,"context_line":"                # and the remaining addresses will be allocated"},{"line_number":186,"context_line":"                # in the next address pool."},{"line_number":187,"context_line":"                pool_num_addresses \u003d av_set.size"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"            if prefer_next:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_556df8c9","line":186,"range":{"start_line":184,"start_character":16,"end_line":186,"end_character":43},"updated":"2019-01-29 13:10:52.000000000","message":"This is a little confusing.","commit_id":"3fd3eca7953de962bdec2d64b8636af0765a214f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"eb38404bf797ee0cabd2806678a6b55112686f36","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            if av_set.size \u003c num_addresses:"},{"line_number":184,"context_line":"                # Allocate enough addresses first,"},{"line_number":185,"context_line":"                # and the remaining addresses will be allocated"},{"line_number":186,"context_line":"                # in the next address pool."},{"line_number":187,"context_line":"                pool_num_addresses \u003d av_set.size"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"            if prefer_next:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_75727caf","line":186,"range":{"start_line":186,"start_character":38,"end_line":186,"end_character":42},"updated":"2019-01-29 13:10:52.000000000","message":"pools","commit_id":"3fd3eca7953de962bdec2d64b8636af0765a214f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"eb38404bf797ee0cabd2806678a6b55112686f36","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                pool_num_addresses \u003d av_set.size"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"            if prefer_next:"},{"line_number":190,"context_line":"                allocated_ip_pool \u003d list(itertools.islice(av_set,"},{"line_number":191,"context_line":"                    pool_num_addresses))"},{"line_number":192,"context_line":"                return [str(allocated_ip)"},{"line_number":193,"context_line":"                        for allocated_ip in allocated_ip_pool]"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"            window \u003d min(av_set.size, MAX_WIN)"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_f5718c45","line":193,"range":{"start_line":190,"start_character":16,"end_line":193,"end_character":62},"updated":"2019-01-29 13:10:52.000000000","message":"If pool_num_addresses (av_set.size) is less than  the prefer_next request number, then here will not return enough IPs.","commit_id":"3fd3eca7953de962bdec2d64b8636af0765a214f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"eb38404bf797ee0cabd2806678a6b55112686f36","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                allocated_ips.extend([str(allocated_ip)"},{"line_number":211,"context_line":"                                      for allocated_ip in allocated_ip_pool])"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"            num_addresses -\u003d pool_num_addresses"},{"line_number":214,"context_line":"            if num_addresses:"},{"line_number":215,"context_line":"                continue"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_3572b47c","line":213,"range":{"start_line":213,"start_character":12,"end_line":213,"end_character":25},"updated":"2019-01-29 13:10:52.000000000","message":"We should not change the parm\u0027s value.","commit_id":"3fd3eca7953de962bdec2d64b8636af0765a214f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"eb38404bf797ee0cabd2806678a6b55112686f36","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                                      for allocated_ip in allocated_ip_pool])"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"            num_addresses -\u003d pool_num_addresses"},{"line_number":214,"context_line":"            if num_addresses:"},{"line_number":215,"context_line":"                continue"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"            return allocated_ips"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_75803c47","line":214,"range":{"start_line":214,"start_character":12,"end_line":214,"end_character":29},"updated":"2019-01-29 13:10:52.000000000","message":"if allocated_address_num !\u003d num_addresses ?","commit_id":"3fd3eca7953de962bdec2d64b8636af0765a214f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"eb38404bf797ee0cabd2806678a6b55112686f36","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                continue"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"            return allocated_ips"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        raise ipam_exc.IpAddressGenerationFailure("},{"line_number":220,"context_line":"                  subnet_id\u003dself.subnet_manager.neutron_id)"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_35495430","line":218,"updated":"2019-01-29 13:10:52.000000000","message":"The temporary variable in this function looks confusing and needs some refactor.","commit_id":"3fd3eca7953de962bdec2d64b8636af0765a214f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"49473a83d8f372ec48a8b228d41198b6a7af0bfc","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                # All expected addresses can be assigned in this loop."},{"line_number":190,"context_line":"                allocated_num_addresses \u003d expected_num_addresses"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"            if prefer_next:"},{"line_number":193,"context_line":"                allocated_ip_pool \u003d list(itertools.islice(av_set,"},{"line_number":194,"context_line":"                    allocated_num_addresses))"},{"line_number":195,"context_line":"                allocated_ips.extend([str(allocated_ip)"},{"line_number":196,"context_line":"                                      for allocated_ip in allocated_ip_pool])"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"                expected_num_addresses -\u003d allocated_num_addresses"},{"line_number":199,"context_line":"                if expected_num_addresses:"},{"line_number":200,"context_line":"                    # More addresses need to be allocated in the next loop."},{"line_number":201,"context_line":"                    continue"},{"line_number":202,"context_line":"                return allocated_ips"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"            window \u003d min(av_set.size, MAX_WIN)"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_16ce75b3","line":202,"range":{"start_line":192,"start_character":12,"end_line":202,"end_character":36},"updated":"2019-01-31 06:18:51.000000000","message":"We have test case for this block?","commit_id":"45fb2a38bc635d0b149a27579f91a6d161a08e73"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f57932eeaa68bb9f31b14a0e1a50fe835eb89e95","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    def _generate_ips(self, context, prefer_next\u003dFalse, num_addresses\u003d1):"},{"line_number":161,"context_line":"        \"\"\"Generate a set of IPs from the set of available addresses.\"\"\""},{"line_number":162,"context_line":"        allocated_ips \u003d []"},{"line_number":163,"context_line":"        expected_num_addresses \u003d num_addresses"},{"line_number":164,"context_line":"        # Note that it is better to remain database connection_debug to 0"},{"line_number":165,"context_line":"        # (default value) in the configuration for production environment."},{"line_number":166,"context_line":"        # Because when there are too many records in the DB,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9fdfeff1_1563bdb3","line":163,"updated":"2019-01-31 18:20:41.000000000","message":"Why do you need this new variable? You can use num_addresses","commit_id":"dfe5dfb4a2008dee973bc0b174e1ee64931fa9f0"},{"author":{"_account_id":25643,"name":"Chengqian Liu","email":"xieling1990.happy@163.com","username":"25643"},"change_message_id":"1cb49fd838243f6b207c92eb80e77f73760e554f","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    def _generate_ips(self, context, prefer_next\u003dFalse, num_addresses\u003d1):"},{"line_number":161,"context_line":"        \"\"\"Generate a set of IPs from the set of available addresses.\"\"\""},{"line_number":162,"context_line":"        allocated_ips \u003d []"},{"line_number":163,"context_line":"        expected_num_addresses \u003d num_addresses"},{"line_number":164,"context_line":"        # Note that it is better to remain database connection_debug to 0"},{"line_number":165,"context_line":"        # (default value) in the configuration for production environment."},{"line_number":166,"context_line":"        # Because when there are too many records in the DB,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9fdfeff1_d99a4712","line":163,"in_reply_to":"9fdfeff1_1563bdb3","updated":"2019-02-01 06:38:48.000000000","message":"Thank you for your review.\nI use expected_num_addresses to indicate the number of addresses I want to allocate in each loop (the first time is definitely the same as num_addresses).\nAnd YuLong suggested that I don\u0027t change the parm\u0027s value.","commit_id":"dfe5dfb4a2008dee973bc0b174e1ee64931fa9f0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f57932eeaa68bb9f31b14a0e1a50fe835eb89e95","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        \"\"\"Generate a set of IPs from the set of available addresses.\"\"\""},{"line_number":162,"context_line":"        allocated_ips \u003d []"},{"line_number":163,"context_line":"        expected_num_addresses \u003d num_addresses"},{"line_number":164,"context_line":"        # Note that it is better to remain database connection_debug to 0"},{"line_number":165,"context_line":"        # (default value) in the configuration for production environment."},{"line_number":166,"context_line":"        # Because when there are too many records in the DB,"},{"line_number":167,"context_line":"        # printing the log will take a long time."}],"source_content_type":"text/x-python","patch_set":13,"id":"9fdfeff1_555385e2","line":164,"updated":"2019-01-31 18:20:41.000000000","message":"I don\u0027t think this comment is needed","commit_id":"dfe5dfb4a2008dee973bc0b174e1ee64931fa9f0"},{"author":{"_account_id":25643,"name":"Chengqian Liu","email":"xieling1990.happy@163.com","username":"25643"},"change_message_id":"1cb49fd838243f6b207c92eb80e77f73760e554f","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        \"\"\"Generate a set of IPs from the set of available addresses.\"\"\""},{"line_number":162,"context_line":"        allocated_ips \u003d []"},{"line_number":163,"context_line":"        expected_num_addresses \u003d num_addresses"},{"line_number":164,"context_line":"        # Note that it is better to remain database connection_debug to 0"},{"line_number":165,"context_line":"        # (default value) in the configuration for production environment."},{"line_number":166,"context_line":"        # Because when there are too many records in the DB,"},{"line_number":167,"context_line":"        # printing the log will take a long time."}],"source_content_type":"text/x-python","patch_set":13,"id":"9fdfeff1_398b53c3","line":164,"in_reply_to":"9fdfeff1_555385e2","updated":"2019-02-01 06:38:48.000000000","message":"This place also has an impact on performance, so I feel that it is better to indicate.","commit_id":"dfe5dfb4a2008dee973bc0b174e1ee64931fa9f0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f57932eeaa68bb9f31b14a0e1a50fe835eb89e95","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            [netaddr.IPAddress(allocation.ip_address)"},{"line_number":174,"context_line":"             for allocation in allocations])"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        for ip_pool in self.subnet_manager.list_pools(context):"},{"line_number":177,"context_line":"            ip_set \u003d netaddr.IPSet()"},{"line_number":178,"context_line":"            ip_set.add(netaddr.IPRange(ip_pool.first_ip, ip_pool.last_ip))"},{"line_number":179,"context_line":"            av_set \u003d ip_set.difference(ip_allocations)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9fdfeff1_9597ad48","line":176,"updated":"2019-01-31 18:20:41.000000000","message":"Just one question: is OK when we are executing \"bulk_allocate\" to retrieve IPs from different subnets?","commit_id":"dfe5dfb4a2008dee973bc0b174e1ee64931fa9f0"},{"author":{"_account_id":25643,"name":"Chengqian Liu","email":"xieling1990.happy@163.com","username":"25643"},"change_message_id":"1cb49fd838243f6b207c92eb80e77f73760e554f","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            [netaddr.IPAddress(allocation.ip_address)"},{"line_number":174,"context_line":"             for allocation in allocations])"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        for ip_pool in self.subnet_manager.list_pools(context):"},{"line_number":177,"context_line":"            ip_set \u003d netaddr.IPSet()"},{"line_number":178,"context_line":"            ip_set.add(netaddr.IPRange(ip_pool.first_ip, ip_pool.last_ip))"},{"line_number":179,"context_line":"            av_set \u003d ip_set.difference(ip_allocations)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9fdfeff1_b9c0a3e2","line":176,"in_reply_to":"9fdfeff1_9597ad48","updated":"2019-02-01 06:38:48.000000000","message":"Sorry, I don\u0027t quite understand what you mean.\nThis is a subnet address management class, how to execute it in another subnet class?","commit_id":"dfe5dfb4a2008dee973bc0b174e1ee64931fa9f0"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"74cc0a5743cce64b7d9629ad7ab547036d1faced","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    def _generate_ips(self, context, prefer_next\u003dFalse, num_addresses\u003d1):"},{"line_number":161,"context_line":"        \"\"\"Generate a set of IPs from the set of available addresses.\"\"\""},{"line_number":162,"context_line":"        allocated_ips \u003d []"},{"line_number":163,"context_line":"        expected_num_addresses \u003d num_addresses"},{"line_number":164,"context_line":"        # Note that it is better to remain database connection_debug to 0"},{"line_number":165,"context_line":"        # (default value) in the configuration for production environment."},{"line_number":166,"context_line":"        # Because when there are too many records in the DB,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9fdfeff1_9b66ce29","line":163,"range":{"start_line":163,"start_character":8,"end_line":163,"end_character":16},"updated":"2019-02-04 20:10:53.000000000","message":"super-nit: requested instead of expected?","commit_id":"1d660755a3acb1e99e8db3df4ec0374cfc9e2b64"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"74cc0a5743cce64b7d9629ad7ab547036d1faced","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        \"\"\"Generate a set of IPs from the set of available addresses.\"\"\""},{"line_number":162,"context_line":"        allocated_ips \u003d []"},{"line_number":163,"context_line":"        expected_num_addresses \u003d num_addresses"},{"line_number":164,"context_line":"        # Note that it is better to remain database connection_debug to 0"},{"line_number":165,"context_line":"        # (default value) in the configuration for production environment."},{"line_number":166,"context_line":"        # Because when there are too many records in the DB,"},{"line_number":167,"context_line":"        # printing the log will take a long time."},{"line_number":168,"context_line":"        allocations \u003d self.subnet_manager.list_allocations(context)"},{"line_number":169,"context_line":"        # It is better not to use \u0027netaddr.IPSet.add\u0027,"},{"line_number":170,"context_line":"        # because _compact_single_network in \u0027IPSet.add\u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"9fdfeff1_0e6ffe92","line":167,"range":{"start_line":164,"start_character":8,"end_line":167,"end_character":49},"updated":"2019-02-04 20:10:53.000000000","message":"I\u0027m not seeing how this comment in applicable here (continuing the discussion from previous patch sets)","commit_id":"1d660755a3acb1e99e8db3df4ec0374cfc9e2b64"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"74cc0a5743cce64b7d9629ad7ab547036d1faced","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        # It is better not to use \u0027netaddr.IPSet.add\u0027,"},{"line_number":170,"context_line":"        # because _compact_single_network in \u0027IPSet.add\u0027"},{"line_number":171,"context_line":"        # is quite time consuming."},{"line_number":172,"context_line":"        ip_allocations \u003d netaddr.IPSet("},{"line_number":173,"context_line":"            [netaddr.IPAddress(allocation.ip_address)"},{"line_number":174,"context_line":"             for allocation in allocations])"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        for ip_pool in self.subnet_manager.list_pools(context):"},{"line_number":177,"context_line":"            ip_set \u003d netaddr.IPSet()"}],"source_content_type":"text/x-python","patch_set":16,"id":"9fdfeff1_3b448274","line":174,"range":{"start_line":172,"start_character":8,"end_line":174,"end_character":44},"updated":"2019-02-04 20:10:53.000000000","message":"The performance of IPSet.add() is an interesting find, good catch.","commit_id":"1d660755a3acb1e99e8db3df4ec0374cfc9e2b64"}],"neutron/tests/unit/ipam/drivers/neutrondb_ipam/test_driver.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"74cc0a5743cce64b7d9629ad7ab547036d1faced","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        self.assertEqual(target_ip_count, len(ip_addresses))"},{"line_number":397,"context_line":"        self.assertRaises(ipam_exc.IpAddressGenerationFailure,"},{"line_number":398,"context_line":"                          ipam_subnet.bulk_allocate,"},{"line_number":399,"context_line":"                          ipam_req.BulkAddressRequest(target_ip_count))"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def test_prefernext_allocate_multiple_address_pools(self):"},{"line_number":402,"context_line":"        ipam_subnet \u003d self._create_and_allocate_ipam_subnet("}],"source_content_type":"text/x-python","patch_set":16,"id":"9fdfeff1_eea07a94","line":399,"range":{"start_line":399,"start_character":54,"end_line":399,"end_character":69},"updated":"2019-02-04 20:10:53.000000000","message":"Can we make this value 2? That might make the boundary case you\u0027re here a little more clear. Or, maybe it makes even more sense to allocate 10 addresses first, then assert that the next request for an 11th (or 11th and 12th if testing bulk) fails.","commit_id":"1d660755a3acb1e99e8db3df4ec0374cfc9e2b64"}]}
