)]}'
{"neutron/tests/functional/services/portforwarding/test_port_forwarding.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9fe5076028e489329fd1df98b6a0c29fce7636b3","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.port \u003d self._create_port("},{"line_number":108,"context_line":"            self.fmt, self.net[\u0027id\u0027],"},{"line_number":109,"context_line":"            fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnet[\u0027id\u0027],"},{"line_number":110,"context_line":"                        \u0027ip_address\u0027: \u002710.0.0.100\u0027}]).json[\u0027port\u0027]"},{"line_number":111,"context_line":"        self.port_forwarding \u003d {"},{"line_number":112,"context_line":"            apidef.RESOURCE_NAME:"},{"line_number":113,"context_line":"                {apidef.EXTERNAL_PORT: 2225,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_c546d0c0","side":"PARENT","line":110,"updated":"2019-02-01 21:48:21.000000000","message":"This was just added in https://review.openstack.org/#/c/631815/ - we should revert that if it didn\u0027t work and try to get something that addresses the comments on L102-106.","commit_id":"f3810d0da3fcb10abc703ec5ce1f024ec7e053fb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"937a81ba8738f70078b7f922ac89d469ab6a868b","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.port \u003d self._create_port("},{"line_number":108,"context_line":"            self.fmt, self.net[\u0027id\u0027],"},{"line_number":109,"context_line":"            fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnet[\u0027id\u0027],"},{"line_number":110,"context_line":"                        \u0027ip_address\u0027: \u002710.0.0.100\u0027}]).json[\u0027port\u0027]"},{"line_number":111,"context_line":"        self.port_forwarding \u003d {"},{"line_number":112,"context_line":"            apidef.RESOURCE_NAME:"},{"line_number":113,"context_line":"                {apidef.EXTERNAL_PORT: 2225,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_22822501","side":"PARENT","line":110,"in_reply_to":"9fdfeff1_c546d0c0","updated":"2019-02-04 04:46:53.000000000","message":"yeah, I forgot about this :/ I will have to do this differently than","commit_id":"f3810d0da3fcb10abc703ec5ce1f024ec7e053fb"}],"neutron/tests/unit/db/test_db_base_plugin_v2.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"b3fa5b852313c95ab5d18d1add2596afa384a9db","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        data \u003d self._deserializers[ctype].deserialize(response.body)[\u0027body\u0027]"},{"line_number":290,"context_line":"        return data"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def _find_ip_address(self, subnet):"},{"line_number":293,"context_line":"        network_ports \u003d self._list_ports("},{"line_number":294,"context_line":"            \"json\", 200, subnet[\u0027network_id\u0027]).json[\u0027ports\u0027]"},{"line_number":295,"context_line":"        used_ips \u003d set()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_fe9c966b","line":292,"range":{"start_line":292,"start_character":8,"end_line":292,"end_character":24},"updated":"2019-02-05 16:27:19.000000000","message":"Is it possible to combine this one and the fullstack one (https://github.com/openstack/neutron/blob/master/neutron/tests/fullstack/base.py#L126) into one method?","commit_id":"414bdd4c5997886c97d0e3a0b19c684dafeabb7a"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"6981c574ce4e3d4b1c63f4238c54a016d2c8bd8a","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        data \u003d self._deserializers[ctype].deserialize(response.body)[\u0027body\u0027]"},{"line_number":290,"context_line":"        return data"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def _find_ip_address(self, subnet):"},{"line_number":293,"context_line":"        network_ports \u003d self._list_ports("},{"line_number":294,"context_line":"            \"json\", 200, subnet[\u0027network_id\u0027]).json[\u0027ports\u0027]"},{"line_number":295,"context_line":"        used_ips \u003d set()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_9d18dd75","line":292,"range":{"start_line":292,"start_character":8,"end_line":292,"end_character":24},"in_reply_to":"9fdfeff1_0d584454","updated":"2019-02-06 15:35:52.000000000","message":"Sure. Fine with me.","commit_id":"414bdd4c5997886c97d0e3a0b19c684dafeabb7a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"641fb36ca2263de8cc5593d24bff39bddb5dea80","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        data \u003d self._deserializers[ctype].deserialize(response.body)[\u0027body\u0027]"},{"line_number":290,"context_line":"        return data"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def _find_ip_address(self, subnet):"},{"line_number":293,"context_line":"        network_ports \u003d self._list_ports("},{"line_number":294,"context_line":"            \"json\", 200, subnet[\u0027network_id\u0027]).json[\u0027ports\u0027]"},{"line_number":295,"context_line":"        used_ips \u003d set()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_0d584454","line":292,"range":{"start_line":292,"start_character":8,"end_line":292,"end_character":24},"in_reply_to":"9fdfeff1_fe9c966b","updated":"2019-02-06 11:46:56.000000000","message":"It can be tricky because there are completely different ways how e.g. ports are listed from neutron-server. In fullstack it is done like with \"real\" client, here it is done bit differently.\nMaybe it could be possible to \"extract\" common parts of those two methods and reuse them in both places but that can also be done as follow-up patch. Would it be fine for You?","commit_id":"414bdd4c5997886c97d0e3a0b19c684dafeabb7a"}]}
