)]}'
{"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"16094020e72837cb105c5ef441e4125e158fcb0c","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                                   self.root_helper,"},{"line_number":616,"context_line":"                                   network.namespace)"},{"line_number":617,"context_line":"        else:"},{"line_number":618,"context_line":"            raise exceptions.NetworkNotFound(net_id\u003dnetwork.id)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    def _set_default_route(self, network, port):"},{"line_number":621,"context_line":"        \"\"\"Sets the default gateway for this dhcp namespace."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F8p5U%3D","line":618,"updated":"2013-12-23 19:32:28.000000000","message":"This exception doesn\u0027t really make sense here any more, does it? I think it should go to where get_dhcp_port() is called.","commit_id":"dbcc75a718f0325057f228a40342e571fca475e5"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"727782f058d85c12637f3c66bcd5ba8e205091c9","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                                   self.root_helper,"},{"line_number":616,"context_line":"                                   network.namespace)"},{"line_number":617,"context_line":"        else:"},{"line_number":618,"context_line":"            raise exceptions.NetworkNotFound(net_id\u003dnetwork.id)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    def _set_default_route(self, network, port):"},{"line_number":621,"context_line":"        \"\"\"Sets the default gateway for this dhcp namespace."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F8pSY%3D","line":618,"in_reply_to":"AAAATn%2F8p5U%3D","updated":"2013-12-23 19:37:10.000000000","message":"I should clarify: setup_dhcp_port() will never return a null port, so we only need to worry about null port from get_dhcp_port(). So handle that case where get_dhcp_port() is called, and then here in _get_device() we can always assume port is not null.","commit_id":"dbcc75a718f0325057f228a40342e571fca475e5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"77e233110b85109dcb534a5a50bc7981306bc8aa","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                                   self.root_helper,"},{"line_number":616,"context_line":"                                   network.namespace)"},{"line_number":617,"context_line":"        else:"},{"line_number":618,"context_line":"            raise exceptions.NetworkNotFound(net_id\u003dnetwork.id)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    def _set_default_route(self, network, port):"},{"line_number":621,"context_line":"        \"\"\"Sets the default gateway for this dhcp namespace."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2F7kI%3D","line":618,"in_reply_to":"AAAATn%2F8pSY%3D","updated":"2013-12-26 21:19:33.000000000","message":"Agreed, this doesn\u0027t quite look right.  I\u0027ll put up another change to address it.","commit_id":"dbcc75a718f0325057f228a40342e571fca475e5"}],"neutron/tests/unit/test_dhcp_agent.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e621d49cdb8ecb53cefc695489fbd1f67b3e8b6c","unresolved":false,"context_lines":[{"line_number":1479,"context_line":"        port \u003d mock.Mock()"},{"line_number":1480,"context_line":""},{"line_number":1481,"context_line":"        dh._get_device(network, port)"},{"line_number":1482,"context_line":""},{"line_number":1483,"context_line":"        self.assertFalse(dh.plugin.get_dhcp_port.called)"},{"line_number":1484,"context_line":"        dh.get_interface_name.assert_called_once_with(network, port)"},{"line_number":1485,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2Fas8%3D","line":1482,"updated":"2014-01-13 23:31:12.000000000","message":"The following test fails before the rest of this patch was applied.","commit_id":"8a298cbd2aa1005dce788cb7d86f9ed8a5cd2bd7"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"d8951ea92d714cffae1ff71b138bb0eb3d56c503","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"        net \u003d net or fake_network"},{"line_number":1124,"context_line":"        port \u003d port or fake_port1"},{"line_number":1125,"context_line":"        plugin \u003d mock.Mock()"},{"line_number":1126,"context_line":"        plugin.create_dhcp_port.return_value \u003d port or fake_port1"},{"line_number":1127,"context_line":"        plugin.get_dhcp_port.return_value \u003d port or fake_port1"},{"line_number":1128,"context_line":"        self.device_exists.return_value \u003d device_exists"},{"line_number":1129,"context_line":"        self.mock_driver.get_device_name.return_value \u003d \u0027tap12345678-12\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUX%2F%2BbjU%3D","line":1126,"updated":"2014-02-21 07:27:26.000000000","message":"nit: mocking get_dhcp_port can be removed (it won\u0027t be called either with or without the fix because of #1132)","commit_id":"f0921a4bbad5946abb6d9679867928a970cf5820"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"d8951ea92d714cffae1ff71b138bb0eb3d56c503","unresolved":false,"context_lines":[{"line_number":1307,"context_line":"            dh._get_device \u003d mock.Mock(return_value\u003ddevice)"},{"line_number":1308,"context_line":"            return dh"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":"    def test_update(self):"},{"line_number":1311,"context_line":"        # Try with namespaces and no metadata network"},{"line_number":1312,"context_line":"        cfg.CONF.set_override(\u0027use_namespaces\u0027, True)"},{"line_number":1313,"context_line":"        cfg.CONF.set_override(\u0027enable_metadata_network\u0027, False)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUX%2F%2Bbeo%3D","line":1310,"updated":"2014-02-21 07:27:26.000000000","message":"may want to also add test for update for the case when port was not found","commit_id":"f0921a4bbad5946abb6d9679867928a970cf5820"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"d8951ea92d714cffae1ff71b138bb0eb3d56c503","unresolved":false,"context_lines":[{"line_number":1327,"context_line":"        cfg.CONF.set_override(\u0027enable_metadata_network\u0027, False)"},{"line_number":1328,"context_line":"        dh \u003d dhcp.DeviceManager(cfg.CONF, cfg.CONF.root_helper, None)"},{"line_number":1329,"context_line":"        dh._set_default_route \u003d mock.Mock()"},{"line_number":1330,"context_line":"        dh.plugin \u003d mock.Mock()"},{"line_number":1331,"context_line":"        dh.plugin.get_dhcp_port.return_value \u003d port"},{"line_number":1332,"context_line":""},{"line_number":1333,"context_line":"        dh.update(FakeV4Network())"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUX%2F%2Bbf8%3D","line":1330,"updated":"2014-02-21 07:27:26.000000000","message":"not really needed to mock plugin and get_dhcp_port here as use_namespaces\u003dFalse. Another option is to check that get_dhcp_port was not called","commit_id":"f0921a4bbad5946abb6d9679867928a970cf5820"}]}
