)]}'
{"neutron/cmd/ovs_cleanup.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c220302f118bcc238b89b48f43287cf5fb3b8ce7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    l3_config.register_l3_agent_config_opts(l3_config.OPTS, conf)"},{"line_number":43,"context_line":"    agent_config.register_interface_driver_opts_helper(conf)"},{"line_number":44,"context_line":"    agent_config.register_interface_opts()"},{"line_number":45,"context_line":"    service_config.register_service_opts(service_config.RPC_EXTRA_OPTS, conf)"},{"line_number":46,"context_line":"    conf.set_default(\"ovsdb_timeout\", CLEANUP_OVSDB_TIMEOUT, \"OVS\")"},{"line_number":47,"context_line":"    return conf"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_4b42ef69","line":45,"updated":"2019-03-01 10:20:48.000000000","message":"Precisely, ovs-cleanup command does not use RPC, so this looks unnecessary.","commit_id":"84f8ae9d1f696b2561b634336338df0e14c37116"}],"neutron/conf/agent/common.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e93bd4b70b96232eb4b450a9ddc0a3ed5c2e2809","unresolved":false,"context_lines":[{"line_number":168,"context_line":"RPC_OPTS \u003d ["},{"line_number":169,"context_line":"    cfg.IntOpt(\u0027rpc_response_max_timeout\u0027,"},{"line_number":170,"context_line":"               default\u003d600,"},{"line_number":171,"context_line":"               help\u003d_(\u0027Maximum seconds to wait for a response from a call.\u0027)),"},{"line_number":172,"context_line":"]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_afa59949","line":171,"range":{"start_line":171,"start_character":67,"end_line":171,"end_character":68},"updated":"2019-02-18 16:25:18.000000000","message":"nit: s/an RPC ?\n\nSo this option is defined over in neutron/conf/service.py - should that instead be moved to it\u0027s own RPC block?  I\u0027m worried we\u0027re going to duplicate the option.","commit_id":"79581757e29057232659a371eae0c282e681c8b3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e2d20a7b15c251e44f843eab6ac4dcdf4ea9401f","unresolved":false,"context_lines":[{"line_number":168,"context_line":"RPC_OPTS \u003d ["},{"line_number":169,"context_line":"    cfg.IntOpt(\u0027rpc_response_max_timeout\u0027,"},{"line_number":170,"context_line":"               default\u003d600,"},{"line_number":171,"context_line":"               help\u003d_(\u0027Maximum seconds to wait for a response from a call.\u0027)),"},{"line_number":172,"context_line":"]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_23322260","line":171,"range":{"start_line":171,"start_character":67,"end_line":171,"end_character":68},"in_reply_to":"9fdfeff1_afa59949","updated":"2019-02-18 18:08:45.000000000","message":"Done","commit_id":"79581757e29057232659a371eae0c282e681c8b3"}],"neutron/opts.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"29fa4429bb84a332558b548a03b744500a82c88f","unresolved":false,"context_lines":[{"line_number":151,"context_line":"         itertools.chain("},{"line_number":152,"context_line":"             neutron.conf.agent.common.INTERFACE_OPTS,"},{"line_number":153,"context_line":"             neutron.conf.agent.common.INTERFACE_DRIVER_OPTS,"},{"line_number":154,"context_line":"             neutron.conf.agent.common.RPC_OPTS)"},{"line_number":155,"context_line":"         ),"},{"line_number":156,"context_line":"        (\u0027agent\u0027, neutron.conf.agent.common.AGENT_STATE_OPTS),"},{"line_number":157,"context_line":"        (\u0027ovs\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_1883c4ab","line":154,"updated":"2019-02-18 22:14:02.000000000","message":"Looks like a typo, should be like L138.","commit_id":"cc0e6f4c47c0c4d3d826cc9e22676c8a0a005d88"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"29fa4429bb84a332558b548a03b744500a82c88f","unresolved":false,"context_lines":[{"line_number":2355,"context_line":"    ext_manager.register_opts(cfg.CONF)"},{"line_number":2356,"context_line":"    agent_config.setup_privsep()"},{"line_number":2357,"context_line":"    service_conf.register_service_opts(service_conf.RPC_EXTRA_OPTS,"},{"line_number":2358,"context_line":"                                       conf\u003dcfg.CONF)"},{"line_number":2359,"context_line":""},{"line_number":2360,"context_line":"    ext_mgr \u003d ext_manager.L2AgentExtensionsManager(cfg.CONF)"},{"line_number":2361,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_d8f77c59","line":2358,"updated":"2019-02-18 22:14:02.000000000","message":"Is cfg.CONF required, I think it\u0027s the default.","commit_id":"cc0e6f4c47c0c4d3d826cc9e22676c8a0a005d88"}],"neutron/tests/fullstack/resources/config.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"04f10f5b8dd51f87b029072bd1ed16baf3c89e2f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                     \u0027host\u0027: rabbitmq_environment.host,"},{"line_number":76,"context_line":"                     \u0027vhost\u0027: rabbitmq_environment.vhost},"},{"line_number":77,"context_line":"                \u0027api_workers\u0027: \u00272\u0027,"},{"line_number":78,"context_line":"                \u0027rpc_response_max_timeout\u0027: 600"},{"line_number":79,"context_line":"            },"},{"line_number":80,"context_line":"            \u0027database\u0027: {"},{"line_number":81,"context_line":"                \u0027connection\u0027: connection,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_410e903b","line":78,"range":{"start_line":78,"start_character":44,"end_line":78,"end_character":47},"updated":"2019-02-13 21:54:53.000000000","message":"s/\u0027600\u0027 not obvious of course :(\n\nand you might as well put a comma at the end, just like api_workers has to make the next addition not have to edit this line too","commit_id":"6b5b7eb77350afaa2ed7e3f77d25385cafffaa30"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fc351849c42c68fc4492d27f27ef66952058d617","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                     \u0027host\u0027: rabbitmq_environment.host,"},{"line_number":76,"context_line":"                     \u0027vhost\u0027: rabbitmq_environment.vhost},"},{"line_number":77,"context_line":"                \u0027api_workers\u0027: \u00272\u0027,"},{"line_number":78,"context_line":"                \u0027rpc_response_max_timeout\u0027: 600"},{"line_number":79,"context_line":"            },"},{"line_number":80,"context_line":"            \u0027database\u0027: {"},{"line_number":81,"context_line":"                \u0027connection\u0027: connection,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_c58fe327","line":78,"range":{"start_line":78,"start_character":44,"end_line":78,"end_character":47},"in_reply_to":"9fdfeff1_410e903b","updated":"2019-02-14 08:34:14.000000000","message":"Thanks!","commit_id":"6b5b7eb77350afaa2ed7e3f77d25385cafffaa30"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9797d8400fc97096f998d311d54bbe652248cdd8","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        self.config.update({"},{"line_number":170,"context_line":"            \u0027DEFAULT\u0027: {"},{"line_number":171,"context_line":"                \u0027rpc_response_max_timeout\u0027: \u0027600\u0027,"},{"line_number":172,"context_line":"            },"},{"line_number":173,"context_line":"            \u0027ovs\u0027: {"},{"line_number":174,"context_line":"                \u0027local_ip\u0027: local_ip,"},{"line_number":175,"context_line":"                \u0027integration_bridge\u0027: self._generate_integration_bridge(),"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_26a18b96","line":172,"updated":"2019-02-21 13:35:37.000000000","message":"is it really necessary here? It is set to default value in fact so should works without this, right? Or am I missing something?","commit_id":"268e97abd645212f0d25456bb8d61246ba92fa86"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"18ec15f92f61291c840ff88206693c5f8bf7f84d","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        self.config.update({"},{"line_number":170,"context_line":"            \u0027DEFAULT\u0027: {"},{"line_number":171,"context_line":"                \u0027rpc_response_max_timeout\u0027: \u0027600\u0027,"},{"line_number":172,"context_line":"            },"},{"line_number":173,"context_line":"            \u0027ovs\u0027: {"},{"line_number":174,"context_line":"                \u0027local_ip\u0027: local_ip,"},{"line_number":175,"context_line":"                \u0027integration_bridge\u0027: self._generate_integration_bridge(),"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_3f3f4ab6","line":172,"in_reply_to":"9fdfeff1_26a18b96","updated":"2019-02-21 15:11:24.000000000","message":"Actually you are right. I\u0027ll remove it and then I\u0027ll check the fullstack logs.","commit_id":"268e97abd645212f0d25456bb8d61246ba92fa86"}]}