)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b593b8cc11921dbab3d7d2cf84d505887e7d770c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bence Romsics \u003cbence.romsics@ericsson.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-03-14 18:08:25 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP Networking guide: Guaranteed minimum bandwidth"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is still not complete, but getting closer."},{"line_number":10,"context_line":"There\u0027s a ton of material here that can already be reviewed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5fc1f717_f23c1094","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2019-03-15 15:50:20.000000000","message":"Are you still making changes or can this be removed so we can get some core review on this? The nova change is dependent on it and we\u0027d like to get that merged for Stein RC1.","commit_id":"9058871b38d64aadb7a3dbc60bc172fc65ba760a"}],"doc/source/admin/config-qos-min-bw.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e204f2e3b40d01eb454251a5a959092db317e1af","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Most Networking Quality of Service (QoS) features are implemented by solely"},{"line_number":7,"context_line":"OpenStack Neutron and they are already documented in the"},{"line_number":8,"context_line":"`QoS configuration chapter of the Networking Guide \u003cconfig-qos.html\u003e`_"},{"line_number":9,"context_line":"Some more complex QoS features necessarily involve the scheduling of a cloud"},{"line_number":10,"context_line":"server, therefore their implementation is shared between OpenStack Nova,"},{"line_number":11,"context_line":"Neutron and Placement. As of the OpenStack Stein release the Guaranteed"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_d0b74c3a","line":8,"range":{"start_line":8,"start_character":52,"end_line":8,"end_character":67},"updated":"2019-03-06 14:08:02.000000000","message":"Does this work? I\u0027d expect a :doc: reference here.","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"a99984cb1bb4c6183a6cdf624a249827d453ac7c","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Most Networking Quality of Service (QoS) features are implemented by solely"},{"line_number":7,"context_line":"OpenStack Neutron and they are already documented in the"},{"line_number":8,"context_line":"`QoS configuration chapter of the Networking Guide \u003cconfig-qos.html\u003e`_"},{"line_number":9,"context_line":"Some more complex QoS features necessarily involve the scheduling of a cloud"},{"line_number":10,"context_line":"server, therefore their implementation is shared between OpenStack Nova,"},{"line_number":11,"context_line":"Neutron and Placement. As of the OpenStack Stein release the Guaranteed"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_03a202fe","line":8,"range":{"start_line":8,"start_character":52,"end_line":8,"end_character":67},"in_reply_to":"5fc1f717_d0b74c3a","updated":"2019-03-13 15:50:27.000000000","message":"That\u0027s better, thanks.","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e204f2e3b40d01eb454251a5a959092db317e1af","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"In short the enforcement has two levels: placement and data plane."},{"line_number":28,"context_line":"Since the data plane enforcement is already documented in the"},{"line_number":29,"context_line":"`QoS chapter \u003cconfig-qos.html\u003e`_"},{"line_number":30,"context_line":"here we only document the placement-level enforcement."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Limitations"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_10dcf472","line":29,"range":{"start_line":29,"start_character":14,"end_line":29,"end_character":29},"updated":"2019-03-06 14:08:02.000000000","message":"same","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"a99984cb1bb4c6183a6cdf624a249827d453ac7c","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"In short the enforcement has two levels: placement and data plane."},{"line_number":28,"context_line":"Since the data plane enforcement is already documented in the"},{"line_number":29,"context_line":"`QoS chapter \u003cconfig-qos.html\u003e`_"},{"line_number":30,"context_line":"here we only document the placement-level enforcement."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Limitations"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_c3a71a0b","line":29,"range":{"start_line":29,"start_character":14,"end_line":29,"end_character":29},"in_reply_to":"5fc1f717_10dcf472","updated":"2019-03-13 15:50:27.000000000","message":"Done","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"15985a4863f309cca81051d8590f8189c1400f60","unresolved":false,"context_lines":[{"line_number":33,"context_line":"-----------"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* The Guaranteed Minimum Bandwidth feature is not complete in the Stein"},{"line_number":36,"context_line":"  release. Not all Nova server lifecycle operations can be executed on a"},{"line_number":37,"context_line":"  server with bandwidth guarantees. In Stein you can boot and delete a server"},{"line_number":38,"context_line":"  with a guarantee and detach ports with a guarantee FIXME grammar (Nova API microversion 2.70). Support for server migrate,"},{"line_number":39,"context_line":"  resize, evacuate, live-migrate, unshelve after shelve-offload is to be implemented later."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_7a3ffb24","line":37,"range":{"start_line":36,"start_character":10,"end_line":37,"end_character":34},"updated":"2019-03-11 15:55:48.000000000","message":"You can link to the new doc added in the nova api-guide in\nhttps://review.openstack.org/#/c/642064","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"a99984cb1bb4c6183a6cdf624a249827d453ac7c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"-----------"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* The Guaranteed Minimum Bandwidth feature is not complete in the Stein"},{"line_number":36,"context_line":"  release. Not all Nova server lifecycle operations can be executed on a"},{"line_number":37,"context_line":"  server with bandwidth guarantees. In Stein you can boot and delete a server"},{"line_number":38,"context_line":"  with a guarantee and detach ports with a guarantee FIXME grammar (Nova API microversion 2.70). Support for server migrate,"},{"line_number":39,"context_line":"  resize, evacuate, live-migrate, unshelve after shelve-offload is to be implemented later."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_cc6f47fa","line":37,"range":{"start_line":36,"start_character":10,"end_line":37,"end_character":34},"in_reply_to":"5fc1f717_7a3ffb24","updated":"2019-03-13 15:50:27.000000000","message":"Done, now you just need to merge that api-guide. :-)","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e204f2e3b40d01eb454251a5a959092db317e1af","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* The Guaranteed Minimum Bandwidth feature is not complete in the Stein"},{"line_number":36,"context_line":"  release. Not all Nova server lifecycle operations can be executed on a"},{"line_number":37,"context_line":"  server with bandwidth guarantees. In Stein you can boot and delete a server"},{"line_number":38,"context_line":"  with a guarantee and detach ports with a guarantee FIXME grammar (Nova API microversion 2.70). Support for server migrate,"},{"line_number":39,"context_line":"  resize, evacuate, live-migrate, unshelve after shelve-offload is to be implemented later."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* If you mix ports with and without bandwidth guarantees on the same physical"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_f0e2882f","line":38,"range":{"start_line":38,"start_character":92,"end_line":38,"end_character":94},"updated":"2019-03-06 14:08:02.000000000","message":"72:\n\nhttps://review.openstack.org/#/c/636360/","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e204f2e3b40d01eb454251a5a959092db317e1af","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* The Guaranteed Minimum Bandwidth feature is not complete in the Stein"},{"line_number":36,"context_line":"  release. Not all Nova server lifecycle operations can be executed on a"},{"line_number":37,"context_line":"  server with bandwidth guarantees. In Stein you can boot and delete a server"},{"line_number":38,"context_line":"  with a guarantee and detach ports with a guarantee FIXME grammar (Nova API microversion 2.70). Support for server migrate,"},{"line_number":39,"context_line":"  resize, evacuate, live-migrate, unshelve after shelve-offload is to be implemented later."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* If you mix ports with and without bandwidth guarantees on the same physical"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_50cb5ca4","line":38,"range":{"start_line":38,"start_character":97,"end_line":38,"end_character":98},"updated":"2019-03-06 14:08:02.000000000","message":"Wrap the line.","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"a99984cb1bb4c6183a6cdf624a249827d453ac7c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* The Guaranteed Minimum Bandwidth feature is not complete in the Stein"},{"line_number":36,"context_line":"  release. Not all Nova server lifecycle operations can be executed on a"},{"line_number":37,"context_line":"  server with bandwidth guarantees. In Stein you can boot and delete a server"},{"line_number":38,"context_line":"  with a guarantee and detach ports with a guarantee FIXME grammar (Nova API microversion 2.70). Support for server migrate,"},{"line_number":39,"context_line":"  resize, evacuate, live-migrate, unshelve after shelve-offload is to be implemented later."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* If you mix ports with and without bandwidth guarantees on the same physical"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_6c7893c3","line":38,"range":{"start_line":38,"start_character":97,"end_line":38,"end_character":98},"in_reply_to":"5fc1f717_50cb5ca4","updated":"2019-03-13 15:50:27.000000000","message":"Done","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"a99984cb1bb4c6183a6cdf624a249827d453ac7c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* The Guaranteed Minimum Bandwidth feature is not complete in the Stein"},{"line_number":36,"context_line":"  release. Not all Nova server lifecycle operations can be executed on a"},{"line_number":37,"context_line":"  server with bandwidth guarantees. In Stein you can boot and delete a server"},{"line_number":38,"context_line":"  with a guarantee and detach ports with a guarantee FIXME grammar (Nova API microversion 2.70). Support for server migrate,"},{"line_number":39,"context_line":"  resize, evacuate, live-migrate, unshelve after shelve-offload is to be implemented later."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* If you mix ports with and without bandwidth guarantees on the same physical"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_8c5e1f42","line":38,"range":{"start_line":38,"start_character":92,"end_line":38,"end_character":94},"in_reply_to":"5fc1f717_f0e2882f","updated":"2019-03-13 15:50:27.000000000","message":"Done","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e204f2e3b40d01eb454251a5a959092db317e1af","unresolved":false,"context_lines":[{"line_number":41,"context_line":"* If you mix ports with and without bandwidth guarantees on the same physical"},{"line_number":42,"context_line":"  interface then the ports without a gaurantee may starve. Therefore mixing"},{"line_number":43,"context_line":"  them is not recommended. Instead it is recommended to separate them by nova"},{"line_number":44,"context_line":"  host aggregates. FIXME link to host aggregate guide"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Bandwidth guarantees for ports can only be requested on networks backed by"},{"line_number":47,"context_line":"  physnets."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_10c5d48e","line":44,"range":{"start_line":44,"start_character":19,"end_line":44,"end_character":53},"updated":"2019-03-06 14:08:02.000000000","message":"https://docs.openstack.org/nova/latest/user/aggregates.html\n\nWhich I guess is something like :nova-doc:`/user/aggregates`.","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"a99984cb1bb4c6183a6cdf624a249827d453ac7c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"* If you mix ports with and without bandwidth guarantees on the same physical"},{"line_number":42,"context_line":"  interface then the ports without a gaurantee may starve. Therefore mixing"},{"line_number":43,"context_line":"  them is not recommended. Instead it is recommended to separate them by nova"},{"line_number":44,"context_line":"  host aggregates. FIXME link to host aggregate guide"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Bandwidth guarantees for ports can only be requested on networks backed by"},{"line_number":47,"context_line":"  physnets."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_728aaebf","line":44,"range":{"start_line":44,"start_character":19,"end_line":44,"end_character":53},"in_reply_to":"5fc1f717_10c5d48e","updated":"2019-03-13 15:50:27.000000000","message":"I guess I got the :nova-doc: role working.","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e204f2e3b40d01eb454251a5a959092db317e1af","unresolved":false,"context_lines":[{"line_number":66,"context_line":"* Changing the guarantee of a QoS policy (adding/deleting a minimum_bandwidth"},{"line_number":67,"context_line":"  rule, or changing the min_kbps field of a minimum_bandwidth rule) is only"},{"line_number":68,"context_line":"  possible until the policy is not in effect. That is ports of the QoS policy"},{"line_number":69,"context_line":"  are not yet used by Nova. Requests to change guarantees of in-effect"},{"line_number":70,"context_line":"  policies are rejected."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* FIXME cannot use network in nova boot, must use port instead"},{"line_number":73,"context_line":"* FIXME the same for attach"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_f069288b","line":70,"range":{"start_line":69,"start_character":28,"end_line":70,"end_character":24},"updated":"2019-03-06 14:08:02.000000000","message":"Has this enforcement merged in neutron yet because when talking about this a few weeks ago it was still a TODO.","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"a99984cb1bb4c6183a6cdf624a249827d453ac7c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"* Changing the guarantee of a QoS policy (adding/deleting a minimum_bandwidth"},{"line_number":67,"context_line":"  rule, or changing the min_kbps field of a minimum_bandwidth rule) is only"},{"line_number":68,"context_line":"  possible until the policy is not in effect. That is ports of the QoS policy"},{"line_number":69,"context_line":"  are not yet used by Nova. Requests to change guarantees of in-effect"},{"line_number":70,"context_line":"  policies are rejected."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* FIXME cannot use network in nova boot, must use port instead"},{"line_number":73,"context_line":"* FIXME the same for attach"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_06a3ebb3","line":70,"range":{"start_line":69,"start_character":28,"end_line":70,"end_character":24},"in_reply_to":"5fc1f717_f069288b","updated":"2019-03-13 15:50:27.000000000","message":"Please see this: https://review.openstack.org/636970","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"15985a4863f309cca81051d8590f8189c1400f60","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* FIXME cannot use network in nova boot, must use port instead"},{"line_number":73,"context_line":"* FIXME the same for attach"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Placement pre-requisites"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"microversion 1.29 FIXME link"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_da2b8f2d","line":74,"updated":"2019-03-11 15:55:48.000000000","message":"* Document that if a PF is used by ovs and the same PF\u0027s VFs are used by the sriov agent then bandwidth needs to be split between the PF RP and the OVS bridge RP by the admin configuring the agents.\n\n* Document that direct-phyical ports does not support qos rules today. The qos driver for SRIOV only supports macvtap and driect vnic_types.","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"a99984cb1bb4c6183a6cdf624a249827d453ac7c","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* FIXME cannot use network in nova boot, must use port instead"},{"line_number":73,"context_line":"* FIXME the same for attach"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Placement pre-requisites"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"microversion 1.29 FIXME link"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_e1c31256","line":74,"in_reply_to":"5fc1f717_da2b8f2d","updated":"2019-03-13 15:50:27.000000000","message":"Done","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e204f2e3b40d01eb454251a5a959092db317e1af","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Placement pre-requisites"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"microversion 1.29 FIXME link"},{"line_number":78,"context_line":"and this was release first in FIXME"},{"line_number":79,"context_line":"https://docs.openstack.org/nova/latest/reference/api-microversion-history.html"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"standalone or not placement"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_90d22434","line":79,"range":{"start_line":77,"start_character":0,"end_line":79,"end_character":78},"updated":"2019-03-06 14:08:02.000000000","message":"https://docs.openstack.org/placement/latest/placement-api-microversion-history.html#support-allocation-candidates-with-nested-resource-providers which was in Rocky.","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"a99984cb1bb4c6183a6cdf624a249827d453ac7c","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Placement pre-requisites"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"microversion 1.29 FIXME link"},{"line_number":78,"context_line":"and this was release first in FIXME"},{"line_number":79,"context_line":"https://docs.openstack.org/nova/latest/reference/api-microversion-history.html"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"standalone or not placement"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_dc0b7421","line":79,"range":{"start_line":77,"start_character":0,"end_line":79,"end_character":78},"in_reply_to":"5fc1f717_90d22434","updated":"2019-03-13 15:50:27.000000000","message":"Done","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e204f2e3b40d01eb454251a5a959092db317e1af","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Nova pre-requisites"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"microversion 2.70 FIXME link"},{"line_number":86,"context_line":"and this was releases first in Stein"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Nova config"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_50dcbc45","line":85,"range":{"start_line":85,"start_character":15,"end_line":85,"end_character":17},"updated":"2019-03-06 14:08:02.000000000","message":"72","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"a99984cb1bb4c6183a6cdf624a249827d453ac7c","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Nova pre-requisites"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"microversion 2.70 FIXME link"},{"line_number":86,"context_line":"and this was releases first in Stein"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Nova config"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_fc299089","line":85,"range":{"start_line":85,"start_character":15,"end_line":85,"end_character":17},"in_reply_to":"5fc1f717_50dcbc45","updated":"2019-03-13 15:50:27.000000000","message":"Done","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e204f2e3b40d01eb454251a5a959092db317e1af","unresolved":false,"context_lines":[{"line_number":85,"context_line":"microversion 2.70 FIXME link"},{"line_number":86,"context_line":"and this was releases first in Stein"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Nova config"},{"line_number":89,"context_line":"14:57:21 \u003c gibi\u003e rubasov: \"The currently unsupported case is when a single compute node has\""},{"line_number":90,"context_line":"14:57:21 \u003c gibi\u003e whitelisted VFs from more than one PFs which are connected to the same"},{"line_number":91,"context_line":"14:57:21 \u003c gibi\u003e physnet. This two PFs can have totally different bandwidth inventories"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_10cf1480","line":88,"updated":"2019-03-06 14:08:02.000000000","message":"Discussed this with gibi but the pci passthrough whitelist change was abandoned and the libvirt driver does this automatically now, however, not all virt drivers have this capability so probably need to mention something about that (likely in the nova feature support matrix https://docs.openstack.org/nova/latest/user/support-matrix.html and in Train we can expose a trait on the compute node resource provider per-driver to indicate if the compute supports the capability so admins can setup aggregates easier for isolating mixed-hypervisor environments).","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"a99984cb1bb4c6183a6cdf624a249827d453ac7c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"microversion 2.70 FIXME link"},{"line_number":86,"context_line":"and this was releases first in Stein"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Nova config"},{"line_number":89,"context_line":"14:57:21 \u003c gibi\u003e rubasov: \"The currently unsupported case is when a single compute node has\""},{"line_number":90,"context_line":"14:57:21 \u003c gibi\u003e whitelisted VFs from more than one PFs which are connected to the same"},{"line_number":91,"context_line":"14:57:21 \u003c gibi\u003e physnet. This two PFs can have totally different bandwidth inventories"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_a190aa4b","line":88,"in_reply_to":"5fc1f717_10cf1480","updated":"2019-03-13 15:50:27.000000000","message":"Updated accordingly.","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e204f2e3b40d01eb454251a5a959092db317e1af","unresolved":false,"context_lines":[{"line_number":102,"context_line":"Neutron config"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"service_plugins"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"[placement]"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"ovs and sr-iov resource_provider_bandwidths and"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_f0c5a85c","line":105,"updated":"2019-03-06 14:08:02.000000000","message":"Probably want to do config in an ini code block:\n\n.. code-block:: ini\n\n  [placement]\n  ...","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"a99984cb1bb4c6183a6cdf624a249827d453ac7c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"Neutron config"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"service_plugins"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"[placement]"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"ovs and sr-iov resource_provider_bandwidths and"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_01d2de00","line":105,"in_reply_to":"5fc1f717_f0c5a85c","updated":"2019-03-13 15:50:27.000000000","message":"Done","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e204f2e3b40d01eb454251a5a959092db317e1af","unresolved":false,"context_lines":[{"line_number":135,"context_line":"setup by admin"},{"line_number":136,"context_line":"usage by ordinary user"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"migration that is heal allocation"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"debugging"},{"line_number":141,"context_line":"agent\u0027s resources_synced"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_d09d0c67","line":138,"updated":"2019-03-06 14:08:02.000000000","message":"I guess we didn\u0027t add something on the nova side, but technically the nova-api should probably reject requests on server create with ports that have requested resources if the minimum nova-compute service version is not high enough to support the new types of requests - that is an upgrade concern on the nova side though and likely not something that needs to be documented here.","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"630986c4bb90de13b8c54f03fa7720c5c43573ef","unresolved":false,"context_lines":[{"line_number":135,"context_line":"setup by admin"},{"line_number":136,"context_line":"usage by ordinary user"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"migration that is heal allocation"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"debugging"},{"line_number":141,"context_line":"agent\u0027s resources_synced"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_aa04b115","line":138,"in_reply_to":"5fc1f717_7039b83f","updated":"2019-03-18 18:52:51.000000000","message":"Ack. Added a few paragraphs on healing allocations.","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9aca63be59fdac45084e7bb52ba30c1437aa189a","unresolved":false,"context_lines":[{"line_number":135,"context_line":"setup by admin"},{"line_number":136,"context_line":"usage by ordinary user"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"migration that is heal allocation"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"debugging"},{"line_number":141,"context_line":"agent\u0027s resources_synced"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_7039b83f","line":138,"in_reply_to":"5fc1f717_d09d0c67","updated":"2019-03-06 14:14:06.000000000","message":"I remember our discussion in nova about this now. If the compute/neutron agent are not upgraded to stein, they should not be reporting bw provider inventory so the nova scheduler should not pick them for these types of ports with resource requests, so that\u0027s why we don\u0027t need a minimum nova-compute service version check in the compute API because the scheduler should properly filter for us.","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e204f2e3b40d01eb454251a5a959092db317e1af","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"migration that is heal allocation"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"debugging"},{"line_number":141,"context_line":"agent\u0027s resources_synced"},{"line_number":142,"context_line":"port\u0027s resource_request"},{"line_number":143,"context_line":"port\u0027s binding:profile.allocation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_307a5024","line":140,"range":{"start_line":140,"start_character":0,"end_line":140,"end_character":9},"updated":"2019-03-06 14:08:02.000000000","message":"Might want to talk about leaked allocations, i.e. is it possible for us to race with an interface detach and leak allocations, or what happens if the admin detaches or deletes the port out of band from nova so that nova doesn\u0027t do the allocation cleanup. That\u0027s a corner case though.","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"da0050babeb35492a1ea6c3d14750e26e9180d7e","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"migration that is heal allocation"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"debugging"},{"line_number":141,"context_line":"agent\u0027s resources_synced"},{"line_number":142,"context_line":"port\u0027s resource_request"},{"line_number":143,"context_line":"port\u0027s binding:profile.allocation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_f1fb9743","line":140,"range":{"start_line":140,"start_character":0,"end_line":140,"end_character":9},"in_reply_to":"5fc1f717_1653b93a","updated":"2019-03-18 11:52:00.000000000","message":"There is another race condition:\n* Create a port with QoS\n* Start a server with the port\n* In parallel with the server create start modifying the size of the QoS policy rule of the port\n\nIf nova reads the port\u0027s resource_request first then the QoS policy is modified, then nova issue the port binding then the resource allocation will be based on the old QoS policy size.","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2ee9807d76441e2e39a63b7f062878571ad5d7cb","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"migration that is heal allocation"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"debugging"},{"line_number":141,"context_line":"agent\u0027s resources_synced"},{"line_number":142,"context_line":"port\u0027s resource_request"},{"line_number":143,"context_line":"port\u0027s binding:profile.allocation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_1653b93a","line":140,"range":{"start_line":140,"start_character":0,"end_line":140,"end_character":9},"in_reply_to":"5fc1f717_307a5024","updated":"2019-03-18 11:02:09.000000000","message":"There are two cases I know of:\n* Admin deletes a bound port that has resource allocation. Such allocation is leaked until the server is deleted (or moved). I\u0027ve reported a bug for it https://bugs.launchpad.net/nova/+bug/1820588\n\n* Admin changes the device_owner and device_id fields of a bound port. Nova does not get notified about this change. I don\u0027t think this is a valid use case.","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"630986c4bb90de13b8c54f03fa7720c5c43573ef","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"migration that is heal allocation"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"debugging"},{"line_number":141,"context_line":"agent\u0027s resources_synced"},{"line_number":142,"context_line":"port\u0027s resource_request"},{"line_number":143,"context_line":"port\u0027s binding:profile.allocation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_6a0a4920","line":140,"range":{"start_line":140,"start_character":0,"end_line":140,"end_character":9},"in_reply_to":"5fc1f717_f1fb9743","updated":"2019-03-18 18:52:51.000000000","message":"Done","commit_id":"7e99064eb96857a6631d583738569c6836f72246"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2ee9807d76441e2e39a63b7f062878571ad5d7cb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  server (``openstack server create``). Passing a network with"},{"line_number":41,"context_line":"  a minimum-bandwidth rule at boot is rejected because of technical"},{"line_number":42,"context_line":"  reasons (in this case the port is created too late for Neutron to affect"},{"line_number":43,"context_line":"  scheduling). The same applies for interface attach (``openstack server"},{"line_number":44,"context_line":"  add port`` but not ``openstack server add network``)."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Bandwidth guarantees for ports can only be requested on networks backed by"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_969a495f","line":43,"range":{"start_line":43,"start_character":16,"end_line":43,"end_character":52},"updated":"2019-03-18 11:02:09.000000000","message":"Interface attach with QoS port or network is not supported at the moment. See https://review.openstack.org/#/c/642064/5/api-guide/source/port_with_resource_request.rst@18","commit_id":"5806e8e4dbef32f2670e2f8534b5c8ccbe393d4a"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"630986c4bb90de13b8c54f03fa7720c5c43573ef","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  server (``openstack server create``). Passing a network with"},{"line_number":41,"context_line":"  a minimum-bandwidth rule at boot is rejected because of technical"},{"line_number":42,"context_line":"  reasons (in this case the port is created too late for Neutron to affect"},{"line_number":43,"context_line":"  scheduling). The same applies for interface attach (``openstack server"},{"line_number":44,"context_line":"  add port`` but not ``openstack server add network``)."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Bandwidth guarantees for ports can only be requested on networks backed by"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_4ccd2e83","line":43,"range":{"start_line":43,"start_character":16,"end_line":43,"end_character":52},"in_reply_to":"5fc1f717_969a495f","updated":"2019-03-18 18:52:51.000000000","message":"Done","commit_id":"5806e8e4dbef32f2670e2f8534b5c8ccbe393d4a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2ee9807d76441e2e39a63b7f062878571ad5d7cb","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Not all Nova virt-drivers are supported, please refer to the"},{"line_number":121,"context_line":"`Virt Driver section of the Nova API Guide"},{"line_number":122,"context_line":"\u003chttps://developer.openstack.org/api-guide/compute/port_with_resource_request.html#virt-driver\u003e`_."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"FIXME `tmp link \u003chttp://logs.openstack.org/64/642064/3/check/build-openstack-api-guide/a29cf91/html/port_with_resource_request.html#virt-driver\u003e`_."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_9601e96c","line":122,"updated":"2019-03-18 11:02:09.000000000","message":"This link has been changed to admin/port_with_resource_request.html#virt-driver-support","commit_id":"5806e8e4dbef32f2670e2f8534b5c8ccbe393d4a"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"630986c4bb90de13b8c54f03fa7720c5c43573ef","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Not all Nova virt-drivers are supported, please refer to the"},{"line_number":121,"context_line":"`Virt Driver section of the Nova API Guide"},{"line_number":122,"context_line":"\u003chttps://developer.openstack.org/api-guide/compute/port_with_resource_request.html#virt-driver\u003e`_."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"FIXME `tmp link \u003chttp://logs.openstack.org/64/642064/3/check/build-openstack-api-guide/a29cf91/html/port_with_resource_request.html#virt-driver\u003e`_."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_ecee5aeb","line":122,"in_reply_to":"5fc1f717_9601e96c","updated":"2019-03-18 18:52:51.000000000","message":"done, tmp link:\n\nhttp://logs.openstack.org/64/642064/5/check/openstack-tox-docs/b6f5255/html/admin/port_with_resource_request.html#virt-driver-support","commit_id":"5806e8e4dbef32f2670e2f8534b5c8ccbe393d4a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2ee9807d76441e2e39a63b7f062878571ad5d7cb","unresolved":false,"context_lines":[{"line_number":141,"context_line":"supported:"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"* Open vSwitch (``openvswitch``): vnic_types: normal, direct"},{"line_number":144,"context_line":"* SR-IOV (``sriovnicswitch``): vnic_types: direct, macvtap, direct-physical"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"neutron-server config"},{"line_number":147,"context_line":"~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_f6f14d96","line":144,"range":{"start_line":144,"start_character":60,"end_line":144,"end_character":75},"updated":"2019-03-18 11:02:09.000000000","message":"This vnic_type is not supported by the QoS service plugin.","commit_id":"5806e8e4dbef32f2670e2f8534b5c8ccbe393d4a"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"630986c4bb90de13b8c54f03fa7720c5c43573ef","unresolved":false,"context_lines":[{"line_number":141,"context_line":"supported:"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"* Open vSwitch (``openvswitch``): vnic_types: normal, direct"},{"line_number":144,"context_line":"* SR-IOV (``sriovnicswitch``): vnic_types: direct, macvtap, direct-physical"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"neutron-server config"},{"line_number":147,"context_line":"~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_6ca90a8e","line":144,"range":{"start_line":144,"start_character":60,"end_line":144,"end_character":75},"in_reply_to":"5fc1f717_f6f14d96","updated":"2019-03-18 18:52:51.000000000","message":"Done","commit_id":"5806e8e4dbef32f2670e2f8534b5c8ccbe393d4a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2ee9807d76441e2e39a63b7f062878571ad5d7cb","unresolved":false,"context_lines":[{"line_number":310,"context_line":"It is important to note that the restart of neutron-server does not trigger"},{"line_number":311,"context_line":"any kind of re-sync to Placement (to avoid an avalanche of updates at once)."},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"FIXME do we want to write here about the resource-use information flow?"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"Sample usage"},{"line_number":316,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_566aa119","line":313,"updated":"2019-03-18 11:02:09.000000000","message":"I think it is enough to link to the Berlin presentation and video as it talks about the flow in good details.","commit_id":"5806e8e4dbef32f2670e2f8534b5c8ccbe393d4a"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"630986c4bb90de13b8c54f03fa7720c5c43573ef","unresolved":false,"context_lines":[{"line_number":310,"context_line":"It is important to note that the restart of neutron-server does not trigger"},{"line_number":311,"context_line":"any kind of re-sync to Placement (to avoid an avalanche of updates at once)."},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"FIXME do we want to write here about the resource-use information flow?"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"Sample usage"},{"line_number":316,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_0c53a63a","line":313,"in_reply_to":"5fc1f717_566aa119","updated":"2019-03-18 18:52:51.000000000","message":"Added a few sentences and the link to the slides.","commit_id":"5806e8e4dbef32f2670e2f8534b5c8ccbe393d4a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e251bbdc98f434ea1980a150ba8b6a77b2d65149","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. _config-qos-min-bw:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Quality of Service (QoS): Guaranteed Bandwidth"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_6907aecb","line":1,"updated":"2019-03-18 19:29:33.000000000","message":"Is this used anywhere? If not just remove it.","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7eb2d5a29e6d499f59591ece69d68433b57a8d7f","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. _config-qos-min-bw:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Quality of Service (QoS): Guaranteed Bandwidth"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_7c1765a5","line":1,"in_reply_to":"5fc1f717_6907aecb","updated":"2019-03-19 10:28:54.000000000","message":"Done","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e251bbdc98f434ea1980a150ba8b6a77b2d65149","unresolved":false,"context_lines":[{"line_number":19,"context_line":"A guarantee of minimum available bandwidth can be enforced on two levels:"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"* Scheduling a server on a compute host where the bandwidth is available."},{"line_number":22,"context_line":"  To be more precise: Scheduling a server\u0027s port on a compute host\u0027s"},{"line_number":23,"context_line":"  physical network interface where the bandwidth is available."},{"line_number":24,"context_line":"* Queueing network packets on a physical network interface to provide the"},{"line_number":25,"context_line":"  guaranteed bandwidth."}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_29268669","line":22,"range":{"start_line":22,"start_character":22,"end_line":22,"end_character":23},"updated":"2019-03-18 19:29:33.000000000","message":"s/S/s/","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7eb2d5a29e6d499f59591ece69d68433b57a8d7f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"A guarantee of minimum available bandwidth can be enforced on two levels:"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"* Scheduling a server on a compute host where the bandwidth is available."},{"line_number":22,"context_line":"  To be more precise: Scheduling a server\u0027s port on a compute host\u0027s"},{"line_number":23,"context_line":"  physical network interface where the bandwidth is available."},{"line_number":24,"context_line":"* Queueing network packets on a physical network interface to provide the"},{"line_number":25,"context_line":"  guaranteed bandwidth."}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_1c0c2193","line":22,"range":{"start_line":22,"start_character":22,"end_line":22,"end_character":23},"in_reply_to":"5fc1f717_29268669","updated":"2019-03-19 10:28:54.000000000","message":"Done","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e251bbdc98f434ea1980a150ba8b6a77b2d65149","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* Changing the guarantee of a QoS policy (adding/deleting a"},{"line_number":61,"context_line":"  ``minimum_bandwidth`` rule, or changing the ``min_kbps`` field of a"},{"line_number":62,"context_line":"  ``minimum_bandwidth`` rule) is only possible until the policy is not in"},{"line_number":63,"context_line":"  effect. That is ports of the QoS policy are not yet used by Nova. Requests"},{"line_number":64,"context_line":"  to change guarantees of in-effect policies are rejected."},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_09e4ea0b","line":62,"range":{"start_line":62,"start_character":47,"end_line":62,"end_character":52},"updated":"2019-03-18 19:29:33.000000000","message":"while","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7eb2d5a29e6d499f59591ece69d68433b57a8d7f","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* Changing the guarantee of a QoS policy (adding/deleting a"},{"line_number":61,"context_line":"  ``minimum_bandwidth`` rule, or changing the ``min_kbps`` field of a"},{"line_number":62,"context_line":"  ``minimum_bandwidth`` rule) is only possible until the policy is not in"},{"line_number":63,"context_line":"  effect. That is ports of the QoS policy are not yet used by Nova. Requests"},{"line_number":64,"context_line":"  to change guarantees of in-effect policies are rejected."},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_bc1cedc1","line":62,"range":{"start_line":62,"start_character":47,"end_line":62,"end_character":52},"in_reply_to":"5fc1f717_09e4ea0b","updated":"2019-03-19 10:28:54.000000000","message":"Done","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e251bbdc98f434ea1980a150ba8b6a77b2d65149","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  ``minimum_bandwidth`` rule, or changing the ``min_kbps`` field of a"},{"line_number":62,"context_line":"  ``minimum_bandwidth`` rule) is only possible until the policy is not in"},{"line_number":63,"context_line":"  effect. That is ports of the QoS policy are not yet used by Nova. Requests"},{"line_number":64,"context_line":"  to change guarantees of in-effect policies are rejected."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* The first data-plane-only Guaranteed Minimum Bandwidth implementation"},{"line_number":67,"context_line":"  (for SR-IOV egress traffic) was released in the Newton"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_c9e902e3","line":64,"range":{"start_line":64,"start_character":29,"end_line":64,"end_character":35},"updated":"2019-03-18 19:29:33.000000000","message":"in-use?","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7eb2d5a29e6d499f59591ece69d68433b57a8d7f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  ``minimum_bandwidth`` rule, or changing the ``min_kbps`` field of a"},{"line_number":62,"context_line":"  ``minimum_bandwidth`` rule) is only possible until the policy is not in"},{"line_number":63,"context_line":"  effect. That is ports of the QoS policy are not yet used by Nova. Requests"},{"line_number":64,"context_line":"  to change guarantees of in-effect policies are rejected."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* The first data-plane-only Guaranteed Minimum Bandwidth implementation"},{"line_number":67,"context_line":"  (for SR-IOV egress traffic) was released in the Newton"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_bc714d0f","line":64,"range":{"start_line":64,"start_character":29,"end_line":64,"end_character":35},"in_reply_to":"5fc1f717_c9e902e3","updated":"2019-03-19 10:28:54.000000000","message":"Done","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e251bbdc98f434ea1980a150ba8b6a77b2d65149","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  \u003chttps://developer.openstack.org/api-guide/compute/port_with_resource_request.html\u003e`_"},{"line_number":90,"context_line":"  of the"},{"line_number":91,"context_line":"  `OpenStack Compute API Guide"},{"line_number":92,"context_line":"  \u003chttps://developer.openstack.org/api-guide/compute/\u003e`_."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* If an SR-IOV physical function is configured for use by neutron-ovs-agent,"},{"line_number":95,"context_line":"  and the same physical function\u0027s virtual functions are configured for use"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_698c8e35","line":92,"range":{"start_line":92,"start_character":2,"end_line":92,"end_character":54},"updated":"2019-03-18 19:29:33.000000000","message":"Not sure this needs to be a link since you linked to the exact topic already.","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7eb2d5a29e6d499f59591ece69d68433b57a8d7f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  \u003chttps://developer.openstack.org/api-guide/compute/port_with_resource_request.html\u003e`_"},{"line_number":90,"context_line":"  of the"},{"line_number":91,"context_line":"  `OpenStack Compute API Guide"},{"line_number":92,"context_line":"  \u003chttps://developer.openstack.org/api-guide/compute/\u003e`_."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* If an SR-IOV physical function is configured for use by neutron-ovs-agent,"},{"line_number":95,"context_line":"  and the same physical function\u0027s virtual functions are configured for use"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_3c5f9d73","line":92,"range":{"start_line":92,"start_character":2,"end_line":92,"end_character":54},"in_reply_to":"5fc1f717_698c8e35","updated":"2019-03-19 10:28:54.000000000","message":"Done","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e251bbdc98f434ea1980a150ba8b6a77b2d65149","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  `OpenStack Compute API Guide"},{"line_number":92,"context_line":"  \u003chttps://developer.openstack.org/api-guide/compute/\u003e`_."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* If an SR-IOV physical function is configured for use by neutron-ovs-agent,"},{"line_number":95,"context_line":"  and the same physical function\u0027s virtual functions are configured for use"},{"line_number":96,"context_line":"  by the neutron-sriov-agent then the available bandwidth must be statically"},{"line_number":97,"context_line":"  split between the corresponding resource providers by administrative"},{"line_number":98,"context_line":"  choice."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Placement pre-requisites"},{"line_number":101,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_89bd3ab8","line":98,"range":{"start_line":94,"start_character":2,"end_line":98,"end_character":9},"updated":"2019-03-18 19:29:33.000000000","message":"This could benefit from some more details, but those details are in the nova admin docs so we could just refer to that, correct? I think it\u0027s this section:\n\nhttps://review.openstack.org/#/c/642064/5/doc/source/admin/port_with_resource_request.rst@24","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"eeb34bd637081f2fa1d1f4d01289eb161e8b32d7","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  `OpenStack Compute API Guide"},{"line_number":92,"context_line":"  \u003chttps://developer.openstack.org/api-guide/compute/\u003e`_."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* If an SR-IOV physical function is configured for use by neutron-ovs-agent,"},{"line_number":95,"context_line":"  and the same physical function\u0027s virtual functions are configured for use"},{"line_number":96,"context_line":"  by the neutron-sriov-agent then the available bandwidth must be statically"},{"line_number":97,"context_line":"  split between the corresponding resource providers by administrative"},{"line_number":98,"context_line":"  choice."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Placement pre-requisites"},{"line_number":101,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_97ff7033","line":98,"range":{"start_line":94,"start_character":2,"end_line":98,"end_character":9},"in_reply_to":"5fc1f717_0f0cd340","updated":"2019-03-20 12:07:23.000000000","message":"Added a short example, let me know if it\u0027s clearer that way.","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5eff14ee0fa27ab067cc09bd29e7414221d867e3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  `OpenStack Compute API Guide"},{"line_number":92,"context_line":"  \u003chttps://developer.openstack.org/api-guide/compute/\u003e`_."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* If an SR-IOV physical function is configured for use by neutron-ovs-agent,"},{"line_number":95,"context_line":"  and the same physical function\u0027s virtual functions are configured for use"},{"line_number":96,"context_line":"  by the neutron-sriov-agent then the available bandwidth must be statically"},{"line_number":97,"context_line":"  split between the corresponding resource providers by administrative"},{"line_number":98,"context_line":"  choice."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Placement pre-requisites"},{"line_number":101,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_bbbb89c2","line":98,"range":{"start_line":94,"start_character":2,"end_line":98,"end_character":9},"in_reply_to":"5fc1f717_420c003b","updated":"2019-03-19 15:44:10.000000000","message":"\u003e I hope the choice of group_policy is irrelevant here, because in\n \u003e this case we\u0027ll have 2 RPs. For example consider a 10g sr-iov nic.\n \u003e Let\u0027s say the admin (via agent config) creates a 5g sr-iov pf RP\n \u003e (its vfs are going to be used only) plus a 5g ovs pf RP. The\n \u003e backing sr-iov nic is shared between these two (but split\n \u003e statically), but I think there\u0027s no overlap from Placement\u0027s RP\n \u003e point of view. Therefore group_policy should not matter. Is that\n \u003e right?\n\nI\u0027ll defer to gibi on that one. My point is this paragraph could benefit from more detail, or an example like you just gave.","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7eb2d5a29e6d499f59591ece69d68433b57a8d7f","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  `OpenStack Compute API Guide"},{"line_number":92,"context_line":"  \u003chttps://developer.openstack.org/api-guide/compute/\u003e`_."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* If an SR-IOV physical function is configured for use by neutron-ovs-agent,"},{"line_number":95,"context_line":"  and the same physical function\u0027s virtual functions are configured for use"},{"line_number":96,"context_line":"  by the neutron-sriov-agent then the available bandwidth must be statically"},{"line_number":97,"context_line":"  split between the corresponding resource providers by administrative"},{"line_number":98,"context_line":"  choice."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Placement pre-requisites"},{"line_number":101,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_420c003b","line":98,"range":{"start_line":94,"start_character":2,"end_line":98,"end_character":9},"in_reply_to":"5fc1f717_89bd3ab8","updated":"2019-03-19 10:28:54.000000000","message":"I hope the choice of group_policy is irrelevant here, because in this case we\u0027ll have 2 RPs. For example consider a 10g sr-iov nic. Let\u0027s say the admin (via agent config) creates a 5g sr-iov pf RP (its vfs are going to be used only) plus a 5g ovs pf RP. The backing sr-iov nic is shared between these two (but split statically), but I think there\u0027s no overlap from Placement\u0027s RP point of view. Therefore group_policy should not matter. Is that right?","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d8aa84f19a9c301ffb1c9dc77449bfeb19bbd7d4","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  `OpenStack Compute API Guide"},{"line_number":92,"context_line":"  \u003chttps://developer.openstack.org/api-guide/compute/\u003e`_."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* If an SR-IOV physical function is configured for use by neutron-ovs-agent,"},{"line_number":95,"context_line":"  and the same physical function\u0027s virtual functions are configured for use"},{"line_number":96,"context_line":"  by the neutron-sriov-agent then the available bandwidth must be statically"},{"line_number":97,"context_line":"  split between the corresponding resource providers by administrative"},{"line_number":98,"context_line":"  choice."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Placement pre-requisites"},{"line_number":101,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_0f0cd340","line":98,"range":{"start_line":94,"start_character":2,"end_line":98,"end_character":9},"in_reply_to":"5fc1f717_bbbb89c2","updated":"2019-03-19 18:02:19.000000000","message":"Yeah, as the there are two separate RPs one for OVS (the 5G from the PF) and another for the SRIOV agent (the other 5G use by the VFs). Therefore when two ports are added to the boot request one for OVS and one for SRIOV the resulting two request group will always be fulfilled by the two sepearete RPs. So both group_policy\u003dNone and group_policy\u003disolate result in the same, correct, allocation. (The actual allocation decision will be done based on the two different vinc_type trait).\n\nI\u0027m totally fine adding Bence\u0027s example to the paragraph.","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e251bbdc98f434ea1980a150ba8b6a77b2d65149","unresolved":false,"context_lines":[{"line_number":100,"context_line":"Placement pre-requisites"},{"line_number":101,"context_line":"------------------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Placement must support `microversion 1.29"},{"line_number":104,"context_line":"\u003chttps://docs.openstack.org/placement/latest/placement-api-microversion-history.html#support-allocation-candidates-with-nested-resource-providers\u003e`_"},{"line_number":105,"context_line":"This was first released in Rocky."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_09c94a57","line":103,"range":{"start_line":103,"start_character":40,"end_line":103,"end_character":41},"updated":"2019-03-18 19:29:33.000000000","message":"missing period","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7eb2d5a29e6d499f59591ece69d68433b57a8d7f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"Placement pre-requisites"},{"line_number":101,"context_line":"------------------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Placement must support `microversion 1.29"},{"line_number":104,"context_line":"\u003chttps://docs.openstack.org/placement/latest/placement-api-microversion-history.html#support-allocation-candidates-with-nested-resource-providers\u003e`_"},{"line_number":105,"context_line":"This was first released in Rocky."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_c2179045","line":103,"range":{"start_line":103,"start_character":40,"end_line":103,"end_character":41},"in_reply_to":"5fc1f717_09c94a57","updated":"2019-03-19 10:28:54.000000000","message":"Done","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e251bbdc98f434ea1980a150ba8b6a77b2d65149","unresolved":false,"context_lines":[{"line_number":104,"context_line":"\u003chttps://docs.openstack.org/placement/latest/placement-api-microversion-history.html#support-allocation-candidates-with-nested-resource-providers\u003e`_"},{"line_number":105,"context_line":"This was first released in Rocky."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Since microversion 1.29 was available before Placement was extracted"},{"line_number":108,"context_line":"from Nova, the Placement left in the Nova repository is expected to work"},{"line_number":109,"context_line":"(as long as it is not yet removed from the ``openstack/nova`` repository),"},{"line_number":110,"context_line":"but the use of standalone Placement is recommended."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Nova pre-requisites"},{"line_number":113,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_89e21ad4","line":110,"range":{"start_line":107,"start_character":0,"end_line":110,"end_character":51},"updated":"2019-03-18 19:29:33.000000000","message":"This will just add confusion so I would remove it.","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7eb2d5a29e6d499f59591ece69d68433b57a8d7f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"\u003chttps://docs.openstack.org/placement/latest/placement-api-microversion-history.html#support-allocation-candidates-with-nested-resource-providers\u003e`_"},{"line_number":105,"context_line":"This was first released in Rocky."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Since microversion 1.29 was available before Placement was extracted"},{"line_number":108,"context_line":"from Nova, the Placement left in the Nova repository is expected to work"},{"line_number":109,"context_line":"(as long as it is not yet removed from the ``openstack/nova`` repository),"},{"line_number":110,"context_line":"but the use of standalone Placement is recommended."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Nova pre-requisites"},{"line_number":113,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_2220d49b","line":110,"range":{"start_line":107,"start_character":0,"end_line":110,"end_character":51},"in_reply_to":"5fc1f717_89e21ad4","updated":"2019-03-19 10:28:54.000000000","message":"Done","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e251bbdc98f434ea1980a150ba8b6a77b2d65149","unresolved":false,"context_lines":[{"line_number":112,"context_line":"Nova pre-requisites"},{"line_number":113,"context_line":"-------------------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Nova must support `microversion 2.72"},{"line_number":116,"context_line":"\u003chttps://docs.openstack.org/nova/latest/reference/api-microversion-history.html#maximum-in-stein\u003e`_"},{"line_number":117,"context_line":"This was first released in Stein."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_a9d8361d","line":115,"range":{"start_line":115,"start_character":35,"end_line":115,"end_character":36},"updated":"2019-03-18 19:29:33.000000000","message":"missing period","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7eb2d5a29e6d499f59591ece69d68433b57a8d7f","unresolved":false,"context_lines":[{"line_number":112,"context_line":"Nova pre-requisites"},{"line_number":113,"context_line":"-------------------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Nova must support `microversion 2.72"},{"line_number":116,"context_line":"\u003chttps://docs.openstack.org/nova/latest/reference/api-microversion-history.html#maximum-in-stein\u003e`_"},{"line_number":117,"context_line":"This was first released in Stein."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_4225e0aa","line":115,"range":{"start_line":115,"start_character":35,"end_line":115,"end_character":36},"in_reply_to":"5fc1f717_a9d8361d","updated":"2019-03-19 10:28:54.000000000","message":"Done","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e251bbdc98f434ea1980a150ba8b6a77b2d65149","unresolved":false,"context_lines":[{"line_number":116,"context_line":"\u003chttps://docs.openstack.org/nova/latest/reference/api-microversion-history.html#maximum-in-stein\u003e`_"},{"line_number":117,"context_line":"This was first released in Stein."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Not all Nova virt-drivers are supported, please refer to the"},{"line_number":120,"context_line":"`Virt Driver Support section of the Nova API Guide"},{"line_number":121,"context_line":"\u003chttps://docs.openstack.org/nova/latest/admin/port_with_resource_request.html#virt-driver-support\u003e`_."},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_69080e91","line":119,"range":{"start_line":119,"start_character":17,"end_line":119,"end_character":18},"updated":"2019-03-18 19:29:33.000000000","message":"drop the dash so you have just \"virt drivers\"","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7eb2d5a29e6d499f59591ece69d68433b57a8d7f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"\u003chttps://docs.openstack.org/nova/latest/reference/api-microversion-history.html#maximum-in-stein\u003e`_"},{"line_number":117,"context_line":"This was first released in Stein."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Not all Nova virt-drivers are supported, please refer to the"},{"line_number":120,"context_line":"`Virt Driver Support section of the Nova API Guide"},{"line_number":121,"context_line":"\u003chttps://docs.openstack.org/nova/latest/admin/port_with_resource_request.html#virt-driver-support\u003e`_."},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_0237d8e5","line":119,"range":{"start_line":119,"start_character":17,"end_line":119,"end_character":18},"in_reply_to":"5fc1f717_69080e91","updated":"2019-03-19 10:28:54.000000000","message":"Done","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e251bbdc98f434ea1980a150ba8b6a77b2d65149","unresolved":false,"context_lines":[{"line_number":117,"context_line":"This was first released in Stein."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Not all Nova virt-drivers are supported, please refer to the"},{"line_number":120,"context_line":"`Virt Driver Support section of the Nova API Guide"},{"line_number":121,"context_line":"\u003chttps://docs.openstack.org/nova/latest/admin/port_with_resource_request.html#virt-driver-support\u003e`_."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Neutron pre-requisites"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_e9fb9e75","line":120,"range":{"start_line":120,"start_character":41,"end_line":120,"end_character":44},"updated":"2019-03-18 19:29:33.000000000","message":"Admin","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7eb2d5a29e6d499f59591ece69d68433b57a8d7f","unresolved":false,"context_lines":[{"line_number":117,"context_line":"This was first released in Stein."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Not all Nova virt-drivers are supported, please refer to the"},{"line_number":120,"context_line":"`Virt Driver Support section of the Nova API Guide"},{"line_number":121,"context_line":"\u003chttps://docs.openstack.org/nova/latest/admin/port_with_resource_request.html#virt-driver-support\u003e`_."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Neutron pre-requisites"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_8250a80c","line":120,"range":{"start_line":120,"start_character":41,"end_line":120,"end_character":44},"in_reply_to":"5fc1f717_e9fb9e75","updated":"2019-03-19 10:28:54.000000000","message":"Done","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bc469b00412ef9d0bd6df3ebfa05d7a9fe69a160","unresolved":false,"context_lines":[{"line_number":138,"context_line":"supported:"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* Open vSwitch (``openvswitch``) vnic_types: ``normal``, ``direct``"},{"line_number":141,"context_line":"* SR-IOV (``sriovnicswitch``) vnic_types: ``direct``, ``macvtap``"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"neutron-server config"},{"line_number":144,"context_line":"~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_c64d713b","line":141,"updated":"2019-03-18 18:28:14.000000000","message":"+ direct-physical\nsee: https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/mech_sriov/mech_driver/mech_driver.py#L61","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bf81a894f94802c674389320d9882c33444b590b","unresolved":false,"context_lines":[{"line_number":138,"context_line":"supported:"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* Open vSwitch (``openvswitch``) vnic_types: ``normal``, ``direct``"},{"line_number":141,"context_line":"* SR-IOV (``sriovnicswitch``) vnic_types: ``direct``, ``macvtap``"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"neutron-server config"},{"line_number":144,"context_line":"~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_34ab1a76","line":141,"in_reply_to":"5fc1f717_490af21f","updated":"2019-03-20 08:06:13.000000000","message":"Cool","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"630986c4bb90de13b8c54f03fa7720c5c43573ef","unresolved":false,"context_lines":[{"line_number":138,"context_line":"supported:"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* Open vSwitch (``openvswitch``) vnic_types: ``normal``, ``direct``"},{"line_number":141,"context_line":"* SR-IOV (``sriovnicswitch``) vnic_types: ``direct``, ``macvtap``"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"neutron-server config"},{"line_number":144,"context_line":"~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_490af21f","line":141,"in_reply_to":"5fc1f717_c64d713b","updated":"2019-03-18 18:52:51.000000000","message":"As gibi discovered direct-physical is a supported vnic_type in general by the sr-iov mech driver, however the sr-iov driver never claims to support that vnic_type. So I think this is correct.","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e251bbdc98f434ea1980a150ba8b6a77b2d65149","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    Egress and ingress available bandwidth values are in ``kilobit/sec (kbps)``."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"If desired, resource provider inventory fields can be tweaked on a"},{"line_number":184,"context_line":"per agent basis by setting ``resource_provider_inventory_defaults``."},{"line_number":185,"context_line":"Valid values are all the"},{"line_number":186,"context_line":"`optional parameters of the update resource provider inventory call"},{"line_number":187,"context_line":"\u003chttps://developer.openstack.org/api-ref/placement/?expanded\u003dupdate-resource-provider-inventory-detail#update-resource-provider-inventory\u003e`_."}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_c91a62c4","line":184,"range":{"start_line":184,"start_character":29,"end_line":184,"end_character":65},"updated":"2019-03-18 19:29:33.000000000","message":"Is it not possible to link to the neutron config docs for this, e.g. :oslo.config:option:`resource_provider_inventory_defaults`?","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7eb2d5a29e6d499f59591ece69d68433b57a8d7f","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    Egress and ingress available bandwidth values are in ``kilobit/sec (kbps)``."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"If desired, resource provider inventory fields can be tweaked on a"},{"line_number":184,"context_line":"per agent basis by setting ``resource_provider_inventory_defaults``."},{"line_number":185,"context_line":"Valid values are all the"},{"line_number":186,"context_line":"`optional parameters of the update resource provider inventory call"},{"line_number":187,"context_line":"\u003chttps://developer.openstack.org/api-ref/placement/?expanded\u003dupdate-resource-provider-inventory-detail#update-resource-provider-inventory\u003e`_."}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_e2cdec86","line":184,"range":{"start_line":184,"start_character":29,"end_line":184,"end_character":65},"in_reply_to":"5fc1f717_c91a62c4","updated":"2019-03-19 10:28:54.000000000","message":"Done","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bc469b00412ef9d0bd6df3ebfa05d7a9fe69a160","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    [ovs]"},{"line_number":203,"context_line":"    bridge_mappings \u003d physnet0:br-physnet0,..."},{"line_number":204,"context_line":"    resource_provider_bandwidths \u003d br-physnet0:10000000:10000000,..."},{"line_number":205,"context_line":"    #resource_provider_inventory_defaults \u003d step_size:1000,..."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    [ovs_driver]"},{"line_number":208,"context_line":"    vnic_type_blacklist \u003d direct"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_c61491eb","line":205,"range":{"start_line":205,"start_character":4,"end_line":205,"end_character":5},"updated":"2019-03-18 18:28:14.000000000","message":"commented line means optional in this context, or accidental copy-paste error?","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bf81a894f94802c674389320d9882c33444b590b","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    [ovs]"},{"line_number":203,"context_line":"    bridge_mappings \u003d physnet0:br-physnet0,..."},{"line_number":204,"context_line":"    resource_provider_bandwidths \u003d br-physnet0:10000000:10000000,..."},{"line_number":205,"context_line":"    #resource_provider_inventory_defaults \u003d step_size:1000,..."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    [ovs_driver]"},{"line_number":208,"context_line":"    vnic_type_blacklist \u003d direct"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_54a82676","line":205,"range":{"start_line":205,"start_character":4,"end_line":205,"end_character":5},"in_reply_to":"5fc1f717_692a4e7f","updated":"2019-03-20 08:06:13.000000000","message":"ok","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"630986c4bb90de13b8c54f03fa7720c5c43573ef","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    [ovs]"},{"line_number":203,"context_line":"    bridge_mappings \u003d physnet0:br-physnet0,..."},{"line_number":204,"context_line":"    resource_provider_bandwidths \u003d br-physnet0:10000000:10000000,..."},{"line_number":205,"context_line":"    #resource_provider_inventory_defaults \u003d step_size:1000,..."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    [ovs_driver]"},{"line_number":208,"context_line":"    vnic_type_blacklist \u003d direct"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_692a4e7f","line":205,"range":{"start_line":205,"start_character":4,"end_line":205,"end_character":5},"in_reply_to":"5fc1f717_c61491eb","updated":"2019-03-18 18:52:51.000000000","message":"That\u0027s exactly my intention - to show this as optional.","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bc469b00412ef9d0bd6df3ebfa05d7a9fe69a160","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    [sriov_nic]"},{"line_number":227,"context_line":"    physical_device_mappings \u003d physnet0:ens5,physnet0:ens6,..."},{"line_number":228,"context_line":"    resource_provider_bandwidths \u003d ens5:40000000:40000000,ens6:40000000:40000000,..."},{"line_number":229,"context_line":"    #resource_provider_inventory_defaults \u003d step_size:1000,..."},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    [sriov_driver]"},{"line_number":232,"context_line":"    #vnic_type_blacklist \u003d direct"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_66d59d1b","line":229,"range":{"start_line":229,"start_character":4,"end_line":229,"end_character":5},"updated":"2019-03-18 18:28:14.000000000","message":"ditto","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"630986c4bb90de13b8c54f03fa7720c5c43573ef","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    [sriov_nic]"},{"line_number":227,"context_line":"    physical_device_mappings \u003d physnet0:ens5,physnet0:ens6,..."},{"line_number":228,"context_line":"    resource_provider_bandwidths \u003d ens5:40000000:40000000,ens6:40000000:40000000,..."},{"line_number":229,"context_line":"    #resource_provider_inventory_defaults \u003d step_size:1000,..."},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    [sriov_driver]"},{"line_number":232,"context_line":"    #vnic_type_blacklist \u003d direct"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_e93ddec3","line":229,"range":{"start_line":229,"start_character":4,"end_line":229,"end_character":5},"in_reply_to":"5fc1f717_66d59d1b","updated":"2019-03-18 18:52:51.000000000","message":"Done","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bc469b00412ef9d0bd6df3ebfa05d7a9fe69a160","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    #resource_provider_inventory_defaults \u003d step_size:1000,..."},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    [sriov_driver]"},{"line_number":232,"context_line":"    #vnic_type_blacklist \u003d direct"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"Propagation of resource information"},{"line_number":235,"context_line":"-----------------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_86d8c952","line":232,"range":{"start_line":232,"start_character":4,"end_line":232,"end_character":5},"updated":"2019-03-18 18:28:14.000000000","message":"ditto","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"630986c4bb90de13b8c54f03fa7720c5c43573ef","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    #resource_provider_inventory_defaults \u003d step_size:1000,..."},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    [sriov_driver]"},{"line_number":232,"context_line":"    #vnic_type_blacklist \u003d direct"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"Propagation of resource information"},{"line_number":235,"context_line":"-----------------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_09394ad5","line":232,"range":{"start_line":232,"start_character":4,"end_line":232,"end_character":5},"in_reply_to":"5fc1f717_86d8c952","updated":"2019-03-18 18:52:51.000000000","message":"Done","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e251bbdc98f434ea1980a150ba8b6a77b2d65149","unresolved":false,"context_lines":[{"line_number":266,"context_line":"                                              \u0027step_size\u0027: 1},"},{"line_number":267,"context_line":"     ..."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"Re-reading the resource related subset of configuration on ``SIGHUP`` is not"},{"line_number":270,"context_line":"implemented. The agent must be restarted to pick up and send changed"},{"line_number":271,"context_line":"configuration."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"Neutron-server propagates the information further to Placement for"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_c96fc225","line":270,"range":{"start_line":269,"start_character":0,"end_line":270,"end_character":12},"updated":"2019-03-18 19:29:33.000000000","message":"Is this something you think might be implemented later? If so, maybe it should be added to the Limitations section above.","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7eb2d5a29e6d499f59591ece69d68433b57a8d7f","unresolved":false,"context_lines":[{"line_number":266,"context_line":"                                              \u0027step_size\u0027: 1},"},{"line_number":267,"context_line":"     ..."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"Re-reading the resource related subset of configuration on ``SIGHUP`` is not"},{"line_number":270,"context_line":"implemented. The agent must be restarted to pick up and send changed"},{"line_number":271,"context_line":"configuration."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"Neutron-server propagates the information further to Placement for"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_42872011","line":270,"range":{"start_line":269,"start_character":0,"end_line":270,"end_character":12},"in_reply_to":"5fc1f717_c96fc225","updated":"2019-03-19 10:28:54.000000000","message":"Not considering it at the moment. Today only a few (mostly logging related) config options can be re-read this way in neutron. Since we can re-trigger the sync by deleting the agent in the API (and then it\u0027s automatically re-created at the next heartbeat) we already have a way to force re-sync without agent restart. So I think live config re-read is not needed.","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e251bbdc98f434ea1980a150ba8b6a77b2d65149","unresolved":false,"context_lines":[{"line_number":327,"context_line":"   request in the ``binding:profile.allocation`` sub-attribute of that port."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"For details please see the `slides (especially slide 15, 17-18)"},{"line_number":330,"context_line":"\u003chttp://bit.ly/min_bw\u003e`_ of a (pre-release) demo that was presented"},{"line_number":331,"context_line":"on the Berlin Summit in November 2018."},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"Sample usage"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_09014a38","line":330,"updated":"2019-03-18 19:29:33.000000000","message":"nit: you could link to https://www.openstack.org/videos/summits/berlin-2018/guaranteed-minimum-bandwidth-feature-demo rather than a hashed URL which links to both the video and the slides.","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7eb2d5a29e6d499f59591ece69d68433b57a8d7f","unresolved":false,"context_lines":[{"line_number":327,"context_line":"   request in the ``binding:profile.allocation`` sub-attribute of that port."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"For details please see the `slides (especially slide 15, 17-18)"},{"line_number":330,"context_line":"\u003chttp://bit.ly/min_bw\u003e`_ of a (pre-release) demo that was presented"},{"line_number":331,"context_line":"on the Berlin Summit in November 2018."},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"Sample usage"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_02235807","line":330,"in_reply_to":"5fc1f717_09014a38","updated":"2019-03-19 10:28:54.000000000","message":"Done","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e251bbdc98f434ea1980a150ba8b6a77b2d65149","unresolved":false,"context_lines":[{"line_number":382,"context_line":"    $ openstack server create server0 \\"},{"line_number":383,"context_line":"        --flavor cirros256 \\"},{"line_number":384,"context_line":"        --image cirros-0.4.0-x86_64-disk \\"},{"line_number":385,"context_line":"        --nic port-id\u003dport-normal-qos \\"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"On Healing of Allocations"},{"line_number":388,"context_line":"-------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_09862aba","line":385,"range":{"start_line":385,"start_character":22,"end_line":385,"end_character":37},"updated":"2019-03-18 19:29:33.000000000","message":"This is a bit misleading since this actually requires the port ID (UUID) rather than the name.","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7eb2d5a29e6d499f59591ece69d68433b57a8d7f","unresolved":false,"context_lines":[{"line_number":382,"context_line":"    $ openstack server create server0 \\"},{"line_number":383,"context_line":"        --flavor cirros256 \\"},{"line_number":384,"context_line":"        --image cirros-0.4.0-x86_64-disk \\"},{"line_number":385,"context_line":"        --nic port-id\u003dport-normal-qos \\"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"On Healing of Allocations"},{"line_number":388,"context_line":"-------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_62eedc8c","line":385,"range":{"start_line":385,"start_character":22,"end_line":385,"end_character":37},"in_reply_to":"5fc1f717_09862aba","updated":"2019-03-19 10:28:54.000000000","message":"In osc \u0027--nic port-id\u003d\u0027 actually works with a port name. But I see your point and replaced it with a nicer looking option.","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e251bbdc98f434ea1980a150ba8b6a77b2d65149","unresolved":false,"context_lines":[{"line_number":412,"context_line":".. note::"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"  Deleting a bound port has no known use case though. Please consider"},{"line_number":415,"context_line":"  ``openstack server remove port`` or ``nova interface-detach`` instead."},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"Incorrect allocations may be fixed by:"},{"line_number":418,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_09af0a2a","line":415,"range":{"start_line":415,"start_character":35,"end_line":415,"end_character":63},"updated":"2019-03-18 19:29:33.000000000","message":"nit: you\u0027ve been using openstack commands up to this point, so just be consistent and continue w/o mentioning nova CLIs.","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7eb2d5a29e6d499f59591ece69d68433b57a8d7f","unresolved":false,"context_lines":[{"line_number":412,"context_line":".. note::"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"  Deleting a bound port has no known use case though. Please consider"},{"line_number":415,"context_line":"  ``openstack server remove port`` or ``nova interface-detach`` instead."},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"Incorrect allocations may be fixed by:"},{"line_number":418,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_229d340a","line":415,"range":{"start_line":415,"start_character":35,"end_line":415,"end_character":63},"in_reply_to":"5fc1f717_09af0a2a","updated":"2019-03-19 10:28:54.000000000","message":"I just wanted to sneak in the better known terminology (interface attach/detach). Rephrased instead.","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e251bbdc98f434ea1980a150ba8b6a77b2d65149","unresolved":false,"context_lines":[{"line_number":421,"context_line":"  Moving servers fixes local overallocations."},{"line_number":422,"context_line":"* The need for an upgrade-helper allocation healing tool is being tracked in"},{"line_number":423,"context_line":"  `bug/1819923 \u003chttps://bugs.launchpad.net/nova/+bug/1819923\u003e`_."},{"line_number":424,"context_line":"* Manually by ``openstack resource provider allocation``."},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"Debugging"},{"line_number":427,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_496e7200","line":424,"range":{"start_line":424,"start_character":44,"end_line":424,"end_character":54},"updated":"2019-03-18 19:29:33.000000000","message":"allocation set?\n\nAlso, link to the CLI you\u0027re referring to here:\n\nhttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-set","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7eb2d5a29e6d499f59591ece69d68433b57a8d7f","unresolved":false,"context_lines":[{"line_number":421,"context_line":"  Moving servers fixes local overallocations."},{"line_number":422,"context_line":"* The need for an upgrade-helper allocation healing tool is being tracked in"},{"line_number":423,"context_line":"  `bug/1819923 \u003chttps://bugs.launchpad.net/nova/+bug/1819923\u003e`_."},{"line_number":424,"context_line":"* Manually by ``openstack resource provider allocation``."},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"Debugging"},{"line_number":427,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_427080dd","line":424,"range":{"start_line":424,"start_character":44,"end_line":424,"end_character":54},"in_reply_to":"5fc1f717_496e7200","updated":"2019-03-19 10:28:54.000000000","message":"Done","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e251bbdc98f434ea1980a150ba8b6a77b2d65149","unresolved":false,"context_lines":[{"line_number":517,"context_line":"    # as admin"},{"line_number":518,"context_line":"    $ openstack --os-placement-api-version 1.17 resource provider show --allocations RP-UUID"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"* Did placement manage to produce an allocation candidate list to nova?"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"* Did nova manage to schedule the server?"},{"line_number":523,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_c927c2c6","line":520,"range":{"start_line":520,"start_character":66,"end_line":520,"end_character":70},"updated":"2019-03-18 19:29:33.000000000","message":"\"during scheduling?\"\n\nPeople reading this probably don\u0027t know what the allocation candidate list means, so for them it just means did nova scheduling, which asks placement for resource providers to fit the allocation request, find a match.","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7eb2d5a29e6d499f59591ece69d68433b57a8d7f","unresolved":false,"context_lines":[{"line_number":517,"context_line":"    # as admin"},{"line_number":518,"context_line":"    $ openstack --os-placement-api-version 1.17 resource provider show --allocations RP-UUID"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"* Did placement manage to produce an allocation candidate list to nova?"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"* Did nova manage to schedule the server?"},{"line_number":523,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_22445474","line":520,"range":{"start_line":520,"start_character":66,"end_line":520,"end_character":70},"in_reply_to":"5fc1f717_c927c2c6","updated":"2019-03-19 10:28:54.000000000","message":"Done","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e251bbdc98f434ea1980a150ba8b6a77b2d65149","unresolved":false,"context_lines":[{"line_number":537,"context_line":"* Pre-release feature demo presented on the Berlin Summit in November 2018"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"  * `video recording \u003chttps://www.openstack.org/videos/summits/berlin-2018/guaranteed-minimum-bandwidth-feature-demo\u003e`_"},{"line_number":540,"context_line":"  * `slides \u003chttp://bit.ly/min_bw\u003e`_"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"* Nova documentation on using a port with ``resource_request``"},{"line_number":543,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_49151248","line":540,"updated":"2019-03-18 19:29:33.000000000","message":"nit: again, the slides are available from the link just before this","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7eb2d5a29e6d499f59591ece69d68433b57a8d7f","unresolved":false,"context_lines":[{"line_number":537,"context_line":"* Pre-release feature demo presented on the Berlin Summit in November 2018"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"  * `video recording \u003chttps://www.openstack.org/videos/summits/berlin-2018/guaranteed-minimum-bandwidth-feature-demo\u003e`_"},{"line_number":540,"context_line":"  * `slides \u003chttp://bit.ly/min_bw\u003e`_"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"* Nova documentation on using a port with ``resource_request``"},{"line_number":543,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc1f717_42496089","line":540,"in_reply_to":"5fc1f717_49151248","updated":"2019-03-19 10:28:54.000000000","message":"Done","commit_id":"7ae870fb4a222d0ccb7937a0b7e8be7f627a9cc2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2f2e6f026bfdff1424491a3ec319a35971ae2ec4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Quality of Service (QoS): Guaranteed Bandwidth"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Most Networking Quality of Service (QoS) features are implemented by"},{"line_number":5,"context_line":"solely OpenStack Neutron and they are already documented in the :doc:`QoS"},{"line_number":6,"context_line":"configuration chapter of the Networking Guide \u003cconfig-qos\u003e`.  Some more"},{"line_number":7,"context_line":"complex QoS features necessarily involve the scheduling of a cloud server,"},{"line_number":8,"context_line":"therefore their implementation is shared between OpenStack Nova, Neutron"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5fc1f717_67cb3b72","line":5,"range":{"start_line":4,"start_character":66,"end_line":5,"end_character":6},"updated":"2019-03-19 22:19:56.000000000","message":"nit: solely by","commit_id":"15b252d48f406cf5ca90464e42009590049a2c27"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"eeb34bd637081f2fa1d1f4d01289eb161e8b32d7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Quality of Service (QoS): Guaranteed Bandwidth"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Most Networking Quality of Service (QoS) features are implemented by"},{"line_number":5,"context_line":"solely OpenStack Neutron and they are already documented in the :doc:`QoS"},{"line_number":6,"context_line":"configuration chapter of the Networking Guide \u003cconfig-qos\u003e`.  Some more"},{"line_number":7,"context_line":"complex QoS features necessarily involve the scheduling of a cloud server,"},{"line_number":8,"context_line":"therefore their implementation is shared between OpenStack Nova, Neutron"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5fc1f717_b7394cf3","line":5,"range":{"start_line":4,"start_character":66,"end_line":5,"end_character":6},"in_reply_to":"5fc1f717_67cb3b72","updated":"2019-03-20 12:07:23.000000000","message":"Done","commit_id":"15b252d48f406cf5ca90464e42009590049a2c27"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2f2e6f026bfdff1424491a3ec319a35971ae2ec4","unresolved":false,"context_lines":[{"line_number":231,"context_line":"The flow of information is different for available and used resources."},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"The authentic source of available resources is neutron agent configuration -"},{"line_number":234,"context_line":"where the resources actually exist. This information is propagated in the"},{"line_number":235,"context_line":"following chain: ``neutron-x-agent -\u003e neutron-server -\u003e Placement``."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"From neutron agent to server the information is included in the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5fc1f717_e7988b1c","line":234,"range":{"start_line":234,"start_character":34,"end_line":234,"end_character":35},"updated":"2019-03-19 22:19:56.000000000","message":"nit: if you roll another patch I would add:\n\nas described in the previous section","commit_id":"15b252d48f406cf5ca90464e42009590049a2c27"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"eeb34bd637081f2fa1d1f4d01289eb161e8b32d7","unresolved":false,"context_lines":[{"line_number":231,"context_line":"The flow of information is different for available and used resources."},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"The authentic source of available resources is neutron agent configuration -"},{"line_number":234,"context_line":"where the resources actually exist. This information is propagated in the"},{"line_number":235,"context_line":"following chain: ``neutron-x-agent -\u003e neutron-server -\u003e Placement``."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"From neutron agent to server the information is included in the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5fc1f717_d7173851","line":234,"range":{"start_line":234,"start_character":34,"end_line":234,"end_character":35},"in_reply_to":"5fc1f717_e7988b1c","updated":"2019-03-20 12:07:23.000000000","message":"Done","commit_id":"15b252d48f406cf5ca90464e42009590049a2c27"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5eff14ee0fa27ab067cc09bd29e7414221d867e3","unresolved":false,"context_lines":[{"line_number":261,"context_line":"     ..."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"Re-reading the resource related subset of configuration on ``SIGHUP`` is not"},{"line_number":264,"context_line":"implemented. The agent must be restarted to pick up and send changed"},{"line_number":265,"context_line":"configuration."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Neutron-server propagates the information further to Placement for"},{"line_number":268,"context_line":"the resources of each agent via Placement\u0027s HTTP REST API. To avoid"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5fc1f717_5ef13301","line":265,"range":{"start_line":264,"start_character":13,"end_line":265,"end_character":14},"updated":"2019-03-19 15:44:10.000000000","message":"In PS5 you said, \"Since we can re-trigger the sync by deleting the agent in the API (and then it\u0027s automatically re-created at the next heartbeat) we already have a way to force re-sync without agent restart.\" so is that worth mentioning here as an alternative to restarting the agent service?","commit_id":"15b252d48f406cf5ca90464e42009590049a2c27"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"eeb34bd637081f2fa1d1f4d01289eb161e8b32d7","unresolved":false,"context_lines":[{"line_number":261,"context_line":"     ..."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"Re-reading the resource related subset of configuration on ``SIGHUP`` is not"},{"line_number":264,"context_line":"implemented. The agent must be restarted to pick up and send changed"},{"line_number":265,"context_line":"configuration."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Neutron-server propagates the information further to Placement for"},{"line_number":268,"context_line":"the resources of each agent via Placement\u0027s HTTP REST API. To avoid"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5fc1f717_77b0c48c","line":265,"range":{"start_line":264,"start_character":13,"end_line":265,"end_character":14},"in_reply_to":"5fc1f717_5ef13301","updated":"2019-03-20 12:07:23.000000000","message":"I tried to talk about this is line 273, but likely in not enough detail to make it clear. Added a short explanation there.","commit_id":"15b252d48f406cf5ca90464e42009590049a2c27"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bf81a894f94802c674389320d9882c33444b590b","unresolved":false,"context_lines":[{"line_number":449,"context_line":"    # as admin"},{"line_number":450,"context_line":"    $ openstack network agent show ... | grep resources_synced"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"* Is the resource provider tree correct? Is the root a compute host? One level"},{"line_number":453,"context_line":"  below the agents? Two levels below the physical network interfaces?"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":".. code-block:: console"},{"line_number":456,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5fc1f717_b4e5cade","line":453,"range":{"start_line":452,"start_character":2,"end_line":453,"end_character":69},"updated":"2019-03-20 08:06:13.000000000","message":"+1 for these questions","commit_id":"15b252d48f406cf5ca90464e42009590049a2c27"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"eeb34bd637081f2fa1d1f4d01289eb161e8b32d7","unresolved":false,"context_lines":[{"line_number":449,"context_line":"    # as admin"},{"line_number":450,"context_line":"    $ openstack network agent show ... | grep resources_synced"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"* Is the resource provider tree correct? Is the root a compute host? One level"},{"line_number":453,"context_line":"  below the agents? Two levels below the physical network interfaces?"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":".. code-block:: console"},{"line_number":456,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5fc1f717_f72fd4a4","line":453,"range":{"start_line":452,"start_character":2,"end_line":453,"end_character":69},"in_reply_to":"5fc1f717_b4e5cade","updated":"2019-03-20 12:07:23.000000000","message":":-)","commit_id":"15b252d48f406cf5ca90464e42009590049a2c27"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"68b9c2b76ad88c45aad080e9b19a6660b472b82a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Quality of Service (QoS): Guaranteed Bandwidth"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Most Networking Quality of Service (QoS) features are implemented solely"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_2e589a54","line":1,"range":{"start_line":1,"start_character":26,"end_line":1,"end_character":46},"updated":"2019-03-20 18:29:28.000000000","message":"nit: perhaps changing the title to \u0027Guaranteed Minimum Bandwidth\u0027 is more specific.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Quality of Service (QoS): Guaranteed Bandwidth"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Most Networking Quality of Service (QoS) features are implemented solely"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_9ca1ba98","line":1,"range":{"start_line":1,"start_character":26,"end_line":1,"end_character":46},"in_reply_to":"5fc1f717_2e589a54","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"68b9c2b76ad88c45aad080e9b19a6660b472b82a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"A guarantee of minimum available bandwidth can be enforced on two levels:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"* Scheduling a server on a compute host where the bandwidth is available."},{"line_number":20,"context_line":"  To be more precise: scheduling a server\u0027s port on a compute host\u0027s"},{"line_number":21,"context_line":"  physical network interface where the bandwidth is available."},{"line_number":22,"context_line":"* Queueing network packets on a physical network interface to provide the"},{"line_number":23,"context_line":"  guaranteed bandwidth."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_a907a418","line":21,"range":{"start_line":20,"start_character":22,"end_line":21,"end_character":28},"updated":"2019-03-20 18:29:28.000000000","message":"nit: The wording doesn\u0027t cover the case that a server has multiple ports and those ports are supposed to be scheduled to multiple physical interface.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":17,"context_line":"A guarantee of minimum available bandwidth can be enforced on two levels:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"* Scheduling a server on a compute host where the bandwidth is available."},{"line_number":20,"context_line":"  To be more precise: scheduling a server\u0027s port on a compute host\u0027s"},{"line_number":21,"context_line":"  physical network interface where the bandwidth is available."},{"line_number":22,"context_line":"* Queueing network packets on a physical network interface to provide the"},{"line_number":23,"context_line":"  guaranteed bandwidth."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_9cca1a4d","line":21,"range":{"start_line":20,"start_character":22,"end_line":21,"end_character":28},"in_reply_to":"5fc1f717_a907a418","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"68b9c2b76ad88c45aad080e9b19a6660b472b82a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Limitations"},{"line_number":35,"context_line":"-----------"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* A port with a ``minimum-bandwidth`` rule must be passed when booting a"},{"line_number":38,"context_line":"  server (``openstack server create``). Passing a network with a"},{"line_number":39,"context_line":"  minimum-bandwidth rule at boot is rejected because of technical"},{"line_number":40,"context_line":"  reasons (in this case the port is created too late for Neutron to"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_a96ec4c6","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":8},"updated":"2019-03-20 18:29:28.000000000","message":"nit: \u0027A pre-created port\u0027 would be more clear.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Limitations"},{"line_number":35,"context_line":"-----------"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* A port with a ``minimum-bandwidth`` rule must be passed when booting a"},{"line_number":38,"context_line":"  server (``openstack server create``). Passing a network with a"},{"line_number":39,"context_line":"  minimum-bandwidth rule at boot is rejected because of technical"},{"line_number":40,"context_line":"  reasons (in this case the port is created too late for Neutron to"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_3c0a068a","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":8},"in_reply_to":"5fc1f717_a96ec4c6","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"68b9c2b76ad88c45aad080e9b19a6660b472b82a","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* A port with a ``minimum-bandwidth`` rule must be passed when booting a"},{"line_number":38,"context_line":"  server (``openstack server create``). Passing a network with a"},{"line_number":39,"context_line":"  minimum-bandwidth rule at boot is rejected because of technical"},{"line_number":40,"context_line":"  reasons (in this case the port is created too late for Neutron to"},{"line_number":41,"context_line":"  affect scheduling)."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_2962d4d9","line":39,"range":{"start_line":39,"start_character":36,"end_line":39,"end_character":44},"updated":"2019-03-20 18:29:28.000000000","message":"not supported?","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* A port with a ``minimum-bandwidth`` rule must be passed when booting a"},{"line_number":38,"context_line":"  server (``openstack server create``). Passing a network with a"},{"line_number":39,"context_line":"  minimum-bandwidth rule at boot is rejected because of technical"},{"line_number":40,"context_line":"  reasons (in this case the port is created too late for Neutron to"},{"line_number":41,"context_line":"  affect scheduling)."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_dc33c261","line":39,"range":{"start_line":39,"start_character":36,"end_line":39,"end_character":44},"in_reply_to":"5fc1f717_2962d4d9","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"68b9c2b76ad88c45aad080e9b19a6660b472b82a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  affect scheduling)."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Bandwidth guarantees for ports can only be requested on networks"},{"line_number":44,"context_line":"  backed by physnets."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* In Stein there is no support for networks with multiple physnets."},{"line_number":47,"context_line":"  However some simpler multi-segment networks are still supported:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_498de079","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":20},"updated":"2019-03-20 18:29:28.000000000","message":"physical network?","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  affect scheduling)."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Bandwidth guarantees for ports can only be requested on networks"},{"line_number":44,"context_line":"  backed by physnets."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* In Stein there is no support for networks with multiple physnets."},{"line_number":47,"context_line":"  However some simpler multi-segment networks are still supported:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_bc3a7631","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":20},"in_reply_to":"5fc1f717_498de079","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"68b9c2b76ad88c45aad080e9b19a6660b472b82a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  ``minimum_bandwidth`` QoS rule, but no resource allocation in Placement)"},{"line_number":77,"context_line":"  are rejected now in a backward-incompatible way."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* The Guaranteed Minimum Bandwidth feature is not complete in the Stein"},{"line_number":80,"context_line":"  release. Not all Nova server lifecycle operations can be executed on a"},{"line_number":81,"context_line":"  server with bandwidth guarantees. In Stein (Nova API microversion 2.72+)"},{"line_number":82,"context_line":"  you can boot and delete a server with a guarantee and detach a port with"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_8990a850","line":79,"range":{"start_line":79,"start_character":50,"end_line":79,"end_character":58},"updated":"2019-03-20 18:29:28.000000000","message":"completed","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  ``minimum_bandwidth`` QoS rule, but no resource allocation in Placement)"},{"line_number":77,"context_line":"  are rejected now in a backward-incompatible way."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* The Guaranteed Minimum Bandwidth feature is not complete in the Stein"},{"line_number":80,"context_line":"  release. Not all Nova server lifecycle operations can be executed on a"},{"line_number":81,"context_line":"  server with bandwidth guarantees. In Stein (Nova API microversion 2.72+)"},{"line_number":82,"context_line":"  you can boot and delete a server with a guarantee and detach a port with"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_1c614a3a","line":79,"range":{"start_line":79,"start_character":50,"end_line":79,"end_character":58},"in_reply_to":"5fc1f717_8990a850","updated":"2019-03-21 10:33:29.000000000","message":"I\u0027m no native speaker, but I think simple negations are generally considered simpler to understand than passive constructs.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  \u003chttps://developer.openstack.org/api-guide/compute/port_with_resource_request.html\u003e`_"},{"line_number":88,"context_line":"  of the OpenStack Compute API Guide."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"* If an SR-IOV physical function is configured for use by neutron-ovs-agent,"},{"line_number":91,"context_line":"  and the same physical function\u0027s virtual functions are configured"},{"line_number":92,"context_line":"  for use by the neutron-sriov-agent then the available bandwidth must"},{"line_number":93,"context_line":"  be statically split between the corresponding resource providers by"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_1f5e29e6","line":90,"range":{"start_line":90,"start_character":55,"end_line":90,"end_character":57},"updated":"2019-03-20 18:20:32.000000000","message":"nit: s/by the","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  \u003chttps://developer.openstack.org/api-guide/compute/port_with_resource_request.html\u003e`_"},{"line_number":88,"context_line":"  of the OpenStack Compute API Guide."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"* If an SR-IOV physical function is configured for use by neutron-ovs-agent,"},{"line_number":91,"context_line":"  and the same physical function\u0027s virtual functions are configured"},{"line_number":92,"context_line":"  for use by the neutron-sriov-agent then the available bandwidth must"},{"line_number":93,"context_line":"  be statically split between the corresponding resource providers by"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_dfd661c4","line":90,"range":{"start_line":90,"start_character":58,"end_line":90,"end_character":75},"updated":"2019-03-20 18:20:32.000000000","message":"s/neutron-openvswitch-agent","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  \u003chttps://developer.openstack.org/api-guide/compute/port_with_resource_request.html\u003e`_"},{"line_number":88,"context_line":"  of the OpenStack Compute API Guide."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"* If an SR-IOV physical function is configured for use by neutron-ovs-agent,"},{"line_number":91,"context_line":"  and the same physical function\u0027s virtual functions are configured"},{"line_number":92,"context_line":"  for use by the neutron-sriov-agent then the available bandwidth must"},{"line_number":93,"context_line":"  be statically split between the corresponding resource providers by"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_dccf4227","line":90,"range":{"start_line":90,"start_character":55,"end_line":90,"end_character":57},"in_reply_to":"5fc1f717_1f5e29e6","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  \u003chttps://developer.openstack.org/api-guide/compute/port_with_resource_request.html\u003e`_"},{"line_number":88,"context_line":"  of the OpenStack Compute API Guide."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"* If an SR-IOV physical function is configured for use by neutron-ovs-agent,"},{"line_number":91,"context_line":"  and the same physical function\u0027s virtual functions are configured"},{"line_number":92,"context_line":"  for use by the neutron-sriov-agent then the available bandwidth must"},{"line_number":93,"context_line":"  be statically split between the corresponding resource providers by"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_fcd47ebf","line":90,"range":{"start_line":90,"start_character":58,"end_line":90,"end_character":75},"in_reply_to":"5fc1f717_dfd661c4","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  and the same physical function\u0027s virtual functions are configured"},{"line_number":92,"context_line":"  for use by the neutron-sriov-agent then the available bandwidth must"},{"line_number":93,"context_line":"  be statically split between the corresponding resource providers by"},{"line_number":94,"context_line":"  administrative choice. For example a 10g SR-IOV capable physical NIC"},{"line_number":95,"context_line":"  could be treated as two independent NICs - a 5g NIC (technically the"},{"line_number":96,"context_line":"  physical function of the NIC) added to an Open vSwitch bridge, and"},{"line_number":97,"context_line":"  another 5g NIC whose virtual functions can be handed out to servers"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_df9e6153","line":94,"range":{"start_line":94,"start_character":39,"end_line":94,"end_character":42},"updated":"2019-03-20 18:20:32.000000000","message":"nit: 10 Gbps ?  I just usually see a capital G","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  and the same physical function\u0027s virtual functions are configured"},{"line_number":92,"context_line":"  for use by the neutron-sriov-agent then the available bandwidth must"},{"line_number":93,"context_line":"  be statically split between the corresponding resource providers by"},{"line_number":94,"context_line":"  administrative choice. For example a 10g SR-IOV capable physical NIC"},{"line_number":95,"context_line":"  could be treated as two independent NICs - a 5g NIC (technically the"},{"line_number":96,"context_line":"  physical function of the NIC) added to an Open vSwitch bridge, and"},{"line_number":97,"context_line":"  another 5g NIC whose virtual functions can be handed out to servers"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_5ce352a5","line":94,"range":{"start_line":94,"start_character":39,"end_line":94,"end_character":42},"in_reply_to":"5fc1f717_df9e6153","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"6a71873ed0eeacfb8aea303b00283fba1005c163","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Not all Nova virt drivers are supported, please refer to the"},{"line_number":115,"context_line":"`Virt Driver Support section of the Nova Admin Guide"},{"line_number":116,"context_line":"\u003chttps://docs.openstack.org/nova/latest/admin/port_with_resource_request.html#virt-driver-support\u003e`_."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Neutron pre-requisites"},{"line_number":119,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_827f1eaa","line":116,"range":{"start_line":116,"start_character":1,"end_line":116,"end_character":68},"updated":"2019-03-20 23:10:37.000000000","message":"This link is not found. I assume there is another patch adding content of this link?","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Not all Nova virt drivers are supported, please refer to the"},{"line_number":115,"context_line":"`Virt Driver Support section of the Nova Admin Guide"},{"line_number":116,"context_line":"\u003chttps://docs.openstack.org/nova/latest/admin/port_with_resource_request.html#virt-driver-support\u003e`_."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Neutron pre-requisites"},{"line_number":119,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_7ce08e97","line":116,"range":{"start_line":116,"start_character":1,"end_line":116,"end_character":68},"in_reply_to":"5fc1f717_744e6cc2","updated":"2019-03-21 10:33:29.000000000","message":"As Matt said.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b78ae445d9707142e9a739c0fe8abed14b4fd1bd","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Not all Nova virt drivers are supported, please refer to the"},{"line_number":115,"context_line":"`Virt Driver Support section of the Nova Admin Guide"},{"line_number":116,"context_line":"\u003chttps://docs.openstack.org/nova/latest/admin/port_with_resource_request.html#virt-driver-support\u003e`_."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Neutron pre-requisites"},{"line_number":119,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_744e6cc2","line":116,"range":{"start_line":116,"start_character":1,"end_line":116,"end_character":68},"in_reply_to":"5fc1f717_827f1eaa","updated":"2019-03-20 23:57:07.000000000","message":"It\u0027s in the nova change referenced in the commit message which depends-on this change, so we can\u0027t depend on the nova change otherwise we\u0027d have a circular import.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"6a71873ed0eeacfb8aea303b00283fba1005c163","unresolved":false,"context_lines":[{"line_number":135,"context_line":"* Open vSwitch (``openvswitch``) vnic_types: ``normal``, ``direct``"},{"line_number":136,"context_line":"* SR-IOV (``sriovnicswitch``) vnic_types: ``direct``, ``macvtap``"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"neutron-server config"},{"line_number":139,"context_line":"~~~~~~~~~~~~~~~~~~~~~"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"The ``placement`` service plugin synchronizes the agents\u0027 resource"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_d4c16082","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":21},"updated":"2019-03-20 23:10:37.000000000","message":"A minor suggestion. I think it is better to mention where this configuration should be performed. In particular, it is on controller node, network node, or compute node?\n\nThis applies to all below.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":135,"context_line":"* Open vSwitch (``openvswitch``) vnic_types: ``normal``, ``direct``"},{"line_number":136,"context_line":"* SR-IOV (``sriovnicswitch``) vnic_types: ``direct``, ``macvtap``"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"neutron-server config"},{"line_number":139,"context_line":"~~~~~~~~~~~~~~~~~~~~~"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"The ``placement`` service plugin synchronizes the agents\u0027 resource"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_5749ed5d","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":21},"in_reply_to":"5fc1f717_d4c16082","updated":"2019-03-21 10:33:29.000000000","message":"Doing this I realized I\u0027ve put the [ovs_driver] and [sriov_driver] ini sections into the wrong doc sections. Moved them to their proper places.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"6a71873ed0eeacfb8aea303b00283fba1005c163","unresolved":false,"context_lines":[{"line_number":144,"context_line":"Since neutron-server talks to Placement you need to configure how"},{"line_number":145,"context_line":"neutron-server should find Placement and authenticate to it."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"``neutron.conf``:"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":".. code-block:: ini"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_345f84e6","line":147,"range":{"start_line":147,"start_character":2,"end_line":147,"end_character":14},"updated":"2019-03-20 23:10:37.000000000","message":"Would be better to mention the exact location, such /etc/neutron/neutron.conf . This applies to all config file below.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":144,"context_line":"Since neutron-server talks to Placement you need to configure how"},{"line_number":145,"context_line":"neutron-server should find Placement and authenticate to it."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"``neutron.conf``:"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":".. code-block:: ini"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_1775a598","line":147,"range":{"start_line":147,"start_character":2,"end_line":147,"end_character":14},"in_reply_to":"5fc1f717_345f84e6","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":149,"context_line":".. code-block:: ini"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    [DEFAULT]"},{"line_number":152,"context_line":"    service_plugins \u003d placement,..."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    [placement]"},{"line_number":155,"context_line":"    auth_type \u003d password"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_bf26f515","line":152,"updated":"2019-03-20 18:20:32.000000000","message":"From reading other docs there is typically a:\n\nauth_strategy \u003d keystone\n\n...","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":149,"context_line":".. code-block:: ini"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    [DEFAULT]"},{"line_number":152,"context_line":"    service_plugins \u003d placement,..."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    [placement]"},{"line_number":155,"context_line":"    auth_type \u003d password"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_d76e3dc8","line":152,"in_reply_to":"5fc1f717_bf26f515","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    [placement]"},{"line_number":155,"context_line":"    auth_type \u003d password"},{"line_number":156,"context_line":"    auth_url \u003d https://keystone.address/identity"},{"line_number":157,"context_line":"    password \u003d secret"},{"line_number":158,"context_line":"    project_domain_name \u003d Default"},{"line_number":159,"context_line":"    project_name \u003d service"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_bf6b551d","line":156,"updated":"2019-03-20 18:20:32.000000000","message":"... and this is typically something like:\n\nauth_url \u003d http://controller:5000\n\nbut you would know better than I since you\u0027ve tested it","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    [placement]"},{"line_number":155,"context_line":"    auth_type \u003d password"},{"line_number":156,"context_line":"    auth_url \u003d https://keystone.address/identity"},{"line_number":157,"context_line":"    password \u003d secret"},{"line_number":158,"context_line":"    project_domain_name \u003d Default"},{"line_number":159,"context_line":"    project_name \u003d service"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_f781f94b","line":156,"in_reply_to":"5fc1f717_bf6b551d","updated":"2019-03-21 10:33:29.000000000","message":"Since keystone is running under apache wsgi the default port is 80 and the endpoint is /identity.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    user_domain_name \u003d Default"},{"line_number":161,"context_line":"    username \u003d placement"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"neutron-ovs-agent config"},{"line_number":164,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Set agent configuration as the authentic source of the resources"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_1f606932","line":163,"range":{"start_line":163,"start_character":0,"end_line":163,"end_character":17},"updated":"2019-03-20 18:20:32.000000000","message":"s/neutron-openvswitch-agent","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    user_domain_name \u003d Default"},{"line_number":161,"context_line":"    username \u003d placement"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"neutron-ovs-agent config"},{"line_number":164,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Set agent configuration as the authentic source of the resources"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_37ed4125","line":163,"range":{"start_line":163,"start_character":0,"end_line":163,"end_character":17},"in_reply_to":"5fc1f717_1f606932","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":163,"context_line":"neutron-ovs-agent config"},{"line_number":164,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Set agent configuration as the authentic source of the resources"},{"line_number":167,"context_line":"available. Set it on a per-bridge basis by"},{"line_number":168,"context_line":":oslo.config:option:`ovs.resource_provider_bandwidths`."},{"line_number":169,"context_line":"The format is: ``bridge:egress:ingress,...``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_dfff4132","line":166,"range":{"start_line":166,"start_character":4,"end_line":166,"end_character":9},"updated":"2019-03-20 18:20:32.000000000","message":"nit: s/the agent","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":163,"context_line":"neutron-ovs-agent config"},{"line_number":164,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Set agent configuration as the authentic source of the resources"},{"line_number":167,"context_line":"available. Set it on a per-bridge basis by"},{"line_number":168,"context_line":":oslo.config:option:`ovs.resource_provider_bandwidths`."},{"line_number":169,"context_line":"The format is: ``bridge:egress:ingress,...``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_b7d8517f","line":166,"range":{"start_line":166,"start_character":4,"end_line":166,"end_character":9},"in_reply_to":"5fc1f717_dfff4132","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"22fcc7646863d7f8647c1caaa62c801ce53feac9","unresolved":false,"context_lines":[{"line_number":167,"context_line":"available. Set it on a per-bridge basis by"},{"line_number":168,"context_line":":oslo.config:option:`ovs.resource_provider_bandwidths`."},{"line_number":169,"context_line":"The format is: ``bridge:egress:ingress,...``"},{"line_number":170,"context_line":"You may set only one direction and omit the other."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":".. note::"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_09ed9824","line":170,"updated":"2019-03-20 15:59:10.000000000","message":"IMO You can add that if some value will be omited, it will be calculated automatically. Or it will not be?","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"c7ff18004392dfaa5c1b877c0b74f094f0ddd5e4","unresolved":false,"context_lines":[{"line_number":167,"context_line":"available. Set it on a per-bridge basis by"},{"line_number":168,"context_line":":oslo.config:option:`ovs.resource_provider_bandwidths`."},{"line_number":169,"context_line":"The format is: ``bridge:egress:ingress,...``"},{"line_number":170,"context_line":"You may set only one direction and omit the other."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":".. note::"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_89518865","line":170,"in_reply_to":"5fc1f717_09ed9824","updated":"2019-03-20 16:28:41.000000000","message":"If it\u0027s omitted then there\u0027s no inventory reported (for that direction) to Placement. There\u0027s no autodiscovery of what the nic can do.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    Egress and ingress available bandwidth values are in ``kilobit/sec (kbps)``."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"If desired, resource provider inventory fields can be tweaked on a"},{"line_number":180,"context_line":"per agent basis by setting"},{"line_number":181,"context_line":":oslo.config:option:`ovs.resource_provider_inventory_defaults`."},{"line_number":182,"context_line":"Valid values are all the"},{"line_number":183,"context_line":"`optional parameters of the update resource provider inventory call"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_1fa38951","line":180,"range":{"start_line":180,"start_character":0,"end_line":180,"end_character":9},"updated":"2019-03-20 18:20:32.000000000","message":"nit: s/per-agent","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    Egress and ingress available bandwidth values are in ``kilobit/sec (kbps)``."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"If desired, resource provider inventory fields can be tweaked on a"},{"line_number":180,"context_line":"per agent basis by setting"},{"line_number":181,"context_line":":oslo.config:option:`ovs.resource_provider_inventory_defaults`."},{"line_number":182,"context_line":"Valid values are all the"},{"line_number":183,"context_line":"`optional parameters of the update resource provider inventory call"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_17d12558","line":180,"range":{"start_line":180,"start_character":0,"end_line":180,"end_character":9},"in_reply_to":"5fc1f717_1fa38951","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":193,"context_line":"`respective mechanism drivers"},{"line_number":194,"context_line":"\u003chttps://docs.openstack.org/neutron/latest/admin/config-ml2.html#supported-vnic-types\u003e`_."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"``ovs_agent.ini`` or ``ml2_conf.ini``:"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":".. code-block:: ini"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_1f7149e1","line":196,"range":{"start_line":196,"start_character":2,"end_line":196,"end_character":15},"updated":"2019-03-20 18:20:32.000000000","message":"s/openvswitch_agent.ini","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":193,"context_line":"`respective mechanism drivers"},{"line_number":194,"context_line":"\u003chttps://docs.openstack.org/neutron/latest/admin/config-ml2.html#supported-vnic-types\u003e`_."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"``ovs_agent.ini`` or ``ml2_conf.ini``:"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":".. code-block:: ini"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_37d6a151","line":196,"range":{"start_line":196,"start_character":2,"end_line":196,"end_character":15},"in_reply_to":"5fc1f717_1f7149e1","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"2be3c43e27c1de5b4de13874ee52b583cd4d3663","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    [ovs]"},{"line_number":201,"context_line":"    bridge_mappings \u003d physnet0:br-physnet0,..."},{"line_number":202,"context_line":"    resource_provider_bandwidths \u003d br-physnet0:10000000:10000000,..."},{"line_number":203,"context_line":"    #resource_provider_inventory_defaults \u003d step_size:1000,..."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    [ovs_driver]"},{"line_number":206,"context_line":"    vnic_type_blacklist \u003d direct"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_a920049d","line":203,"range":{"start_line":203,"start_character":4,"end_line":203,"end_character":62},"updated":"2019-03-20 15:47:21.000000000","message":"This is not needed?","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"c7ff18004392dfaa5c1b877c0b74f094f0ddd5e4","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    [ovs]"},{"line_number":201,"context_line":"    bridge_mappings \u003d physnet0:br-physnet0,..."},{"line_number":202,"context_line":"    resource_provider_bandwidths \u003d br-physnet0:10000000:10000000,..."},{"line_number":203,"context_line":"    #resource_provider_inventory_defaults \u003d step_size:1000,..."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    [ovs_driver]"},{"line_number":206,"context_line":"    vnic_type_blacklist \u003d direct"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_6920dc4a","line":203,"range":{"start_line":203,"start_character":4,"end_line":203,"end_character":62},"in_reply_to":"5fc1f717_a920049d","updated":"2019-03-20 16:28:41.000000000","message":"These are commented because I want to show that they are optional and can be used if somebody needs them.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":209,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"The configuration of neutron-sriov-agent is analog to that of"},{"line_number":212,"context_line":"neutron-ovs-agent. However look out for:"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"* The different .ini section names as you can see below."},{"line_number":215,"context_line":"* That neutron-sriov-agent allows a physnet to be backed by multiple physical"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_bfd915f5","line":212,"range":{"start_line":212,"start_character":0,"end_line":212,"end_character":17},"updated":"2019-03-20 18:20:32.000000000","message":"s/the neutron-openvswitch-agent","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":209,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"The configuration of neutron-sriov-agent is analog to that of"},{"line_number":212,"context_line":"neutron-ovs-agent. However look out for:"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"* The different .ini section names as you can see below."},{"line_number":215,"context_line":"* That neutron-sriov-agent allows a physnet to be backed by multiple physical"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_f7cfb9ad","line":212,"range":{"start_line":212,"start_character":0,"end_line":212,"end_character":17},"in_reply_to":"5fc1f717_bfd915f5","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"2be3c43e27c1de5b4de13874ee52b583cd4d3663","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    [sriov_nic]"},{"line_number":225,"context_line":"    physical_device_mappings \u003d physnet0:ens5,physnet0:ens6,..."},{"line_number":226,"context_line":"    resource_provider_bandwidths \u003d ens5:40000000:40000000,ens6:40000000:40000000,..."},{"line_number":227,"context_line":"    #resource_provider_inventory_defaults \u003d step_size:1000,..."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    [sriov_driver]"},{"line_number":230,"context_line":"    #vnic_type_blacklist \u003d direct"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_49188074","line":227,"range":{"start_line":227,"start_character":4,"end_line":227,"end_character":62},"updated":"2019-03-20 15:47:21.000000000","message":"This is not needed?","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    [sriov_nic]"},{"line_number":225,"context_line":"    physical_device_mappings \u003d physnet0:ens5,physnet0:ens6,..."},{"line_number":226,"context_line":"    resource_provider_bandwidths \u003d ens5:40000000:40000000,ens6:40000000:40000000,..."},{"line_number":227,"context_line":"    #resource_provider_inventory_defaults \u003d step_size:1000,..."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    [sriov_driver]"},{"line_number":230,"context_line":"    #vnic_type_blacklist \u003d direct"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_d73f1d85","line":227,"range":{"start_line":227,"start_character":4,"end_line":227,"end_character":62},"in_reply_to":"5fc1f717_49188074","updated":"2019-03-21 10:33:29.000000000","message":"As above.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"2be3c43e27c1de5b4de13874ee52b583cd4d3663","unresolved":false,"context_lines":[{"line_number":227,"context_line":"    #resource_provider_inventory_defaults \u003d step_size:1000,..."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    [sriov_driver]"},{"line_number":230,"context_line":"    #vnic_type_blacklist \u003d direct"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"Propagation of resource information"},{"line_number":233,"context_line":"-----------------------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_092cb897","line":230,"range":{"start_line":230,"start_character":4,"end_line":230,"end_character":33},"updated":"2019-03-20 15:47:21.000000000","message":"ditto","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":227,"context_line":"    #resource_provider_inventory_defaults \u003d step_size:1000,..."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    [sriov_driver]"},{"line_number":230,"context_line":"    #vnic_type_blacklist \u003d direct"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"Propagation of resource information"},{"line_number":233,"context_line":"-----------------------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_f744991d","line":230,"range":{"start_line":230,"start_character":4,"end_line":230,"end_character":33},"in_reply_to":"5fc1f717_092cb897","updated":"2019-03-21 10:33:29.000000000","message":"As above.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"22fcc7646863d7f8647c1caaa62c801ce53feac9","unresolved":false,"context_lines":[{"line_number":237,"context_line":"The authentic source of available resources is neutron agent configuration -"},{"line_number":238,"context_line":"where the resources actually exist, as described in the agent configuration"},{"line_number":239,"context_line":"sections above. This information is propagated in the following chain:"},{"line_number":240,"context_line":"``neutron-x-agent -\u003e neutron-server -\u003e Placement``."},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"From neutron agent to server the information is included in the"},{"line_number":243,"context_line":"``configurations`` field of the agent heartbeat message sent on the message"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_09d6f850","line":240,"range":{"start_line":240,"start_character":10,"end_line":240,"end_character":11},"updated":"2019-03-20 15:59:10.000000000","message":"nit: IMHO You can say here \"neutron-l2-agent\" but that isn\u0027t big deal and that\u0027s only my personal opinion :)","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":237,"context_line":"The authentic source of available resources is neutron agent configuration -"},{"line_number":238,"context_line":"where the resources actually exist, as described in the agent configuration"},{"line_number":239,"context_line":"sections above. This information is propagated in the following chain:"},{"line_number":240,"context_line":"``neutron-x-agent -\u003e neutron-server -\u003e Placement``."},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"From neutron agent to server the information is included in the"},{"line_number":243,"context_line":"``configurations`` field of the agent heartbeat message sent on the message"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_97499533","line":240,"range":{"start_line":240,"start_character":10,"end_line":240,"end_character":11},"in_reply_to":"5fc1f717_09d6f850","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"6a71873ed0eeacfb8aea303b00283fba1005c163","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":".. code-block:: console"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    # as admin"},{"line_number":249,"context_line":"    $ openstack network agent list --agent-type open-vswitch --host devstack0"},{"line_number":250,"context_line":"    +--------------------------------------+--------------------+-----------+-------------------+-------+-------+---------------------------+"},{"line_number":251,"context_line":"    | ID                                   | Agent Type         | Host      | Availability Zone | Alive | State | Binary                    |"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_d46f2090","line":248,"range":{"start_line":248,"start_character":4,"end_line":248,"end_character":14},"updated":"2019-03-20 23:10:37.000000000","message":"First, I think this is obvious so we might not need to mention it. Second, the format \"# ..\" might confuse readers since they might think this is command running under root.\n\nThis applies to all below.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":".. code-block:: console"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    # as admin"},{"line_number":249,"context_line":"    $ openstack network agent list --agent-type open-vswitch --host devstack0"},{"line_number":250,"context_line":"    +--------------------------------------+--------------------+-----------+-------------------+-------+-------+---------------------------+"},{"line_number":251,"context_line":"    | ID                                   | Agent Type         | Host      | Availability Zone | Alive | State | Binary                    |"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_77698989","line":248,"range":{"start_line":248,"start_character":4,"end_line":248,"end_character":14},"in_reply_to":"5fc1f717_d46f2090","updated":"2019-03-21 10:33:29.000000000","message":"Maybe it\u0027s not trivial to everybody what needs to be done as admin and non-admin, especially that we have both kinds in this doc. I hope readers can parse # as a comment.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4a86b2fcc6843c74fe956a687de16872f0625ef9","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                                              \u0027min_unit\u0027: 1,"},{"line_number":264,"context_line":"                                              \u0027reserved\u0027: 0,"},{"line_number":265,"context_line":"                                              \u0027step_size\u0027: 1},"},{"line_number":266,"context_line":"     ..."},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"Re-reading the resource related subset of configuration on ``SIGHUP`` is not"},{"line_number":269,"context_line":"implemented. The agent must be restarted to pick up and send changed"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_099fd8b4","line":266,"updated":"2019-03-20 15:53:40.000000000","message":"Missing the end \"}\"","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"c7ff18004392dfaa5c1b877c0b74f094f0ddd5e4","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                                              \u0027min_unit\u0027: 1,"},{"line_number":264,"context_line":"                                              \u0027reserved\u0027: 0,"},{"line_number":265,"context_line":"                                              \u0027step_size\u0027: 1},"},{"line_number":266,"context_line":"     ..."},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"Re-reading the resource related subset of configuration on ``SIGHUP`` is not"},{"line_number":269,"context_line":"implemented. The agent must be restarted to pick up and send changed"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_89ff4833","line":266,"in_reply_to":"5fc1f717_099fd8b4","updated":"2019-03-20 16:28:41.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"* None: No sync was attempted (normal for agents not reporting"},{"line_number":300,"context_line":"  Placement-backed resources)."},{"line_number":301,"context_line":"* True: The last sync attempt was completely successful."},{"line_number":302,"context_line":"* False: The last sync attempt was partially or utterly unsuccessful."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"In case ``resources_synced`` is not True for an agent, neutron-server"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_0221ee9f","line":301,"range":{"start_line":301,"start_character":34,"end_line":301,"end_character":55},"updated":"2019-03-20 18:20:32.000000000","message":"nit: s/completed successfully\n\nbut i guess you did this to match below?","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"* None: No sync was attempted (normal for agents not reporting"},{"line_number":300,"context_line":"  Placement-backed resources)."},{"line_number":301,"context_line":"* True: The last sync attempt was completely successful."},{"line_number":302,"context_line":"* False: The last sync attempt was partially or utterly unsuccessful."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"In case ``resources_synced`` is not True for an agent, neutron-server"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_f7e019fd","line":301,"range":{"start_line":301,"start_character":34,"end_line":301,"end_character":55},"in_reply_to":"5fc1f717_0221ee9f","updated":"2019-03-21 10:33:29.000000000","message":"In these two lines I wanted to express that a partial success is counted as unsuccessful. If I change L301 to \u0027successful\u0027 and L302 to \u0027uncuccessful\u0027 this information would be lost.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":299,"context_line":"* None: No sync was attempted (normal for agents not reporting"},{"line_number":300,"context_line":"  Placement-backed resources)."},{"line_number":301,"context_line":"* True: The last sync attempt was completely successful."},{"line_number":302,"context_line":"* False: The last sync attempt was partially or utterly unsuccessful."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"In case ``resources_synced`` is not True for an agent, neutron-server"},{"line_number":305,"context_line":"does try to re-sync on receiving every heartbeat message from that"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_8234fedf","line":302,"range":{"start_line":302,"start_character":35,"end_line":302,"end_character":55},"updated":"2019-03-20 18:20:32.000000000","message":"nit: d/ (as unsuccessful is enough, right?)","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":299,"context_line":"* None: No sync was attempted (normal for agents not reporting"},{"line_number":300,"context_line":"  Placement-backed resources)."},{"line_number":301,"context_line":"* True: The last sync attempt was completely successful."},{"line_number":302,"context_line":"* False: The last sync attempt was partially or utterly unsuccessful."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"In case ``resources_synced`` is not True for an agent, neutron-server"},{"line_number":305,"context_line":"does try to re-sync on receiving every heartbeat message from that"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_57c48d40","line":302,"range":{"start_line":302,"start_character":35,"end_line":302,"end_character":55},"in_reply_to":"5fc1f717_8234fedf","updated":"2019-03-21 10:33:29.000000000","message":"As above.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":310,"context_line":"It is important to note that the restart of neutron-server does not trigger"},{"line_number":311,"context_line":"any kind of re-sync to Placement (to avoid an update storm)."},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"As mentioned before the information flow for resources requested and"},{"line_number":314,"context_line":"(if proper) allocated is different. It involves a conversation between Nova,"},{"line_number":315,"context_line":"Neutron and Placement."},{"line_number":316,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_627a3289","line":313,"range":{"start_line":313,"start_character":13,"end_line":313,"end_character":19},"updated":"2019-03-20 18:20:32.000000000","message":"nit: s/before,","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":310,"context_line":"It is important to note that the restart of neutron-server does not trigger"},{"line_number":311,"context_line":"any kind of re-sync to Placement (to avoid an update storm)."},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"As mentioned before the information flow for resources requested and"},{"line_number":314,"context_line":"(if proper) allocated is different. It involves a conversation between Nova,"},{"line_number":315,"context_line":"Neutron and Placement."},{"line_number":316,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_17dcc516","line":313,"range":{"start_line":313,"start_character":13,"end_line":313,"end_character":19},"in_reply_to":"5fc1f717_627a3289","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        --network net0 \\"},{"line_number":376,"context_line":"        --qos-policy policy0"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    # alternatively an sr-iov port, unused in this example"},{"line_number":379,"context_line":"    $ openstack port create port-direct-qos \\"},{"line_number":380,"context_line":"        --network net0 \\"},{"line_number":381,"context_line":"        --vnic-type direct \\"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_22a98ade","line":378,"range":{"start_line":378,"start_character":23,"end_line":378,"end_character":29},"updated":"2019-03-20 18:20:32.000000000","message":"nit: s/SR-IOV","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        --network net0 \\"},{"line_number":376,"context_line":"        --qos-policy policy0"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    # alternatively an sr-iov port, unused in this example"},{"line_number":379,"context_line":"    $ openstack port create port-direct-qos \\"},{"line_number":380,"context_line":"        --network net0 \\"},{"line_number":381,"context_line":"        --vnic-type direct \\"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_f7ea59aa","line":378,"range":{"start_line":378,"start_character":23,"end_line":378,"end_character":29},"in_reply_to":"5fc1f717_22a98ade","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"22fcc7646863d7f8647c1caaa62c801ce53feac9","unresolved":false,"context_lines":[{"line_number":393,"context_line":"(what is available, what is used) it may in some conditions get out of sync"},{"line_number":394,"context_line":"with reality."},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"One important case is when the Neutron-only Minimum Guaranteed Bandwidth"},{"line_number":397,"context_line":"feature was used before Stein (first released in Newton). Since before Stein"},{"line_number":398,"context_line":"guarantees were not enforced during server placement the available resources"},{"line_number":399,"context_line":"may have become overallocated without notice. In this case Placement\u0027s view"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_499ac06e","line":396,"range":{"start_line":396,"start_character":31,"end_line":396,"end_character":44},"updated":"2019-03-20 15:59:10.000000000","message":"I would say \"data plane only (best effort)\"","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"c7ff18004392dfaa5c1b877c0b74f094f0ddd5e4","unresolved":false,"context_lines":[{"line_number":393,"context_line":"(what is available, what is used) it may in some conditions get out of sync"},{"line_number":394,"context_line":"with reality."},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"One important case is when the Neutron-only Minimum Guaranteed Bandwidth"},{"line_number":397,"context_line":"feature was used before Stein (first released in Newton). Since before Stein"},{"line_number":398,"context_line":"guarantees were not enforced during server placement the available resources"},{"line_number":399,"context_line":"may have become overallocated without notice. In this case Placement\u0027s view"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_0999181e","line":396,"range":{"start_line":396,"start_character":31,"end_line":396,"end_character":44},"in_reply_to":"5fc1f717_499ac06e","updated":"2019-03-20 16:28:41.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":397,"context_line":"feature was used before Stein (first released in Newton). Since before Stein"},{"line_number":398,"context_line":"guarantees were not enforced during server placement the available resources"},{"line_number":399,"context_line":"may have become overallocated without notice. In this case Placement\u0027s view"},{"line_number":400,"context_line":"and the reality of resource use should be made consistent during/after an"},{"line_number":401,"context_line":"upgrade to Stein."},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"Another case stems from OpenStack not having distributed transactions to"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_c2968695","line":400,"range":{"start_line":400,"start_character":28,"end_line":400,"end_character":31},"updated":"2019-03-20 18:20:32.000000000","message":"nit: s/usage ?","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":397,"context_line":"feature was used before Stein (first released in Newton). Since before Stein"},{"line_number":398,"context_line":"guarantees were not enforced during server placement the available resources"},{"line_number":399,"context_line":"may have become overallocated without notice. In this case Placement\u0027s view"},{"line_number":400,"context_line":"and the reality of resource use should be made consistent during/after an"},{"line_number":401,"context_line":"upgrade to Stein."},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"Another case stems from OpenStack not having distributed transactions to"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_372f81f7","line":400,"range":{"start_line":400,"start_character":28,"end_line":400,"end_character":31},"in_reply_to":"5fc1f717_c2968695","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":403,"context_line":"Another case stems from OpenStack not having distributed transactions to"},{"line_number":404,"context_line":"allocate resources provided by multiple OpenStack components (here Nova and"},{"line_number":405,"context_line":"Neutron). There are known race conditions in which Placement\u0027s view may get"},{"line_number":406,"context_line":"out of touch with reality. The design knowingly minimizes the race condition"},{"line_number":407,"context_line":"windows though. Known problems:"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"* A QoS policy is modified after Nova read a port\u0027s ``resource_request``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_22f74af8","line":406,"range":{"start_line":406,"start_character":7,"end_line":406,"end_character":12},"updated":"2019-03-20 18:20:32.000000000","message":"nit: s/sync ?  \"out of touch\" is giving Placement feelings :)","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":403,"context_line":"Another case stems from OpenStack not having distributed transactions to"},{"line_number":404,"context_line":"allocate resources provided by multiple OpenStack components (here Nova and"},{"line_number":405,"context_line":"Neutron). There are known race conditions in which Placement\u0027s view may get"},{"line_number":406,"context_line":"out of touch with reality. The design knowingly minimizes the race condition"},{"line_number":407,"context_line":"windows though. Known problems:"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"* A QoS policy is modified after Nova read a port\u0027s ``resource_request``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_973d152e","line":406,"range":{"start_line":406,"start_character":7,"end_line":406,"end_character":12},"in_reply_to":"5fc1f717_22f74af8","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":404,"context_line":"allocate resources provided by multiple OpenStack components (here Nova and"},{"line_number":405,"context_line":"Neutron). There are known race conditions in which Placement\u0027s view may get"},{"line_number":406,"context_line":"out of touch with reality. The design knowingly minimizes the race condition"},{"line_number":407,"context_line":"windows though. Known problems:"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"* A QoS policy is modified after Nova read a port\u0027s ``resource_request``"},{"line_number":410,"context_line":"  but before the port is bound."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_626472ba","line":407,"range":{"start_line":407,"start_character":8,"end_line":407,"end_character":15},"updated":"2019-03-20 18:20:32.000000000","message":"nit: s/though, but there are known","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":404,"context_line":"allocate resources provided by multiple OpenStack components (here Nova and"},{"line_number":405,"context_line":"Neutron). There are known race conditions in which Placement\u0027s view may get"},{"line_number":406,"context_line":"out of touch with reality. The design knowingly minimizes the race condition"},{"line_number":407,"context_line":"windows though. Known problems:"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"* A QoS policy is modified after Nova read a port\u0027s ``resource_request``"},{"line_number":410,"context_line":"  but before the port is bound."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_e2f4e2d1","line":407,"range":{"start_line":407,"start_character":0,"end_line":407,"end_character":30},"updated":"2019-03-20 18:20:32.000000000","message":"nit: s/window, but there are known problems:","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":404,"context_line":"allocate resources provided by multiple OpenStack components (here Nova and"},{"line_number":405,"context_line":"Neutron). There are known race conditions in which Placement\u0027s view may get"},{"line_number":406,"context_line":"out of touch with reality. The design knowingly minimizes the race condition"},{"line_number":407,"context_line":"windows though. Known problems:"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"* A QoS policy is modified after Nova read a port\u0027s ``resource_request``"},{"line_number":410,"context_line":"  but before the port is bound."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_171365ba","line":407,"range":{"start_line":407,"start_character":0,"end_line":407,"end_character":30},"in_reply_to":"5fc1f717_e2f4e2d1","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":406,"context_line":"out of touch with reality. The design knowingly minimizes the race condition"},{"line_number":407,"context_line":"windows though. Known problems:"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"* A QoS policy is modified after Nova read a port\u0027s ``resource_request``"},{"line_number":410,"context_line":"  but before the port is bound."},{"line_number":411,"context_line":"* `A bound port with a resource allocation is deleted. The port\u0027s allocation"},{"line_number":412,"context_line":"  is leaked. \u003chttps://bugs.launchpad.net/nova/+bug/1820588\u003e`_"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_42bb76e4","line":409,"range":{"start_line":409,"start_character":2,"end_line":409,"end_character":3},"updated":"2019-03-20 18:20:32.000000000","message":"s/If a","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":406,"context_line":"out of touch with reality. The design knowingly minimizes the race condition"},{"line_number":407,"context_line":"windows though. Known problems:"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"* A QoS policy is modified after Nova read a port\u0027s ``resource_request``"},{"line_number":410,"context_line":"  but before the port is bound."},{"line_number":411,"context_line":"* `A bound port with a resource allocation is deleted. The port\u0027s allocation"},{"line_number":412,"context_line":"  is leaked. \u003chttps://bugs.launchpad.net/nova/+bug/1820588\u003e`_"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_d7815dc5","line":409,"range":{"start_line":409,"start_character":2,"end_line":409,"end_character":3},"in_reply_to":"5fc1f717_42bb76e4","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":407,"context_line":"windows though. Known problems:"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"* A QoS policy is modified after Nova read a port\u0027s ``resource_request``"},{"line_number":410,"context_line":"  but before the port is bound."},{"line_number":411,"context_line":"* `A bound port with a resource allocation is deleted. The port\u0027s allocation"},{"line_number":412,"context_line":"  is leaked. \u003chttps://bugs.launchpad.net/nova/+bug/1820588\u003e`_"},{"line_number":413,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_e2cb826f","line":410,"updated":"2019-03-20 18:20:32.000000000","message":"The sentence doesn\u0027t completely describe the problem, is the policy not getting applied properly?","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":407,"context_line":"windows though. Known problems:"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"* A QoS policy is modified after Nova read a port\u0027s ``resource_request``"},{"line_number":410,"context_line":"  but before the port is bound."},{"line_number":411,"context_line":"* `A bound port with a resource allocation is deleted. The port\u0027s allocation"},{"line_number":412,"context_line":"  is leaked. \u003chttps://bugs.launchpad.net/nova/+bug/1820588\u003e`_"},{"line_number":413,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_1794c5e7","line":410,"in_reply_to":"5fc1f717_e2cb826f","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":408,"context_line":""},{"line_number":409,"context_line":"* A QoS policy is modified after Nova read a port\u0027s ``resource_request``"},{"line_number":410,"context_line":"  but before the port is bound."},{"line_number":411,"context_line":"* `A bound port with a resource allocation is deleted. The port\u0027s allocation"},{"line_number":412,"context_line":"  is leaked. \u003chttps://bugs.launchpad.net/nova/+bug/1820588\u003e`_"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_e2e2a201","line":411,"range":{"start_line":411,"start_character":3,"end_line":411,"end_character":58},"updated":"2019-03-20 18:20:32.000000000","message":"s/If a bound port with a resource allocation is deleted, the\n\nI would maybe even just put the bug as a link and not the whole sentence.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":408,"context_line":""},{"line_number":409,"context_line":"* A QoS policy is modified after Nova read a port\u0027s ``resource_request``"},{"line_number":410,"context_line":"  but before the port is bound."},{"line_number":411,"context_line":"* `A bound port with a resource allocation is deleted. The port\u0027s allocation"},{"line_number":412,"context_line":"  is leaked. \u003chttps://bugs.launchpad.net/nova/+bug/1820588\u003e`_"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_772ae990","line":411,"range":{"start_line":411,"start_character":3,"end_line":411,"end_character":58},"in_reply_to":"5fc1f717_e2e2a201","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":413,"context_line":""},{"line_number":414,"context_line":".. note::"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"  Deleting a bound port has no known use case though. Please consider"},{"line_number":417,"context_line":"  detaching the interface first by ``openstack server remove port`` instead."},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"Incorrect allocations may be fixed by:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_826cfe9c","line":416,"range":{"start_line":416,"start_character":45,"end_line":416,"end_character":52},"updated":"2019-03-20 18:20:32.000000000","message":"d/","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":413,"context_line":""},{"line_number":414,"context_line":".. note::"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"  Deleting a bound port has no known use case though. Please consider"},{"line_number":417,"context_line":"  detaching the interface first by ``openstack server remove port`` instead."},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"Incorrect allocations may be fixed by:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_371ea170","line":416,"range":{"start_line":416,"start_character":45,"end_line":416,"end_character":52},"in_reply_to":"5fc1f717_826cfe9c","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":418,"context_line":""},{"line_number":419,"context_line":"Incorrect allocations may be fixed by:"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"* Moving a server deletes the wrong and re-creates the proper allocation"},{"line_number":422,"context_line":"  as soon as move operations are implemented (not in Stein unfortunately)."},{"line_number":423,"context_line":"  Moving servers fixes local overallocations."},{"line_number":424,"context_line":"* The need for an upgrade-helper allocation healing tool is being tracked in"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_02832e06","line":421,"range":{"start_line":421,"start_character":2,"end_line":421,"end_character":50},"updated":"2019-03-20 18:20:32.000000000","message":"s/Moving the server, which will delete the wrong allocation and create the correct allocation...","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":418,"context_line":""},{"line_number":419,"context_line":"Incorrect allocations may be fixed by:"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"* Moving a server deletes the wrong and re-creates the proper allocation"},{"line_number":422,"context_line":"  as soon as move operations are implemented (not in Stein unfortunately)."},{"line_number":423,"context_line":"  Moving servers fixes local overallocations."},{"line_number":424,"context_line":"* The need for an upgrade-helper allocation healing tool is being tracked in"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_f2f6e7f9","line":421,"range":{"start_line":421,"start_character":2,"end_line":421,"end_character":50},"in_reply_to":"5fc1f717_02832e06","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":422,"context_line":"  as soon as move operations are implemented (not in Stein unfortunately)."},{"line_number":423,"context_line":"  Moving servers fixes local overallocations."},{"line_number":424,"context_line":"* The need for an upgrade-helper allocation healing tool is being tracked in"},{"line_number":425,"context_line":"  `bug/1819923 \u003chttps://bugs.launchpad.net/nova/+bug/1819923\u003e`_."},{"line_number":426,"context_line":"* Manually by `openstack resource provider allocation set"},{"line_number":427,"context_line":"  \u003chttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-set\u003e`_"},{"line_number":428,"context_line":"  /`delete \u003chttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-delete\u003e`_."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_82763e3e","line":425,"range":{"start_line":425,"start_character":3,"end_line":425,"end_character":14},"updated":"2019-03-20 18:20:32.000000000","message":"nit: s/bug 1819923","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":422,"context_line":"  as soon as move operations are implemented (not in Stein unfortunately)."},{"line_number":423,"context_line":"  Moving servers fixes local overallocations."},{"line_number":424,"context_line":"* The need for an upgrade-helper allocation healing tool is being tracked in"},{"line_number":425,"context_line":"  `bug/1819923 \u003chttps://bugs.launchpad.net/nova/+bug/1819923\u003e`_."},{"line_number":426,"context_line":"* Manually by `openstack resource provider allocation set"},{"line_number":427,"context_line":"  \u003chttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-set\u003e`_"},{"line_number":428,"context_line":"  /`delete \u003chttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-delete\u003e`_."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_52e57b37","line":425,"range":{"start_line":425,"start_character":3,"end_line":425,"end_character":14},"in_reply_to":"5fc1f717_82763e3e","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":423,"context_line":"  Moving servers fixes local overallocations."},{"line_number":424,"context_line":"* The need for an upgrade-helper allocation healing tool is being tracked in"},{"line_number":425,"context_line":"  `bug/1819923 \u003chttps://bugs.launchpad.net/nova/+bug/1819923\u003e`_."},{"line_number":426,"context_line":"* Manually by `openstack resource provider allocation set"},{"line_number":427,"context_line":"  \u003chttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-set\u003e`_"},{"line_number":428,"context_line":"  /`delete \u003chttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-delete\u003e`_."},{"line_number":429,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_62931251","line":426,"range":{"start_line":426,"start_character":2,"end_line":426,"end_character":13},"updated":"2019-03-20 18:20:32.000000000","message":"s/Manually, by using","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":423,"context_line":"  Moving servers fixes local overallocations."},{"line_number":424,"context_line":"* The need for an upgrade-helper allocation healing tool is being tracked in"},{"line_number":425,"context_line":"  `bug/1819923 \u003chttps://bugs.launchpad.net/nova/+bug/1819923\u003e`_."},{"line_number":426,"context_line":"* Manually by `openstack resource provider allocation set"},{"line_number":427,"context_line":"  \u003chttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-set\u003e`_"},{"line_number":428,"context_line":"  /`delete \u003chttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-delete\u003e`_."},{"line_number":429,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_72e2f731","line":426,"range":{"start_line":426,"start_character":2,"end_line":426,"end_character":13},"in_reply_to":"5fc1f717_62931251","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4a86b2fcc6843c74fe956a687de16872f0625ef9","unresolved":false,"context_lines":[{"line_number":427,"context_line":"  \u003chttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-set\u003e`_"},{"line_number":428,"context_line":"  /`delete \u003chttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-delete\u003e`_."},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Debugging"},{"line_number":431,"context_line":"---------"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"* Are all components running at least the Stein release?"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_090918dc","line":430,"range":{"start_line":430,"start_character":0,"end_line":430,"end_character":9},"updated":"2019-03-20 15:53:40.000000000","message":"The most of the following question does not have the answer, so if it is possible to give user some possible check clue or CLI command?","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"c7ff18004392dfaa5c1b877c0b74f094f0ddd5e4","unresolved":false,"context_lines":[{"line_number":427,"context_line":"  \u003chttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-set\u003e`_"},{"line_number":428,"context_line":"  /`delete \u003chttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-delete\u003e`_."},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Debugging"},{"line_number":431,"context_line":"---------"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"* Are all components running at least the Stein release?"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_e9184c85","line":430,"range":{"start_line":430,"start_character":0,"end_line":430,"end_character":9},"in_reply_to":"5fc1f717_090918dc","updated":"2019-03-20 16:28:41.000000000","message":"These are questions that are meant to guide debugging. At some places I can add an example of a correctly working system. But many outputs are heavily dependent on system configuration and the answer cannot and will not be generic.\n\nIf we want example outputs here, I\u0027d recommend doing that as a followup, because that would be quite a lot of work until tommorrow evening.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4a86b2fcc6843c74fe956a687de16872f0625ef9","unresolved":false,"context_lines":[{"line_number":447,"context_line":".. code-block:: console"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    # as admin"},{"line_number":450,"context_line":"    $ openstack network agent show ... | grep configurations"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"* Did neutron-server successfully sync to Placement?"},{"line_number":453,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_a9f1e403","line":450,"range":{"start_line":450,"start_character":6,"end_line":450,"end_character":60},"updated":"2019-03-20 15:53:40.000000000","message":"Any output example here?","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":447,"context_line":".. code-block:: console"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    # as admin"},{"line_number":450,"context_line":"    $ openstack network agent show ... | grep configurations"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"* Did neutron-server successfully sync to Placement?"},{"line_number":453,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_a2a81a77","line":450,"range":{"start_line":450,"start_character":6,"end_line":450,"end_character":60},"in_reply_to":"5fc1f717_a9f1e403","updated":"2019-03-20 18:20:32.000000000","message":"+1","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":447,"context_line":".. code-block:: console"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    # as admin"},{"line_number":450,"context_line":"    $ openstack network agent show ... | grep configurations"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"* Did neutron-server successfully sync to Placement?"},{"line_number":453,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_127853f6","line":450,"range":{"start_line":450,"start_character":6,"end_line":450,"end_character":60},"in_reply_to":"5fc1f717_a9f1e403","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4a86b2fcc6843c74fe956a687de16872f0625ef9","unresolved":false,"context_lines":[{"line_number":454,"context_line":".. code-block:: console"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    # as admin"},{"line_number":457,"context_line":"    $ openstack network agent show ... | grep resources_synced"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"* Is the resource provider tree correct? Is the root a compute host? One level"},{"line_number":460,"context_line":"  below the agents? Two levels below the physical network interfaces?"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_69dbfc7c","line":457,"range":{"start_line":457,"start_character":6,"end_line":457,"end_character":62},"updated":"2019-03-20 15:53:40.000000000","message":"Any output example here?","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":454,"context_line":".. code-block:: console"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    # as admin"},{"line_number":457,"context_line":"    $ openstack network agent show ... | grep resources_synced"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"* Is the resource provider tree correct? Is the root a compute host? One level"},{"line_number":460,"context_line":"  below the agents? Two levels below the physical network interfaces?"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_62bc72bb","line":457,"range":{"start_line":457,"start_character":6,"end_line":457,"end_character":62},"in_reply_to":"5fc1f717_69dbfc7c","updated":"2019-03-20 18:20:32.000000000","message":"+1","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":454,"context_line":".. code-block:: console"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    # as admin"},{"line_number":457,"context_line":"    $ openstack network agent show ... | grep resources_synced"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"* Is the resource provider tree correct? Is the root a compute host? One level"},{"line_number":460,"context_line":"  below the agents? Two levels below the physical network interfaces?"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_327d4fe7","line":457,"range":{"start_line":457,"start_character":6,"end_line":457,"end_character":62},"in_reply_to":"5fc1f717_69dbfc7c","updated":"2019-03-21 10:33:29.000000000","message":"Done","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e110ca76de0ed9e8c85ced920c610afbfc95357f","unresolved":false,"context_lines":[{"line_number":513,"context_line":"    # as admin"},{"line_number":514,"context_line":"    $ openstack --os-placement-api-version 1.17 resource provider allocation show SERVER-UUID"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"* Does the allocation have a part on the expected physical network interface"},{"line_number":517,"context_line":"  resource provider?"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_e2c70245","line":516,"range":{"start_line":516,"start_character":29,"end_line":516,"end_character":33},"updated":"2019-03-20 18:20:32.000000000","message":"s/port","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"f2ed9e19e40da98c5f2dd75f91aff31afea6f4bc","unresolved":false,"context_lines":[{"line_number":513,"context_line":"    # as admin"},{"line_number":514,"context_line":"    $ openstack --os-placement-api-version 1.17 resource provider allocation show SERVER-UUID"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"* Does the allocation have a part on the expected physical network interface"},{"line_number":517,"context_line":"  resource provider?"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fc1f717_12a053a5","line":516,"range":{"start_line":516,"start_character":29,"end_line":516,"end_character":33},"in_reply_to":"5fc1f717_e2c70245","updated":"2019-03-21 10:33:29.000000000","message":"That\u0027s not a typo.","commit_id":"252598b08827c0cd5e5c4174f84b4196c59f7493"}]}
