)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"0a202094abcd662481d64b50f72a3a61e5edd8f6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable ipv6_forwarding in HA router\u0027s namespace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When HA router is created in \"stanby\" mode, ipv6 forwarding is"},{"line_number":10,"context_line":"disabled by default in its namespace."},{"line_number":11,"context_line":"But when router is transitioned to be \"master\" on node, ipv6"},{"line_number":12,"context_line":"forwarding should be enabled. This was fine for routers with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5fc1f717_ce538816","line":9,"range":{"start_line":9,"start_character":30,"end_line":9,"end_character":36},"updated":"2019-03-14 14:17:23.000000000","message":"nit: standby","commit_id":"b119247bea89aec5604e7ac61675aed240195931"}],"neutron/agent/l3/ha.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f941d89c999203b65cf762dc7a47353c5b551177","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self.state_change_notifier.queue_event((router_id, state))"},{"line_number":134,"context_line":"        self.l3_ext_manager.ha_state_change(self.context, state_change_data)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def _configure_ipv6_params(self, ri, state):"},{"line_number":137,"context_line":"        if ri.router.get(\u0027distributed\u0027, False):"},{"line_number":138,"context_line":"            namespace \u003d ri.ha_namespace"},{"line_number":139,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_8b77493c","line":136,"updated":"2019-03-04 16:57:16.000000000","message":"_configure_ipv6_params_on_gw() has a self.use_ipv6 check, this would need similar.","commit_id":"9b80933e3b1874796cbcaf1d7a02a34b5ef95dee"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f941d89c999203b65cf762dc7a47353c5b551177","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        else:"},{"line_number":140,"context_line":"            namespace \u003d ri.ns_name"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        self._configure_ipv6_params_on_ext_gw_port_if_necessary(ri, state)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        ipv6_forwarding_enable \u003d state \u003d\u003d \u0027master\u0027"},{"line_number":145,"context_line":"        ri.driver.configure_ipv6_forwarding("}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_8b8e6930","line":142,"updated":"2019-03-04 16:57:16.000000000","message":"This is the only caller of _configure_ipv6_params_on_ext_gw_port_if_necessary(), so maybe we can just pass along the namespace and \"enable\" flag ?  Or just have it set it in the \u0027all\u0027 case?","commit_id":"9b80933e3b1874796cbcaf1d7a02a34b5ef95dee"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"55f5d31f610f940e28a06c90d5620e932271442a","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        else:"},{"line_number":140,"context_line":"            namespace \u003d ri.ns_name"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        self._configure_ipv6_params_on_ext_gw_port_if_necessary(ri, state)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        ipv6_forwarding_enable \u003d state \u003d\u003d \u0027master\u0027"},{"line_number":145,"context_line":"        ri.driver.configure_ipv6_forwarding("}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_602f9c88","line":142,"in_reply_to":"9fdfeff1_8b8e6930","updated":"2019-03-04 21:58:59.000000000","message":"I changed it a bit. I don\u0027t want to move everything into one method as IMHO it is more readable like it is now.","commit_id":"9b80933e3b1874796cbcaf1d7a02a34b5ef95dee"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f941d89c999203b65cf762dc7a47353c5b551177","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        ipv6_forwarding_enable \u003d state \u003d\u003d \u0027master\u0027"},{"line_number":145,"context_line":"        ri.driver.configure_ipv6_forwarding("},{"line_number":146,"context_line":"            namespace, \u0027all\u0027, ipv6_forwarding_enable)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _configure_ipv6_params_on_ext_gw_port_if_necessary(self, ri, state):"},{"line_number":149,"context_line":"        # If ipv6 is enabled on the platform, ipv6_gateway config flag is"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_ebb4d5d6","line":146,"updated":"2019-03-04 16:57:16.000000000","message":"Like _configure_ipv6_params_on_gw() - does this need a check to only call on \u0027enable\u0027 ?  Because if we flip if off we\u0027ll send an MLDv2 packet.","commit_id":"9b80933e3b1874796cbcaf1d7a02a34b5ef95dee"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"55f5d31f610f940e28a06c90d5620e932271442a","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        ipv6_forwarding_enable \u003d state \u003d\u003d \u0027master\u0027"},{"line_number":145,"context_line":"        ri.driver.configure_ipv6_forwarding("},{"line_number":146,"context_line":"            namespace, \u0027all\u0027, ipv6_forwarding_enable)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _configure_ipv6_params_on_ext_gw_port_if_necessary(self, ri, state):"},{"line_number":149,"context_line":"        # If ipv6 is enabled on the platform, ipv6_gateway config flag is"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_254e8696","line":146,"in_reply_to":"9fdfeff1_ebb4d5d6","updated":"2019-03-04 21:58:59.000000000","message":"if I will only check for enabled, then there are 2 things:\n1. It will in fact be IMHO not necessary as after first failover it will be enabled everywhere so it will be the same as it was before patch https://github.com/openstack/neutron/commit/3e9e2a5b4b2654864bb0e2a7d9b841eb03240147\n2. I tried that in first PS here, and it cause failure of functional tests like https://github.com/openstack/neutron/blob/master/neutron/tests/functional/agent/l3/test_ha_router.py#L142","commit_id":"9b80933e3b1874796cbcaf1d7a02a34b5ef95dee"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c8ab1c18730f3703a2598c520a76166aa23f3771","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            namespace \u003d ri.ns_name"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        self._configure_ipv6_params_on_ext_gw_port_if_necessary("},{"line_number":147,"context_line":"            ri, ipv6_forwarding_enable)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        ri.driver.configure_ipv6_forwarding("},{"line_number":150,"context_line":"            namespace, \u0027all\u0027, ipv6_forwarding_enable)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_b61deebe","line":147,"updated":"2019-03-05 19:57:35.000000000","message":"Can you pass namespace as well?","commit_id":"1e14e87db8eb2e468d6edc291a9fa3242f03c973"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"68cf9e87ff967b6efa974b90cf673403611db2ba","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            namespace \u003d ri.ns_name"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        self._configure_ipv6_params_on_ext_gw_port_if_necessary("},{"line_number":147,"context_line":"            ri, ipv6_forwarding_enable)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        ri.driver.configure_ipv6_forwarding("},{"line_number":150,"context_line":"            namespace, \u0027all\u0027, ipv6_forwarding_enable)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_3f51a6d9","line":147,"in_reply_to":"5fc1f717_b61deebe","updated":"2019-03-07 11:47:38.000000000","message":"ok, after second look into that, I finally think that You were right and I merged those 2 methods into one :)","commit_id":"1e14e87db8eb2e468d6edc291a9fa3242f03c973"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3ed7ba24bc43073be43531a5fee9fcc0796c639d","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            namespace \u003d ri.ns_name"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        ri.driver.configure_ipv6_forwarding("},{"line_number":147,"context_line":"            namespace, \u0027all\u0027, ipv6_forwarding_enable)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # If ipv6 is enabled on the platform, ipv6_gateway config flag is"},{"line_number":150,"context_line":"        # not set and external_network associated to the router does not"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_0ed11555","line":147,"updated":"2019-03-07 15:26:00.000000000","message":"So I can\u0027t remember if this was supposed to be under an \"if ipv6_forwarding_enable\" check?  Otherwise the transition will cause an MLDv2.  Maybe there was just a functional test update required?","commit_id":"5d50d8e6bc30c33d60035b748d7ee53db5415f70"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4b73314cd79c49bf071b3000ccfc66868a62f4e6","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            namespace \u003d ri.ns_name"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        ri.driver.configure_ipv6_forwarding("},{"line_number":147,"context_line":"            namespace, \u0027all\u0027, ipv6_forwarding_enable)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # If ipv6 is enabled on the platform, ipv6_gateway config flag is"},{"line_number":150,"context_line":"        # not set and external_network associated to the router does not"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_92db9a7a","line":147,"updated":"2019-03-12 14:02:08.000000000","message":"This call is also done in _configure_ipv6_params_on_gw() if it\u0027s called, but it is under a \"if enabled\" check.  For that reason I think we should also do it here to be consistent.\n\nIf the functional test is failing, _test_ipv6_router_advts_and_fwd_helper() - I think that should also be changed to have an \"if expected_forwarding\" check as well since it\u0027s indeterminate if it started life in the \u0027backup\u0027 state.","commit_id":"44e40a0a3bccd7d7b51d0548f07546734764cd42"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f99dc25b8b280e31d90d4c1c7a4afb9967f297aa","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            namespace \u003d ri.ns_name"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        ri.driver.configure_ipv6_forwarding("},{"line_number":147,"context_line":"            namespace, \u0027all\u0027, ipv6_forwarding_enable)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # If ipv6 is enabled on the platform, ipv6_gateway config flag is"},{"line_number":150,"context_line":"        # not set and external_network associated to the router does not"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_39087490","line":147,"in_reply_to":"5fc1f717_92db9a7a","updated":"2019-03-13 13:08:04.000000000","message":"Done","commit_id":"44e40a0a3bccd7d7b51d0548f07546734764cd42"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"bbe05aa280209ece03425d19e9bf716de1c859bb","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            namespace \u003d ri.ns_name"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        ri.driver.configure_ipv6_forwarding("},{"line_number":147,"context_line":"            namespace, \u0027all\u0027, ipv6_forwarding_enable)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # If ipv6 is enabled on the platform, ipv6_gateway config flag is"},{"line_number":150,"context_line":"        # not set and external_network associated to the router does not"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_043d0cc3","line":147,"in_reply_to":"5fc1f717_92db9a7a","updated":"2019-03-13 14:23:59.000000000","message":"The \"if enabled\" check is a good idea not only for consistency\u0027s sake, but also because of this comment https://github.com/openstack/neutron/blob/7b64623f96b7f730aff82e1f87bacbfef1afac7c/neutron/agent/l3/ha_router.py#L52-L54.","commit_id":"44e40a0a3bccd7d7b51d0548f07546734764cd42"}],"neutron/tests/functional/agent/l3/framework.py.orig":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"5434ce14b00eb2c0e04ecec1fbad03705c7e9af3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"5fc1f717_ac55cdfb","line":1,"updated":"2019-03-15 14:19:43.000000000","message":"I suppose the merge conflict was on framework.py :)","commit_id":"3959f18d73358cacb916d9e1b1cb1d324eb6b4e6"}],"neutron/tests/functional/agent/l3/test_ha_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3ed7ba24bc43073be43531a5fee9fcc0796c639d","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        self._assert_ipv6_accept_ra(new_slave, False)"},{"line_number":425,"context_line":"        # after transition from master -\u003e slave, \u0027all\u0027 IPv6 forwarding should"},{"line_number":426,"context_line":"        # be disabled"},{"line_number":427,"context_line":"        self._assert_ipv6_forwarding(new_slave, False, False)"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def test_ha_router_lost_gw_connection(self):"},{"line_number":430,"context_line":"        self.agent.conf.set_override("}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_ee40490a","line":427,"updated":"2019-03-07 15:26:00.000000000","message":"I guess this answers my other question.  So we don\u0027t have an MLDv2 being sent and causing issues?","commit_id":"5d50d8e6bc30c33d60035b748d7ee53db5415f70"}]}
