)]}'
{"neutron/tests/functional/agent/common/test_ovs_lib.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"dd701ae613e8238cd9b285ffd908faa73bec0546","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                return True"},{"line_number":136,"context_line":"            return ret[0] \u003d\u003d expected_value"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        ret \u003d [None]"},{"line_number":139,"context_line":"        keys_to_check \u003d kwargs.pop(\u0027keys_to_check\u0027, None)"},{"line_number":140,"context_line":"        part_check_value \u003d functools.partial(check_value, ret, keys_to_check)"},{"line_number":141,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_6e1c596a","line":138,"updated":"2019-03-07 15:18:30.000000000","message":"why do we need to use a list \"[None]\" for \"ret\"?\n\"check_value\" function above just refers to ret[0], so I wonder why we need to pass [None].\n\nIf we really need this, some comment would be appreciated.","commit_id":"5a41c5d321a2b625114a8e7f4bd331e0aa5193e3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"407666919605972a81ef591f26e966cb04962850","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                return True"},{"line_number":136,"context_line":"            return ret[0] \u003d\u003d expected_value"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        ret \u003d [None]"},{"line_number":139,"context_line":"        keys_to_check \u003d kwargs.pop(\u0027keys_to_check\u0027, None)"},{"line_number":140,"context_line":"        part_check_value \u003d functools.partial(check_value, ret, keys_to_check)"},{"line_number":141,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_8ee3c533","line":138,"in_reply_to":"5fc1f717_6e1c596a","updated":"2019-03-07 15:24:51.000000000","message":"It looks like to refer the return value of retrieve_fn (inside check_value) from the outside of the check_value function (i.e., at L.145).\n\nAnyway some comment would be helpful (as a follow-up patch).","commit_id":"5a41c5d321a2b625114a8e7f4bd331e0aa5193e3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ab4342a1e18781e94dda174b595cd744a6635fc5","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                return True"},{"line_number":136,"context_line":"            return ret[0] \u003d\u003d expected_value"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        ret \u003d [None]"},{"line_number":139,"context_line":"        keys_to_check \u003d kwargs.pop(\u0027keys_to_check\u0027, None)"},{"line_number":140,"context_line":"        part_check_value \u003d functools.partial(check_value, ret, keys_to_check)"},{"line_number":141,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_99b55134","line":138,"in_reply_to":"5fc1f717_8ee3c533","updated":"2019-03-07 16:01:19.000000000","message":"This line is just to initialize ret as a list with one element, to be used then in the inner function \"check_value\". Maybe is not the most elegant way.\n\nPlease, if you know a more elegant way, you are welcome.","commit_id":"5a41c5d321a2b625114a8e7f4bd331e0aa5193e3"}]}