)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2e5153c51689d1048fc7930afec5e132017e5da5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     songbaisen \u003csongbaisen@szzt.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-03-06 10:35:16 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"the PeriodicWorker function misssing the desc"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After this pr merged.https://review.openstack.org/#/c/637019/"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_aff26899","line":7,"updated":"2019-03-06 03:44:06.000000000","message":"s/PeriodicWorker class init missing desc argument","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2e5153c51689d1048fc7930afec5e132017e5da5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"the PeriodicWorker function misssing the desc"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After this pr merged.https://review.openstack.org/#/c/637019/"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"we should add the default desc in PeriodicWorker. Otherwise"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_cf725412","line":9,"range":{"start_line":9,"start_character":14,"end_line":9,"end_character":21},"updated":"2019-03-06 03:44:06.000000000","message":"s/merged, https","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2e5153c51689d1048fc7930afec5e132017e5da5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After this pr merged.https://review.openstack.org/#/c/637019/"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"we should add the default desc in PeriodicWorker. Otherwise"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"some class base on the PeriodicWorker which do not set the"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_0f3b7c38","line":11,"range":{"start_line":11,"start_character":48,"end_line":11,"end_character":49},"updated":"2019-03-06 03:44:06.000000000","message":"s/ class.","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2e5153c51689d1048fc7930afec5e132017e5da5","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"we should add the default desc in PeriodicWorker. Otherwise"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"some class base on the PeriodicWorker which do not set the"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"setproctitle off in neutorn conf will get the core dump error."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_cf4494ba","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":15},"updated":"2019-03-06 03:44:06.000000000","message":"s/a class based","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2e5153c51689d1048fc7930afec5e132017e5da5","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"we should add the default desc in PeriodicWorker. Otherwise"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"some class base on the PeriodicWorker which do not set the"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"setproctitle off in neutorn conf will get the core dump error."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_6f1320ba","line":13,"range":{"start_line":13,"start_character":44,"end_line":13,"end_character":50},"updated":"2019-03-06 03:44:06.000000000","message":"s/does not","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2e5153c51689d1048fc7930afec5e132017e5da5","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"some class base on the PeriodicWorker which do not set the"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"setproctitle off in neutorn conf will get the core dump error."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"like below, where set_proctitle is None and do not have the"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_8f18ccd3","line":15,"range":{"start_line":15,"start_character":12,"end_line":15,"end_character":16},"updated":"2019-03-06 03:44:06.000000000","message":"s/\u003doff","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2e5153c51689d1048fc7930afec5e132017e5da5","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"some class base on the PeriodicWorker which do not set the"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"setproctitle off in neutorn conf will get the core dump error."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"like below, where set_proctitle is None and do not have the"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_4f12e4b3","line":15,"range":{"start_line":15,"start_character":42,"end_line":15,"end_character":61},"updated":"2019-03-06 03:44:06.000000000","message":"s/an exception","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2e5153c51689d1048fc7930afec5e132017e5da5","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"some class base on the PeriodicWorker which do not set the"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"setproctitle off in neutorn conf will get the core dump error."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"like below, where set_proctitle is None and do not have the"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_2f0d1890","line":15,"range":{"start_line":15,"start_character":20,"end_line":15,"end_character":32},"updated":"2019-03-06 03:44:06.000000000","message":"s/neutron.conf","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2e5153c51689d1048fc7930afec5e132017e5da5","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"setproctitle off in neutorn conf will get the core dump error."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"like below, where set_proctitle is None and do not have the"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"setproctitle config"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_0f24dc0c","line":17,"range":{"start_line":17,"start_character":44,"end_line":17,"end_character":59},"updated":"2019-03-06 03:44:06.000000000","message":"s/there is no","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2e5153c51689d1048fc7930afec5e132017e5da5","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"like below, where set_proctitle is None and do not have the"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"setproctitle config"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"packages/neutron/worker.py\", line 21, in __init__"},{"line_number":22,"context_line":"    set_proctitle \u003d set_proctitle or cfg.CONF.setproctitle"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_ef6b901c","line":19,"updated":"2019-03-06 03:44:06.000000000","message":"Also, the above paragraph should be single-spaced","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2e5153c51689d1048fc7930afec5e132017e5da5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"setproctitle config"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"packages/neutron/worker.py\", line 21, in __init__"},{"line_number":22,"context_line":"    set_proctitle \u003d set_proctitle or cfg.CONF.setproctitle"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug:https://bugs.launchpad.net/neutron/+bug/1818765"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_8f7d2ce9","line":22,"updated":"2019-03-06 03:44:06.000000000","message":"I don\u0027t think putting this code here make the message more clear","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2e5153c51689d1048fc7930afec5e132017e5da5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"packages/neutron/worker.py\", line 21, in __init__"},{"line_number":22,"context_line":"    set_proctitle \u003d set_proctitle or cfg.CONF.setproctitle"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug:https://bugs.launchpad.net/neutron/+bug/1818765"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Ib3e0273308b1c7824a1bd78a51b826e429d38fa4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_0ff61c91","line":24,"updated":"2019-03-06 03:44:06.000000000","message":"Can be:\n\nCloses-bug: #1818765","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"}],"neutron/worker.py":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"651cafc05f96a9dcf3a1d57e664ff60264559fe6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class PeriodicWorker(NeutronBaseWorker):"},{"line_number":32,"context_line":"    \"\"\"A worker that runs a function at a fixed interval.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, check_func, interval, initial_delay, desc\u003d\"periodic worker\"):"},{"line_number":35,"context_line":"        super(PeriodicWorker, self).__init__(worker_process_count\u003d0, desc\u003d\"periodic worker\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self._check_func \u003d check_func"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_ac06f61f","line":34,"range":{"start_line":34,"start_character":60,"end_line":34,"end_character":82},"updated":"2019-03-06 02:52:28.000000000","message":"Don\u0027t need this arg here, do we? Who\u0027s using it?","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"aeb83f72824b41ed2696eaac1d8945e848fe4eb6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class PeriodicWorker(NeutronBaseWorker):"},{"line_number":32,"context_line":"    \"\"\"A worker that runs a function at a fixed interval.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, check_func, interval, initial_delay, desc\u003d\"periodic worker\"):"},{"line_number":35,"context_line":"        super(PeriodicWorker, self).__init__(worker_process_count\u003d0, desc\u003d\"periodic worker\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self._check_func \u003d check_func"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_8f676c26","line":34,"range":{"start_line":34,"start_character":60,"end_line":34,"end_character":82},"in_reply_to":"5fc1f717_4f60a433","updated":"2019-03-06 03:50:21.000000000","message":"Right, I\u0027m also confused.  desc is defaulted at the bottom of neutron-lib, so it\u0027s non-fatal if it\u0027s None.\n\nAnd the trace shows an exception for a missing config element, not a missing argument.\n\nIt almost looks like you have a newer service.py/worker.py and an older neutron/conf/* directory. Is there any chance you can try doing a \"tox -r\" in your sfc repo, and let it rebuild the neutron and neutron-lib from latest?","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2e5153c51689d1048fc7930afec5e132017e5da5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class PeriodicWorker(NeutronBaseWorker):"},{"line_number":32,"context_line":"    \"\"\"A worker that runs a function at a fixed interval.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, check_func, interval, initial_delay, desc\u003d\"periodic worker\"):"},{"line_number":35,"context_line":"        super(PeriodicWorker, self).__init__(worker_process_count\u003d0, desc\u003d\"periodic worker\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self._check_func \u003d check_func"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_4f60a433","line":34,"range":{"start_line":34,"start_character":60,"end_line":34,"end_character":82},"in_reply_to":"5fc1f717_8f51ac11","updated":"2019-03-06 03:44:06.000000000","message":"This trace doesn\u0027t show why it\u0027s needed here either, but I guess if the caller wanted to set the desc to something else it needs to be here?","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":27215,"name":"baisen","email":"songbaisen@szzt.com.cn","username":"songbaisen"},"change_message_id":"4bc53b71cc4d1db4d5293fe3d90a65b5b8bb0be3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class PeriodicWorker(NeutronBaseWorker):"},{"line_number":32,"context_line":"    \"\"\"A worker that runs a function at a fixed interval.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, check_func, interval, initial_delay, desc\u003d\"periodic worker\"):"},{"line_number":35,"context_line":"        super(PeriodicWorker, self).__init__(worker_process_count\u003d0, desc\u003d\"periodic worker\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self._check_func \u003d check_func"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_e0e2bf2f","line":34,"range":{"start_line":34,"start_character":60,"end_line":34,"end_character":82},"in_reply_to":"5fc1f717_ac06f61f","updated":"2019-03-06 06:34:52.000000000","message":"Done","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":27215,"name":"baisen","email":"songbaisen@szzt.com.cn","username":"songbaisen"},"change_message_id":"ba1048d1d23dcaceb302a2790358e2a64be013de","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class PeriodicWorker(NeutronBaseWorker):"},{"line_number":32,"context_line":"    \"\"\"A worker that runs a function at a fixed interval.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, check_func, interval, initial_delay, desc\u003d\"periodic worker\"):"},{"line_number":35,"context_line":"        super(PeriodicWorker, self).__init__(worker_process_count\u003d0, desc\u003d\"periodic worker\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self._check_func \u003d check_func"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_8f51ac11","line":34,"range":{"start_line":34,"start_character":60,"end_line":34,"end_character":82},"in_reply_to":"5fc1f717_ac06f61f","updated":"2019-03-06 03:01:16.000000000","message":"see this.\n   n \u003d super(TricirclePlugin, cls).__new__(cls, *args, **kwargs)\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron_lib/callbacks/registry.py\", line 106, in replacement_new\n    instance \u003d orig_new(cls, *args, **kwargs)\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/db/db_base_plugin_v2.py\", line 156, in __new__\n    return super(NeutronDbPluginV2, cls).__new__(cls, *args, **kwargs)\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron_lib/db/resource_extend.py\", line 126, in replacement_new\n    instance \u003d orig_new(cls, *args, **kwargs)\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron_lib/callbacks/registry.py\", line 104, in replacement_new\n    instance \u003d super_new(cls, *args, **kwargs)\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron_lib/db/resource_extend.py\", line 126, in replacement_new\n    instance \u003d orig_new(cls, *args, **kwargs)\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron_lib/callbacks/registry.py\", line 106, in replacement_new\n    instance \u003d orig_new(cls, *args, **kwargs)\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/db/external_net_db.py\", line 77, in __new__\n    return super(External_net_db_mixin, cls).__new__(cls, *args, **kwargs)\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron_lib/db/resource_extend.py\", line 126, in replacement_new\n    instance \u003d orig_new(cls, *args, **kwargs)\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/db/portbindings_db.py\", line 54, in __new__\n    return super(PortBindingMixin, cls).__new__(cls, *args, **kwargs)\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron_lib/db/resource_extend.py\", line 124, in replacement_new\n    instance \u003d super_new(cls, *args, **kwargs)\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron_lib/db/resource_extend.py\", line 124, in replacement_new\n    instance \u003d super_new(cls, *args, **kwargs)\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron_lib/callbacks/registry.py\", line 106, in replacement_new\n    instance \u003d orig_new(cls, *args, **kwargs)\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/db/l3_db.py\", line 96, in __new__\n    inst._start_janitor()\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/db/l3_db.py\", line 139, in _start_janitor\n    initial_delay)\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/worker.py\", line 35, in __init__\n    super(PeriodicWorker, self).__init__(worker_process_count\u003d0)\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/worker.py\", line 21, in __init__\n    set_proctitle \u003d set_proctitle or cfg.CONF.setproctitle\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/oslo_config/cfg.py\", line 2187, in __getattr__\n    raise NoSuchOptError(name)\noslo_config.cfg.NoSuchOptError: no such option setproctitle in group [DEFAULT]","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"651cafc05f96a9dcf3a1d57e664ff60264559fe6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\"A worker that runs a function at a fixed interval.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, check_func, interval, initial_delay, desc\u003d\"periodic worker\"):"},{"line_number":35,"context_line":"        super(PeriodicWorker, self).__init__(worker_process_count\u003d0, desc\u003d\"periodic worker\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self._check_func \u003d check_func"},{"line_number":38,"context_line":"        self._loop \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_8c1e9a6e","line":35,"range":{"start_line":35,"start_character":75,"end_line":35,"end_character":90},"updated":"2019-03-06 02:52:28.000000000","message":"This is good, but the desc should\u0027ve been set to PeriodicWorker, right?","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":27215,"name":"baisen","email":"songbaisen@szzt.com.cn","username":"songbaisen"},"change_message_id":"4bc53b71cc4d1db4d5293fe3d90a65b5b8bb0be3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\"A worker that runs a function at a fixed interval.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, check_func, interval, initial_delay, desc\u003d\"periodic worker\"):"},{"line_number":35,"context_line":"        super(PeriodicWorker, self).__init__(worker_process_count\u003d0, desc\u003d\"periodic worker\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self._check_func \u003d check_func"},{"line_number":38,"context_line":"        self._loop \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_40cb93a4","line":35,"range":{"start_line":35,"start_character":75,"end_line":35,"end_character":90},"in_reply_to":"5fc1f717_6fbd6067","updated":"2019-03-06 06:34:52.000000000","message":"Done","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2e5153c51689d1048fc7930afec5e132017e5da5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\"A worker that runs a function at a fixed interval.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, check_func, interval, initial_delay, desc\u003d\"periodic worker\"):"},{"line_number":35,"context_line":"        super(PeriodicWorker, self).__init__(worker_process_count\u003d0, desc\u003d\"periodic worker\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self._check_func \u003d check_func"},{"line_number":38,"context_line":"        self._loop \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_8fcbec1c","line":35,"range":{"start_line":35,"start_character":75,"end_line":35,"end_character":90},"in_reply_to":"5fc1f717_8c1e9a6e","updated":"2019-03-06 03:44:06.000000000","message":"If the above change is done, this should be desc\u003ddesc anyways.\n\nDoug - doesn\u0027t the \"periodic worker\" match the other descriptions you used?  Or is this different?\n\nI think this line is too long and will generate a pep8 error as well.","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"aeb83f72824b41ed2696eaac1d8945e848fe4eb6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\"A worker that runs a function at a fixed interval.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, check_func, interval, initial_delay, desc\u003d\"periodic worker\"):"},{"line_number":35,"context_line":"        super(PeriodicWorker, self).__init__(worker_process_count\u003d0, desc\u003d\"periodic worker\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self._check_func \u003d check_func"},{"line_number":38,"context_line":"        self._loop \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_6fbd6067","line":35,"range":{"start_line":35,"start_character":75,"end_line":35,"end_character":90},"in_reply_to":"5fc1f717_8fcbec1c","updated":"2019-03-06 03:50:21.000000000","message":"Yes, \"periodic worker\" is consistent, and I like that part of this change.","commit_id":"a1a76af319136fe1b702ab4d1e943e2c9de61e5e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3e2cf62801b2b9ddc29624058c40023eb056dc55","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\"A worker that runs a function at a fixed interval.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, check_func, interval, initial_delay):"},{"line_number":35,"context_line":"        super(PeriodicWorker, self).__init__(worker_process_count\u003d0, desc\u003d\"PeriodicWorker\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self._check_func \u003d check_func"},{"line_number":38,"context_line":"        self._loop \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_fb69118b","line":35,"range":{"start_line":35,"start_character":69,"end_line":35,"end_character":90},"updated":"2019-03-06 08:07:44.000000000","message":"This will not work as NeutronBaseWorker.__init__ has no arg desc (see: l.20.)\nAnd the line is still too long :-)","commit_id":"b6c3c340f045a6c5f5d533678ff518dcfbbaaddd"},{"author":{"_account_id":27215,"name":"baisen","email":"songbaisen@szzt.com.cn","username":"songbaisen"},"change_message_id":"8459350795cb118764bad476c477b1a56d6346f9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\"A worker that runs a function at a fixed interval.\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, check_func, interval, initial_delay):"},{"line_number":35,"context_line":"        super(PeriodicWorker, self).__init__(worker_process_count\u003d0, desc\u003d\"PeriodicWorker\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self._check_func \u003d check_func"},{"line_number":38,"context_line":"        self._loop \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_fb55911e","line":35,"range":{"start_line":35,"start_character":69,"end_line":35,"end_character":90},"in_reply_to":"5fc1f717_fb69118b","updated":"2019-03-06 08:32:14.000000000","message":"Done.\nWe need this default desc. it is because some class based on the PeriodWorker will exception.in here :\nset_proctitle \u003d set_proctitle or cfg.CONF.setproctitle\nif set_proctitle  is None also we do not config the \nsetproctitle in neutron.conf.","commit_id":"b6c3c340f045a6c5f5d533678ff518dcfbbaaddd"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"b4745f0106c05933d30bb27b897b9bac9ab20293","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def __init__(self, check_func, interval, initial_delay):"},{"line_number":35,"context_line":"        super(PeriodicWorker, self).__init__("},{"line_number":36,"context_line":"            worker_process_count\u003d0,"},{"line_number":37,"context_line":"            set_proctitle\u003d\"PeriodicWorker\""},{"line_number":38,"context_line":"        )"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self._check_func \u003d check_func"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_bad051cb","line":37,"range":{"start_line":37,"start_character":27,"end_line":37,"end_character":41},"updated":"2019-03-06 21:52:23.000000000","message":"Umm, that\u0027s not a valid value for that arg.\n\nI still am not understanding how adding a description will fix a missing config entry?","commit_id":"ea75272cb76dbda1d3986f337338339ea415202d"},{"author":{"_account_id":27215,"name":"baisen","email":"songbaisen@szzt.com.cn","username":"songbaisen"},"change_message_id":"4f56ab842134cb1c28c55de57a6290c98c3cdcfc","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def __init__(self, check_func, interval, initial_delay):"},{"line_number":35,"context_line":"        super(PeriodicWorker, self).__init__("},{"line_number":36,"context_line":"            worker_process_count\u003d0,"},{"line_number":37,"context_line":"            set_proctitle\u003d\"PeriodicWorker\""},{"line_number":38,"context_line":"        )"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self._check_func \u003d check_func"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_a6cd985e","line":37,"range":{"start_line":37,"start_character":27,"end_line":37,"end_character":41},"in_reply_to":"5fc1f717_bad051cb","updated":"2019-03-07 01:51:06.000000000","message":"\u003e Umm, that\u0027s not a valid value for that arg.\n \u003e \n \u003e I still am not understanding how adding a description will fix a\n \u003e missing config entry?\n\nWe need this default desc. it is because some class based on the PeriodWorker will exception.in here : set_proctitle \u003d set_proctitle or cfg.CONF.setproctitle if set_proctitle is None also we do not config the setproctitle in neutron.conf. like below:\n\n File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/worker.py\", line 35, in __init__\n    super(PeriodicWorker, self).__init__(worker_process_count\u003d0)\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/worker.py\", line 21, in __init__\n    set_proctitle \u003d set_proctitle or cfg.CONF.setproctitle\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/oslo_config/cfg.py\", line 2187, in __getattr__\n    raise NoSuchOptError(name)\noslo_config.cfg.NoSuchOptError: no such option setproctitle in group [DEFAULT]","commit_id":"ea75272cb76dbda1d3986f337338339ea415202d"},{"author":{"_account_id":27215,"name":"baisen","email":"songbaisen@szzt.com.cn","username":"songbaisen"},"change_message_id":"9ad1dc19005167c91874148d475919107fef1840","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def __init__(self, check_func, interval, initial_delay):"},{"line_number":35,"context_line":"        super(PeriodicWorker, self).__init__("},{"line_number":36,"context_line":"            worker_process_count\u003d0,"},{"line_number":37,"context_line":"            set_proctitle\u003d\"PeriodicWorker\""},{"line_number":38,"context_line":"        )"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self._check_func \u003d check_func"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_fa93344e","line":37,"range":{"start_line":37,"start_character":27,"end_line":37,"end_character":41},"in_reply_to":"5fc1f717_bad051cb","updated":"2019-03-07 03:08:40.000000000","message":"\u003e Umm, that\u0027s not a valid value for that arg.\n \u003e \n \u003e I still am not understanding how adding a description will fix a\n \u003e missing config entry?\n https://github.com/openstack/neutron/blob/9a15084375a80df830cf50c1fb20908b5d7f822c/neutron/db/l3_db.py#L138\nit exceptin from here.\nFile \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/db/l3_db.py\", line 96, in __new__\n    inst._start_janitor()\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/db/l3_db.py\", line 139, in _start_janitor\n    initial_delay)\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/worker.py\", line 35, in __init__\n    super(PeriodicWorker, self).__init__(worker_process_count\u003d0)\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/neutron/worker.py\", line 21, in __init__\n    set_proctitle \u003d set_proctitle or cfg.CONF.setproctitle\n  File \"/home/zuul/src/git.openstack.org/openstack/tricircle/.tox/py27/local/lib/python2.7/site-packages/oslo_config/cfg.py\", line 2187, in __getattr__\n    raise NoSuchOptError(name)\noslo_config.cfg.NoSuchOptError: no such option setproctitle in group [DEFAULT]","commit_id":"ea75272cb76dbda1d3986f337338339ea415202d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8659f30ef488ed8193606d3a6f2117c41d0cd000","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def __init__(self, check_func, interval, initial_delay):"},{"line_number":35,"context_line":"        super(PeriodicWorker, self).__init__("},{"line_number":36,"context_line":"            worker_process_count\u003d0,"},{"line_number":37,"context_line":"            set_proctitle\u003d\"PeriodicWorker\""},{"line_number":38,"context_line":"        )"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self._check_func \u003d check_func"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_c4453719","line":37,"range":{"start_line":37,"start_character":27,"end_line":37,"end_character":41},"in_reply_to":"5fc1f717_fa93344e","updated":"2019-03-07 10:05:24.000000000","message":"set_proctitle can solve this, if I understand well","commit_id":"ea75272cb76dbda1d3986f337338339ea415202d"}]}