)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"change_message_id":"6862cef42ef860fbb6b381ba72fa473a4763234b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"For the ability to load same driver with different configurations"},{"line_number":10,"context_line":"as different service providers, a service provider name is passed"},{"line_number":11,"context_line":"to a driver when instantiated. Now, a driver can load it\u0027s configuration"},{"line_number":12,"context_line":"accordingly to the provider name raceived."},{"line_number":13,"context_line":"Driver path must not be unique anymore. Service type and provider name"},{"line_number":14,"context_line":"still should be a unique combination."},{"line_number":15,"context_line":"Driver configuration name in configuration file is not hardcoded"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAAUH%2F%2BsbU%3D","line":12,"updated":"2014-01-23 08:44:38.000000000","message":"nit: according to. and raceived?","commit_id":"e62d03c63d22fa4b158ef32c763572c5e1623199"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"853721494e8d2411fd405eff5c6f135fa7a651c7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"For the ability to load same driver with different configurations"},{"line_number":10,"context_line":"as different service providers, a service provider name is passed"},{"line_number":11,"context_line":"to a driver when instantiated. Now, a driver can load it\u0027s configuration"},{"line_number":12,"context_line":"accordingly to the provider name raceived."},{"line_number":13,"context_line":"Driver path must not be unique anymore. Service type and provider name"},{"line_number":14,"context_line":"still should be a unique combination."},{"line_number":15,"context_line":"Driver configuration name in configuration file is not hardcoded"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAAUH%2F%2Bq8k%3D","line":12,"in_reply_to":"AAAAUH%2F%2BsbU%3D","updated":"2014-01-23 11:06:58.000000000","message":"Done","commit_id":"e62d03c63d22fa4b158ef32c763572c5e1623199"}],"etc/neutron.conf":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"85b30c5a9b191f508bad96ef25b073cb57f98900","unresolved":false,"context_lines":[{"line_number":364,"context_line":"# List of allowed service type include LOADBALANCER, FIREWALL, VPN"},{"line_number":365,"context_line":"# Combination of \u003cservice type\u003e and \u003cname\u003e must be unique."},{"line_number":366,"context_line":"# Only one provider may be configured as default."},{"line_number":367,"context_line":"# Multiple providers may be configured to use the same driver. In this case the provider name must be unique. Such configuration allows using same driver with different configuration."},{"line_number":368,"context_line":"# This is multiline option, example for default provider:"},{"line_number":369,"context_line":"# service_provider\u003dLOADBALANCER:name:lbaas_plugin_driver_path:default"},{"line_number":370,"context_line":"# example of non-default provider:"}],"source_content_type":"text/plain","patch_set":4,"id":"AAAAT3%2F%2F3V4%3D","line":367,"updated":"2013-12-29 20:12:43.000000000","message":"nit: I think it\u0027s better to shorten the line (split in two)","commit_id":"8185b3df0ddef56d404a57558983f04e1670f483"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"8ea0369bf27240f11d9666ee71d140de2de1c028","unresolved":false,"context_lines":[{"line_number":364,"context_line":"# List of allowed service type include LOADBALANCER, FIREWALL, VPN"},{"line_number":365,"context_line":"# Combination of \u003cservice type\u003e and \u003cname\u003e must be unique."},{"line_number":366,"context_line":"# Only one provider may be configured as default."},{"line_number":367,"context_line":"# Multiple providers may be configured to use the same driver. In this case the provider name must be unique. Such configuration allows using same driver with different configuration."},{"line_number":368,"context_line":"# This is multiline option, example for default provider:"},{"line_number":369,"context_line":"# service_provider\u003dLOADBALANCER:name:lbaas_plugin_driver_path:default"},{"line_number":370,"context_line":"# example of non-default provider:"}],"source_content_type":"text/plain","patch_set":4,"id":"AAAAT3%2F%2F2Rk%3D","line":367,"in_reply_to":"AAAAT3%2F%2F3V4%3D","updated":"2013-12-30 09:49:19.000000000","message":"Done","commit_id":"8185b3df0ddef56d404a57558983f04e1670f483"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0c8ed50c1cf7132cb2aad914a1f99f7b90f89928","unresolved":false,"context_lines":[{"line_number":365,"context_line":"# Combination of \u003cservice type\u003e and \u003cname\u003e must be unique."},{"line_number":366,"context_line":"# Only one provider may be configured as default."},{"line_number":367,"context_line":"# Multiple providers may be configured to use the same driver."},{"line_number":368,"context_line":"# In this case the provider name must be unique."},{"line_number":369,"context_line":"# Such configuration allows using same driver with different configuration."},{"line_number":370,"context_line":"# This is multiline option, example for default provider:"},{"line_number":371,"context_line":"# service_provider\u003dLOADBALANCER:name:lbaas_plugin_driver_path:default"}],"source_content_type":"text/plain","patch_set":6,"id":"AAAAUH%2F%2F9NA%3D","line":368,"updated":"2014-01-06 09:21:11.000000000","message":"provider name must be unique in any case (for the same service type)","commit_id":"235ec4ede6a908ef43a7e5515a9ab9626bd9f31f"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"9dcf3cb4a4f6fe6d6effd28e59e425625c6677be","unresolved":false,"context_lines":[{"line_number":365,"context_line":"# Combination of \u003cservice type\u003e and \u003cname\u003e must be unique."},{"line_number":366,"context_line":"# Only one provider may be configured as default."},{"line_number":367,"context_line":"# Multiple providers may be configured to use the same driver."},{"line_number":368,"context_line":"# In this case the provider name must be unique."},{"line_number":369,"context_line":"# Such configuration allows using same driver with different configuration."},{"line_number":370,"context_line":"# This is multiline option, example for default provider:"},{"line_number":371,"context_line":"# service_provider\u003dLOADBALANCER:name:lbaas_plugin_driver_path:default"}],"source_content_type":"text/plain","patch_set":6,"id":"AAAAUH%2F%2F8GI%3D","line":368,"in_reply_to":"AAAAUH%2F%2F9NA%3D","updated":"2014-01-06 17:34:33.000000000","message":"Done","commit_id":"235ec4ede6a908ef43a7e5515a9ab9626bd9f31f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e5a0ebb996b7ce252c308f54a0b3c23c2e9c41a3","unresolved":false,"context_lines":[{"line_number":365,"context_line":"# Combination of \u003cservice type\u003e and \u003cname\u003e must be unique."},{"line_number":366,"context_line":"# Only one provider may be configured as default."},{"line_number":367,"context_line":"# Multiple providers may be configured to use the same driver."},{"line_number":368,"context_line":"# Such configuration allows using same driver with different configuration."},{"line_number":369,"context_line":"# This is multiline option, example for default provider:"},{"line_number":370,"context_line":"# service_provider\u003dLOADBALANCER:name:lbaas_plugin_driver_path:default"},{"line_number":371,"context_line":"# example of non-default provider:"}],"source_content_type":"text/plain","patch_set":7,"id":"AAAAUH%2F%2Fszs%3D","line":368,"updated":"2014-01-09 13:33:04.000000000","message":"nit - last line needed? This sentence is hard to parse and i think covered by the previous one. Or add sthing about \u0027multiple providers same driver, but with unique name(s)\u0027","commit_id":"e62d03c63d22fa4b158ef32c763572c5e1623199"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"853721494e8d2411fd405eff5c6f135fa7a651c7","unresolved":false,"context_lines":[{"line_number":365,"context_line":"# Combination of \u003cservice type\u003e and \u003cname\u003e must be unique."},{"line_number":366,"context_line":"# Only one provider may be configured as default."},{"line_number":367,"context_line":"# Multiple providers may be configured to use the same driver."},{"line_number":368,"context_line":"# Such configuration allows using same driver with different configuration."},{"line_number":369,"context_line":"# This is multiline option, example for default provider:"},{"line_number":370,"context_line":"# service_provider\u003dLOADBALANCER:name:lbaas_plugin_driver_path:default"},{"line_number":371,"context_line":"# example of non-default provider:"}],"source_content_type":"text/plain","patch_set":7,"id":"AAAAUH%2F%2Bq8s%3D","line":368,"in_reply_to":"AAAAUH%2F%2Fszs%3D","updated":"2014-01-23 11:06:58.000000000","message":"Done","commit_id":"e62d03c63d22fa4b158ef32c763572c5e1623199"}],"etc/services.conf":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0c8ed50c1cf7132cb2aad914a1f99f7b90f89928","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#l4_workflow_name \u003d openstack_l4"},{"line_number":19,"context_line":"#l2_l3_ctor_params \u003d service: _REPLACE_, ha_network_name: HA-Network, ha_ip_pool_name: default, allocate_ha_vrrp: True, allocate_ha_ips: True"},{"line_number":20,"context_line":"#l2_l3_setup_params \u003d data_port: 1, data_ip_address: 192.168.200.99, data_ip_mask: 255.255.255.0, gateway: 192.168.200.1, ha_port: 2"},{"line_number":21,"context_line":"[radwareha]"},{"line_number":22,"context_line":"#vdirect_address \u003d 0.0.0.0"},{"line_number":23,"context_line":"#vdirect_user \u003d vDirect"},{"line_number":24,"context_line":"#vdirect_password \u003d radware"}],"source_content_type":"text/plain","patch_set":6,"id":"AAAAUH%2F%2F9CM%3D","line":21,"updated":"2014-01-06 09:21:11.000000000","message":"looks like currently there is no difference between radware and radwareha providers, is it intentionally? Shouldn\u0027t ha options be removed from radware provider config?","commit_id":"235ec4ede6a908ef43a7e5515a9ab9626bd9f31f"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"9dcf3cb4a4f6fe6d6effd28e59e425625c6677be","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#l4_workflow_name \u003d openstack_l4"},{"line_number":19,"context_line":"#l2_l3_ctor_params \u003d service: _REPLACE_, ha_network_name: HA-Network, ha_ip_pool_name: default, allocate_ha_vrrp: True, allocate_ha_ips: True"},{"line_number":20,"context_line":"#l2_l3_setup_params \u003d data_port: 1, data_ip_address: 192.168.200.99, data_ip_mask: 255.255.255.0, gateway: 192.168.200.1, ha_port: 2"},{"line_number":21,"context_line":"[radwareha]"},{"line_number":22,"context_line":"#vdirect_address \u003d 0.0.0.0"},{"line_number":23,"context_line":"#vdirect_user \u003d vDirect"},{"line_number":24,"context_line":"#vdirect_password \u003d radware"}],"source_content_type":"text/plain","patch_set":6,"id":"AAAAUH%2F%2F8FA%3D","line":21,"in_reply_to":"AAAAUH%2F%2F9CM%3D","updated":"2014-01-06 17:34:33.000000000","message":"It is different for service_ha_pair","commit_id":"235ec4ede6a908ef43a7e5515a9ab9626bd9f31f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e5a0ebb996b7ce252c308f54a0b3c23c2e9c41a3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#service_compression_throughput \u003d 100"},{"line_number":29,"context_line":"#service_cache \u003d 20"},{"line_number":30,"context_line":"#service_adc_type \u003d VA"},{"line_number":31,"context_line":"#service_adc_version\u003d"},{"line_number":32,"context_line":"#service_session_mirroring_enabled \u003d False"},{"line_number":33,"context_line":"#service_isl_vlan \u003d -1"},{"line_number":34,"context_line":"#service_resource_pool_ids \u003d []"}],"source_content_type":"text/plain","patch_set":7,"id":"AAAAUH%2F%2Fsxw%3D","line":31,"updated":"2014-01-09 13:33:04.000000000","message":"no default needed for version?","commit_id":"e62d03c63d22fa4b158ef32c763572c5e1623199"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"853721494e8d2411fd405eff5c6f135fa7a651c7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#service_compression_throughput \u003d 100"},{"line_number":29,"context_line":"#service_cache \u003d 20"},{"line_number":30,"context_line":"#service_adc_type \u003d VA"},{"line_number":31,"context_line":"#service_adc_version\u003d"},{"line_number":32,"context_line":"#service_session_mirroring_enabled \u003d False"},{"line_number":33,"context_line":"#service_isl_vlan \u003d -1"},{"line_number":34,"context_line":"#service_resource_pool_ids \u003d []"}],"source_content_type":"text/plain","patch_set":7,"id":"AAAAUH%2F%2Bq8Y%3D","line":31,"in_reply_to":"AAAAUH%2F%2Fsxw%3D","updated":"2014-01-23 11:06:58.000000000","message":"No. This parameter is not currently used","commit_id":"e62d03c63d22fa4b158ef32c763572c5e1623199"}],"neutron/services/loadbalancer/drivers/haproxy/namespace_driver.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0215ced857fff0912ee1279764238b6ffc8a4dec","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class HaproxyNSDriver(agent_device_driver.AgentDeviceDriver):"},{"line_number":65,"context_line":"    def __init__(self, conf, plugin_rpc, config_name\u003d\"haproxy\"):"},{"line_number":66,"context_line":"        cfg.CONF.register_opts(OPTS, config_name)"},{"line_number":67,"context_line":"        self.conf \u003d conf"},{"line_number":68,"context_line":"        self.config_name \u003d config_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2F86Y%3D","line":65,"updated":"2013-12-26 12:52:14.000000000","message":"This driver is loaded by agent manager which doesn\u0027t pass config_name parameter so can you please clarify why changing this file? Also please note that configured haproxy provider name in neutron.conf is \u0027Haproxy\u0027","commit_id":"22001aa3f358054f77be50050f977278481bf431"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"ed3d11df05478f3b53842e25d7819c347d8fb5e1","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class HaproxyNSDriver(agent_device_driver.AgentDeviceDriver):"},{"line_number":65,"context_line":"    def __init__(self, conf, plugin_rpc, config_name\u003d\"haproxy\"):"},{"line_number":66,"context_line":"        cfg.CONF.register_opts(OPTS, config_name)"},{"line_number":67,"context_line":"        self.conf \u003d conf"},{"line_number":68,"context_line":"        self.config_name \u003d config_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2F8zY%3D","line":65,"in_reply_to":"AAAAT3%2F%2F86Y%3D","updated":"2013-12-26 14:54:51.000000000","message":"Right, forgot to remove it, it\u0027s unnecessary,Thanks.\nRegarding Haproxy, services/provider_configuration.py lowers the name\u0027s case","commit_id":"22001aa3f358054f77be50050f977278481bf431"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0215ced857fff0912ee1279764238b6ffc8a4dec","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class HaproxyNSDriver(agent_device_driver.AgentDeviceDriver):"},{"line_number":65,"context_line":"    def __init__(self, conf, plugin_rpc, config_name\u003d\"haproxy\"):"},{"line_number":66,"context_line":"        cfg.CONF.register_opts(OPTS, config_name)"},{"line_number":67,"context_line":"        self.conf \u003d conf"},{"line_number":68,"context_line":"        self.config_name \u003d config_name"},{"line_number":69,"context_line":"        self.root_helper \u003d config.get_root_helper(conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2F86I%3D","line":66,"updated":"2013-12-26 12:52:14.000000000","message":"it\u0027s a bit odd that options are registered in cfg.CONF object and later addressed from self.conf object.","commit_id":"22001aa3f358054f77be50050f977278481bf431"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"ed3d11df05478f3b53842e25d7819c347d8fb5e1","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class HaproxyNSDriver(agent_device_driver.AgentDeviceDriver):"},{"line_number":65,"context_line":"    def __init__(self, conf, plugin_rpc, config_name\u003d\"haproxy\"):"},{"line_number":66,"context_line":"        cfg.CONF.register_opts(OPTS, config_name)"},{"line_number":67,"context_line":"        self.conf \u003d conf"},{"line_number":68,"context_line":"        self.config_name \u003d config_name"},{"line_number":69,"context_line":"        self.root_helper \u003d config.get_root_helper(conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2F8x8%3D","line":66,"in_reply_to":"AAAAT3%2F%2F86I%3D","updated":"2013-12-26 14:54:51.000000000","message":"Agree. Actually it\u0027s the same conf passed by agent to agent manager and then passed to NS driver.","commit_id":"22001aa3f358054f77be50050f977278481bf431"}],"neutron/services/loadbalancer/drivers/haproxy/plugin_driver.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0215ced857fff0912ee1279764238b6ffc8a4dec","unresolved":false,"context_lines":[{"line_number":326,"context_line":"    # vendor specific plugin drivers must override it;"},{"line_number":327,"context_line":"    device_driver \u003d None"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def __init__(self, plugin, config_name):"},{"line_number":330,"context_line":"        if not self.device_driver:"},{"line_number":331,"context_line":"            raise DriverNotSpecified()"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2F83w%3D","line":329,"updated":"2013-12-26 12:52:14.000000000","message":"why naming this parameter as config_name while actually it is provider_name? I see that Radware driver uses it to differentiate config options but I think common name for the parameter should be \u0027provider_name\u0027.","commit_id":"22001aa3f358054f77be50050f977278481bf431"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"ed3d11df05478f3b53842e25d7819c347d8fb5e1","unresolved":false,"context_lines":[{"line_number":326,"context_line":"    # vendor specific plugin drivers must override it;"},{"line_number":327,"context_line":"    device_driver \u003d None"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def __init__(self, plugin, config_name):"},{"line_number":330,"context_line":"        if not self.device_driver:"},{"line_number":331,"context_line":"            raise DriverNotSpecified()"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2F8xc%3D","line":329,"in_reply_to":"AAAAT3%2F%2F83w%3D","updated":"2013-12-26 14:54:51.000000000","message":"Agree","commit_id":"22001aa3f358054f77be50050f977278481bf431"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"c6814c98417602d6030e97232ab53764e4e600ea","unresolved":false,"context_lines":[{"line_number":326,"context_line":"    # vendor specific plugin drivers must override it;"},{"line_number":327,"context_line":"    device_driver \u003d None"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def __init__(self, plugin, provider_name):"},{"line_number":330,"context_line":"        if not self.device_driver:"},{"line_number":331,"context_line":"            raise DriverNotSpecified()"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2F59E%3D","line":329,"updated":"2013-12-27 12:32:57.000000000","message":"make it default None","commit_id":"5d7850264e5d7817ab42c6e3d7c5d0d6d44d8f80"}],"neutron/services/loadbalancer/drivers/radware/driver.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0215ced857fff0912ee1279764238b6ffc8a4dec","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"eventlet.monkey_patch(thread\u003dTrue)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"RESP_STATUS \u003d 0"},{"line_number":45,"context_line":"RESP_REASON \u003d 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2F83o%3D","side":"PARENT","line":42,"updated":"2013-12-26 12:52:14.000000000","message":"is it related change?","commit_id":"84aeb9a407cde367ff4d6e2b5986dd0a689bc332"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"ed3d11df05478f3b53842e25d7819c347d8fb5e1","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"eventlet.monkey_patch(thread\u003dTrue)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"RESP_STATUS \u003d 0"},{"line_number":45,"context_line":"RESP_REASON \u003d 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2F8w0%3D","side":"PARENT","line":42,"in_reply_to":"AAAAT3%2F%2F83o%3D","updated":"2013-12-26 14:54:51.000000000","message":"Not related to a change but related to the new possibility.\nWill mention that in commit message","commit_id":"84aeb9a407cde367ff4d6e2b5986dd0a689bc332"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"c6814c98417602d6030e97232ab53764e4e600ea","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def __init__(self, plugin, provider_name):"},{"line_number":133,"context_line":"        cfg.CONF.register_opts(driver_opts, provider_name)"},{"line_number":134,"context_line":"        conf \u003d cfg.CONF.__getattr__(provider_name)"},{"line_number":135,"context_line":"        self.LOG \u003d logging.getLogger(__name__ + \".\" + provider_name)"},{"line_number":136,"context_line":"        self.plugin \u003d plugin"},{"line_number":137,"context_line":"        self.service \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2F6ZU%3D","line":134,"updated":"2013-12-27 12:32:57.000000000","message":"use getaddr instead of __getaddr__","commit_id":"5d7850264e5d7817ab42c6e3d7c5d0d6d44d8f80"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"92c002c634a4db50438f64587f9e5f507a97d05d","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        service_name \u003d self._get_available_service(incoming_service_name)"},{"line_number":414,"context_line":"        if not service_name:"},{"line_number":415,"context_line":"            self.LOG.debug("},{"line_number":416,"context_line":"                \u0027Could not find a service named \u0027 + incoming_service_name)"},{"line_number":417,"context_line":"            service_name \u003d self._create_service(pool_id, network_id)"},{"line_number":418,"context_line":"            self.l2_l3_ctor_params[\"service\"] \u003d incoming_service_name"},{"line_number":419,"context_line":"            wf_name \u003d \u0027l2_l3_\u0027 + network_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2F8Tw%3D","line":416,"updated":"2013-12-26 18:03:58.000000000","message":"nit: It improves readability.\n self.LOG.debug(\u0027Could not find a service named \u0027 +\n                           incoming_service_name)","commit_id":"5d7850264e5d7817ab42c6e3d7c5d0d6d44d8f80"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"92c002c634a4db50438f64587f9e5f507a97d05d","unresolved":false,"context_lines":[{"line_number":532,"context_line":"                        \u0027ssl\u0027: self.ssl}"},{"line_number":533,"context_line":"        self.LOG.debug(_(\u0027vDirectRESTClient:init server\u003d%(server)s, \u0027"},{"line_number":534,"context_line":"                       \u0027port\u003d%(port)d, \u0027"},{"line_number":535,"context_line":"                       \u0027ssl\u003d%(ssl)r\u0027), debug_params)"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"    @call_log.log"},{"line_number":538,"context_line":"    def call(self, action, resource, data, headers, binary\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2F8NA%3D","line":535,"updated":"2013-12-26 18:03:58.000000000","message":"you might consider:\n        self.LOG.debug(_(\u0027vDirectRESTClient:init server\u003d%(server)s, \u0027\n                       \u0027port\u003d%(port)d, ssl\u003d%(ssl)r\u0027), debug_params)","commit_id":"5d7850264e5d7817ab42c6e3d7c5d0d6d44d8f80"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"92c002c634a4db50438f64587f9e5f507a97d05d","unresolved":false,"context_lines":[{"line_number":654,"context_line":""},{"line_number":655,"context_line":"                self.LOG.debug(\u0027Operation consumed from the queue: \u0027 +"},{"line_number":656,"context_line":"                               str(oper))"},{"line_number":657,"context_line":"                 # check the status - if oper is done: update the db ,"},{"line_number":658,"context_line":"                 # else push the oper again to the queue"},{"line_number":659,"context_line":"                result \u003d self.rest_client.call(\u0027GET\u0027,"},{"line_number":660,"context_line":"                                               oper.operation_url,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2F8L4%3D","line":657,"updated":"2013-12-26 18:03:58.000000000","message":"May want to consider, and add localization\n       \tself.LOG.debug(_(\u0027Operation consumed from the queue: %s\u0027) %\n                               str(oper))","commit_id":"5d7850264e5d7817ab42c6e3d7c5d0d6d44d8f80"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"92c002c634a4db50438f64587f9e5f507a97d05d","unresolved":false,"context_lines":[{"line_number":676,"context_line":"                    db_status \u003d self._get_db_status(oper, success)"},{"line_number":677,"context_line":"                    if db_status:"},{"line_number":678,"context_line":"                        _update_vip_graph_status("},{"line_number":679,"context_line":"                            self.LOG, self.plugin, oper, db_status)"},{"line_number":680,"context_line":"                    else:"},{"line_number":681,"context_line":"                        _remove_object_from_db("},{"line_number":682,"context_line":"                            self.LOG, self.plugin, oper)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2F8Q8%3D","line":679,"updated":"2013-12-26 18:03:58.000000000","message":"update_vip_graph_status(self.LOG, self.plugin, oper,\n                                                 db_status)","commit_id":"5d7850264e5d7817ab42c6e3d7c5d0d6d44d8f80"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"92c002c634a4db50438f64587f9e5f507a97d05d","unresolved":false,"context_lines":[{"line_number":679,"context_line":"                            self.LOG, self.plugin, oper, db_status)"},{"line_number":680,"context_line":"                    else:"},{"line_number":681,"context_line":"                        _remove_object_from_db("},{"line_number":682,"context_line":"                            self.LOG, self.plugin, oper)"},{"line_number":683,"context_line":"                else:"},{"line_number":684,"context_line":"                    self.LOG.debug(_(\u0027Operation %s is not completed yet..\u0027) %"},{"line_number":685,"context_line":"                                   oper)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2F8RI%3D","line":682,"updated":"2013-12-26 18:03:58.000000000","message":"this can be all on one line.\n _remove_object_from_db(self.LOG, self.plugin, oper)","commit_id":"5d7850264e5d7817ab42c6e3d7c5d0d6d44d8f80"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"92c002c634a4db50438f64587f9e5f507a97d05d","unresolved":false,"context_lines":[{"line_number":826,"context_line":"        return ids"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"    trans_vip \u003d {}"},{"line_number":829,"context_line":"    log.debug(\u0027Vip graph to be translated: \u0027 + str(extended_vip))"},{"line_number":830,"context_line":"    for vip_property in VIP_PROPERTIES:"},{"line_number":831,"context_line":"        trans_vip[\u0027vip_\u0027 + vip_property] \u003d extended_vip.get("},{"line_number":832,"context_line":"            vip_property, TRANSLATION_DEFAULTS.get(vip_property))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2F8Kw%3D","line":829,"updated":"2013-12-26 18:03:58.000000000","message":"May want to consider, and localization:\nlog.debug(_(\u0027Vip graph to be translated: %s\u0027) % str(extended_vip))","commit_id":"5d7850264e5d7817ab42c6e3d7c5d0d6d44d8f80"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"92c002c634a4db50438f64587f9e5f507a97d05d","unresolved":false,"context_lines":[{"line_number":856,"context_line":"                          _trans_prop_name(hm_property))].append(value)"},{"line_number":857,"context_line":"    ids \u003d get_ids(extended_vip)"},{"line_number":858,"context_line":"    trans_vip[\u0027__ids__\u0027] \u003d ids"},{"line_number":859,"context_line":"    log.debug(\u0027Translated Vip graph: \u0027 + str(trans_vip))"},{"line_number":860,"context_line":"    return trans_vip"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2F8Kg%3D","line":859,"updated":"2013-12-26 18:03:58.000000000","message":"May want to consider, and add localization:\nlog.debug(_(\u0027Translated Vip graph: %s\u0027) % str(trans_vip))","commit_id":"5d7850264e5d7817ab42c6e3d7c5d0d6d44d8f80"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"85b30c5a9b191f508bad96ef25b073cb57f98900","unresolved":false,"context_lines":[{"line_number":652,"context_line":"                if self.opers_to_handle_before_rest \u003c\u003d 0:"},{"line_number":653,"context_line":"                    self.opers_to_handle_before_rest \u003d self.queue.qsize() + 1"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"                self.LOG.debug(_(\u0027Operation consumed from the queue: %s\u0027) %"},{"line_number":656,"context_line":"                               str(oper))"},{"line_number":657,"context_line":"                 # check the status - if oper is done: update the db ,"},{"line_number":658,"context_line":"                 # else push the oper again to the queue"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2F3RY%3D","line":655,"updated":"2013-12-29 20:12:43.000000000","message":"nit: it\u0027s better to use comma then % in case when passing arguments to logging methods. also, is str() conversion needed? seems oper is passed as is below.","commit_id":"8185b3df0ddef56d404a57558983f04e1670f483"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"8ea0369bf27240f11d9666ee71d140de2de1c028","unresolved":false,"context_lines":[{"line_number":652,"context_line":"                if self.opers_to_handle_before_rest \u003c\u003d 0:"},{"line_number":653,"context_line":"                    self.opers_to_handle_before_rest \u003d self.queue.qsize() + 1"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"                self.LOG.debug(_(\u0027Operation consumed from the queue: %s\u0027) %"},{"line_number":656,"context_line":"                               str(oper))"},{"line_number":657,"context_line":"                 # check the status - if oper is done: update the db ,"},{"line_number":658,"context_line":"                 # else push the oper again to the queue"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2F2Qo%3D","line":655,"in_reply_to":"AAAAT3%2F%2F3RY%3D","updated":"2013-12-30 09:49:19.000000000","message":"Done","commit_id":"8185b3df0ddef56d404a57558983f04e1670f483"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"85b30c5a9b191f508bad96ef25b073cb57f98900","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                    else:"},{"line_number":681,"context_line":"                        _remove_object_from_db(self.LOG, self.plugin, oper)"},{"line_number":682,"context_line":"                else:"},{"line_number":683,"context_line":"                    self.LOG.debug(_(\u0027Operation %s is not completed yet..\u0027) %"},{"line_number":684,"context_line":"                                   oper)"},{"line_number":685,"context_line":"                    # Not completed - push to the queue again"},{"line_number":686,"context_line":"                    self.queue.put_nowait(oper)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2F3Rg%3D","line":683,"updated":"2013-12-29 20:12:43.000000000","message":"nit: comma instead of %","commit_id":"8185b3df0ddef56d404a57558983f04e1670f483"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"8ea0369bf27240f11d9666ee71d140de2de1c028","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                    else:"},{"line_number":681,"context_line":"                        _remove_object_from_db(self.LOG, self.plugin, oper)"},{"line_number":682,"context_line":"                else:"},{"line_number":683,"context_line":"                    self.LOG.debug(_(\u0027Operation %s is not completed yet..\u0027) %"},{"line_number":684,"context_line":"                                   oper)"},{"line_number":685,"context_line":"                    # Not completed - push to the queue again"},{"line_number":686,"context_line":"                    self.queue.put_nowait(oper)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2F2Qg%3D","line":683,"in_reply_to":"AAAAT3%2F%2F3Rg%3D","updated":"2013-12-30 09:49:19.000000000","message":"Done","commit_id":"8185b3df0ddef56d404a57558983f04e1670f483"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"85b30c5a9b191f508bad96ef25b073cb57f98900","unresolved":false,"context_lines":[{"line_number":825,"context_line":"        return ids"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"    trans_vip \u003d {}"},{"line_number":828,"context_line":"    log.debug(_(\u0027Vip graph to be translated: %s\u0027) % str(extended_vip))"},{"line_number":829,"context_line":"    for vip_property in VIP_PROPERTIES:"},{"line_number":830,"context_line":"        trans_vip[\u0027vip_\u0027 + vip_property] \u003d extended_vip.get("},{"line_number":831,"context_line":"            vip_property, TRANSLATION_DEFAULTS.get(vip_property))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2F3Ro%3D","line":828,"updated":"2013-12-29 20:12:43.000000000","message":"same as above. is str() needed?","commit_id":"8185b3df0ddef56d404a57558983f04e1670f483"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"8ea0369bf27240f11d9666ee71d140de2de1c028","unresolved":false,"context_lines":[{"line_number":825,"context_line":"        return ids"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"    trans_vip \u003d {}"},{"line_number":828,"context_line":"    log.debug(_(\u0027Vip graph to be translated: %s\u0027) % str(extended_vip))"},{"line_number":829,"context_line":"    for vip_property in VIP_PROPERTIES:"},{"line_number":830,"context_line":"        trans_vip[\u0027vip_\u0027 + vip_property] \u003d extended_vip.get("},{"line_number":831,"context_line":"            vip_property, TRANSLATION_DEFAULTS.get(vip_property))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2F2QU%3D","line":828,"in_reply_to":"AAAAT3%2F%2F3Ro%3D","updated":"2013-12-30 09:49:19.000000000","message":"Done","commit_id":"8185b3df0ddef56d404a57558983f04e1670f483"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"85b30c5a9b191f508bad96ef25b073cb57f98900","unresolved":false,"context_lines":[{"line_number":855,"context_line":"                          _trans_prop_name(hm_property))].append(value)"},{"line_number":856,"context_line":"    ids \u003d get_ids(extended_vip)"},{"line_number":857,"context_line":"    trans_vip[\u0027__ids__\u0027] \u003d ids"},{"line_number":858,"context_line":"    log.debug(_(\u0027Translated Vip graph: %s\u0027) % str(trans_vip))"},{"line_number":859,"context_line":"    return trans_vip"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2F3Rk%3D","line":858,"updated":"2013-12-29 20:12:43.000000000","message":"same as above","commit_id":"8185b3df0ddef56d404a57558983f04e1670f483"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"8ea0369bf27240f11d9666ee71d140de2de1c028","unresolved":false,"context_lines":[{"line_number":855,"context_line":"                          _trans_prop_name(hm_property))].append(value)"},{"line_number":856,"context_line":"    ids \u003d get_ids(extended_vip)"},{"line_number":857,"context_line":"    trans_vip[\u0027__ids__\u0027] \u003d ids"},{"line_number":858,"context_line":"    log.debug(_(\u0027Translated Vip graph: %s\u0027) % str(trans_vip))"},{"line_number":859,"context_line":"    return trans_vip"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2F2QM%3D","line":858,"in_reply_to":"AAAAT3%2F%2F3Rk%3D","updated":"2013-12-30 09:49:19.000000000","message":"Done","commit_id":"8185b3df0ddef56d404a57558983f04e1670f483"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"78b8c885ffa0bf8c93ca88cc56437153f0bc0c34","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        if not service_name:"},{"line_number":415,"context_line":"            self.LOG.debug("},{"line_number":416,"context_line":"                \u0027Could not find a service named \u0027 +"},{"line_number":417,"context_line":"                incoming_service_name)"},{"line_number":418,"context_line":"            service_name \u003d self._create_service(pool_id, network_id)"},{"line_number":419,"context_line":"            self.l2_l3_ctor_params[\"service\"] \u003d incoming_service_name"},{"line_number":420,"context_line":"            wf_name \u003d \u0027l2_l3_\u0027 + network_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2Frkk%3D","line":417,"updated":"2014-01-03 16:14:40.000000000","message":"Use the \"_\" see below:\n\nMay want to consider using the %s instead of the string append \"+\". e.g.self.LOG.debug(_(\u0027Could not find a service named %s\u0027),\n(incoming_service_name))","commit_id":"46d5480bbb24d8f061212fc1b4be0318dcaf5df9"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"0916470187460e91ed5e9bd6d75ad728baea693d","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        if not service_name:"},{"line_number":415,"context_line":"            self.LOG.debug("},{"line_number":416,"context_line":"                \u0027Could not find a service named \u0027 +"},{"line_number":417,"context_line":"                incoming_service_name)"},{"line_number":418,"context_line":"            service_name \u003d self._create_service(pool_id, network_id)"},{"line_number":419,"context_line":"            self.l2_l3_ctor_params[\"service\"] \u003d incoming_service_name"},{"line_number":420,"context_line":"            wf_name \u003d \u0027l2_l3_\u0027 + network_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2F%2FxM%3D","line":417,"in_reply_to":"AAAAT3%2F%2Frkk%3D","updated":"2014-01-07 17:09:47.000000000","message":"Done","commit_id":"46d5480bbb24d8f061212fc1b4be0318dcaf5df9"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"78b8c885ffa0bf8c93ca88cc56437153f0bc0c34","unresolved":false,"context_lines":[{"line_number":423,"context_line":"            self._update_workflow("},{"line_number":424,"context_line":"                wf_name, \"setup_l2_l3\", self.l2_l3_setup_params, None)"},{"line_number":425,"context_line":"        else:"},{"line_number":426,"context_line":"            self.LOG.debug(\u0027A service named \u0027 + service_name + \u0027 was found.\u0027)"},{"line_number":427,"context_line":"        return service_name"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def _create_service(self, pool_id, network_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2FrkY%3D","line":426,"updated":"2014-01-03 16:14:40.000000000","message":"may want to consider the following:\nself.LOG.debug(_(\u0027A service named %s was found.\u0027), (service_name))","commit_id":"46d5480bbb24d8f061212fc1b4be0318dcaf5df9"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"0916470187460e91ed5e9bd6d75ad728baea693d","unresolved":false,"context_lines":[{"line_number":423,"context_line":"            self._update_workflow("},{"line_number":424,"context_line":"                wf_name, \"setup_l2_l3\", self.l2_l3_setup_params, None)"},{"line_number":425,"context_line":"        else:"},{"line_number":426,"context_line":"            self.LOG.debug(\u0027A service named \u0027 + service_name + \u0027 was found.\u0027)"},{"line_number":427,"context_line":"        return service_name"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def _create_service(self, pool_id, network_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2F%2FxI%3D","line":426,"in_reply_to":"AAAAT3%2F%2FrkY%3D","updated":"2014-01-07 17:09:47.000000000","message":"Done","commit_id":"46d5480bbb24d8f061212fc1b4be0318dcaf5df9"}],"neutron/tests/unit/services/loadbalancer/drivers/haproxy/test_plugin_driver.py":[{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"92c002c634a4db50438f64587f9e5f507a97d05d","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        self.mock_get_driver.return_value \u003d (plugin_driver."},{"line_number":464,"context_line":"                                             AgentBasedPluginDriver("},{"line_number":465,"context_line":"                                                 self.plugin_instance, \"dummy\""},{"line_number":466,"context_line":"                                             ))"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":469,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2F8OY%3D","line":466,"updated":"2013-12-26 18:03:58.000000000","message":"We don\u0027t usually split a line up like this, better might be:\n        self.mock_get_driver.return_value \u003d (\n            plugin_driver.AgentBasedPluginDriver(self.plugin_instance,\n                                                 \"dummy\"))","commit_id":"5d7850264e5d7817ab42c6e3d7c5d0d6d44d8f80"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0c8ed50c1cf7132cb2aad914a1f99f7b90f89928","unresolved":false,"context_lines":[{"line_number":462,"context_line":"                                                 \u0027_get_driver\u0027)"},{"line_number":463,"context_line":"        self.mock_get_driver.return_value \u003d ("},{"line_number":464,"context_line":"            plugin_driver.AgentBasedPluginDriver(self.plugin_instance,"},{"line_number":465,"context_line":"                                                 \"dummy\"))"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":468,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2F9KQ%3D","line":465,"updated":"2014-01-06 09:21:11.000000000","message":"not necessary as AgentBasedPluginDriver has default value for provider_name","commit_id":"235ec4ede6a908ef43a7e5515a9ab9626bd9f31f"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"9dcf3cb4a4f6fe6d6effd28e59e425625c6677be","unresolved":false,"context_lines":[{"line_number":462,"context_line":"                                                 \u0027_get_driver\u0027)"},{"line_number":463,"context_line":"        self.mock_get_driver.return_value \u003d ("},{"line_number":464,"context_line":"            plugin_driver.AgentBasedPluginDriver(self.plugin_instance,"},{"line_number":465,"context_line":"                                                 \"dummy\"))"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":468,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2F8Do%3D","line":465,"in_reply_to":"AAAAUH%2F%2F9KQ%3D","updated":"2014-01-06 17:34:33.000000000","message":"Done","commit_id":"235ec4ede6a908ef43a7e5515a9ab9626bd9f31f"}],"neutron/tests/unit/test_provider_configuration.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"04b0b685a20c7a4e69f67179dfcb1579216a5484","unresolved":false,"context_lines":[{"line_number":113,"context_line":"class ProviderConfigurationTestCase(base.BaseTestCase):"},{"line_number":114,"context_line":"    def setUp(self):"},{"line_number":115,"context_line":"        super(ProviderConfigurationTestCase, self).setUp()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_ensure_default_unique(self):"},{"line_number":118,"context_line":"        pconf \u003d provconf.ProviderConfiguration([])"},{"line_number":119,"context_line":"        pconf.providers[(\u0027svctype\u0027, \u0027name\u0027)] \u003d {\u0027driver\u0027: \u0027driver\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2BZIs%3D","line":116,"updated":"2014-01-27 12:35:59.000000000","message":"Why don\u0027t you add a test for your change? Maybe you can check that you can use the same driver with different service providers.","commit_id":"2293a5d3e0f4d1b3236529aa302542b4e162f92d"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"9efe06828cd5053be8ecfbf31a27c6d176cfd45a","unresolved":false,"context_lines":[{"line_number":113,"context_line":"class ProviderConfigurationTestCase(base.BaseTestCase):"},{"line_number":114,"context_line":"    def setUp(self):"},{"line_number":115,"context_line":"        super(ProviderConfigurationTestCase, self).setUp()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_ensure_default_unique(self):"},{"line_number":118,"context_line":"        pconf \u003d provconf.ProviderConfiguration([])"},{"line_number":119,"context_line":"        pconf.providers[(\u0027svctype\u0027, \u0027name\u0027)] \u003d {\u0027driver\u0027: \u0027driver\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F9nYU%3D","line":116,"in_reply_to":"AAAAUH%2F%2BZIs%3D","updated":"2014-02-05 16:43:22.000000000","message":"Done","commit_id":"2293a5d3e0f4d1b3236529aa302542b4e162f92d"}]}
