)]}'
{"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6152426c5336507961761ad27ca23ff40c98807a","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"DEFAULT_PRIORITY \u003d 255"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"DHCP_PROCESS_GREENLET_MAX \u003d 32"},{"line_number":52,"context_line":"DHCP_PROCESS_GREENLET_MIN \u003d 8"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def _sync_lock(f):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_7d3ff524","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":29},"updated":"2019-03-11 16:34:13.000000000","message":"I refer to Doug\u0027s question: why 8 for min, and 32 for max?\n\nDo we have now (without his patch) 8 green thread, and that\u0027s why 8 is the min value?","commit_id":"76dc4c35f8f71ca6644096e63d6dde957cbd69f0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8002e7e5e79cb9c9924b6b21adc9af873c7a026a","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"DEFAULT_PRIORITY \u003d 255"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"DHCP_PROCESS_GREENLET_MAX \u003d 32"},{"line_number":52,"context_line":"DHCP_PROCESS_GREENLET_MIN \u003d 8"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def _sync_lock(f):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_6aff1c34","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":29},"in_reply_to":"5fc1f717_6baf2be3","updated":"2019-03-12 06:19:22.000000000","message":"Ok","commit_id":"76dc4c35f8f71ca6644096e63d6dde957cbd69f0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d3e46c01bc82b4726c922cf9452cb256226a50e8","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"DEFAULT_PRIORITY \u003d 255"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"DHCP_PROCESS_GREENLET_MAX \u003d 32"},{"line_number":52,"context_line":"DHCP_PROCESS_GREENLET_MIN \u003d 8"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def _sync_lock(f):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_6baf2be3","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":29},"in_reply_to":"5fc1f717_7d3ff524","updated":"2019-03-11 17:41:45.000000000","message":"Because 8 is the current thread count, and in most situations is just fine for a minimum.  I chose 32 as the maximum to mimic the l3-agent","commit_id":"76dc4c35f8f71ca6644096e63d6dde957cbd69f0"}],"neutron/tests/functional/agent/test_dhcp_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a652d41a6056211e730111d15eb8f6ed0793902a","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def network_create_end(self, network, dhcp_enabled\u003dTrue):"},{"line_number":169,"context_line":"        payload \u003d dict(network\u003dnetwork)"},{"line_number":170,"context_line":"        self.agent.create_network_end(None, payload)"},{"line_number":171,"context_line":"        self.agent._process_resource_update()"},{"line_number":172,"context_line":"        self.addCleanup(self._cleanup_network, network, dhcp_enabled)"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_0efa6774","line":170,"updated":"2019-03-08 02:23:01.000000000","message":"that was a silly typo, and in the delete code","commit_id":"bd437eeda1b1e79f4b3ab176dd384397fae08a1b"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"43411203f6484a0572dd0eef0722ebcf07f88458","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        self.mock_plugin_api.dhcp_ready_on_ports.assert_called_with("},{"line_number":401,"context_line":"            ports_to_send)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    def test_dhcp_processing_pool_size(self):"},{"line_number":404,"context_line":"        network_info_1 \u003d self.network_dict_for_dhcp()"},{"line_number":405,"context_line":"        self.configure_dhcp_for_network(network\u003dnetwork_info_1)"},{"line_number":406,"context_line":"        self.assertEqual(agent.DHCP_PROCESS_GREENLET_MIN,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_1af25371","line":403,"updated":"2019-03-13 00:00:59.000000000","message":"Do not need any mock here? Functional DHCP agent can handle this large set of networks?","commit_id":"15194d18378797fd197b5477e305e80931303e47"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5926dfec3bd1480ec5f9aaac1f01390969274c0f","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        self.mock_plugin_api.dhcp_ready_on_ports.assert_called_with("},{"line_number":401,"context_line":"            ports_to_send)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    def test_dhcp_processing_pool_size(self):"},{"line_number":404,"context_line":"        network_info_1 \u003d self.network_dict_for_dhcp()"},{"line_number":405,"context_line":"        self.configure_dhcp_for_network(network\u003dnetwork_info_1)"},{"line_number":406,"context_line":"        self.assertEqual(agent.DHCP_PROCESS_GREENLET_MIN,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_235da3e8","line":403,"in_reply_to":"5fc1f717_1af25371","updated":"2019-03-13 11:09:10.000000000","message":"Hmmm I was thinking about the problem you found in [1]. If we find random problems with this test, maybe we can mock some DhcpAgentWithStateReport functions, the same as in [1].\n\n[1] https://review.openstack.org/#/c/639034/10/neutron/tests/functional/agent/l3/test_legacy_router.py","commit_id":"15194d18378797fd197b5477e305e80931303e47"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4c8ca7c056b9f2b21b20a88951f623353e55c15d","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        self.mock_plugin_api.dhcp_ready_on_ports.assert_called_with("},{"line_number":401,"context_line":"            ports_to_send)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    def test_dhcp_processing_pool_size(self):"},{"line_number":404,"context_line":"        network_info_1 \u003d self.network_dict_for_dhcp()"},{"line_number":405,"context_line":"        self.configure_dhcp_for_network(network\u003dnetwork_info_1)"},{"line_number":406,"context_line":"        self.assertEqual(agent.DHCP_PROCESS_GREENLET_MIN,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_59cea02e","line":403,"in_reply_to":"5fc1f717_235da3e8","updated":"2019-03-13 13:23:07.000000000","message":"Let me try mocking both call_driver and update/delete_isolated_metadata_proxy since we really don\u0027t care about them.  Thanks for the suggestion.","commit_id":"15194d18378797fd197b5477e305e80931303e47"}],"releasenotes/notes/dynamically-resize-agent-greenthreads-c163ab37d36fcafe.yaml":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5f73f56496a93a40c75b4fd51fb206733538bb1b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The Neutron L3 and DHCP agents now dynamically tune the number of"},{"line_number":5,"context_line":"    processing greenthreads they run based on the number of objects they"},{"line_number":6,"context_line":"    are managing, with the current values for this range being between eight"},{"line_number":7,"context_line":"    thirty-two threads, which is an increase over the previous static value"},{"line_number":8,"context_line":"    of eight threads. This should help address some of the scaling problems"},{"line_number":9,"context_line":"    in the agents. For more information see bug"},{"line_number":10,"context_line":"    `1813787 \u003chttps://bugs.launchpad.net/neutron/+bug/1813787\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5fc1f717_6d79f591","line":7,"range":{"start_line":6,"start_character":71,"end_line":7,"end_character":14},"updated":"2019-03-18 22:19:53.000000000","message":"eight and thirty two","commit_id":"99109c1da39372ff52892913253323028d635f4d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8003d975f2bd12771cfb58035c66ba63e898bd64","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The Neutron L3 and DHCP agents now dynamically tune the number of"},{"line_number":5,"context_line":"    processing greenthreads they run based on the number of objects they"},{"line_number":6,"context_line":"    are managing, with the current values for this range being between eight"},{"line_number":7,"context_line":"    thirty-two threads, which is an increase over the previous static value"},{"line_number":8,"context_line":"    of eight threads. This should help address some of the scaling problems"},{"line_number":9,"context_line":"    in the agents. For more information see bug"},{"line_number":10,"context_line":"    `1813787 \u003chttps://bugs.launchpad.net/neutron/+bug/1813787\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5fc1f717_4de75948","line":7,"range":{"start_line":6,"start_character":71,"end_line":7,"end_character":14},"in_reply_to":"5fc1f717_6d79f591","updated":"2019-03-18 22:25:09.000000000","message":"Done","commit_id":"99109c1da39372ff52892913253323028d635f4d"}]}
