)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c6df3e2ab5e870685f337c4d10f4c3a26f3183c4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"See the ovs-vswitchd.conf.db man page for full descriptions."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If0d42919412dac75deb4d7f484c42cea630fbc59"},{"line_number":16,"context_line":"Closes-Bug: #1817022"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_f98255c8","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":20},"updated":"2019-03-07 16:21:12.000000000","message":"This may also address the bug:\nhttps://bugs.launchpad.net/neutron/+bug/1813705\nYes, we have changed these values locally for heavy load agents.","commit_id":"7d20786e67b8042343cb08e5c2e4fbdd9b7d3da3"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"e98f76c3acba5eb027c58d919dccd36289be2808","unresolved":false,"context_lines":[{"line_number":13,"context_line":"See the ovs-vswitchd.conf.db man page for full descriptions."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If0d42919412dac75deb4d7f484c42cea630fbc59"},{"line_number":16,"context_line":"Closes-Bug: #1817022"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_847393b1","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":20},"in_reply_to":"5fc1f717_f98255c8","updated":"2019-03-08 11:16:02.000000000","message":"\u003e This may also address the bug:\n \u003e https://bugs.launchpad.net/neutron/+bug/1813705\n \u003e Yes, we have changed these values locally for heavy load agents.\n\nthx, will add as related bug.","commit_id":"7d20786e67b8042343cb08e5c2e4fbdd9b7d3da3"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"39331dad41f8162d78acb5548799e94ec8ff0e16","unresolved":false,"context_lines":[{"line_number":687,"context_line":"        \"\"\""},{"line_number":688,"context_line":"        self.set_controller_field(\u0027connection_mode\u0027, connection_mode)"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"    def set_controllers_inactivity_probe(self, interval):"},{"line_number":691,"context_line":"        self.set_controller_field(\u0027inactivity_probe\u0027, interval * 1000)"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"    def _set_egress_bw_limit_for_port(self, port_name, max_kbps,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_e8add331","line":690,"updated":"2019-05-16 18:33:53.000000000","message":"Shouldn\u0027t this have a docstring, like set_controllers_connection_mode above it, because it is an externally visible function?  At a minimum it would be useful to make explicit the units for \u0027interval\u0027.","commit_id":"342b0f753189aeabcc397a047f2a3d6b764450df"}],"neutron/conf/plugins/ml2/drivers/ovs_conf.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c6df3e2ab5e870685f337c4d10f4c3a26f3183c4","unresolved":false,"context_lines":[{"line_number":121,"context_line":"               help\u003d_(\"Timeout in seconds to wait for a single \""},{"line_number":122,"context_line":"                      \"OpenFlow request. \""},{"line_number":123,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"},{"line_number":124,"context_line":"    cfg.IntOpt(\u0027of_inactivity_probe\u0027, default\u003d5,"},{"line_number":125,"context_line":"               help\u003d_(\"The inactivity_probe interval in seconds for the local \""},{"line_number":126,"context_line":"                      \"switch connection to the controller. \""},{"line_number":127,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_59ccc934","line":124,"range":{"start_line":124,"start_character":38,"end_line":124,"end_character":47},"updated":"2019-03-07 16:21:12.000000000","message":"For our environment, we set this to 10s.","commit_id":"7d20786e67b8042343cb08e5c2e4fbdd9b7d3da3"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"e98f76c3acba5eb027c58d919dccd36289be2808","unresolved":false,"context_lines":[{"line_number":121,"context_line":"               help\u003d_(\"Timeout in seconds to wait for a single \""},{"line_number":122,"context_line":"                      \"OpenFlow request. \""},{"line_number":123,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"},{"line_number":124,"context_line":"    cfg.IntOpt(\u0027of_inactivity_probe\u0027, default\u003d5,"},{"line_number":125,"context_line":"               help\u003d_(\"The inactivity_probe interval in seconds for the local \""},{"line_number":126,"context_line":"                      \"switch connection to the controller. \""},{"line_number":127,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_e44a9753","line":124,"range":{"start_line":124,"start_character":38,"end_line":124,"end_character":47},"in_reply_to":"5fc1f717_59ccc934","updated":"2019-03-08 11:16:02.000000000","message":"\u003e For our environment, we set this to 10s.\n\nI choose 5 because it is the OVS default and don\u0027t want to change default behavior.","commit_id":"7d20786e67b8042343cb08e5c2e4fbdd9b7d3da3"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"32250978c240ed64cc03e4fdd8e5da99b01454ed","unresolved":false,"context_lines":[{"line_number":121,"context_line":"               help\u003d_(\"Timeout in seconds to wait for a single \""},{"line_number":122,"context_line":"                      \"OpenFlow request. \""},{"line_number":123,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"},{"line_number":124,"context_line":"    cfg.IntOpt(\u0027of_inactivity_probe\u0027, default\u003d5,"},{"line_number":125,"context_line":"               help\u003d_(\"The inactivity_probe interval in seconds for the local \""},{"line_number":126,"context_line":"                      \"switch connection to the controller. \""},{"line_number":127,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_eb60fba7","line":124,"range":{"start_line":124,"start_character":38,"end_line":124,"end_character":47},"in_reply_to":"5fc1f717_e2ca8718","updated":"2019-03-11 17:50:15.000000000","message":"\u003e What would be side-effect of defaulting this to 10 for neutron\n \u003e purposes? If it allows neutron to scale better out of the box\n \u003e without any operator intervention I would support that. If we have\n \u003e good reasons there is no reason we can\u0027t override OVS defaults to\n \u003e suit our needs.\n\nI don\u0027t see any negative side-effects. I will make it 10sec.","commit_id":"7d20786e67b8042343cb08e5c2e4fbdd9b7d3da3"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"664e817faa817b3dfba91d8950be5e1f005c42a2","unresolved":false,"context_lines":[{"line_number":121,"context_line":"               help\u003d_(\"Timeout in seconds to wait for a single \""},{"line_number":122,"context_line":"                      \"OpenFlow request. \""},{"line_number":123,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"},{"line_number":124,"context_line":"    cfg.IntOpt(\u0027of_inactivity_probe\u0027, default\u003d5,"},{"line_number":125,"context_line":"               help\u003d_(\"The inactivity_probe interval in seconds for the local \""},{"line_number":126,"context_line":"                      \"switch connection to the controller. \""},{"line_number":127,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_e2ca8718","line":124,"range":{"start_line":124,"start_character":38,"end_line":124,"end_character":47},"in_reply_to":"5fc1f717_e44a9753","updated":"2019-03-08 14:23:02.000000000","message":"What would be side-effect of defaulting this to 10 for neutron purposes? If it allows neutron to scale better out of the box without any operator intervention I would support that. If we have good reasons there is no reason we can\u0027t override OVS defaults to suit our needs.","commit_id":"7d20786e67b8042343cb08e5c2e4fbdd9b7d3da3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5ecbbaadef436b36e6beca59a0f8c1bbc9f8d482","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"},{"line_number":124,"context_line":"    cfg.IntOpt(\u0027of_inactivity_probe\u0027, default\u003d5,"},{"line_number":125,"context_line":"               help\u003d_(\"The inactivity_probe interval in seconds for the local \""},{"line_number":126,"context_line":"                      \"switch connection to the controller. \""},{"line_number":127,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"},{"line_number":128,"context_line":"    cfg.IntOpt(\u0027of_max_backoff\u0027, default\u003d8,"},{"line_number":129,"context_line":"               help\u003d_(\"The max_backoff time in seconds for retrying \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_e8211ca1","line":126,"updated":"2019-03-07 17:09:27.000000000","message":"Please, add that \"0\" disables inactivity probes","commit_id":"7d20786e67b8042343cb08e5c2e4fbdd9b7d3da3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b558344bb90f38d900d73207287230318b83d3b5","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"},{"line_number":124,"context_line":"    cfg.IntOpt(\u0027of_inactivity_probe\u0027, default\u003d5,"},{"line_number":125,"context_line":"               help\u003d_(\"The inactivity_probe interval in seconds for the local \""},{"line_number":126,"context_line":"                      \"switch connection to the controller. \""},{"line_number":127,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"},{"line_number":128,"context_line":"    cfg.IntOpt(\u0027of_max_backoff\u0027, default\u003d8,"},{"line_number":129,"context_line":"               help\u003d_(\"The max_backoff time in seconds for retrying \""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_42f6eafb","line":126,"in_reply_to":"5fc1f717_c4799b93","updated":"2019-05-08 09:42:50.000000000","message":"Same comment here. Not in PS2","commit_id":"7d20786e67b8042343cb08e5c2e4fbdd9b7d3da3"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"e98f76c3acba5eb027c58d919dccd36289be2808","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"},{"line_number":124,"context_line":"    cfg.IntOpt(\u0027of_inactivity_probe\u0027, default\u003d5,"},{"line_number":125,"context_line":"               help\u003d_(\"The inactivity_probe interval in seconds for the local \""},{"line_number":126,"context_line":"                      \"switch connection to the controller. \""},{"line_number":127,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"},{"line_number":128,"context_line":"    cfg.IntOpt(\u0027of_max_backoff\u0027, default\u003d8,"},{"line_number":129,"context_line":"               help\u003d_(\"The max_backoff time in seconds for retrying \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_c4799b93","line":126,"in_reply_to":"5fc1f717_e8211ca1","updated":"2019-03-08 11:16:02.000000000","message":"\u003e Please, add that \"0\" disables inactivity probes\n\nwill do.","commit_id":"7d20786e67b8042343cb08e5c2e4fbdd9b7d3da3"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"45fa946b0ab8bdb0e9e5ab6e9cf214a39dd24ae0","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"},{"line_number":124,"context_line":"    cfg.IntOpt(\u0027of_inactivity_probe\u0027, default\u003d5,"},{"line_number":125,"context_line":"               help\u003d_(\"The inactivity_probe interval in seconds for the local \""},{"line_number":126,"context_line":"                      \"switch connection to the controller. \""},{"line_number":127,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"},{"line_number":128,"context_line":"    cfg.IntOpt(\u0027of_max_backoff\u0027, default\u003d8,"},{"line_number":129,"context_line":"               help\u003d_(\"The max_backoff time in seconds for retrying \""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_22009667","line":126,"in_reply_to":"dfbec78f_42f6eafb","updated":"2019-05-08 10:20:44.000000000","message":"Done","commit_id":"7d20786e67b8042343cb08e5c2e4fbdd9b7d3da3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c35d8e9c0934dcd4d574da83debd490f3162252d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                      \"OpenFlow request. \""},{"line_number":123,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"},{"line_number":124,"context_line":"    cfg.IntOpt(\u0027of_inactivity_probe\u0027, default\u003d10,"},{"line_number":125,"context_line":"               help\u003d_(\"The inactivity_probe interval in seconds for the local \""},{"line_number":126,"context_line":"                      \"switch connection to the controller. \""},{"line_number":127,"context_line":"                      \"A value of 0 disables inactivity probes. \""},{"line_number":128,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_0128e7df","line":125,"updated":"2019-05-08 20:38:49.000000000","message":"what if I will set value lower than 0? Will it work or crash the agent?","commit_id":"96c5ef8aa1d887ef1f5e908a96bcb0e3d96584f7"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"384e0c1473f8dfc7731d583cc2a190b0de6ad5a8","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                      \"OpenFlow request. \""},{"line_number":123,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"},{"line_number":124,"context_line":"    cfg.IntOpt(\u0027of_inactivity_probe\u0027, default\u003d10,"},{"line_number":125,"context_line":"               help\u003d_(\"The inactivity_probe interval in seconds for the local \""},{"line_number":126,"context_line":"                      \"switch connection to the controller. \""},{"line_number":127,"context_line":"                      \"A value of 0 disables inactivity probes. \""},{"line_number":128,"context_line":"                      \"Used only for \u0027native\u0027 driver.\")),"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_33ea1c0f","line":125,"in_reply_to":"dfbec78f_0128e7df","updated":"2019-05-09 09:18:53.000000000","message":"The agent will not crash. OVS will set it to 5 sec. https://github.com/openvswitch/ovs/blob/branch-2.11/ofproto/connmgr.c#L1364","commit_id":"96c5ef8aa1d887ef1f5e908a96bcb0e3d96584f7"}]}