)]}'
{"neutron/agent/l3/dvr_local_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"040b23f58630e2be526aaf27b5ab77016fdbf622","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def remove_floating_ip(self, device, ip_cidr):"},{"line_number":200,"context_line":"        self.floating_ip_removed_dist(ip_cidr)"},{"line_number":201,"context_line":"        super(DvrLocalRouter, self).remove_floating_ip(device, ip_cidr)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def move_floating_ip(self, fip):"},{"line_number":204,"context_line":"        self.floating_ip_moved_dist(fip)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_deaada83","line":201,"updated":"2019-03-07 18:40:02.000000000","message":"The problem is the super() call will get to delete_addr_and_conntrack_state(), but with DVR we haven\u0027t configured the IP on the interface.\n\nPerhaps the conntrack part of that code can be broken out to its own method, assuming the removal does fix the bug.","commit_id":"aa35f12f1db872bdcc9a7d84db22c56632d12db8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9a38173fe05e442ddbae482fb7779fc93c0ed561","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def remove_floating_ip(self, device, ip_cidr):"},{"line_number":200,"context_line":"        self.floating_ip_removed_dist(ip_cidr)"},{"line_number":201,"context_line":"        super(DvrLocalRouter, self).remove_floating_ip(device, ip_cidr)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def move_floating_ip(self, fip):"},{"line_number":204,"context_line":"        self.floating_ip_moved_dist(fip)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_730f4be1","line":201,"in_reply_to":"5fc1f717_1e8f0224","updated":"2019-03-08 16:15:19.000000000","message":"Actually it is, this is call from process_floating_ip_addresses. \"device\" is \n  device \u003d ip_lib.IPDevice(interface_name, namespace\u003dself.ns_name)","commit_id":"aa35f12f1db872bdcc9a7d84db22c56632d12db8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"91f942aede383c0b506a6faf974502fdab17b649","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def remove_floating_ip(self, device, ip_cidr):"},{"line_number":200,"context_line":"        self.floating_ip_removed_dist(ip_cidr)"},{"line_number":201,"context_line":"        super(DvrLocalRouter, self).remove_floating_ip(device, ip_cidr)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def move_floating_ip(self, fip):"},{"line_number":204,"context_line":"        self.floating_ip_moved_dist(fip)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_910c373c","line":201,"in_reply_to":"5fc1f717_1e8f0224","updated":"2019-03-08 09:35:09.000000000","message":"Ohhh yes, you are right.","commit_id":"aa35f12f1db872bdcc9a7d84db22c56632d12db8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"91f942aede383c0b506a6faf974502fdab17b649","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def remove_floating_ip(self, device, ip_cidr):"},{"line_number":200,"context_line":"        self.floating_ip_removed_dist(ip_cidr)"},{"line_number":201,"context_line":"        super(DvrLocalRouter, self).remove_floating_ip(device, ip_cidr)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def move_floating_ip(self, fip):"},{"line_number":204,"context_line":"        self.floating_ip_moved_dist(fip)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_71098b2a","line":201,"in_reply_to":"5fc1f717_deaada83","updated":"2019-03-08 09:35:09.000000000","message":"I realize that just one second before pushing the patch. Thanks!!\n\nAs you said, I need to break the code to have a specific function to only remove the conntrack rule.","commit_id":"aa35f12f1db872bdcc9a7d84db22c56632d12db8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f5dffc8dc0627fe1d2f1514c5f157001c134f1ad","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def remove_floating_ip(self, device, ip_cidr):"},{"line_number":200,"context_line":"        self.floating_ip_removed_dist(ip_cidr)"},{"line_number":201,"context_line":"        super(DvrLocalRouter, self).remove_floating_ip(device, ip_cidr)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def move_floating_ip(self, fip):"},{"line_number":204,"context_line":"        self.floating_ip_moved_dist(fip)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_1e8f0224","line":201,"in_reply_to":"5fc1f717_deaada83","updated":"2019-03-07 18:42:40.000000000","message":"Plus, device here is not an IPDevice() :(","commit_id":"aa35f12f1db872bdcc9a7d84db22c56632d12db8"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"960ae0ade5279daa07e211033903065b2895f4a3","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def remove_floating_ip(self, device, ip_cidr):"},{"line_number":198,"context_line":"        fip_2_rtr_device \u003d self.floating_ip_removed_dist(ip_cidr)"},{"line_number":199,"context_line":"        if fip_2_rtr_device:"},{"line_number":200,"context_line":"            fip_2_rtr_device.delete_conntrack_state(ip_cidr)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def move_floating_ip(self, fip):"},{"line_number":203,"context_line":"        self.floating_ip_moved_dist(fip)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_c53d302d","line":200,"range":{"start_line":199,"start_character":0,"end_line":200,"end_character":60},"updated":"2019-03-20 19:05:18.000000000","message":"Can\u0027t we directly call the \u0027super(DVRLocalRouter, self).remove_floating_ip(device,ip_cidr)","commit_id":"24f231d4562ec08d57ab9c20357cd4fb54161034"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"a1611938d5eca1e3a98d8b49bccff565c557f84d","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def remove_floating_ip(self, device, ip_cidr):"},{"line_number":198,"context_line":"        fip_2_rtr_device \u003d self.floating_ip_removed_dist(ip_cidr)"},{"line_number":199,"context_line":"        if fip_2_rtr_device:"},{"line_number":200,"context_line":"            fip_2_rtr_device.delete_conntrack_state(ip_cidr)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def move_floating_ip(self, fip):"},{"line_number":203,"context_line":"        self.floating_ip_moved_dist(fip)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_39b441d1","line":200,"range":{"start_line":199,"start_character":0,"end_line":200,"end_character":60},"in_reply_to":"5fc1f717_4de5da37","updated":"2019-03-21 23:29:43.000000000","message":"Thanks.","commit_id":"24f231d4562ec08d57ab9c20357cd4fb54161034"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a178649feaac8cbe5659896ea8cfa2a12b106072","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def remove_floating_ip(self, device, ip_cidr):"},{"line_number":198,"context_line":"        fip_2_rtr_device \u003d self.floating_ip_removed_dist(ip_cidr)"},{"line_number":199,"context_line":"        if fip_2_rtr_device:"},{"line_number":200,"context_line":"            fip_2_rtr_device.delete_conntrack_state(ip_cidr)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def move_floating_ip(self, fip):"},{"line_number":203,"context_line":"        self.floating_ip_moved_dist(fip)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_4de5da37","line":200,"range":{"start_line":199,"start_character":0,"end_line":200,"end_character":60},"in_reply_to":"5fc1f717_c53d302d","updated":"2019-03-21 10:45:12.000000000","message":"RouterInfo.remove_floating_ip is calling IPDevice.delete_addr_and_conntrack_state. This function, apart from deleting the conntrack rule, is deleting the CIDR, something we don\u0027t need here.\n\nThat\u0027s why I divided delete_addr_and_conntrack_state in two blocks: delete the CIDR and the rule.","commit_id":"24f231d4562ec08d57ab9c20357cd4fb54161034"}],"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3e1b200b1b4736dbda196906b8b681536429bfe7","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        ip_str \u003d str(netaddr.IPNetwork(cidr).ip)"},{"line_number":339,"context_line":"        ip_wrapper \u003d IPWrapper(namespace\u003dself.namespace)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        # Delete conntrack state for ingress traffic."},{"line_number":342,"context_line":"        # If 0 flow entries have been deleted conntrack -D will return 1."},{"line_number":343,"context_line":"        try:"},{"line_number":344,"context_line":"            ip_wrapper.netns.execute([\"conntrack\", \"-D\", \"-d\", ip_str],"},{"line_number":345,"context_line":"                                     check_exit_code\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_d8e1e09c","line":342,"range":{"start_line":341,"start_character":8,"end_line":342,"end_character":73},"updated":"2019-03-28 14:30:50.000000000","message":"nit: Can we leave this and the following changes as it is? These unrelated changes may cause backport conflicts if stable branches need this.","commit_id":"d5ec5fc7fd3af779c0fc4ddff91eb75f4626128a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e48872884460394c68873b0e78fbdd94684b5067","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        ip_str \u003d str(netaddr.IPNetwork(cidr).ip)"},{"line_number":339,"context_line":"        ip_wrapper \u003d IPWrapper(namespace\u003dself.namespace)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        # Delete conntrack state for ingress traffic."},{"line_number":342,"context_line":"        # If 0 flow entries have been deleted conntrack -D will return 1."},{"line_number":343,"context_line":"        try:"},{"line_number":344,"context_line":"            ip_wrapper.netns.execute([\"conntrack\", \"-D\", \"-d\", ip_str],"},{"line_number":345,"context_line":"                                     check_exit_code\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_bb888e70","line":342,"range":{"start_line":341,"start_character":8,"end_line":342,"end_character":73},"in_reply_to":"5fc1f717_d8e1e09c","updated":"2019-03-28 14:40:23.000000000","message":"Done","commit_id":"d5ec5fc7fd3af779c0fc4ddff91eb75f4626128a"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3e1b200b1b4736dbda196906b8b681536429bfe7","unresolved":false,"context_lines":[{"line_number":344,"context_line":"            ip_wrapper.netns.execute([\"conntrack\", \"-D\", \"-d\", ip_str],"},{"line_number":345,"context_line":"                                     check_exit_code\u003dTrue,"},{"line_number":346,"context_line":"                                     extra_ok_codes\u003d[1])"},{"line_number":347,"context_line":"        except RuntimeError:"},{"line_number":348,"context_line":"            LOG.exception(\"Failed deleting ingress connection state of \""},{"line_number":349,"context_line":"                          \"floatingip %s\", ip_str)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        # Delete conntrack state for egress traffic"},{"line_number":352,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_98f1186e","line":349,"range":{"start_line":347,"start_character":8,"end_line":349,"end_character":50},"updated":"2019-03-28 14:30:50.000000000","message":"ditto","commit_id":"d5ec5fc7fd3af779c0fc4ddff91eb75f4626128a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e48872884460394c68873b0e78fbdd94684b5067","unresolved":false,"context_lines":[{"line_number":344,"context_line":"            ip_wrapper.netns.execute([\"conntrack\", \"-D\", \"-d\", ip_str],"},{"line_number":345,"context_line":"                                     check_exit_code\u003dTrue,"},{"line_number":346,"context_line":"                                     extra_ok_codes\u003d[1])"},{"line_number":347,"context_line":"        except RuntimeError:"},{"line_number":348,"context_line":"            LOG.exception(\"Failed deleting ingress connection state of \""},{"line_number":349,"context_line":"                          \"floatingip %s\", ip_str)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        # Delete conntrack state for egress traffic"},{"line_number":352,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_7b7ea66a","line":349,"range":{"start_line":347,"start_character":8,"end_line":349,"end_character":50},"in_reply_to":"5fc1f717_98f1186e","updated":"2019-03-28 14:40:23.000000000","message":"Done","commit_id":"d5ec5fc7fd3af779c0fc4ddff91eb75f4626128a"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3e1b200b1b4736dbda196906b8b681536429bfe7","unresolved":false,"context_lines":[{"line_number":354,"context_line":"                                     check_exit_code\u003dTrue,"},{"line_number":355,"context_line":"                                     extra_ok_codes\u003d[1])"},{"line_number":356,"context_line":"        except RuntimeError:"},{"line_number":357,"context_line":"            LOG.exception(\"Failed deleting egress connection state of \""},{"line_number":358,"context_line":"                          \"floatingip %s\", ip_str)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    def delete_socket_conntrack_state(self, cidr, dport, protocol):"},{"line_number":361,"context_line":"        ip_str \u003d str(netaddr.IPNetwork(cidr).ip)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_18052846","line":358,"range":{"start_line":357,"start_character":11,"end_line":358,"end_character":50},"updated":"2019-03-28 14:30:50.000000000","message":"ditto","commit_id":"d5ec5fc7fd3af779c0fc4ddff91eb75f4626128a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e48872884460394c68873b0e78fbdd94684b5067","unresolved":false,"context_lines":[{"line_number":354,"context_line":"                                     check_exit_code\u003dTrue,"},{"line_number":355,"context_line":"                                     extra_ok_codes\u003d[1])"},{"line_number":356,"context_line":"        except RuntimeError:"},{"line_number":357,"context_line":"            LOG.exception(\"Failed deleting egress connection state of \""},{"line_number":358,"context_line":"                          \"floatingip %s\", ip_str)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    def delete_socket_conntrack_state(self, cidr, dport, protocol):"},{"line_number":361,"context_line":"        ip_str \u003d str(netaddr.IPNetwork(cidr).ip)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_3b949e8a","line":358,"range":{"start_line":357,"start_character":11,"end_line":358,"end_character":50},"in_reply_to":"5fc1f717_18052846","updated":"2019-03-28 14:40:23.000000000","message":"Done","commit_id":"d5ec5fc7fd3af779c0fc4ddff91eb75f4626128a"}]}
