)]}'
{"neutron/agent/linux/iptables_firewall.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"ff1a71cc77ab117bb30eef44c0372174243c4a7a","unresolved":false,"context_lines":[{"line_number":739,"context_line":"                    args +\u003d [\u0027-m\u0027, \u0027multiport\u0027, \u0027--%ss\u0027 % direction,"},{"line_number":740,"context_line":"                             \u0027%s\u0027 % port_range_min]"},{"line_number":741,"context_line":"                else:"},{"line_number":742,"context_line":"                    args +\u003d [\u0027--%s\u0027 % direction, \u0027%s\u0027 % (port_range_min,)]"},{"line_number":743,"context_line":"            else:"},{"line_number":744,"context_line":"                args +\u003d [\u0027-m\u0027, \u0027multiport\u0027, \u0027--%ss\u0027 % direction,"},{"line_number":745,"context_line":"                         \u0027%s:%s\u0027 % (port_range_min, port_range_max)]"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_1ad5731c","line":742,"updated":"2019-03-12 23:31:49.000000000","message":"Nit: Change \n\u003e \u0027%s\u0027 % (port_range_min,) \nto \n\u003e \u0027%s\u0027 % port_range_min\nFor consistency","commit_id":"1c82ce4d264fbf56b40d9cdd07e6de948d010e15"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4f77d838e082a51ae56d7c5791db42f276151f05","unresolved":false,"context_lines":[{"line_number":739,"context_line":"                    args +\u003d [\u0027-m\u0027, \u0027multiport\u0027, \u0027--%ss\u0027 % direction,"},{"line_number":740,"context_line":"                             \u0027%s\u0027 % port_range_min]"},{"line_number":741,"context_line":"                else:"},{"line_number":742,"context_line":"                    args +\u003d [\u0027--%s\u0027 % direction, \u0027%s\u0027 % (port_range_min,)]"},{"line_number":743,"context_line":"            else:"},{"line_number":744,"context_line":"                args +\u003d [\u0027-m\u0027, \u0027multiport\u0027, \u0027--%ss\u0027 % direction,"},{"line_number":745,"context_line":"                         \u0027%s:%s\u0027 % (port_range_min, port_range_max)]"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_bb69b3f9","line":742,"in_reply_to":"5fc1f717_1ad5731c","updated":"2019-03-13 17:48:15.000000000","message":"Done","commit_id":"1c82ce4d264fbf56b40d9cdd07e6de948d010e15"}],"neutron/extensions/securitygroup.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cfb6e9bb48497ef03dbd2054d5c35d60f66704e7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"class SecurityGroupInvalidProtocolForPort(exceptions.InvalidInput):"},{"line_number":44,"context_line":"    message \u003d _(\"Ports cannot be specified for protocol %(protocol)s. \""},{"line_number":45,"context_line":"                \"Ports are only supported for \""},{"line_number":46,"context_line":"                \"TCP, UDP, UDPLITE, SCTP and DCCP.\")"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class SecurityGroupInvalidPortValue(exceptions.InvalidInput):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_6cc6619d","line":46,"range":{"start_line":46,"start_character":16,"end_line":46,"end_character":50},"updated":"2019-03-11 20:30:30.000000000","message":"Maybe You can use list IPTABLES_PORT_PROTOCOLS here?","commit_id":"051422f8cba193405a4768a9808c9e290165e23f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6366c7dac22ae3457b75d9be8e0bb93bc6d099bd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"class SecurityGroupInvalidProtocolForPort(exceptions.InvalidInput):"},{"line_number":44,"context_line":"    message \u003d _(\"Ports cannot be specified for protocol %(protocol)s. \""},{"line_number":45,"context_line":"                \"Ports are only supported for \""},{"line_number":46,"context_line":"                \"TCP, UDP, UDPLITE, SCTP and DCCP.\")"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class SecurityGroupInvalidPortValue(exceptions.InvalidInput):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_00ed2124","line":46,"range":{"start_line":46,"start_character":16,"end_line":46,"end_character":50},"in_reply_to":"5fc1f717_6cc6619d","updated":"2019-03-11 22:13:20.000000000","message":"Yes, I can make it more generic (no iptables prefix) and put it in the constants file.","commit_id":"051422f8cba193405a4768a9808c9e290165e23f"}],"neutron/tests/unit/agent/linux/test_iptables_firewall.py":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"47338f250cf6f82e8cf1dbda8307f3cc21b5fb1d","unresolved":false,"context_lines":[{"line_number":440,"context_line":"            top\u003dFalse, comment\u003dNone)"},{"line_number":441,"context_line":"        egress \u003d None"},{"line_number":442,"context_line":"        self._test_prepare_port_filter(rule, ingress, egress)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    def test_filter_ipv4_ingress_protocol_blank(self):"},{"line_number":445,"context_line":"        rule \u003d {\u0027ethertype\u0027: \u0027IPv4\u0027,"},{"line_number":446,"context_line":"                \u0027direction\u0027: \u0027ingress\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_e341cd3a","line":443,"updated":"2019-03-13 21:28:54.000000000","message":"I\u0027d love to see a udplite negative test, since it\u0027s an oddball.","commit_id":"f49a203383311c97d1e2d8de7eac9c17c0cd4516"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e5e102134e0a993e8c89b648b99094ebab0f36a8","unresolved":false,"context_lines":[{"line_number":440,"context_line":"            top\u003dFalse, comment\u003dNone)"},{"line_number":441,"context_line":"        egress \u003d None"},{"line_number":442,"context_line":"        self._test_prepare_port_filter(rule, ingress, egress)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    def test_filter_ipv4_ingress_protocol_blank(self):"},{"line_number":445,"context_line":"        rule \u003d {\u0027ethertype\u0027: \u0027IPv4\u0027,"},{"line_number":446,"context_line":"                \u0027direction\u0027: \u0027ingress\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_2e0fac37","line":443,"in_reply_to":"5fc1f717_63f15d6b","updated":"2019-03-14 14:48:24.000000000","message":"Hmm, this section is all about testing _prepare_port_filter() generates the correct iptables output, there isn\u0027t really a way to make a negative test, plus there is no way to have a negative UDPlite test through this code path.  So I\u0027m going to punt on this one.","commit_id":"f49a203383311c97d1e2d8de7eac9c17c0cd4516"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"58968743ac9d8e73eeba3076e28fdd7b4fc322b6","unresolved":false,"context_lines":[{"line_number":440,"context_line":"            top\u003dFalse, comment\u003dNone)"},{"line_number":441,"context_line":"        egress \u003d None"},{"line_number":442,"context_line":"        self._test_prepare_port_filter(rule, ingress, egress)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    def test_filter_ipv4_ingress_protocol_blank(self):"},{"line_number":445,"context_line":"        rule \u003d {\u0027ethertype\u0027: \u0027IPv4\u0027,"},{"line_number":446,"context_line":"                \u0027direction\u0027: \u0027ingress\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_63f15d6b","line":443,"in_reply_to":"5fc1f717_e341cd3a","updated":"2019-03-13 22:09:30.000000000","message":"Sure, I can cook one up.","commit_id":"f49a203383311c97d1e2d8de7eac9c17c0cd4516"}],"neutron/tests/unit/extensions/test_securitygroup.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"abbadef8856f925e1bb25ab0e3dc4d14c58ad2ab","unresolved":false,"context_lines":[{"line_number":1281,"context_line":"                    const.PROTO_NAME_TCP, \u002722\u0027, None)"},{"line_number":1282,"context_line":"                res \u003d self._create_security_group_rule(self.fmt, rule)"},{"line_number":1283,"context_line":"                self.deserialize(self.fmt, res)"},{"line_number":1284,"context_line":"                self.assertEqual(webob.exc.HTTPCreated.code, res.status_int)"},{"line_number":1285,"context_line":""},{"line_number":1286,"context_line":"    def test_create_security_group_rule_port_range_max_only(self):"},{"line_number":1287,"context_line":"        name \u003d \u0027webservers\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_39ec18f2","line":1284,"updated":"2019-03-12 00:57:55.000000000","message":"This test and the one at L621 are almost identical now that we\u0027ve change to a valid protocol for ports, so maybe that one needs to change to stay at 111 and be an invalid request.","commit_id":"acfa054b168f30a512a279057e1bb6ed6f2b97a4"}]}
