)]}'
{".zuul.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5337f3d4ecb7cf2e38df6ebea59102ee6c53b1ab","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            ovs:"},{"line_number":125,"context_line":"              ovsdb_timeout: 30"},{"line_number":126,"context_line":"              of_request_timeout: 30"},{"line_number":127,"context_line":"              of_connect_timeout: 120"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"- job:"},{"line_number":130,"context_line":"    name: neutron-functional-python27"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_51fd34af","line":127,"updated":"2019-03-12 11:35:28.000000000","message":"I\u0027m not sure if that will have effect in functional tests. Maybe better would be to override those values in e.g. https://github.com/openstack/neutron/blob/master/neutron/tests/functional/base.py module","commit_id":"3799b4a0f6a0f66dd5c65ca933ce294129b03f51"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0513f49f939ac1d47345ddee41e80fb6a247d7ac","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            ovs:"},{"line_number":125,"context_line":"              ovsdb_timeout: 30"},{"line_number":126,"context_line":"              of_request_timeout: 30"},{"line_number":127,"context_line":"              of_connect_timeout: 120"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"- job:"},{"line_number":130,"context_line":"    name: neutron-functional-python27"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_d1e924b7","line":127,"in_reply_to":"5fc1f717_51fd34af","updated":"2019-03-12 11:45:44.000000000","message":"Ok","commit_id":"3799b4a0f6a0f66dd5c65ca933ce294129b03f51"}],"neutron/tests/functional/base.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"b500fedbf77241b60af0e111d84d649e273dd26c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.agent.linux import utils"},{"line_number":23,"context_line":"from neutron.conf.agent import common as config"},{"line_number":24,"context_line":"from neutron.conf.agent import ovs_conf"},{"line_number":25,"context_line":"from neutron.conf.plugins.ml2.drivers import ovs_conf as ml2_ovs_conf"},{"line_number":26,"context_line":"from neutron.tests import base"},{"line_number":27,"context_line":"from neutron.tests.common import base as common_base"},{"line_number":28,"context_line":"from neutron.tests.common import helpers"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_f3f33a9e","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":69},"updated":"2019-03-21 21:31:35.000000000","message":"pep8 is flagging this as an unused import","commit_id":"9853c8bef1dda7500a328798423f5d96caceff4b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"884e5ffbf25a1ae049d48c1c52a93e6cea1192ff","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.agent.linux import utils"},{"line_number":23,"context_line":"from neutron.conf.agent import common as config"},{"line_number":24,"context_line":"from neutron.conf.agent import ovs_conf"},{"line_number":25,"context_line":"from neutron.conf.plugins.ml2.drivers import ovs_conf as ml2_ovs_conf"},{"line_number":26,"context_line":"from neutron.tests import base"},{"line_number":27,"context_line":"from neutron.tests.common import base as common_base"},{"line_number":28,"context_line":"from neutron.tests.common import helpers"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_b2be03fd","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":69},"in_reply_to":"5fc1f717_f3f33a9e","updated":"2019-03-22 09:56:52.000000000","message":"Done","commit_id":"9853c8bef1dda7500a328798423f5d96caceff4b"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"b500fedbf77241b60af0e111d84d649e273dd26c","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @staticmethod"},{"line_number":92,"context_line":"    def _override_default_config():"},{"line_number":93,"context_line":"        # NOTE(ralonsoh): once https://review.openstack.org/#/c/641681/ is"},{"line_number":94,"context_line":"        # merged, we should increase the default value of those new parameters."},{"line_number":95,"context_line":"        ovs_agent_opts \u003d [(\u0027ovsdb_timeout\u0027, 30, \u0027OVS\u0027)]"},{"line_number":96,"context_line":"        ovs_agent_decorator \u003d config_decorator("},{"line_number":97,"context_line":"            ovs_conf.register_ovs_agent_opts, ovs_agent_opts)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_ae046ec7","line":94,"range":{"start_line":93,"start_character":0,"end_line":94,"end_character":79},"updated":"2019-03-21 21:31:35.000000000","message":"Thanks for this note.","commit_id":"9853c8bef1dda7500a328798423f5d96caceff4b"}],"neutron/tests/unit/tests/functional/__init__.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3646734a65d5bde037b286194d33fb70b7f706aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5fc1f717_f1b3f208","updated":"2019-03-12 21:12:15.000000000","message":"is this change of file mode intentional ?","commit_id":"5da10dfc018c9a8a43c6e9b62592e392a180abe0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"860df966525e5b7abf52c46c93002cb9a330be0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5fc1f717_ad30a2e9","in_reply_to":"5fc1f717_f1b3f208","updated":"2019-03-13 09:25:45.000000000","message":"Yes and no. This is because I\u0027ve created this file in this patch, the same as https://review.openstack.org/#/c/642721/4/neutron/tests/unit/tests/functional/test_base.py","commit_id":"5da10dfc018c9a8a43c6e9b62592e392a180abe0"}],"neutron/tests/unit/tests/functional/test_base.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3646734a65d5bde037b286194d33fb70b7f706aa","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def test_override_bool(self):"},{"line_number":68,"context_line":"        opts \u003d [(\u0027bool_opt\u0027, False, \u0027testgroup\u0027)]"},{"line_number":69,"context_line":"        self._mock_register_options(opts)"},{"line_number":70,"context_line":"        self.assertEqual(\u0027default_value\u0027, cfg.CONF.testgroup.str_opt)"},{"line_number":71,"context_line":"        self.assertEqual(\u00271\u0027, cfg.CONF.testgroup.int_opt)"},{"line_number":72,"context_line":"        self.assertFalse(cfg.CONF.testgroup.bool_opt)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_91c06e2c","line":71,"range":{"start_line":70,"start_character":8,"end_line":71,"end_character":57},"updated":"2019-03-12 21:12:15.000000000","message":"is this should be done repeatedly in every test ?","commit_id":"5da10dfc018c9a8a43c6e9b62592e392a180abe0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"860df966525e5b7abf52c46c93002cb9a330be0d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def test_override_bool(self):"},{"line_number":68,"context_line":"        opts \u003d [(\u0027bool_opt\u0027, False, \u0027testgroup\u0027)]"},{"line_number":69,"context_line":"        self._mock_register_options(opts)"},{"line_number":70,"context_line":"        self.assertEqual(\u0027default_value\u0027, cfg.CONF.testgroup.str_opt)"},{"line_number":71,"context_line":"        self.assertEqual(\u00271\u0027, cfg.CONF.testgroup.int_opt)"},{"line_number":72,"context_line":"        self.assertFalse(cfg.CONF.testgroup.bool_opt)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_ad450245","line":71,"range":{"start_line":70,"start_character":8,"end_line":71,"end_character":57},"in_reply_to":"5fc1f717_91c06e2c","updated":"2019-03-13 09:25:45.000000000","message":"yes if we want to test that only one variable is modified in each test","commit_id":"5da10dfc018c9a8a43c6e9b62592e392a180abe0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3646734a65d5bde037b286194d33fb70b7f706aa","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                   \u0027register_some_options\u0027, new\u003dcfg_decorator).start()"},{"line_number":51,"context_line":"        register_some_options()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_override_str(self):"},{"line_number":54,"context_line":"        opts \u003d [(\u0027str_opt\u0027, \u0027another_value\u0027, \u0027testgroup\u0027)]"},{"line_number":55,"context_line":"        self._mock_register_options(opts)"},{"line_number":56,"context_line":"        self.assertEqual(\u0027another_value\u0027, cfg.CONF.testgroup.str_opt)"},{"line_number":57,"context_line":"        self.assertEqual(\u00271\u0027, cfg.CONF.testgroup.int_opt)"},{"line_number":58,"context_line":"        self.assertTrue(cfg.CONF.testgroup.bool_opt)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_override_int(self):"},{"line_number":61,"context_line":"        opts \u003d [(\u0027int_opt\u0027, 123, \u0027testgroup\u0027)]"},{"line_number":62,"context_line":"        self._mock_register_options(opts)"},{"line_number":63,"context_line":"        self.assertEqual(\u0027default_value\u0027, cfg.CONF.testgroup.str_opt)"},{"line_number":64,"context_line":"        self.assertEqual(\u0027123\u0027, cfg.CONF.testgroup.int_opt)"},{"line_number":65,"context_line":"        self.assertTrue(True, cfg.CONF.testgroup.bool_opt)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_override_bool(self):"},{"line_number":68,"context_line":"        opts \u003d [(\u0027bool_opt\u0027, False, \u0027testgroup\u0027)]"},{"line_number":69,"context_line":"        self._mock_register_options(opts)"},{"line_number":70,"context_line":"        self.assertEqual(\u0027default_value\u0027, cfg.CONF.testgroup.str_opt)"},{"line_number":71,"context_line":"        self.assertEqual(\u00271\u0027, cfg.CONF.testgroup.int_opt)"},{"line_number":72,"context_line":"        self.assertFalse(cfg.CONF.testgroup.bool_opt)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_71d8621d","line":72,"range":{"start_line":53,"start_character":4,"end_line":72,"end_character":53},"updated":"2019-03-12 21:12:15.000000000","message":"IMO, this is unnecessary complexity being added without much value, while a single test would be enough !","commit_id":"5da10dfc018c9a8a43c6e9b62592e392a180abe0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"860df966525e5b7abf52c46c93002cb9a330be0d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                   \u0027register_some_options\u0027, new\u003dcfg_decorator).start()"},{"line_number":51,"context_line":"        register_some_options()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_override_str(self):"},{"line_number":54,"context_line":"        opts \u003d [(\u0027str_opt\u0027, \u0027another_value\u0027, \u0027testgroup\u0027)]"},{"line_number":55,"context_line":"        self._mock_register_options(opts)"},{"line_number":56,"context_line":"        self.assertEqual(\u0027another_value\u0027, cfg.CONF.testgroup.str_opt)"},{"line_number":57,"context_line":"        self.assertEqual(\u00271\u0027, cfg.CONF.testgroup.int_opt)"},{"line_number":58,"context_line":"        self.assertTrue(cfg.CONF.testgroup.bool_opt)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_override_int(self):"},{"line_number":61,"context_line":"        opts \u003d [(\u0027int_opt\u0027, 123, \u0027testgroup\u0027)]"},{"line_number":62,"context_line":"        self._mock_register_options(opts)"},{"line_number":63,"context_line":"        self.assertEqual(\u0027default_value\u0027, cfg.CONF.testgroup.str_opt)"},{"line_number":64,"context_line":"        self.assertEqual(\u0027123\u0027, cfg.CONF.testgroup.int_opt)"},{"line_number":65,"context_line":"        self.assertTrue(True, cfg.CONF.testgroup.bool_opt)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_override_bool(self):"},{"line_number":68,"context_line":"        opts \u003d [(\u0027bool_opt\u0027, False, \u0027testgroup\u0027)]"},{"line_number":69,"context_line":"        self._mock_register_options(opts)"},{"line_number":70,"context_line":"        self.assertEqual(\u0027default_value\u0027, cfg.CONF.testgroup.str_opt)"},{"line_number":71,"context_line":"        self.assertEqual(\u00271\u0027, cfg.CONF.testgroup.int_opt)"},{"line_number":72,"context_line":"        self.assertFalse(cfg.CONF.testgroup.bool_opt)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_4d781e8f","line":72,"range":{"start_line":53,"start_character":4,"end_line":72,"end_character":53},"in_reply_to":"5fc1f717_71d8621d","updated":"2019-03-13 09:25:45.000000000","message":"What I\u0027m testing in each test is the modification of only one variable. I\u0027ll squash them.","commit_id":"5da10dfc018c9a8a43c6e9b62592e392a180abe0"}]}