)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"963124c7201b2230f670e02da31bdcdb79e263b0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Testing] Random IP for concurrent create pf and update_port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Maybe another IP collision..."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I157e08288765f1716b4cb12bb2e176760db806c0"},{"line_number":12,"context_line":"Closes-Bug: #1818334"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_d03e82b8","line":9,"range":{"start_line":9,"start_character":14,"end_line":9,"end_character":26},"updated":"2019-03-18 23:51:39.000000000","message":"Yes, it is.\n\n\n{0} neutron.tests.functional.services.portforwarding.test_port_forwarding.PortForwardingTestCase.test_concurrent_create_port_forwarding_update_port [14.705509s] ... FAILED\n\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n    b\u0027Traceback (most recent call last):\u0027\n    b\u0027  File \"/opt/stack/neutron/neutron/tests/base.py\", line 174, in func\u0027\n    b\u0027    return f(self, *args, **kwargs)\u0027\n    b\u0027  File \"/opt/stack/neutron/neutron/tests/functional/services/portforwarding/test_port_forwarding.py\", line 459, in test_concurrent_create_port_forwarding_update_port\u0027\n    b\"    self.context, floatingip_id\u003dself.fip[\u0027id\u0027]))\"\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/testtools/testcase.py\", line 411, in assertEqual\u0027\n    b\u0027    self.assertThat(observed, matcher, message)\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/testtools/testcase.py\", line 498, in assertThat\u0027\n    b\u0027    raise mismatch_error\u0027\n    b\u0027testtools.matchers._impl.MismatchError: !\u003d:\u0027\n    b\u0027reference \u003d []\u0027\n    b\"actual    \u003d [{\u0027external_port\u0027: 2225,\"\n    b\"  \u0027floating_ip_address\u0027: \u0027172.24.2.226\u0027,\"\n    b\"  \u0027floatingip_id\u0027: \u002748ce20ea-26d6-460d-ac76-427842f06ef3\u0027,\"\n    b\"  \u0027id\u0027: \u00273404d24b-7f2a-4f4f-ac42-4003073138d8\u0027,\"\n    b\"  \u0027internal_ip_address\u0027: \u002710.0.0.2\u0027,\"\n    b\"  \u0027internal_port\u0027: 25,\"\n    b\"  \u0027internal_port_id\u0027: \u0027f4b2e570-e2c1-454e-818c-afc8d0f2734c\u0027,\"\n    b\"  \u0027protocol\u0027: \u0027tcp\u0027,\"\n    b\"  \u0027router_id\u0027: \u0027bde8ba5d-278b-4f6e-958f-9daa41d0ce41\u0027}]\"\n    b\u0027\u0027\n    b\u0027\u0027\n\nCaptured stdout:\n~~~~~~~~~~~~~~~~\n    b\u0027\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003dold 10.0.0.2\u0027\n    b\u0027\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003dnew 10.0.0.2\u0027","commit_id":"c79afb5d76bf323d53e0f43e6ea5bdf1a0a28b7b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"78aa24be5e474ef8f4b2342a7c879bc38b0bf821","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Port forwarding test port IP should be specified, otherwise IP"},{"line_number":10,"context_line":"collision may happen between new port IP and router interface IP."},{"line_number":11,"context_line":"Or sometimes, port new ip and old IP are same."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"After this patch, the port new IP will be randomly choiced from"},{"line_number":14,"context_line":"the subset without [old_port_ips, router_interface_ips]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_0a75aacc","line":11,"range":{"start_line":11,"start_character":23,"end_line":11,"end_character":25},"updated":"2019-03-19 13:26:29.000000000","message":"nit: IP :)","commit_id":"9bcfdb9245283870a9632f926f726eb2d570a1f7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ddb14172f1c5db24168731831f6cdb528104a568","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Port forwarding test port IP should be specified, otherwise IP"},{"line_number":10,"context_line":"collision may happen between new port IP and router interface IP."},{"line_number":11,"context_line":"Or sometimes, port new ip and old IP are same."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"After this patch, the port new IP will be randomly choiced from"},{"line_number":14,"context_line":"the subset without [old_port_ips, router_interface_ips]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_fb959289","line":11,"range":{"start_line":11,"start_character":23,"end_line":11,"end_character":25},"in_reply_to":"5fc1f717_0a75aacc","updated":"2019-03-19 14:58:37.000000000","message":"Done","commit_id":"9bcfdb9245283870a9632f926f726eb2d570a1f7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"78aa24be5e474ef8f4b2342a7c879bc38b0bf821","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Or sometimes, port new ip and old IP are same."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"After this patch, the port new IP will be randomly choiced from"},{"line_number":14,"context_line":"the subset without [old_port_ips, router_interface_ips]."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially reverts commit 414bdd4c5997886c97d0e3a0b19c684dafeabb7a."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_8a619a14","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":10},"updated":"2019-03-19 13:26:29.000000000","message":"s/subnet","commit_id":"9bcfdb9245283870a9632f926f726eb2d570a1f7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6d32c1d2bb41f2f8028340ddf39cc81449295025","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Or sometimes, port new ip and old IP are same."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"After this patch, the port new IP will be randomly choiced from"},{"line_number":14,"context_line":"the subset without [old_port_ips, router_interface_ips]."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially reverts commit 414bdd4c5997886c97d0e3a0b19c684dafeabb7a."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_45e5e5db","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":10},"in_reply_to":"5fc1f717_8a619a14","updated":"2019-03-19 13:48:53.000000000","message":":). But actually, it is subset. I mean IP set without those used IPs.","commit_id":"9bcfdb9245283870a9632f926f726eb2d570a1f7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4c87807a7619ead38381a39c40b9009d304b31db","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Random IP for concurrent create pf and update_port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Port forwarding test port IP should be specified, otherwise IP"},{"line_number":10,"context_line":"collision may happen between new port IP and router interface IP."},{"line_number":11,"context_line":"Or sometimes, port new IP and old IP are same."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"After this patch, the port new IP will be randomly choiced from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5fc1f717_eee7f245","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":9},"updated":"2019-03-20 15:22:25.000000000","message":"Unfortunately error still can be seen:\n\n{0} neutron.tests.functional.services.portforwarding.test_port_forwarding.PortForwardingTestCase.test_concurrent_create_port_forwarding_update_port [13.879313s] ... FAILED\n\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n    b\u0027Traceback (most recent call last):\u0027\n    b\u0027  File \"/opt/stack/neutron/neutron/tests/base.py\", line 174, in func\u0027\n    b\u0027    return f(self, *args, **kwargs)\u0027\n    b\u0027  File \"/opt/stack/neutron/neutron/tests/functional/services/portforwarding/test_port_forwarding.py\", line 474, in test_concurrent_create_port_forwarding_update_port\u0027\n    b\u0027    self._simulate_concurrent_requests_process_and_raise(funcs, args_list)\u0027\n    b\u0027  File \"/opt/stack/neutron/neutron/tests/functional/services/portforwarding/test_port_forwarding.py\", line 419, in _simulate_concurrent_requests_process_and_raise\u0027\n    b\u0027    raise e\u0027\n    b\u0027  File \"/opt/stack/neutron/neutron/tests/functional/services/portforwarding/test_port_forwarding.py\", line 394, in run\u0027\n    b\u0027    func(*func_args)\u0027\n    b\u0027  File \"/opt/stack/neutron/neutron/tests/functional/services/portforwarding/test_port_forwarding.py\", line 65, in _update_port\u0027\n    b\"    self.context, port_id, {\u0027port\u0027: update_info})\"\n    b\u0027  File \"/opt/stack/neutron/neutron/common/utils.py\", line 668, in inner\u0027\n    b\u0027    return f(self, context, *args, **kwargs)\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/neutron_lib/db/api.py\", line 233, in wrapped\u0027\n    b\u0027    return method(*args, **kwargs)\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/neutron_lib/db/api.py\", line 139, in wrapped\u0027\n    b\"    setattr(e, \u0027_RETRY_EXCEEDED\u0027, True)\"\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/oslo_utils/excutils.py\", line 220, in __exit__\u0027\n    b\u0027    self.force_reraise()\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/oslo_utils/excutils.py\", line 196, in force_reraise\u0027\n    b\u0027    six.reraise(self.type_, self.value, self.tb)\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/six.py\", line 693, in reraise\u0027\n    b\u0027    raise value\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/neutron_lib/db/api.py\", line 135, in wrapped\u0027\n    b\u0027    return f(*args, **kwargs)\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/oslo_db/api.py\", line 154, in wrapper\u0027\n    b\u0027    ectxt.value \u003d e.inner_exc\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/oslo_utils/excutils.py\", line 220, in __exit__\u0027\n    b\u0027    self.force_reraise()\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/oslo_utils/excutils.py\", line 196, in force_reraise\u0027\n    b\u0027    six.reraise(self.type_, self.value, self.tb)\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/six.py\", line 693, in reraise\u0027\n    b\u0027    raise value\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/oslo_db/api.py\", line 142, in wrapper\u0027\n    b\u0027    return f(*args, **kwargs)\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/neutron_lib/db/api.py\", line 183, in wrapped\u0027\n    b\u0027    LOG.debug(\"Retry wrapper got retriable exception: %s\", e)\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/oslo_utils/excutils.py\", line 220, in __exit__\u0027\n    b\u0027    self.force_reraise()\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/oslo_utils/excutils.py\", line 196, in force_reraise\u0027\n    b\u0027    six.reraise(self.type_, self.value, self.tb)\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/six.py\", line 693, in reraise\u0027\n    b\u0027    raise value\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/neutron_lib/db/api.py\", line 179, in wrapped\u0027\n    b\u0027    return f(*dup_args, **dup_kwargs)\u0027\n    b\u0027  File \"/opt/stack/neutron/neutron/plugins/ml2/plugin.py\", line 1422, in update_port\u0027\n    b\u0027    port)\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/neutron_lib/db/api.py\", line 233, in wrapped\u0027\n    b\u0027    return method(*args, **kwargs)\u0027\n    b\u0027  File \"/opt/stack/neutron/neutron/db/db_base_plugin_v2.py\", line 1496, in update_port\u0027\n    b\u0027    new_port\u003dnew_port)\u0027\n    b\u0027  File \"/opt/stack/neutron/neutron/db/ipam_backend_mixin.py\", line 655, in update_port\u0027\n    b\"    new_port.get(\u0027mac_address\u0027))\"\n    b\u0027  File \"/opt/stack/neutron/neutron/db/ipam_pluggable_backend.py\", line 417, in update_port_with_ips\u0027\n    b\u0027    new_mac)\u0027\n    b\u0027  File \"/opt/stack/neutron/neutron/db/ipam_pluggable_backend.py\", line 367, in _update_ips_for_port\u0027\n    b\u0027    port, to_add)\u0027\n    b\u0027  File \"/opt/stack/neutron/neutron/db/ipam_pluggable_backend.py\", line 164, in _ipam_allocate_ips\u0027\n    b\u0027    \"external system for %s\", addresses)\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/oslo_utils/excutils.py\", line 220, in __exit__\u0027\n    b\u0027    self.force_reraise()\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/oslo_utils/excutils.py\", line 196, in force_reraise\u0027\n    b\u0027    six.reraise(self.type_, self.value, self.tb)\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/six.py\", line 693, in reraise\u0027\n    b\u0027    raise value\u0027\n    b\u0027  File \"/opt/stack/neutron/neutron/db/ipam_pluggable_backend.py\", line 138, in _ipam_allocate_ips\u0027\n    b\u0027    ip_address, subnet_id \u003d ipam_allocator.allocate(ip_request)\u0027\n    b\u0027  File \"/opt/stack/neutron/neutron/ipam/subnet_alloc.py\", line 237, in allocate\u0027\n    b\u0027    return ipam_subnet.allocate(address_request), subnet_id\u0027\n    b\u0027  File \"/opt/stack/neutron/neutron/ipam/drivers/neutrondb_ipam/driver.py\", line 243, in allocate\u0027\n    b\u0027    self._verify_ip(self._context, ip_address)\u0027\n    b\u0027  File \"/opt/stack/neutron/neutron/ipam/drivers/neutrondb_ipam/driver.py\", line 148, in _verify_ip\u0027\n    b\u0027    ip\u003dip_address)\u0027\n    b\u0027neutron.ipam.exceptions.IpAddressAlreadyAllocated: IP address 10.0.0.186 already allocated in subnet b219e90f-d85e-4c30-b4ae-9510d218769a\u0027\n    b\u0027\u0027\n\nCaptured stdout:\n~~~~~~~~~~~~~~~~\n    b\u0027\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003dold 10.0.0.173\u0027\n    b\u0027\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003dnew 10.0.0.186\u0027","commit_id":"f440eb371e0cda925b475d623f27b74b3ca09865"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4c87807a7619ead38381a39c40b9009d304b31db","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Port forwarding test port IP should be specified, otherwise IP"},{"line_number":10,"context_line":"collision may happen between new port IP and router interface IP."},{"line_number":11,"context_line":"Or sometimes, port new IP and old IP are same."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"After this patch, the port new IP will be randomly choiced from"},{"line_number":14,"context_line":"the subset without [old_port_ips, router_interface_ips]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5fc1f717_aef1ea03","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":36},"updated":"2019-03-20 15:22:25.000000000","message":"And here:\n\n{0} neutron.tests.functional.services.portforwarding.test_port_forwarding.PortForwardingTestCase.test_concurrent_create_port_forwarding_update_port [13.920212s] ... FAILED\n\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n    b\u0027Traceback (most recent call last):\u0027\n    b\u0027  File \"/opt/stack/neutron/neutron/tests/base.py\", line 174, in func\u0027\n    b\u0027    return f(self, *args, **kwargs)\u0027\n    b\u0027  File \"/opt/stack/neutron/neutron/tests/functional/services/portforwarding/test_port_forwarding.py\", line 476, in test_concurrent_create_port_forwarding_update_port\u0027\n    b\"    self.context, floatingip_id\u003dself.fip[\u0027id\u0027]))\"\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/testtools/testcase.py\", line 411, in assertEqual\u0027\n    b\u0027    self.assertThat(observed, matcher, message)\u0027\n    b\u0027  File \"/opt/stack/neutron/.tox/dsvm-functional/lib/python3.4/site-packages/testtools/testcase.py\", line 498, in assertThat\u0027\n    b\u0027    raise mismatch_error\u0027\n    b\u0027testtools.matchers._impl.MismatchError: !\u003d:\u0027\n    b\u0027reference \u003d []\u0027\n    b\"actual    \u003d [{\u0027external_port\u0027: 2225,\"\n    b\"  \u0027floating_ip_address\u0027: \u0027172.24.2.250\u0027,\"\n    b\"  \u0027floatingip_id\u0027: \u0027a17874b1-7d71-4c8f-bdb7-066297d3fa72\u0027,\"\n    b\"  \u0027id\u0027: \u0027fee2f4d4-3054-41a8-bc05-4f6e58fbb683\u0027,\"\n    b\"  \u0027internal_ip_address\u0027: \u002710.0.0.166\u0027,\"\n    b\"  \u0027internal_port\u0027: 25,\"\n    b\"  \u0027internal_port_id\u0027: \u0027c25f88ef-6564-45f0-b918-19023b2f9d48\u0027,\"\n    b\"  \u0027protocol\u0027: \u0027tcp\u0027,\"\n    b\"  \u0027router_id\u0027: \u0027dafd94e2-47ac-4d6a-9142-315e90c30b9a\u0027}]\"\n    b\u0027\u0027\n    b\u0027\u0027\n\nCaptured stdout:\n~~~~~~~~~~~~~~~~\n    b\u0027\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003dold 10.0.0.166\u0027\n    b\u0027\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003dnew 10.0.0.166\u0027","commit_id":"f440eb371e0cda925b475d623f27b74b3ca09865"}],"neutron/tests/functional/services/portforwarding/test_port_forwarding.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"78aa24be5e474ef8f4b2342a7c879bc38b0bf821","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            filters\u003d{\"network_id\": [self.net[\u0027id\u0027]]})"},{"line_number":95,"context_line":"        net_port_ips \u003d []"},{"line_number":96,"context_line":"        for p in net_ports:"},{"line_number":97,"context_line":"            net_port_ips.append(p[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"},{"line_number":98,"context_line":"        return net_port_ips"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _prepare_env(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_4a9df208","line":97,"updated":"2019-03-19 13:26:29.000000000","message":"list comprehension?\n\nnet_port_ips \u003d [p[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027] for p in net_ports]","commit_id":"9bcfdb9245283870a9632f926f726eb2d570a1f7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ddb14172f1c5db24168731831f6cdb528104a568","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            filters\u003d{\"network_id\": [self.net[\u0027id\u0027]]})"},{"line_number":95,"context_line":"        net_port_ips \u003d []"},{"line_number":96,"context_line":"        for p in net_ports:"},{"line_number":97,"context_line":"            net_port_ips.append(p[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"},{"line_number":98,"context_line":"        return net_port_ips"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _prepare_env(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_fb48322f","line":97,"in_reply_to":"5fc1f717_4a9df208","updated":"2019-03-19 14:58:37.000000000","message":"Done","commit_id":"9bcfdb9245283870a9632f926f726eb2d570a1f7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8bdaa350b39375abb32f82fb508fc6181b2f5b0d","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        self._add_router_interface(self.router[\u0027id\u0027], self.subnet[\u0027id\u0027])"},{"line_number":113,"context_line":"        self.fip \u003d self._create_floatingip(self.ext_net[\u0027id\u0027])"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        self.port_ip \u003d self._find_ip_address("},{"line_number":116,"context_line":"            self.subnet, exclude\u003dself._get_network_port_ips(), is_random\u003dTrue)"},{"line_number":117,"context_line":"        self.port \u003d self._create_port("},{"line_number":118,"context_line":"            self.fmt, self.net[\u0027id\u0027],"},{"line_number":119,"context_line":"            fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnet[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_df042281","line":116,"range":{"start_line":115,"start_character":8,"end_line":116,"end_character":78},"updated":"2019-03-20 17:09:14.000000000","message":"Do we need this? When the port is created, there should never been an IP collision in the same network. We don\u0027t need this.","commit_id":"f440eb371e0cda925b475d623f27b74b3ca09865"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7ea0f36719bffe41c47d697a6f67aa4167a389bb","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        self._add_router_interface(self.router[\u0027id\u0027], self.subnet[\u0027id\u0027])"},{"line_number":113,"context_line":"        self.fip \u003d self._create_floatingip(self.ext_net[\u0027id\u0027])"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        self.port_ip \u003d self._find_ip_address("},{"line_number":116,"context_line":"            self.subnet, exclude\u003dself._get_network_port_ips(), is_random\u003dTrue)"},{"line_number":117,"context_line":"        self.port \u003d self._create_port("},{"line_number":118,"context_line":"            self.fmt, self.net[\u0027id\u0027],"},{"line_number":119,"context_line":"            fixed_ips\u003d[{\u0027subnet_id\u0027: self.subnet[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_6d73f64e","line":116,"range":{"start_line":115,"start_character":8,"end_line":116,"end_character":78},"in_reply_to":"5fc1f717_df042281","updated":"2019-03-21 10:57:18.000000000","message":"My thought is to let the port IP to be predefined, then we can trace/log the IP change.","commit_id":"f440eb371e0cda925b475d623f27b74b3ca09865"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8bdaa350b39375abb32f82fb508fc6181b2f5b0d","unresolved":false,"context_lines":[{"line_number":461,"context_line":"    def test_concurrent_create_port_forwarding_update_port(self):"},{"line_number":462,"context_line":"        new_ip \u003d self._find_ip_address("},{"line_number":463,"context_line":"            self.subnet,"},{"line_number":464,"context_line":"            exclude\u003dself._get_network_port_ips(),"},{"line_number":465,"context_line":"            is_random\u003dTrue)"},{"line_number":466,"context_line":"        funcs \u003d [self.pf_plugin.create_floatingip_port_forwarding,"},{"line_number":467,"context_line":"                 self._update_port]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_ff09de94","line":464,"range":{"start_line":464,"start_character":20,"end_line":464,"end_character":48},"updated":"2019-03-20 17:09:14.000000000","message":"nit: I think here is ok to directly write the port IP and the router IP, without querying the DB","commit_id":"f440eb371e0cda925b475d623f27b74b3ca09865"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7ea0f36719bffe41c47d697a6f67aa4167a389bb","unresolved":false,"context_lines":[{"line_number":461,"context_line":"    def test_concurrent_create_port_forwarding_update_port(self):"},{"line_number":462,"context_line":"        new_ip \u003d self._find_ip_address("},{"line_number":463,"context_line":"            self.subnet,"},{"line_number":464,"context_line":"            exclude\u003dself._get_network_port_ips(),"},{"line_number":465,"context_line":"            is_random\u003dTrue)"},{"line_number":466,"context_line":"        funcs \u003d [self.pf_plugin.create_floatingip_port_forwarding,"},{"line_number":467,"context_line":"                 self._update_port]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_6dec56f3","line":464,"range":{"start_line":464,"start_character":20,"end_line":464,"end_character":48},"in_reply_to":"5fc1f717_ff09de94","updated":"2019-03-21 10:57:18.000000000","message":"Router ports may be varied, now it is \u0027dvr\u0027, the ports\u0027 device_owner will be \"network:router_interface_distributed\", \"network:router_centralized_snat\". But maybe someday this case are going to be changed to none_dvr or ha, the router port IP addresses will also be changed. Currently we just get all the used IP from the network, it is easy to cover such used IP change case.","commit_id":"f440eb371e0cda925b475d623f27b74b3ca09865"}],"neutron/tests/unit/db/test_db_base_plugin_v2.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"78aa24be5e474ef8f4b2342a7c879bc38b0bf821","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            \"json\", 200, subnet[\u0027network_id\u0027]).json[\u0027ports\u0027]"},{"line_number":295,"context_line":"        used_ips \u003d set()"},{"line_number":296,"context_line":"        if exclude:"},{"line_number":297,"context_line":"            if isinstance(exclude, (list, set, tuple)):"},{"line_number":298,"context_line":"                used_ips \u003d set(exclude)"},{"line_number":299,"context_line":"            else:"},{"line_number":300,"context_line":"                used_ips.add(exclude)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_6abb0e72","line":297,"updated":"2019-03-19 13:26:29.000000000","message":"isn\u0027t exclude always a list?  can we just make the callers pass the same type?","commit_id":"9bcfdb9245283870a9632f926f726eb2d570a1f7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ddb14172f1c5db24168731831f6cdb528104a568","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            \"json\", 200, subnet[\u0027network_id\u0027]).json[\u0027ports\u0027]"},{"line_number":295,"context_line":"        used_ips \u003d set()"},{"line_number":296,"context_line":"        if exclude:"},{"line_number":297,"context_line":"            if isinstance(exclude, (list, set, tuple)):"},{"line_number":298,"context_line":"                used_ips \u003d set(exclude)"},{"line_number":299,"context_line":"            else:"},{"line_number":300,"context_line":"                used_ips.add(exclude)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_60700fde","line":297,"in_reply_to":"5fc1f717_6abb0e72","updated":"2019-03-19 14:58:37.000000000","message":"A more robust param, we can accept one IP addr here, right?","commit_id":"9bcfdb9245283870a9632f926f726eb2d570a1f7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8bdaa350b39375abb32f82fb508fc6181b2f5b0d","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        for pool in subnet[\u0027allocation_pools\u0027]:"},{"line_number":307,"context_line":"            ips_range \u003d netaddr.IPRange(pool[\u0027start\u0027], pool[\u0027end\u0027])"},{"line_number":308,"context_line":"            ip_list \u003d [ip for ip in ips_range if ip not in used_ips]"},{"line_number":309,"context_line":"            if len(ip_list) !\u003d 0:"},{"line_number":310,"context_line":"                if is_random:"},{"line_number":311,"context_line":"                    return str(random.choice(ip_list))"},{"line_number":312,"context_line":"                return str(ip_list[0])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_3f9a066e","line":309,"range":{"start_line":309,"start_character":12,"end_line":309,"end_character":33},"updated":"2019-03-20 17:09:14.000000000","message":"nit:\n  if ip_list:","commit_id":"f440eb371e0cda925b475d623f27b74b3ca09865"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"2c72e1d0fbfec7ffacd175d2aa82c2d1af6d0ae9","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        for pool in subnet[\u0027allocation_pools\u0027]:"},{"line_number":307,"context_line":"            ips_range \u003d netaddr.IPRange(pool[\u0027start\u0027], pool[\u0027end\u0027])"},{"line_number":308,"context_line":"            ip_list \u003d [str(ip) for ip in ips_range if str(ip) not in used_ips]"},{"line_number":309,"context_line":"            if ip_list:"},{"line_number":310,"context_line":"                if is_random:"},{"line_number":311,"context_line":"                    return random.choice(ip_list)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_daef39e7","line":308,"range":{"start_line":308,"start_character":35,"end_line":308,"end_character":37},"updated":"2019-03-21 15:49:48.000000000","message":"Yes, problem was solved by this. This IP here is not a string, it is an IpAddress object form netaddr. Every time that \"in\" or \"\u003d\u003d\" will not be true in the original code.","commit_id":"cd6bf8035d9a63e1803e6c763083d3aef0e9408c"}]}
