)]}'
{"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"a59ebb0198efbbb16579b4aa14fef6611d90c20b","unresolved":false,"context_lines":[{"line_number":700,"context_line":"                net_uuid, lvid, network_type, physical_network,"},{"line_number":701,"context_line":"                segmentation_id)"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"        LOG.info(\"Assigning %(vlan_id)s as local vlan for net-id\u003d%(net_uuid)s\","},{"line_number":704,"context_line":"                 {\u0027vlan_id\u0027: lvid, \u0027net_uuid\u0027: net_uuid})"},{"line_number":705,"context_line":"        return lvid"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"    def provision_local_vlan(self, net_uuid, network_type, physical_network,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_e054ff23","line":704,"range":{"start_line":703,"start_character":8,"end_line":704,"end_character":57},"updated":"2019-03-19 14:31:00.000000000","message":"These lines can moved to L721, since the process can be returned in L720.","commit_id":"22ce4419f1581a0d6ffcb1ea98ffc02a6fa9f3cb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"11a03881f26cedd3df61d24953d3a4409634c631","unresolved":false,"context_lines":[{"line_number":717,"context_line":"        \u0027\u0027\u0027"},{"line_number":718,"context_line":"        lvm \u003d self._add_local_vlan(net_uuid, network_type, physical_network,"},{"line_number":719,"context_line":"                                   segmentation_id)"},{"line_number":720,"context_line":"        lvid \u003d lvm.vlan"},{"line_number":721,"context_line":"        if not lvid:"},{"line_number":722,"context_line":"            return"},{"line_number":723,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_092b5882","line":720,"updated":"2019-04-02 07:58:28.000000000","message":"if You will not find lvid in L691 You will return None in L696 and then here it will raise exception. You should handle such case and return from this method then.","commit_id":"b6067f9adbcabacaceb6d045eef80fb3a8549049"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d3f2d7ca4615bf1401f61af46dd64ce121121cd7","unresolved":false,"context_lines":[{"line_number":717,"context_line":"        \u0027\u0027\u0027"},{"line_number":718,"context_line":"        lvm \u003d self._add_local_vlan(net_uuid, network_type, physical_network,"},{"line_number":719,"context_line":"                                   segmentation_id)"},{"line_number":720,"context_line":"        lvid \u003d lvm.vlan"},{"line_number":721,"context_line":"        if not lvid:"},{"line_number":722,"context_line":"            return"},{"line_number":723,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_49d5e0e4","line":720,"in_reply_to":"5fc1f717_092b5882","updated":"2019-04-02 08:22:51.000000000","message":"Good catch!!\n\nWe don\u0027t need to raise an exception but I should handle hen lvm is None.","commit_id":"b6067f9adbcabacaceb6d045eef80fb3a8549049"}]}