)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a1f73acbcd453255e27779fb5b37328eb6da708f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Ignore first local port update notification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ovs-agent local port notification will be sent during"},{"line_number":10,"context_line":"the first rpc loop. This will cause these ports to"},{"line_number":11,"context_line":"be processed twice."},{"line_number":12,"context_line":"This patch passes the restart flag (iteration num 0)"},{"line_number":13,"context_line":"to the local port_update call trace. After this patch,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fb8cfa7_f4368151","line":10,"range":{"start_line":10,"start_character":36,"end_line":10,"end_character":41},"updated":"2019-06-25 08:41:00.000000000","message":"which ports exactly? Can You elaborate little bit more about what was the workflow and how it will be changed with this patch?","commit_id":"5470d172c1be31d4ab7fa807fbd73dab5c503e15"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"03c3426b34f11780d982e288f1b09ea2d575a94b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Ignore first local port update notification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ovs-agent local port notification will be sent during"},{"line_number":10,"context_line":"the first rpc loop. This will cause these ports to"},{"line_number":11,"context_line":"be processed twice."},{"line_number":12,"context_line":"This patch passes the restart flag (iteration num 0)"},{"line_number":13,"context_line":"to the local port_update call trace. After this patch,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fb8cfa7_1c6a4519","line":10,"range":{"start_line":10,"start_character":36,"end_line":10,"end_character":41},"in_reply_to":"9fb8cfa7_8c67f9b7","updated":"2019-06-26 10:55:06.000000000","message":"Ok, now I understand :)\nAnd looking at logs in e.g. fullstack job, like: http://logs.openstack.org/13/644613/7/check/neutron-fullstack/8443d3b/controller/logs/dsvm-fullstack-logs/TestUninterruptedConnectivityOnL2AgentRestart.test_l2_agent_restart_OVS,Flat-network_/neutron-openvswitch-agent--2019-06-26--01-58-49-551876_log.txt.gz?level\u003dINFO#_2019-06-26_01_58_58_695 indeed port is processed only once.\nI compared it to same test in other patch and it was done twice for every port, e.g: http://logs.openstack.org/35/521035/6/check/neutron-fullstack/b881d65/controller/logs/dsvm-fullstack-logs/TestUninterruptedConnectivityOnL2AgentRestart.test_l2_agent_restart_OVS,Flat-network_/neutron-openvswitch-agent--2019-06-26--03-35-38-366939_log.txt.gz?level\u003dINFO#_2019-06-26_03_35_48_096","commit_id":"5470d172c1be31d4ab7fa807fbd73dab5c503e15"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"caa103638d12dd06c9eaa800191088047076b1cf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Ignore first local port update notification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ovs-agent local port notification will be sent during"},{"line_number":10,"context_line":"the first rpc loop. This will cause these ports to"},{"line_number":11,"context_line":"be processed twice."},{"line_number":12,"context_line":"This patch passes the restart flag (iteration num 0)"},{"line_number":13,"context_line":"to the local port_update call trace. After this patch,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fb8cfa7_8c67f9b7","line":10,"range":{"start_line":10,"start_character":36,"end_line":10,"end_character":41},"in_reply_to":"9fb8cfa7_ca0ab677","updated":"2019-06-25 13:54:27.000000000","message":"Done","commit_id":"5470d172c1be31d4ab7fa807fbd73dab5c503e15"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"cb36233d8b4e321d5f7908a8f4bc76c13336ebdf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Ignore first local port update notification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ovs-agent local port notification will be sent during"},{"line_number":10,"context_line":"the first rpc loop. This will cause these ports to"},{"line_number":11,"context_line":"be processed twice."},{"line_number":12,"context_line":"This patch passes the restart flag (iteration num 0)"},{"line_number":13,"context_line":"to the local port_update call trace. After this patch,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fb8cfa7_ca0ab677","line":10,"range":{"start_line":10,"start_character":36,"end_line":10,"end_character":41},"in_reply_to":"9fb8cfa7_f4368151","updated":"2019-06-25 11:15:39.000000000","message":"I mean that port for notification here (first line), so it is just these ports.","commit_id":"5470d172c1be31d4ab7fa807fbd73dab5c503e15"}],"neutron/agent/resource_cache.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"42273cb5900f87a302337fcb994aa15babeeb7e6","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        Queries the server if this is the first time a given query for"},{"line_number":68,"context_line":"        rtype has been issued."},{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":"        agent_restarted \u003d filter_kwargs.pop(\"agent_restarted\", False)"},{"line_number":71,"context_line":"        query_ids \u003d self._get_query_ids(rtype, filter_kwargs)"},{"line_number":72,"context_line":"        if query_ids.issubset(self._satisfied_server_queries):"},{"line_number":73,"context_line":"            # we\u0027ve already asked the server this question so we don\u0027t"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_68dbaaec","line":70,"updated":"2019-05-23 20:15:54.000000000","message":"Seems odd to pass agent_restarted in **filter_kwargs since those are used for the query, should just be a new arg I think.","commit_id":"5470d172c1be31d4ab7fa807fbd73dab5c503e15"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"c507737bfc6621ff5e226d4f834afc0b538bbdb4","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        Queries the server if this is the first time a given query for"},{"line_number":68,"context_line":"        rtype has been issued."},{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":"        agent_restarted \u003d filter_kwargs.pop(\"agent_restarted\", False)"},{"line_number":71,"context_line":"        query_ids \u003d self._get_query_ids(rtype, filter_kwargs)"},{"line_number":72,"context_line":"        if query_ids.issubset(self._satisfied_server_queries):"},{"line_number":73,"context_line":"            # we\u0027ve already asked the server this question so we don\u0027t"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_7bf4d2cf","line":70,"in_reply_to":"bfb3d3c7_68dbaaec","updated":"2019-05-23 20:48:58.000000000","message":"+1 Seems like a sensible tweak here.","commit_id":"5470d172c1be31d4ab7fa807fbd73dab5c503e15"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"705cb10fb456622854588af4076150d6cbdca823","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        Queries the server if this is the first time a given query for"},{"line_number":68,"context_line":"        rtype has been issued."},{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":"        agent_restarted \u003d filter_kwargs.pop(\"agent_restarted\", False)"},{"line_number":71,"context_line":"        query_ids \u003d self._get_query_ids(rtype, filter_kwargs)"},{"line_number":72,"context_line":"        if query_ids.issubset(self._satisfied_server_queries):"},{"line_number":73,"context_line":"            # we\u0027ve already asked the server this question so we don\u0027t"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_983adac9","line":70,"in_reply_to":"bfb3d3c7_7bf4d2cf","updated":"2019-05-24 15:56:30.000000000","message":"That will drag another call stack, see line 124 and 115. And we pop here.","commit_id":"5470d172c1be31d4ab7fa807fbd73dab5c503e15"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d1c9286765cc8c6d58ca91b0de0476709261733a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        Queries the server if this is the first time a given query for"},{"line_number":68,"context_line":"        rtype has been issued."},{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":"        agent_restarted \u003d filter_kwargs.pop(\"agent_restarted\", False)"},{"line_number":71,"context_line":"        query_ids \u003d self._get_query_ids(rtype, filter_kwargs)"},{"line_number":72,"context_line":"        if query_ids.issubset(self._satisfied_server_queries):"},{"line_number":73,"context_line":"            # we\u0027ve already asked the server this question so we don\u0027t"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_a902f23b","line":70,"in_reply_to":"bfb3d3c7_983adac9","updated":"2019-05-24 20:23:24.000000000","message":"Right, but it\u0027s only one additional caller.  I just don\u0027t like overloading the argument.","commit_id":"5470d172c1be31d4ab7fa807fbd73dab5c503e15"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"caa103638d12dd06c9eaa800191088047076b1cf","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        Queries the server if this is the first time a given query for"},{"line_number":68,"context_line":"        rtype has been issued."},{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":"        agent_restarted \u003d filter_kwargs.pop(\"agent_restarted\", False)"},{"line_number":71,"context_line":"        query_ids \u003d self._get_query_ids(rtype, filter_kwargs)"},{"line_number":72,"context_line":"        if query_ids.issubset(self._satisfied_server_queries):"},{"line_number":73,"context_line":"            # we\u0027ve already asked the server this question so we don\u0027t"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_2c060dd0","line":70,"in_reply_to":"bfb3d3c7_a902f23b","updated":"2019-06-25 13:54:27.000000000","message":"Done","commit_id":"5470d172c1be31d4ab7fa807fbd73dab5c503e15"}],"neutron/agent/rpc.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a1f73acbcd453255e27779fb5b37328eb6da708f","unresolved":false,"context_lines":[{"line_number":111,"context_line":"              the device port"},{"line_number":112,"context_line":"        1.4 - tunnel_sync rpc signature upgrade to obtain \u0027host\u0027"},{"line_number":113,"context_line":"        1.5 - Support update_device_list and"},{"line_number":114,"context_line":"              get_devices_details_list_and_failed_devices"},{"line_number":115,"context_line":"    \u0027\u0027\u0027"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def __init__(self, topic):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_54d74def","line":114,"updated":"2019-06-25 08:41:00.000000000","message":"shouldn\u0027t You bump version?","commit_id":"5470d172c1be31d4ab7fa807fbd73dab5c503e15"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"cb36233d8b4e321d5f7908a8f4bc76c13336ebdf","unresolved":false,"context_lines":[{"line_number":111,"context_line":"              the device port"},{"line_number":112,"context_line":"        1.4 - tunnel_sync rpc signature upgrade to obtain \u0027host\u0027"},{"line_number":113,"context_line":"        1.5 - Support update_device_list and"},{"line_number":114,"context_line":"              get_devices_details_list_and_failed_devices"},{"line_number":115,"context_line":"    \u0027\u0027\u0027"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def __init__(self, topic):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_eae8dab3","line":114,"in_reply_to":"9fb8cfa7_54d74def","updated":"2019-06-25 11:15:39.000000000","message":"We actually do not change the real call params of this RPC API.","commit_id":"5470d172c1be31d4ab7fa807fbd73dab5c503e15"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a1f73acbcd453255e27779fb5b37328eb6da708f","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def get_devices_details_list_and_failed_devices(self, context, devices,"},{"line_number":132,"context_line":"                                                    agent_id, host\u003dNone,"},{"line_number":133,"context_line":"                                                    **kwargs):"},{"line_number":134,"context_line":"        \"\"\"Get devices details and the list of devices that failed."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        This method returns the devices details. If an error is thrown when"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_d4e33dd7","line":133,"updated":"2019-06-25 08:41:00.000000000","message":"why kwargs and not just \"agent_restarted\"?\nAnd also it looks that those kwargs aren\u0027t passed anywhere from here","commit_id":"5470d172c1be31d4ab7fa807fbd73dab5c503e15"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"cb36233d8b4e321d5f7908a8f4bc76c13336ebdf","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def get_devices_details_list_and_failed_devices(self, context, devices,"},{"line_number":132,"context_line":"                                                    agent_id, host\u003dNone,"},{"line_number":133,"context_line":"                                                    **kwargs):"},{"line_number":134,"context_line":"        \"\"\"Get devices details and the list of devices that failed."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        This method returns the devices details. If an error is thrown when"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_eab3fae7","line":133,"in_reply_to":"9fb8cfa7_d4e33dd7","updated":"2019-06-25 11:15:39.000000000","message":"It\u0027s a little interesting here, we have the CacheBackedPluginApi and this real rpc PluginApi. The call trace is biscally go into that cached backend for this change. And these two different APIs have the totally same functions. Since I changed the corresponding function in CacheBackedPluginApi, so I would like to make it consistent, and make sure we do not break call of the PluginApi here.","commit_id":"5470d172c1be31d4ab7fa807fbd73dab5c503e15"}]}