)]}'
{"neutron/api/v2/resource_helper.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"1d8a0a5a9bd4d5bd216668b27e4ed86a71cedb0c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (c) Copyright 2013 Cisco Systems Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2FvxQ%3D","line":1,"updated":"2014-01-02 13:51:26.000000000","message":"I\u0027ll update this to 2014","commit_id":"f08c63576786a7ed2fbc056591bc4f4e08a076a2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"569d35953de39bbfc07c145151a6ebcc36690f77","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def build_resource_info(plural_mappings, resource_map, which_service,"},{"line_number":41,"context_line":"                        action_map\u003d{}, register_quota\u003dFalse,"},{"line_number":42,"context_line":"                        translate_name\u003dFalse, allow_bulk\u003dFalse):"},{"line_number":43,"context_line":"    \"\"\"Build resources for advanced services."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F5Dg%3D","line":41,"updated":"2014-01-07 06:13:28.000000000","message":"Although action_map is not updated in this function, I would prefer that we avoid using a mutable default argument if it is not specifically intended (and accompanied by a comment explaining the intent). \n\nI suggest the usual alternative: use a default value of None and start the function with\n\n    if action_map is None:\n        action_map \u003d {}","commit_id":"21ed8dbb51350355bf01fda80dea73c4003deb97"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"db18b31389ee7b84b57a64a0215b9c0182a2ce29","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def build_resource_info(plural_mappings, resource_map, which_service,"},{"line_number":41,"context_line":"                        action_map\u003d{}, register_quota\u003dFalse,"},{"line_number":42,"context_line":"                        translate_name\u003dFalse, allow_bulk\u003dFalse):"},{"line_number":43,"context_line":"    \"\"\"Build resources for advanced services."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F3no%3D","line":41,"in_reply_to":"AAAAUH%2F%2F5Dg%3D","updated":"2014-01-07 13:03:03.000000000","message":"Done","commit_id":"21ed8dbb51350355bf01fda80dea73c4003deb97"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"c57a84b00601d436352e64a4f07f79d93bb24fe2","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            collection_name, resource_name, plugin, params,"},{"line_number":64,"context_line":"            member_actions\u003dmember_actions,"},{"line_number":65,"context_line":"            allow_bulk\u003dallow_bulk,"},{"line_number":66,"context_line":"            allow_pagination\u003dcfg.CONF.allow_pagination,"},{"line_number":67,"context_line":"            allow_sorting\u003dcfg.CONF.allow_sorting)"},{"line_number":68,"context_line":"        resource \u003d extensions.ResourceExtension("},{"line_number":69,"context_line":"            collection_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2F1ME%3D","line":66,"updated":"2014-01-07 23:22:04.000000000","message":"Not every extension supports this. \nso this should be controllable by augment.","commit_id":"18c0f0937534ee763216236728e43383b9abb51c"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e236bc3c52dfee53286916e147930431cec679cd","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            collection_name, resource_name, plugin, params,"},{"line_number":64,"context_line":"            member_actions\u003dmember_actions,"},{"line_number":65,"context_line":"            allow_bulk\u003dallow_bulk,"},{"line_number":66,"context_line":"            allow_pagination\u003dcfg.CONF.allow_pagination,"},{"line_number":67,"context_line":"            allow_sorting\u003dcfg.CONF.allow_sorting)"},{"line_number":68,"context_line":"        resource \u003d extensions.ResourceExtension("},{"line_number":69,"context_line":"            collection_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FyrY%3D","line":66,"in_reply_to":"AAAAUH%2F%2F1ME%3D","updated":"2014-01-08 12:20:32.000000000","message":"I\u0027m currently limiting the applicability of this helper to service extensions and all currently have this setting.\n\nShould we defer adding this as an argument to function, until the time when we hit a case where a service extension does not support it? Same for allow_sorting?\n\nIf we do add allow_pagination (and allow_sorting), should we keep them as keyword args (concern over number of args), or should they be placed into a dict (concern over usage being less clear)?","commit_id":"18c0f0937534ee763216236728e43383b9abb51c"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"94b0f4d041f0a1ebb3add32bc8901fd8a3636230","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            collection_name, resource_name, plugin, params,"},{"line_number":64,"context_line":"            member_actions\u003dmember_actions,"},{"line_number":65,"context_line":"            allow_bulk\u003dallow_bulk,"},{"line_number":66,"context_line":"            allow_pagination\u003dcfg.CONF.allow_pagination,"},{"line_number":67,"context_line":"            allow_sorting\u003dcfg.CONF.allow_sorting)"},{"line_number":68,"context_line":"        resource \u003d extensions.ResourceExtension("},{"line_number":69,"context_line":"            collection_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Fvpk%3D","line":66,"in_reply_to":"AAAAUH%2F%2FyrY%3D","updated":"2014-01-08 23:24:26.000000000","message":"I got it. let\u0027s do it when it is needed","commit_id":"18c0f0937534ee763216236728e43383b9abb51c"}]}