)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b2ea6dc4e387e3fa1cb9902ff86f790da8657a0e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"multiple master router is up. This patch just sets the veth"},{"line_number":12,"context_line":"pair devices up."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1819160"},{"line_number":15,"context_line":"Change-Id: I0e0d0311d73bce83d3c7341e7a0167917818b1ff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_551ac46e","line":14,"updated":"2019-03-26 20:23:37.000000000","message":"It still don\u0027t close this bug for sure. I just did same test as in one of previous patches from Rodolfo. Result is like:\n\n1480         def test_dvr_ha_router_unbound_from_agents(self):\n1481             import remote_pdb; remote_pdb.set_trace(port\u003d1234)\n1482             self._setup_dvr_ha_agents()\n1483             self._setup_dvr_ha_bridges()\n1484\n1485             router1 \u003d self._create_dvr_ha_router(\n1486                 self.agent, enable_gw\u003dTrue)\n1487             router2 \u003d self._create_dvr_ha_router(\n1488                 self.failover_agent, enable_gw\u003dTrue)\n1489\n1490  -\u003e         utils.wait_until_true(lambda: router1.ha_state \u003d\u003d \u0027master\u0027)\n1491             utils.wait_until_true(lambda: router2.ha_state \u003d\u003d \u0027backup\u0027)\n1492\n1493             self._assert_ip_addresses_in_dvr_ha_snat_namespace(router1)\n1494             self._assert_no_ip_addresses_in_dvr_ha_snat_namespace(router2)\n1495             router1_ha_device \u003d router1.get_ha_device_name()\n1496             router2_ha_device \u003d router2.get_ha_device_name()\n1497             self.assertTrue(\n1498                 ip_lib.device_exists(router1_ha_device, router1.ha_namespace))\n1499             self.assertTrue(\n1500                 ip_lib.device_exists(router2_ha_device, router2.ha_namespace))\n1501\n1502             router1.router[\u0027_ha_interface\u0027] \u003d None\n1503             self.agent._process_updated_router(router1.router)\n1504             router_updated \u003d self.agent.router_info[router1.router_id]\n1505\n1506             self.assertTrue(self._namespace_exists(router_updated.ns_name))\n1507             self._assert_snat_namespace_exists(router_updated)\n1508             snat_namespace_name \u003d dvr_snat_ns.SnatNamespace.get_snat_ns_name(\n1509     ...\n(Pdb++) pp router1.ha_state\n\u0027master\u0027\n(Pdb++) pp router2.ha_state\n\u0027master\u0027\n(Pdb++) pp router1.router[\u0027_ha_interface\u0027]\n{\u0027admin_state_up\u0027: True,\n \u0027agent_host\u0027: \u0027aaa\u0027,\n \u0027agent_id\u0027: \u0027e2fa06fd-2f7d-42d6-a0b3-333146fc9554\u0027,\n \u0027device_id\u0027: \u0027fa8c84ad-0b28-4889-8739-a692dcab9a66\u0027,\n \u0027device_owner\u0027: \u0027network:router_ha_interface\u0027,\n \u0027fixed_ips\u0027: [{\u0027ip_address\u0027: \u0027169.254.192.1\u0027,\n                \u0027prefixlen\u0027: 18,\n                \u0027subnet_id\u0027: \u0027f392cb60-0271-4514-9fee-fba4d0751a12\u0027}],\n \u0027id\u0027: \u002723964384-1f53-48ae-b57c-d7b8cc957e08\u0027,\n \u0027mac_address\u0027: \u002712:34:56:78:2b:aa\u0027,\n \u0027mtu\u0027: 1500,\n \u0027name\u0027: \u0027L3 HA Admin port 0\u0027,\n \u0027network_id\u0027: \u002792cdb78d-3bdc-4202-8967-4644094af521\u0027,\n \u0027priority\u0027: 1,\n \u0027status\u0027: \u0027ACTIVE\u0027,\n \u0027subnets\u0027: [{\u0027cidr\u0027: \u0027169.254.192.0/18\u0027,\n              \u0027gateway_ip\u0027: \u0027169.254.255.254\u0027,\n              \u0027id\u0027: \u0027f392cb60-0271-4514-9fee-fba4d0751a12\u0027}],\n \u0027tenant_id\u0027: \u0027\u0027}\n(Pdb++) pp router2.router[\u0027_ha_interface\u0027]\n{\u0027admin_state_up\u0027: True,\n \u0027agent_host\u0027: \u0027aaa\u0027,\n \u0027agent_id\u0027: \u0027dc2f1651-b477-4d87-a4cc-68d1337d4f96\u0027,\n \u0027device_id\u0027: \u00276118aebf-a67a-4a3d-9a1b-020cc0bb2884\u0027,\n \u0027device_owner\u0027: \u0027network:router_ha_interface\u0027,\n \u0027fixed_ips\u0027: [{\u0027ip_address\u0027: \u0027169.254.192.1\u0027,\n                \u0027prefixlen\u0027: 18,\n                \u0027subnet_id\u0027: \u0027e890ba39-029c-47a3-9f3e-d9fde0e6d62c\u0027}],\n \u0027id\u0027: \u002782e94c85-5e88-42c6-adc7-9ccff0596eb4\u0027,\n \u0027mac_address\u0027: \u002712:34:56:78:2b:aa\u0027,\n \u0027mtu\u0027: 1500,\n \u0027name\u0027: \u0027L3 HA Admin port 0\u0027,\n \u0027network_id\u0027: \u002717ca7c0c-8fb2-4aa8-ab68-e58375242383\u0027,\n \u0027priority\u0027: 1,\n \u0027status\u0027: \u0027ACTIVE\u0027,\n \u0027subnets\u0027: [{\u0027cidr\u0027: \u0027169.254.192.0/18\u0027,\n              \u0027gateway_ip\u0027: \u0027169.254.255.254\u0027,\n              \u0027id\u0027: \u0027e890ba39-029c-47a3-9f3e-d9fde0e6d62c\u0027}],\n \u0027tenant_id\u0027: \u0027\u0027}\n\n\nSo both routers are master after some time. And still both routers have got completely different ha network, same IP and MAC address so how You expect that keepalived will work between those two ports?","commit_id":"ed408c6e5296dfc569bc4f5bf931a493c43a0426"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7d17490fedc4d9bb4af7d045b6fa55117d340974","unresolved":false,"context_lines":[{"line_number":11,"context_line":"multiple master router is up. This patch just sets the veth"},{"line_number":12,"context_line":"pair devices up."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1819160"},{"line_number":15,"context_line":"Change-Id: I0e0d0311d73bce83d3c7341e7a0167917818b1ff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_9e05a948","line":14,"in_reply_to":"5fc1f717_551ac46e","updated":"2019-03-26 23:48:53.000000000","message":"Thanks Slawek, the IP addr and VRRP ID were handled in this patch:\nhttps://review.openstack.org/642220\nIn that patch, I just give each case a specific vrrp id, and each ha port a specific IP addr and MAC addr.","commit_id":"ed408c6e5296dfc569bc4f5bf931a493c43a0426"}],"neutron/tests/functional/agent/l3/test_dvr_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7428f7ffe5cbb0f37d8ceb19702c94acff13ff47","unresolved":false,"context_lines":[{"line_number":1322,"context_line":""},{"line_number":1323,"context_line":"        veth1, veth2 \u003d self.useFixture(net_helpers.VethFixture()).ports"},{"line_number":1324,"context_line":"        veth1.link.set_up()"},{"line_number":1325,"context_line":"        veth2.link.set_up()"},{"line_number":1326,"context_line":"        br_int_1.add_port(veth1.name)"},{"line_number":1327,"context_line":"        br_int_2.add_port(veth2.name)"},{"line_number":1328,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_5be43c0d","line":1325,"updated":"2019-03-26 16:22:10.000000000","message":"It would be great if it was this all along, nice catch!  BTW, neutron/tests/functional/agent/l3/test_ha_router.py as exactly the same code in a setUp() call, but with the set_up() calls :)","commit_id":"ed408c6e5296dfc569bc4f5bf931a493c43a0426"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7d17490fedc4d9bb4af7d045b6fa55117d340974","unresolved":false,"context_lines":[{"line_number":1322,"context_line":""},{"line_number":1323,"context_line":"        veth1, veth2 \u003d self.useFixture(net_helpers.VethFixture()).ports"},{"line_number":1324,"context_line":"        veth1.link.set_up()"},{"line_number":1325,"context_line":"        veth2.link.set_up()"},{"line_number":1326,"context_line":"        br_int_1.add_port(veth1.name)"},{"line_number":1327,"context_line":"        br_int_2.add_port(veth2.name)"},{"line_number":1328,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_fe9f0dff","line":1325,"in_reply_to":"5fc1f717_5be43c0d","updated":"2019-03-26 23:48:53.000000000","message":"Yes, those cases are connected and the devices are UP.","commit_id":"ed408c6e5296dfc569bc4f5bf931a493c43a0426"}]}
