)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"aacc337763f8c619ed1df9813dc162af47341c9e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Refactors Bigswitch/Restproxy plugin by separating into"},{"line_number":10,"context_line":"reusable libraries that can be used by the plugin as well"},{"line_number":11,"context_line":"as the ml2 driver to proxy calls to the backend controller."},{"line_number":12,"context_line":"Also enables basic unit tests for the ML2 driver"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint bigswitch-ml2-driver"},{"line_number":15,"context_line":"Change-Id: I4e22ba7e20ec4f405b9fd34a1bf08a48544f317d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAAUH%2F%2Bj4Q%3D","line":12,"updated":"2014-01-24 11:37:55.000000000","message":"Should add mention of bulking support changes made.","commit_id":"b66b01fb9ae0b9229247bea346ba5c17f6513ba0"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"77e9fba80b1b60568a9ded99360710f0b3193f51","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Refactors Bigswitch/Restproxy plugin by separating into"},{"line_number":10,"context_line":"reusable libraries that can be used by the plugin as well"},{"line_number":11,"context_line":"as the ml2 driver to proxy calls to the backend controller."},{"line_number":12,"context_line":"Also enables basic unit tests for the ML2 driver"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint bigswitch-ml2-driver"},{"line_number":15,"context_line":"Change-Id: I4e22ba7e20ec4f405b9fd34a1bf08a48544f317d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAAUH%2F%2Bhuw%3D","line":12,"in_reply_to":"AAAAUH%2F%2Bj4Q%3D","updated":"2014-01-24 18:24:08.000000000","message":"Done","commit_id":"b66b01fb9ae0b9229247bea346ba5c17f6513ba0"}],"neutron/plugins/bigswitch/plugin.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"37a01e1f7621c11fc28467eeb5894c61d4bd4e72","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            self.timeout \u003d timeout"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        # validate config"},{"line_number":272,"context_line":"        assert servers is not None, _(\u0027Servers not defined. Aborting plugin\u0027)"},{"line_number":273,"context_line":"        servers \u003d tuple(s.rsplit(\u0027:\u0027, 1) for s in servers.split(\u0027,\u0027))"},{"line_number":274,"context_line":"        servers \u003d tuple((server, int(port)) for server, port in servers)"},{"line_number":275,"context_line":"        assert all(len(s) \u003d\u003d 2 for s in servers), SYNTAX_ERROR_MESSAGE"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F8jc%3D","line":272,"updated":"2014-01-06 12:11:01.000000000","message":"Should this be an assert vs an exception raised that exits the plugin?","commit_id":"76d20b827572c01befa6e09e0f70ef00f5c3dc9a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"296c345fc55316e0ca59b6eb38ece71876d5054d","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            self.timeout \u003d timeout"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        # validate config"},{"line_number":272,"context_line":"        assert servers is not None, _(\u0027Servers not defined. Aborting plugin\u0027)"},{"line_number":273,"context_line":"        servers \u003d tuple(s.rsplit(\u0027:\u0027, 1) for s in servers.split(\u0027,\u0027))"},{"line_number":274,"context_line":"        servers \u003d tuple((server, int(port)) for server, port in servers)"},{"line_number":275,"context_line":"        assert all(len(s) \u003d\u003d 2 for s in servers), SYNTAX_ERROR_MESSAGE"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Bm0A%3D","line":272,"in_reply_to":"AAAAUH%2F%2F8jc%3D","updated":"2014-01-24 00:51:31.000000000","message":"Done","commit_id":"76d20b827572c01befa6e09e0f70ef00f5c3dc9a"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"37a01e1f7621c11fc28467eeb5894c61d4bd4e72","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        assert servers is not None, _(\u0027Servers not defined. Aborting plugin\u0027)"},{"line_number":273,"context_line":"        servers \u003d tuple(s.rsplit(\u0027:\u0027, 1) for s in servers.split(\u0027,\u0027))"},{"line_number":274,"context_line":"        servers \u003d tuple((server, int(port)) for server, port in servers)"},{"line_number":275,"context_line":"        assert all(len(s) \u003d\u003d 2 for s in servers), SYNTAX_ERROR_MESSAGE"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        self.servers \u003d []"},{"line_number":278,"context_line":"        for server_port in servers:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F8ik%3D","line":275,"updated":"2014-01-06 12:11:01.000000000","message":"ditto.","commit_id":"76d20b827572c01befa6e09e0f70ef00f5c3dc9a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"296c345fc55316e0ca59b6eb38ece71876d5054d","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        assert servers is not None, _(\u0027Servers not defined. Aborting plugin\u0027)"},{"line_number":273,"context_line":"        servers \u003d tuple(s.rsplit(\u0027:\u0027, 1) for s in servers.split(\u0027,\u0027))"},{"line_number":274,"context_line":"        servers \u003d tuple((server, int(port)) for server, port in servers)"},{"line_number":275,"context_line":"        assert all(len(s) \u003d\u003d 2 for s in servers), SYNTAX_ERROR_MESSAGE"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        self.servers \u003d []"},{"line_number":278,"context_line":"        for server_port in servers:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Bmz4%3D","line":275,"in_reply_to":"AAAAUH%2F%2F8ik%3D","updated":"2014-01-24 00:51:31.000000000","message":"Done","commit_id":"76d20b827572c01befa6e09e0f70ef00f5c3dc9a"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"37a01e1f7621c11fc28467eeb5894c61d4bd4e72","unresolved":false,"context_lines":[{"line_number":445,"context_line":"    servers \u003d None"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def __init__(self, server_timeout\u003dNone):"},{"line_number":448,"context_line":"        # This base class is not intended to be instantiated directly."},{"line_number":449,"context_line":"        # Extending class should set ServerPool."},{"line_number":450,"context_line":"        if not self.servers:"},{"line_number":451,"context_line":"            LOG.warning(_(\"ServerPool not set!\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F8iU%3D","line":448,"updated":"2014-01-06 12:11:01.000000000","message":"Make an ABC?","commit_id":"76d20b827572c01befa6e09e0f70ef00f5c3dc9a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"296c345fc55316e0ca59b6eb38ece71876d5054d","unresolved":false,"context_lines":[{"line_number":445,"context_line":"    servers \u003d None"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def __init__(self, server_timeout\u003dNone):"},{"line_number":448,"context_line":"        # This base class is not intended to be instantiated directly."},{"line_number":449,"context_line":"        # Extending class should set ServerPool."},{"line_number":450,"context_line":"        if not self.servers:"},{"line_number":451,"context_line":"            LOG.warning(_(\"ServerPool not set!\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Bmw8%3D","line":448,"in_reply_to":"AAAAUH%2F%2F8iU%3D","updated":"2014-01-24 00:51:31.000000000","message":"It extends other classes though. It does all of the base mixins and provides utility functions necessary for the plugin and ML2 driver. The classes that inherit from this don\u0027t override the methods either.","commit_id":"76d20b827572c01befa6e09e0f70ef00f5c3dc9a"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"43676a266a4de4cb2358282589cf1aba288389f7","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        # validate config"},{"line_number":272,"context_line":"        if not servers:"},{"line_number":273,"context_line":"            raise cfg.Error(_(\u0027Servers not defined. Aborting plugin\u0027))"},{"line_number":274,"context_line":"        servers \u003d tuple(s.rsplit(\u0027:\u0027, 1) for s in servers.split(\u0027,\u0027))"},{"line_number":275,"context_line":"        servers \u003d tuple((server, int(port)) for server, port in servers)"},{"line_number":276,"context_line":"        if not all(len(s) \u003d\u003d 2 for s in servers):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2BhnY%3D","line":273,"updated":"2014-01-24 19:12:13.000000000","message":"Consider replacing 274-281 with:\nself.servers \u003d [\n    self.server_proxy_for(server, int(port) \n    for server, port in (s.rsplit(\u0027:\u0027, 1) for s in servers.split(\u0027,\u0027))\n]","commit_id":"bc3dd6df6b2075fd867306a6bfa0f7948f8db559"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"59ed9d5de47603a72ea64a8d0069a763baa5a2bd","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        # validate config"},{"line_number":272,"context_line":"        if not servers:"},{"line_number":273,"context_line":"            raise cfg.Error(_(\u0027Servers not defined. Aborting plugin\u0027))"},{"line_number":274,"context_line":"        servers \u003d tuple(s.rsplit(\u0027:\u0027, 1) for s in servers.split(\u0027,\u0027))"},{"line_number":275,"context_line":"        servers \u003d tuple((server, int(port)) for server, port in servers)"},{"line_number":276,"context_line":"        if not all(len(s) \u003d\u003d 2 for s in servers):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2BhbQ%3D","line":273,"in_reply_to":"AAAAUH%2F%2BhnY%3D","updated":"2014-01-24 19:50:32.000000000","message":"Done","commit_id":"bc3dd6df6b2075fd867306a6bfa0f7948f8db559"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"43676a266a4de4cb2358282589cf1aba288389f7","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            raise cfg.Error(_(\u0027Servers not defined. Aborting plugin\u0027))"},{"line_number":274,"context_line":"        servers \u003d tuple(s.rsplit(\u0027:\u0027, 1) for s in servers.split(\u0027,\u0027))"},{"line_number":275,"context_line":"        servers \u003d tuple((server, int(port)) for server, port in servers)"},{"line_number":276,"context_line":"        if not all(len(s) \u003d\u003d 2 for s in servers):"},{"line_number":277,"context_line":"            raise cfg.Error(SYNTAX_ERROR_MESSAGE)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        self.servers \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2Bhm8%3D","line":276,"updated":"2014-01-24 19:12:13.000000000","message":"This is not needed since the server, int(port) part above will ensure the tuple has two items.","commit_id":"bc3dd6df6b2075fd867306a6bfa0f7948f8db559"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"59ed9d5de47603a72ea64a8d0069a763baa5a2bd","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            raise cfg.Error(_(\u0027Servers not defined. Aborting plugin\u0027))"},{"line_number":274,"context_line":"        servers \u003d tuple(s.rsplit(\u0027:\u0027, 1) for s in servers.split(\u0027,\u0027))"},{"line_number":275,"context_line":"        servers \u003d tuple((server, int(port)) for server, port in servers)"},{"line_number":276,"context_line":"        if not all(len(s) \u003d\u003d 2 for s in servers):"},{"line_number":277,"context_line":"            raise cfg.Error(SYNTAX_ERROR_MESSAGE)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        self.servers \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2BhbM%3D","line":276,"in_reply_to":"AAAAUH%2F%2Bhm8%3D","updated":"2014-01-24 19:50:32.000000000","message":"Done","commit_id":"bc3dd6df6b2075fd867306a6bfa0f7948f8db559"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"95b0d747085904e57f922dd3aabb7de577d9c815","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        if not servers:"},{"line_number":273,"context_line":"            raise cfg.Error(_(\u0027Servers not defined. Aborting plugin\u0027))"},{"line_number":274,"context_line":"        self.servers \u003d ["},{"line_number":275,"context_line":"            self.server_proxy_for(server, int(port)"},{"line_number":276,"context_line":"            for server, port in (s.rsplit(\u0027:\u0027, 1) for s in servers.split(\u0027,\u0027))"},{"line_number":277,"context_line":"        ]"},{"line_number":278,"context_line":"        LOG.debug(_(\"ServerPool: initialization done\"))"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2BhU0%3D","line":275,"updated":"2014-01-24 19:59:41.000000000","message":"Missing paren?","commit_id":"d4617f88de25597a8e73d04710066badee54b147"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3a32577035db533f874b21a608820ccf83ab0b09","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        if not servers:"},{"line_number":273,"context_line":"            raise cfg.Error(_(\u0027Servers not defined. Aborting plugin\u0027))"},{"line_number":274,"context_line":"        self.servers \u003d ["},{"line_number":275,"context_line":"            self.server_proxy_for(server, int(port)"},{"line_number":276,"context_line":"            for server, port in (s.rsplit(\u0027:\u0027, 1) for s in servers.split(\u0027,\u0027))"},{"line_number":277,"context_line":"        ]"},{"line_number":278,"context_line":"        LOG.debug(_(\"ServerPool: initialization done\"))"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2BhS4%3D","line":275,"in_reply_to":"AAAAUH%2F%2BhU0%3D","updated":"2014-01-24 20:13:45.000000000","message":"Done","commit_id":"d4617f88de25597a8e73d04710066badee54b147"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"95b0d747085904e57f922dd3aabb7de577d9c815","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            raise cfg.Error(_(\u0027Servers not defined. Aborting plugin\u0027))"},{"line_number":274,"context_line":"        self.servers \u003d ["},{"line_number":275,"context_line":"            self.server_proxy_for(server, int(port)"},{"line_number":276,"context_line":"            for server, port in (s.rsplit(\u0027:\u0027, 1) for s in servers.split(\u0027,\u0027))"},{"line_number":277,"context_line":"        ]"},{"line_number":278,"context_line":"        LOG.debug(_(\"ServerPool: initialization done\"))"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2BhTo%3D","line":276,"updated":"2014-01-24 19:59:41.000000000","message":"The check for server/port pair being there is removed. Is that because there will always be a pair(IOW not needed).","commit_id":"d4617f88de25597a8e73d04710066badee54b147"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3a32577035db533f874b21a608820ccf83ab0b09","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            raise cfg.Error(_(\u0027Servers not defined. Aborting plugin\u0027))"},{"line_number":274,"context_line":"        self.servers \u003d ["},{"line_number":275,"context_line":"            self.server_proxy_for(server, int(port)"},{"line_number":276,"context_line":"            for server, port in (s.rsplit(\u0027:\u0027, 1) for s in servers.split(\u0027,\u0027))"},{"line_number":277,"context_line":"        ]"},{"line_number":278,"context_line":"        LOG.debug(_(\"ServerPool: initialization done\"))"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2BhSY%3D","line":276,"in_reply_to":"AAAAUH%2F%2BhTo%3D","updated":"2014-01-24 20:13:45.000000000","message":"Yes, there should always be a pair. It will raise an ugly exception here though. I will add a check with a nicer exception.","commit_id":"d4617f88de25597a8e73d04710066badee54b147"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"1a898648128f746d66ae91478dd1dbe831dec29a","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        # validate config"},{"line_number":272,"context_line":"        if not servers:"},{"line_number":273,"context_line":"            raise cfg.Error(_(\u0027Servers not defined. Aborting plugin\u0027))"},{"line_number":274,"context_line":"        if any((len(spl) !\u003d 2)for spl in [sp.split(\u0027:\u0027, 1)"},{"line_number":275,"context_line":"                                          for sp in servers.split(\u0027,\u0027)]):"},{"line_number":276,"context_line":"            raise cfg.Error(_(\u0027Servers must be defined as \u003cip\u003e:\u003cport\u003e\u0027))"},{"line_number":277,"context_line":"        self.servers \u003d ["}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUH%2F9g1I%3D","line":274,"updated":"2014-02-06 12:07:08.000000000","message":"NIT: space before \u0027for\u0027","commit_id":"e70743386afd1c9dcbd18d9f0f9d321c6f6f9dc5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b51d401eebbe0773d83482a0e126c0bf48f4089a","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        # validate config"},{"line_number":272,"context_line":"        if not servers:"},{"line_number":273,"context_line":"            raise cfg.Error(_(\u0027Servers not defined. Aborting plugin\u0027))"},{"line_number":274,"context_line":"        if any((len(spl) !\u003d 2)for spl in [sp.split(\u0027:\u0027, 1)"},{"line_number":275,"context_line":"                                          for sp in servers.split(\u0027,\u0027)]):"},{"line_number":276,"context_line":"            raise cfg.Error(_(\u0027Servers must be defined as \u003cip\u003e:\u003cport\u003e\u0027))"},{"line_number":277,"context_line":"        self.servers \u003d ["}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUH%2F9blo%3D","line":274,"in_reply_to":"AAAAUH%2F9g1I%3D","updated":"2014-02-06 23:22:03.000000000","message":"Done","commit_id":"e70743386afd1c9dcbd18d9f0f9d321c6f6f9dc5"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"1a898648128f746d66ae91478dd1dbe831dec29a","unresolved":false,"context_lines":[{"line_number":593,"context_line":"    def _warn_on_state_status(self, resource):"},{"line_number":594,"context_line":"        if resource.get(\u0027admin_state_up\u0027, True) is False:"},{"line_number":595,"context_line":"            LOG.warning(_(\"Setting admin_state_up\u003dFalse is not supported\""},{"line_number":596,"context_line":"                          \" in this plugin version. Ignoring setting for \""},{"line_number":597,"context_line":"                          \"resource: %s\"), resource)"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        if \u0027status\u0027 in resource:"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUH%2F9gy4%3D","line":596,"updated":"2014-02-06 12:07:08.000000000","message":"NIT: May want to be consistent about handling of multi-line strings and whitespace (e.g. put space on L595 and remove from start of L596). Just makes it easier to tell if there are missing spaces.\n\nL602 and L626 each use different styles as well.","commit_id":"e70743386afd1c9dcbd18d9f0f9d321c6f6f9dc5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b51d401eebbe0773d83482a0e126c0bf48f4089a","unresolved":false,"context_lines":[{"line_number":593,"context_line":"    def _warn_on_state_status(self, resource):"},{"line_number":594,"context_line":"        if resource.get(\u0027admin_state_up\u0027, True) is False:"},{"line_number":595,"context_line":"            LOG.warning(_(\"Setting admin_state_up\u003dFalse is not supported\""},{"line_number":596,"context_line":"                          \" in this plugin version. Ignoring setting for \""},{"line_number":597,"context_line":"                          \"resource: %s\"), resource)"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        if \u0027status\u0027 in resource:"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUH%2F9bk8%3D","line":596,"in_reply_to":"AAAAUH%2F9gy4%3D","updated":"2014-02-06 23:22:03.000000000","message":"Done","commit_id":"e70743386afd1c9dcbd18d9f0f9d321c6f6f9dc5"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"392359a8fcb0438f2f5fdcf2d03a161e9572c238","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        data \u003d {\"port\": port}"},{"line_number":401,"context_line":"        device_id \u003d port.get(\"device_id\")"},{"line_number":402,"context_line":"        if not port[\"mac_address\"] or not device_id:"},{"line_number":403,"context_line":"            # controller only cares about ports attached to devices"},{"line_number":404,"context_line":"            return"},{"line_number":405,"context_line":"        data[\"attachment\"] \u003d {\"id\": device_id,"},{"line_number":406,"context_line":"                              \"mac\": port[\"mac_address\"]}"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAUH%2F9as4%3D","line":403,"updated":"2014-02-07 02:33:23.000000000","message":"you might want to log here","commit_id":"6436b44cf98b5ae632d6ac5700e2fcd8c8bc43e4"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"483b98f32957dd6a01142dad399123fec5434f5c","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        data \u003d {\"port\": port}"},{"line_number":401,"context_line":"        device_id \u003d port.get(\"device_id\")"},{"line_number":402,"context_line":"        if not port[\"mac_address\"] or not device_id:"},{"line_number":403,"context_line":"            # controller only cares about ports attached to devices"},{"line_number":404,"context_line":"            return"},{"line_number":405,"context_line":"        data[\"attachment\"] \u003d {\"id\": device_id,"},{"line_number":406,"context_line":"                              \"mac\": port[\"mac_address\"]}"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAUH%2F9anA%3D","line":403,"in_reply_to":"AAAAUH%2F9as4%3D","updated":"2014-02-07 04:04:23.000000000","message":"Done","commit_id":"6436b44cf98b5ae632d6ac5700e2fcd8c8bc43e4"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"392359a8fcb0438f2f5fdcf2d03a161e9572c238","unresolved":false,"context_lines":[{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    def rest_update_port(self, tenant_id, net_id, port):"},{"line_number":416,"context_line":"        # Controller has no update operation for the port endpoint"},{"line_number":417,"context_line":"        self.rest_delete_port(tenant_id, net_id, port[\u0027id\u0027])"},{"line_number":418,"context_line":"        self.rest_create_port(tenant_id, net_id, port)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAUH%2F9asQ%3D","line":417,"updated":"2014-02-07 02:33:23.000000000","message":"how do we handle the condition when delete port on the controller succeeds but the next call fails?","commit_id":"6436b44cf98b5ae632d6ac5700e2fcd8c8bc43e4"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"483b98f32957dd6a01142dad399123fec5434f5c","unresolved":false,"context_lines":[{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    def rest_update_port(self, tenant_id, net_id, port):"},{"line_number":416,"context_line":"        # Controller has no update operation for the port endpoint"},{"line_number":417,"context_line":"        self.rest_delete_port(tenant_id, net_id, port[\u0027id\u0027])"},{"line_number":418,"context_line":"        self.rest_create_port(tenant_id, net_id, port)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAUH%2F9akk%3D","line":417,"in_reply_to":"AAAAUH%2F9asQ%3D","updated":"2014-02-07 04:04:23.000000000","message":"I have updated the verb for the create call to PUT. On the controller backend, it will replace any existing ports with the same ID. This eliminates the need to call delete first.","commit_id":"6436b44cf98b5ae632d6ac5700e2fcd8c8bc43e4"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"392359a8fcb0438f2f5fdcf2d03a161e9572c238","unresolved":false,"context_lines":[{"line_number":851,"context_line":"            mapped_port \u003d self._map_state_and_status(new_port)"},{"line_number":852,"context_line":"            self.servers.rest_create_port(net[\"tenant_id\"],"},{"line_number":853,"context_line":"                                          new_port[\"network_id\"],"},{"line_number":854,"context_line":"                                          mapped_port)"},{"line_number":855,"context_line":"        return new_port"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"    def get_port(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAUH%2F9aoE%3D","line":854,"updated":"2014-02-07 02:33:23.000000000","message":"See the comment in the ML2 driver class, wondering if it\u0027s feasible to factor out some of the above steps into a common method which can be called from here as well as from the ML2 driver.","commit_id":"6436b44cf98b5ae632d6ac5700e2fcd8c8bc43e4"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"635a0d2e869279cc390e0916c7fd43903f3a4c62","unresolved":false,"context_lines":[{"line_number":586,"context_line":"        resource[\u0027state\u0027] \u003d (\u0027UP\u0027 if resource.pop(\u0027admin_state_up\u0027,"},{"line_number":587,"context_line":"                                                  True) else \u0027DOWN\u0027)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        if \u0027status\u0027 in resource:"},{"line_number":590,"context_line":"            del resource[\u0027status\u0027]"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        return resource"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAUX%2F%2FwsM%3D","line":589,"updated":"2014-02-10 23:50:39.000000000","message":"resource.pop(\u0027status\u0027, None)","commit_id":"dbacb52f420364cb85500a9c132207670afef4b5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3cb8070b1f0272652c604dcba2f2c1c2e397c0e0","unresolved":false,"context_lines":[{"line_number":586,"context_line":"        resource[\u0027state\u0027] \u003d (\u0027UP\u0027 if resource.pop(\u0027admin_state_up\u0027,"},{"line_number":587,"context_line":"                                                  True) else \u0027DOWN\u0027)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        if \u0027status\u0027 in resource:"},{"line_number":590,"context_line":"            del resource[\u0027status\u0027]"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        return resource"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAUX%2F%2Fwp0%3D","line":589,"in_reply_to":"AAAAUX%2F%2FwsM%3D","updated":"2014-02-10 23:56:15.000000000","message":"Thanks. I\u0027ll catch it next patch.","commit_id":"dbacb52f420364cb85500a9c132207670afef4b5"}],"neutron/plugins/ml2/config.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"43676a266a4de4cb2358282589cf1aba288389f7","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                help\u003d_(\"An ordered list of networking mechanism driver \""},{"line_number":31,"context_line":"                       \"entrypoints to be loaded from the \""},{"line_number":32,"context_line":"                       \"neutron.ml2.mechanism_drivers namespace.\")),"},{"line_number":33,"context_line":"    cfg.BoolOpt(\u0027bulk_support\u0027,"},{"line_number":34,"context_line":"                default\u003dTrue,"},{"line_number":35,"context_line":"                help\u003d_(\"Use bulk operations with ML2 drivers\"))"},{"line_number":36,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2BhgE%3D","line":33,"updated":"2014-01-24 19:12:13.000000000","message":"Please separate out this change to toggle bulk support into a distinct change.  Combining community code changes with a driver might cause members of the community to miss this.","commit_id":"bc3dd6df6b2075fd867306a6bfa0f7948f8db559"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"59ed9d5de47603a72ea64a8d0069a763baa5a2bd","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                help\u003d_(\"An ordered list of networking mechanism driver \""},{"line_number":31,"context_line":"                       \"entrypoints to be loaded from the \""},{"line_number":32,"context_line":"                       \"neutron.ml2.mechanism_drivers namespace.\")),"},{"line_number":33,"context_line":"    cfg.BoolOpt(\u0027bulk_support\u0027,"},{"line_number":34,"context_line":"                default\u003dTrue,"},{"line_number":35,"context_line":"                help\u003d_(\"Use bulk operations with ML2 drivers\"))"},{"line_number":36,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2Bhaw%3D","line":33,"in_reply_to":"AAAAUH%2F%2BhgE%3D","updated":"2014-01-24 19:50:32.000000000","message":"Done","commit_id":"bc3dd6df6b2075fd867306a6bfa0f7948f8db559"}],"neutron/plugins/ml2/drivers/mech_bigswitch/driver.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"bf9718b3a3300c7b4ee60961484188e830cc9faf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Big Switch Networks, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2F%2FpQ%3D","line":3,"updated":"2014-01-04 11:15:27.000000000","message":"nit: 2014","commit_id":"2169dc9b4c3d4282f8c3df404da6d3fd261881fc"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ff3719dfe74288c6567721e7494d7cdd1c8c3a4a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Big Switch Networks, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2F%2Fmc%3D","line":3,"in_reply_to":"AAAAUH%2F%2F%2FpQ%3D","updated":"2014-01-04 12:37:09.000000000","message":"Done","commit_id":"2169dc9b4c3d4282f8c3df404da6d3fd261881fc"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"37a01e1f7621c11fc28467eeb5894c61d4bd4e72","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class BigSwitchMechanismDriver(NeutronRestProxyV2Base,"},{"line_number":34,"context_line":"                               api.MechanismDriver):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    \"\"\"Mechanism Driver for Big Switch Networks Controller."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F8hY%3D","line":34,"updated":"2014-01-06 12:11:01.000000000","message":"Is this indentation wrong or just not visually showing up right in the review output?","commit_id":"76d20b827572c01befa6e09e0f70ef00f5c3dc9a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"296c345fc55316e0ca59b6eb38ece71876d5054d","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class BigSwitchMechanismDriver(NeutronRestProxyV2Base,"},{"line_number":34,"context_line":"                               api.MechanismDriver):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    \"\"\"Mechanism Driver for Big Switch Networks Controller."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2BmrY%3D","line":34,"in_reply_to":"AAAAUH%2F%2F8hY%3D","updated":"2014-01-24 00:51:31.000000000","message":"Looks like just a bug in the review output.","commit_id":"76d20b827572c01befa6e09e0f70ef00f5c3dc9a"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"37a01e1f7621c11fc28467eeb5894c61d4bd4e72","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        LOG.debug(_(\u0027Initializing driver\u0027))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # modify flag in ML2 plugin to disable bulk support"},{"line_number":46,"context_line":"        stack \u003d inspect.stack()"},{"line_number":47,"context_line":"        parentframe \u003d stack[2][0]"},{"line_number":48,"context_line":"        class_ref \u003d parentframe.f_locals[\u0027self\u0027].__class__"},{"line_number":49,"context_line":"        class_ref._Ml2Plugin__native_bulk_support \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F8hQ%3D","line":46,"updated":"2014-01-06 12:11:01.000000000","message":"Is there a cleaner way to change the bulk support (versus looking back into the stack frame)?","commit_id":"76d20b827572c01befa6e09e0f70ef00f5c3dc9a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"296c345fc55316e0ca59b6eb38ece71876d5054d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        LOG.debug(_(\u0027Initializing driver\u0027))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # modify flag in ML2 plugin to disable bulk support"},{"line_number":46,"context_line":"        stack \u003d inspect.stack()"},{"line_number":47,"context_line":"        parentframe \u003d stack[2][0]"},{"line_number":48,"context_line":"        class_ref \u003d parentframe.f_locals[\u0027self\u0027].__class__"},{"line_number":49,"context_line":"        class_ref._Ml2Plugin__native_bulk_support \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2BmqU%3D","line":46,"in_reply_to":"AAAAUH%2F%2F12w%3D","updated":"2014-01-24 00:51:31.000000000","message":"It\u0027s because the driver doesn\u0027t support bulk operations right now (that bug you linked to takes me to a bug in clamav). \n\nI adjusted it to a configuration driven option.","commit_id":"76d20b827572c01befa6e09e0f70ef00f5c3dc9a"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"a630018196945b53df92d020447c217db6bc0cf2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        LOG.debug(_(\u0027Initializing driver\u0027))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # modify flag in ML2 plugin to disable bulk support"},{"line_number":46,"context_line":"        stack \u003d inspect.stack()"},{"line_number":47,"context_line":"        parentframe \u003d stack[2][0]"},{"line_number":48,"context_line":"        class_ref \u003d parentframe.f_locals[\u0027self\u0027].__class__"},{"line_number":49,"context_line":"        class_ref._Ml2Plugin__native_bulk_support \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F12w%3D","line":46,"in_reply_to":"AAAAUH%2F%2F8hQ%3D","updated":"2014-01-07 21:00:56.000000000","message":"I second Paul\u0027s comment. At a minimum, I\u0027d like to see a comment in the code explaining why bulk support is being disabled. My guess is that it has to do with ml2 not yet implementing bulk operations properly (https://bugs.launchpad.net/neutron/+bug/1193861). \n\nIf so, this probably applies to any driver that makes remote calls from postcommit methods, but it may not be an issue for the L2 agent drivers. It seems that either bulk support should be properly implemented in ml2, or ml2 should allow the bulk support to be enabled/disabled via configuration.","commit_id":"76d20b827572c01befa6e09e0f70ef00f5c3dc9a"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"a630018196945b53df92d020447c217db6bc0cf2","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # init network ctrl connections"},{"line_number":52,"context_line":"        self.servers \u003d ServerPool(server_timeout)"},{"line_number":53,"context_line":"        self.segmentation_type \u003d \u0027, \u0027.join(cfg.CONF.ml2.type_drivers)"},{"line_number":54,"context_line":"        LOG.debug(_(\"Initialization done\"))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def create_network_postcommit(self, context):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F10k%3D","line":53,"updated":"2014-01-07 21:00:56.000000000","message":"I don\u0027t see where self.segmentation_type is being used. If its intended to list the network_type values that might appear in network segments, then this probably doesn\u0027t do what you want. The type_drivers config variable is the list of type driver names, which isn\u0027t necessarily the same as the list of network_type values supported by those drivers.","commit_id":"76d20b827572c01befa6e09e0f70ef00f5c3dc9a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"296c345fc55316e0ca59b6eb38ece71876d5054d","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # init network ctrl connections"},{"line_number":52,"context_line":"        self.servers \u003d ServerPool(server_timeout)"},{"line_number":53,"context_line":"        self.segmentation_type \u003d \u0027, \u0027.join(cfg.CONF.ml2.type_drivers)"},{"line_number":54,"context_line":"        LOG.debug(_(\"Initialization done\"))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def create_network_postcommit(self, context):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2BmOY%3D","line":53,"in_reply_to":"AAAAUH%2F%2F10k%3D","updated":"2014-01-24 00:51:31.000000000","message":"This is just to provide the information to the backend about the network. This patch was missing the part including it in the request.","commit_id":"76d20b827572c01befa6e09e0f70ef00f5c3dc9a"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"1a898648128f746d66ae91478dd1dbe831dec29a","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def create_port_postcommit(self, context):"},{"line_number":67,"context_line":"        # create port on the network controller"},{"line_number":68,"context_line":"        port \u003d context.current"},{"line_number":69,"context_line":"        actx \u003d ctx.get_admin_context()"},{"line_number":70,"context_line":"        port \u003d self._prepare_port_for_controller(actx, port)"},{"line_number":71,"context_line":"        net \u003d context.network.current"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUH%2F9gx0%3D","line":68,"updated":"2014-02-06 12:07:08.000000000","message":"Can consider extracting duplicate port related code L68-73 and L79-84 into function and share.","commit_id":"e70743386afd1c9dcbd18d9f0f9d321c6f6f9dc5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b51d401eebbe0773d83482a0e126c0bf48f4089a","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def create_port_postcommit(self, context):"},{"line_number":67,"context_line":"        # create port on the network controller"},{"line_number":68,"context_line":"        port \u003d context.current"},{"line_number":69,"context_line":"        actx \u003d ctx.get_admin_context()"},{"line_number":70,"context_line":"        port \u003d self._prepare_port_for_controller(actx, port)"},{"line_number":71,"context_line":"        net \u003d context.network.current"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUH%2F9bl4%3D","line":68,"in_reply_to":"AAAAUH%2F9gx0%3D","updated":"2014-02-06 23:22:03.000000000","message":"Done","commit_id":"e70743386afd1c9dcbd18d9f0f9d321c6f6f9dc5"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"4eca67d14dba9587d1ddf64dbcdbc85d8f452ba9","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def create_port_postcommit(self, context):"},{"line_number":67,"context_line":"        # create port on the network controller"},{"line_number":68,"context_line":"        port \u003d self._prepare_port_for_controller(context)"},{"line_number":69,"context_line":"        if not port:"},{"line_number":70,"context_line":"            return"},{"line_number":71,"context_line":"        self.servers.rest_create_port(port[\"network\"][\"tenant_id\"],"},{"line_number":72,"context_line":"                                      port[\"network\"][\"id\"], port)"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAUH%2F9bE8%3D","line":69,"updated":"2014-02-07 00:46:42.000000000","message":"Can just do...\n\nif port:\n    self.servers.rest_create_port(...)\n\nsame below.","commit_id":"953a995838cd5cb97414bd8b7cba746d0f83fd09"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"22fd9215eb0db49da94790d0135eaec14f5e4802","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def create_port_postcommit(self, context):"},{"line_number":67,"context_line":"        # create port on the network controller"},{"line_number":68,"context_line":"        port \u003d self._prepare_port_for_controller(context)"},{"line_number":69,"context_line":"        if not port:"},{"line_number":70,"context_line":"            return"},{"line_number":71,"context_line":"        self.servers.rest_create_port(port[\"network\"][\"tenant_id\"],"},{"line_number":72,"context_line":"                                      port[\"network\"][\"id\"], port)"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAUH%2F9bDo%3D","line":69,"in_reply_to":"AAAAUH%2F9bE8%3D","updated":"2014-02-07 00:49:26.000000000","message":"Done","commit_id":"953a995838cd5cb97414bd8b7cba746d0f83fd09"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"392359a8fcb0438f2f5fdcf2d03a161e9572c238","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        net \u003d context.network.current"},{"line_number":84,"context_line":"        self.servers.rest_delete_port(net[\"tenant_id\"], net[\"id\"], port[\u0027id\u0027])"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _prepare_port_for_controller(self, context):"},{"line_number":87,"context_line":"        port \u003d context.current"},{"line_number":88,"context_line":"        net \u003d context.network.current"},{"line_number":89,"context_line":"        port[\u0027network\u0027] \u003d net"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAUH%2F9apk%3D","line":86,"updated":"2014-02-07 02:33:23.000000000","message":"Is it possible to move this logic to the NeutronRestProxyV2Base and then have _send_xxx_port() rather than directly calling rest_xxx_port() methods? It seems like what we are doing here is a subset of what we are doing in create_port inside NeutronRestProxyV2Base.","commit_id":"6436b44cf98b5ae632d6ac5700e2fcd8c8bc43e4"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"483b98f32957dd6a01142dad399123fec5434f5c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        net \u003d context.network.current"},{"line_number":84,"context_line":"        self.servers.rest_delete_port(net[\"tenant_id\"], net[\"id\"], port[\u0027id\u0027])"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _prepare_port_for_controller(self, context):"},{"line_number":87,"context_line":"        port \u003d context.current"},{"line_number":88,"context_line":"        net \u003d context.network.current"},{"line_number":89,"context_line":"        port[\u0027network\u0027] \u003d net"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAUH%2F9ag4%3D","line":86,"in_reply_to":"AAAAUH%2F9apk%3D","updated":"2014-02-07 04:04:23.000000000","message":"They are different enough that I was having trouble doing that. \n\nIn ML2, we don\u0027t send if missing the host_id. We also get the network from different places (already in context from ML2 vs a get_network call for the plugin).  \n\nAlso, in the plugin we also need to call extend_port_dict_binding on the new db object, not the port object that gets sent to the controller. So the only thing they really have in common is the map_state_and_status call.\n\nLet me know if you had something else in mind.","commit_id":"6436b44cf98b5ae632d6ac5700e2fcd8c8bc43e4"}],"neutron/tests/unit/ml2/drivers/test_bigswitch_mech.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"bf9718b3a3300c7b4ee60961484188e830cc9faf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"# Copyright 2013 Big Switch Networks, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2F%2FpM%3D","line":2,"updated":"2014-01-04 11:15:27.000000000","message":"nit: 2014","commit_id":"2169dc9b4c3d4282f8c3df404da6d3fd261881fc"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ff3719dfe74288c6567721e7494d7cdd1c8c3a4a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"# Copyright 2013 Big Switch Networks, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2F%2FmY%3D","line":2,"in_reply_to":"AAAAUH%2F%2F%2FpM%3D","updated":"2014-01-04 12:37:09.000000000","message":"Done","commit_id":"2169dc9b4c3d4282f8c3df404da6d3fd261881fc"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"37a01e1f7621c11fc28467eeb5894c61d4bd4e72","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import neutron.tests.unit.bigswitch.test_restproxy_plugin as trp"},{"line_number":21,"context_line":"from neutron.tests.unit import test_db_plugin"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ML2_PLUGIN \u003d \u0027neutron.plugins.ml2.plugin.Ml2Plugin\u0027"},{"line_number":24,"context_line":"PHYS_NET \u003d \u0027physnet1\u0027"},{"line_number":25,"context_line":"VLAN_START \u003d 1000"},{"line_number":26,"context_line":"VLAN_END \u003d 1100"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F8gs%3D","line":23,"updated":"2014-01-06 12:11:01.000000000","message":"I see this in a few other places, should it be put in some commonly imported test file?","commit_id":"76d20b827572c01befa6e09e0f70ef00f5c3dc9a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"296c345fc55316e0ca59b6eb38ece71876d5054d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import neutron.tests.unit.bigswitch.test_restproxy_plugin as trp"},{"line_number":21,"context_line":"from neutron.tests.unit import test_db_plugin"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ML2_PLUGIN \u003d \u0027neutron.plugins.ml2.plugin.Ml2Plugin\u0027"},{"line_number":24,"context_line":"PHYS_NET \u003d \u0027physnet1\u0027"},{"line_number":25,"context_line":"VLAN_START \u003d 1000"},{"line_number":26,"context_line":"VLAN_END \u003d 1100"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2BmSw%3D","line":23,"in_reply_to":"AAAAUH%2F%2F8gs%3D","updated":"2014-01-24 00:51:31.000000000","message":"Done","commit_id":"76d20b827572c01befa6e09e0f70ef00f5c3dc9a"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"aca5a4b42e7b9e62b857bed6ce6449c158c720ab","unresolved":false,"context_lines":[{"line_number":29,"context_line":"class TestBigSwitchMechDriverNetworksV2(test_db_plugin.TestNetworksV2,"},{"line_number":30,"context_line":"                                        trp.BigSwitchProxyPluginV2TestCase):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def setUp(self):"},{"line_number":33,"context_line":"        # Configure the ML2 mechanism drivers and network types"},{"line_number":34,"context_line":"        ml2_opts \u003d {"},{"line_number":35,"context_line":"            \u0027mechanism_drivers\u0027: [\u0027bigswitch\u0027],"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2BT7w%3D","line":32,"updated":"2014-01-28 03:55:22.000000000","message":"I guess we can refactor this and the other setup() into a base class?","commit_id":"db1195225323ab40ac15b082e40baed4c00374c8"}]}
