)]}'
{"neutron/agent/l3/ha_router.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e09236e3ef479df6f10df5dc12cacca4c79fa902","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                \u0027--state_path\u003d%s\u0027 % self.agent_conf.state_path,"},{"line_number":377,"context_line":"                \u0027--user\u003d%s\u0027 % os.geteuid(),"},{"line_number":378,"context_line":"                \u0027--group\u003d%s\u0027 % os.getegid(),"},{"line_number":379,"context_line":"                \u0027--AGENT-root_helper\u003d%s\u0027 % self.agent_conf.AGENT.root_helper,"},{"line_number":380,"context_line":"                \u0027--AGENT-root_helper_daemon\u003d%s\u0027 % root_helper_daemon]"},{"line_number":381,"context_line":"            return cmd"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_08feb604","line":379,"updated":"2019-04-04 13:54:00.000000000","message":"shouldn\u0027t we do the same for root_helper also?","commit_id":"afbbec83a2578aac6aa0f16c205c5da3a788969b"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"d92cf1877b3a156339bb9dbfa230cd911eef6b89","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                \u0027--state_path\u003d%s\u0027 % self.agent_conf.state_path,"},{"line_number":377,"context_line":"                \u0027--user\u003d%s\u0027 % os.geteuid(),"},{"line_number":378,"context_line":"                \u0027--group\u003d%s\u0027 % os.getegid(),"},{"line_number":379,"context_line":"                \u0027--AGENT-root_helper\u003d%s\u0027 % self.agent_conf.AGENT.root_helper,"},{"line_number":380,"context_line":"                \u0027--AGENT-root_helper_daemon\u003d%s\u0027 % root_helper_daemon]"},{"line_number":381,"context_line":"            return cmd"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_572d3ba6","line":379,"in_reply_to":"5fc1f717_08feb604","updated":"2019-04-04 17:41:47.000000000","message":"Slawek, root_helper has a non-null default (unlike root_helper_daemon) hence why I didn\u0027t do this same for that config. If you think it is necessary i can add it too.","commit_id":"afbbec83a2578aac6aa0f16c205c5da3a788969b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"184680ce5fa75e1eebda2f4f9c701d62a9248b9f","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                \u0027--state_path\u003d%s\u0027 % self.agent_conf.state_path,"},{"line_number":377,"context_line":"                \u0027--user\u003d%s\u0027 % os.geteuid(),"},{"line_number":378,"context_line":"                \u0027--group\u003d%s\u0027 % os.getegid(),"},{"line_number":379,"context_line":"                \u0027--AGENT-root_helper\u003d%s\u0027 % self.agent_conf.AGENT.root_helper,"},{"line_number":380,"context_line":"                \u0027--AGENT-root_helper_daemon\u003d%s\u0027 % root_helper_daemon]"},{"line_number":381,"context_line":"            return cmd"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_5d447947","line":379,"in_reply_to":"5fc1f717_572d3ba6","updated":"2019-04-04 19:15:12.000000000","message":"ok, maybe it\u0027s not necessary","commit_id":"afbbec83a2578aac6aa0f16c205c5da3a788969b"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"27c0cb58d6b59a37879788d0fe2913067efef611","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                \u0027--state_path\u003d%s\u0027 % self.agent_conf.state_path,"},{"line_number":377,"context_line":"                \u0027--user\u003d%s\u0027 % os.geteuid(),"},{"line_number":378,"context_line":"                \u0027--group\u003d%s\u0027 % os.getegid(),"},{"line_number":379,"context_line":"                \u0027--AGENT-root_helper\u003d%s\u0027 % self.agent_conf.AGENT.root_helper,"},{"line_number":380,"context_line":"                \u0027--AGENT-root_helper_daemon\u003d%s\u0027 % root_helper_daemon]"},{"line_number":381,"context_line":"            return cmd"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_f1b6aedc","line":379,"in_reply_to":"5fc1f717_5d447947","updated":"2019-04-04 23:45:14.000000000","message":"https://github.com/openstack/neutron/blob/7198fb6a0a8451e60c1fbeb8111083516d23f061/neutron/conf/agent/common.py#L78\n\nYeah, setting to \"\" would mean not using sudo nor neutron-rootwrap, not sure we support that.","commit_id":"afbbec83a2578aac6aa0f16c205c5da3a788969b"}]}