)]}'
{"neutron/tests/fullstack/agents/ovs_agent.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f2c919fa92b4e7ca52f8fe271a32f2a7381feb66","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def monkeypatch_qos():"},{"line_number":43,"context_line":"    mock.patch.object(ovs_lib.OVSBridge, \u0027clear_minimum_bandwidth_qos\u0027).start()"},{"line_number":44,"context_line":"    if \"qos\" in cfg.CONF.service_plugins:"},{"line_number":45,"context_line":"        mock.patch.object(qos_extension.QosAgentExtension,"},{"line_number":46,"context_line":"                          \u0027_process_reset_port\u0027).start()"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_aadc8618","line":44,"updated":"2019-04-12 08:15:49.000000000","message":"do we need this \"if\"? What if we will mock it when \"qos\" plugin isn\u0027t loaded?","commit_id":"1c1f17688216f221abbcb6b2f598d0f5c0e1a877"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c7a35031557cccb68562bcad0754c4706ecca306","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def monkeypatch_qos():"},{"line_number":43,"context_line":"    mock.patch.object(ovs_lib.OVSBridge, \u0027clear_minimum_bandwidth_qos\u0027).start()"},{"line_number":44,"context_line":"    if \"qos\" in cfg.CONF.service_plugins:"},{"line_number":45,"context_line":"        mock.patch.object(qos_extension.QosAgentExtension,"},{"line_number":46,"context_line":"                          \u0027_process_reset_port\u0027).start()"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_42bb4971","line":44,"in_reply_to":"3fce034c_aadc8618","updated":"2019-04-16 14:41:23.000000000","message":"Well, you are right, nothing will happen. I can remove this if I respin the patch.","commit_id":"1c1f17688216f221abbcb6b2f598d0f5c0e1a877"}],"neutron/tests/fullstack/test_qos.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"093155bf64934a6c63e8f0780f400a087df63fc9","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def setUp(self):"},{"line_number":65,"context_line":"        mock.patch.object(qos_extension.QosAgentExtension,"},{"line_number":66,"context_line":"                          \u0027_process_reset_port\u0027).start()"},{"line_number":67,"context_line":"        host_desc \u003d ["},{"line_number":68,"context_line":"            environment.HostDescription("},{"line_number":69,"context_line":"                l3_agent\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_ac84e8b1","line":66,"updated":"2019-04-10 12:54:52.000000000","message":"It won\u0027t have any effect on any newly spawned l2 agent processes","commit_id":"acf22a08f9613017679b1e1fcb277bdbbd9b86c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"31c62663a74b0469f7d25dded563fb8fa1e992bc","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def setUp(self):"},{"line_number":65,"context_line":"        mock.patch.object(qos_extension.QosAgentExtension,"},{"line_number":66,"context_line":"                          \u0027_process_reset_port\u0027).start()"},{"line_number":67,"context_line":"        host_desc \u003d ["},{"line_number":68,"context_line":"            environment.HostDescription("},{"line_number":69,"context_line":"                l3_agent\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_36e9f57f","line":66,"in_reply_to":"5fc1f717_ac84e8b1","updated":"2019-04-11 08:06:43.000000000","message":"You are right. The agents are different processes and this won\u0027t mock this method.","commit_id":"acf22a08f9613017679b1e1fcb277bdbbd9b86c9"}]}
