)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6946c596d604aadff78bb1f7e001d9ede3e6e51b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t add arp responder for non tunnel network port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the vlan and vxlan both exist in env, and l2population"},{"line_number":10,"context_line":"and arp_responder are enabled, when we update a vlan port\u0027s"},{"line_number":11,"context_line":"ip address, there will be arp responder related flows added"},{"line_number":12,"context_line":"into br-tun, this will cause too many arp reply for one arp"},{"line_number":13,"context_line":"request, and vm connections will be unnormal."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fce034c_e4bee963","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":30},"updated":"2019-04-17 14:45:32.000000000","message":".","commit_id":"69e88a38a37af41dcda77216b9828bf754769e08"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6946c596d604aadff78bb1f7e001d9ede3e6e51b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t add arp responder for non tunnel network port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the vlan and vxlan both exist in env, and l2population"},{"line_number":10,"context_line":"and arp_responder are enabled, when we update a vlan port\u0027s"},{"line_number":11,"context_line":"ip address, there will be arp responder related flows added"},{"line_number":12,"context_line":"into br-tun, this will cause too many arp reply for one arp"},{"line_number":13,"context_line":"request, and vm connections will be unnormal."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fce034c_04c215ea","line":10,"range":{"start_line":10,"start_character":31,"end_line":10,"end_character":35},"updated":"2019-04-17 14:45:32.000000000","message":"If","commit_id":"69e88a38a37af41dcda77216b9828bf754769e08"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6946c596d604aadff78bb1f7e001d9ede3e6e51b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t add arp responder for non tunnel network port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the vlan and vxlan both exist in env, and l2population"},{"line_number":10,"context_line":"and arp_responder are enabled, when we update a vlan port\u0027s"},{"line_number":11,"context_line":"ip address, there will be arp responder related flows added"},{"line_number":12,"context_line":"into br-tun, this will cause too many arp reply for one arp"},{"line_number":13,"context_line":"request, and vm connections will be unnormal."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fce034c_84ada532","line":10,"range":{"start_line":10,"start_character":46,"end_line":10,"end_character":59},"updated":"2019-04-17 14:45:32.000000000","message":"a port from vlan type network","commit_id":"69e88a38a37af41dcda77216b9828bf754769e08"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6946c596d604aadff78bb1f7e001d9ede3e6e51b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"and arp_responder are enabled, when we update a vlan port\u0027s"},{"line_number":11,"context_line":"ip address, there will be arp responder related flows added"},{"line_number":12,"context_line":"into br-tun, this will cause too many arp reply for one arp"},{"line_number":13,"context_line":"request, and vm connections will be unnormal."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1824504"},{"line_number":16,"context_line":"Change-Id: I1b6154b9433a9442d3e0118dedfa01c4a9b4740b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fce034c_c4708ddf","line":13,"range":{"start_line":13,"start_character":36,"end_line":13,"end_character":44},"updated":"2019-04-17 14:45:32.000000000","message":"Can you explain more about this? And how this patch helps?","commit_id":"69e88a38a37af41dcda77216b9828bf754769e08"},{"author":{"_account_id":19956,"name":"Yang Li","email":"yang.li@easystack.cn","username":"leonstack"},"change_message_id":"dc0de0d21c8c3be1113a0856067955b015ff94ae","unresolved":false,"context_lines":[{"line_number":10,"context_line":"and arp_responder are enabled, when we update a vlan port\u0027s"},{"line_number":11,"context_line":"ip address, there will be arp responder related flows added"},{"line_number":12,"context_line":"into br-tun, this will cause too many arp reply for one arp"},{"line_number":13,"context_line":"request, and vm connections will be unnormal."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1824504"},{"line_number":16,"context_line":"Change-Id: I1b6154b9433a9442d3e0118dedfa01c4a9b4740b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ffb9cba7_4aea7a75","line":13,"range":{"start_line":13,"start_character":36,"end_line":13,"end_character":44},"in_reply_to":"3fce034c_c4708ddf","updated":"2019-04-25 01:59:32.000000000","message":"I will add some more explanation on the bug launchpad :)\nhttps://bugs.launchpad.net/neutron/+bug/1824504","commit_id":"69e88a38a37af41dcda77216b9828bf754769e08"},{"author":{"_account_id":19956,"name":"Yang Li","email":"yang.li@easystack.cn","username":"leonstack"},"change_message_id":"57af28dde5389efde48990cb1745ebf5d67d5f75","unresolved":false,"context_lines":[{"line_number":10,"context_line":"and arp_responder are enabled, when we update a vlan port\u0027s"},{"line_number":11,"context_line":"ip address, there will be arp responder related flows added"},{"line_number":12,"context_line":"into br-tun, this will cause too many arp reply for one arp"},{"line_number":13,"context_line":"request, and vm connections will be unnormal."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1824504"},{"line_number":16,"context_line":"Change-Id: I1b6154b9433a9442d3e0118dedfa01c4a9b4740b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ffb9cba7_dd171645","line":13,"range":{"start_line":13,"start_character":36,"end_line":13,"end_character":44},"in_reply_to":"ffb9cba7_4aea7a75","updated":"2019-04-25 02:28:01.000000000","message":"reproduce step:\nenv:\nWe enabled l2population in mechanism driver, and enable l2_population, arp_responder on agent side.\n\n/etc/neutron/plugins/ml2/ml2_conf.ini\n[ml2]\ntype_drivers \u003d vxlan,vlan,flat,local\ntenant_network_types \u003d vlan\nmechanism_drivers \u003dopenvswitch,l2population\n\n/etc/neutron/plugins/ml2/openvswitch_agent.ini\n[agent]\nl2_population \u003d True\narp_responder \u003d True\n\n1. Create a vlan network.\n2. Create 3 VMs(vm1, vm2, vm3) in different compute nodes(host1, host2, host3) with the vlan network.\n3. Modify vm1\u0027s ip address, for example the new ip address is 192.168.111.95.\n4. Login to host2 and host3, you will find the vm1\u0027s ip address arp related openflows in br-tun.\n# ovs-ofctl dump-flows br-tun | grep ARP | grep 192.168.111.95\n cookie\u003d0x9b7c0a4c49fcb20b, duration\u003d12.806s, table\u003d21, n_packets\u003d0, n_bytes\u003d0, idle_age\u003d12, priority\u003d1,arp,dl_vlan\u003d3,arp_tpa\u003d192.168.111.95 actions\u003dmove:NXM_OF_ETH_SRC[]-\u003eNXM_OF_ETH_DST[],mod_dl_src:fa:16:3e:ad:40:47,load:0x2-\u003eNXM_OF_ARP_OP[],move:NXM_NX_ARP_SHA[]-\u003eNXM_NX_ARP_THA[],move:NXM_OF_ARP_SPA[]-\u003eNXM_OF_ARP_TPA[],load:0xfa163ead4047-\u003eNXM_NX_ARP_SHA[],load:0xc0a86f5f-\u003eNXM_OF_ARP_SPA[],IN_PORT\n\nThen when we ping 192.168.111.95 from a VM or namespace, the first arp mac destination is ff:ff:ff:ff:ff:ff, all the compute nodes will receive this packet, and because of arp responder for 192.168.111.95, 2 or more computed nodes will reply this packet, this will make the mac looks like exist on several compute nodes, this is impossible on common situation, and it will confuse the physical switch between compute nodes, it won\u0027t know the real port the mac belong to. And then all the packet to this mac cannot be forward to the right VM.\n\nThis patch will prevent arp responder creation for port from vlan network, only create arp responder for tunnel network","commit_id":"69e88a38a37af41dcda77216b9828bf754769e08"}],"neutron/plugins/ml2/drivers/l2pop/mech_driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b5e3336a998793a6c6706bcceca1a0d8a31fc4f4","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        # We should not add arp responder for non tunnel network type"},{"line_number":124,"context_line":"        session \u003d db_api.get_session()"},{"line_number":125,"context_line":"        agent \u003d l2pop_db.get_agent_by_host(session, agent_host)"},{"line_number":126,"context_line":"        segment \u003d context.bottom_bound_segment"},{"line_number":127,"context_line":"        if not self._validate_segment(segment, port[\u0027id\u0027], agent):"},{"line_number":128,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_cb2c6a49","line":125,"updated":"2019-04-12 19:16:33.000000000","message":"I believe this was a context as the first argument.  In update_port_up() a similar call looks like this:\n\nport_context \u003d context._plugin_context                                  \nagent \u003d l2pop_db.get_agent_by_host(port_context, agent_host)","commit_id":"37742aa93f574c0ff6133879cbd3e15f35a83630"}],"neutron/tests/unit/plugins/ml2/drivers/l2pop/test_mech_driver.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8c52b7d4174190e21568e2cfa5307b0dced5f67a","unresolved":false,"context_lines":[{"line_number":1103,"context_line":"                l2pop_mech.L2PopulationAgentNotify \u003d mock.Mock()"},{"line_number":1104,"context_line":"                l2notify \u003d l2pop_mech.L2PopulationAgentNotify"},{"line_number":1105,"context_line":"                l2notify.update_fdb_entries \u003d mock.Mock()"},{"line_number":1106,"context_line":"                self.assertFalse(l2notify.update_fdb_entries.called)"},{"line_number":1107,"context_line":""},{"line_number":1108,"context_line":"    def test_fixed_ips_changed(self):"},{"line_number":1109,"context_line":"        self._register_ml2_agents()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_e35d86e9","line":1106,"updated":"2019-04-17 08:09:04.000000000","message":"You created l2notify object after calling update_device_up callback so IMO it is quite obvious that it will not be called and this check is useless here. Am I missing something here?","commit_id":"69e88a38a37af41dcda77216b9828bf754769e08"},{"author":{"_account_id":19956,"name":"Yang Li","email":"yang.li@easystack.cn","username":"leonstack"},"change_message_id":"82a66f0891fb910e6ba4ae1bbfa43ff8df2deb61","unresolved":false,"context_lines":[{"line_number":1103,"context_line":"                l2pop_mech.L2PopulationAgentNotify \u003d mock.Mock()"},{"line_number":1104,"context_line":"                l2notify \u003d l2pop_mech.L2PopulationAgentNotify"},{"line_number":1105,"context_line":"                l2notify.update_fdb_entries \u003d mock.Mock()"},{"line_number":1106,"context_line":"                self.assertFalse(l2notify.update_fdb_entries.called)"},{"line_number":1107,"context_line":""},{"line_number":1108,"context_line":"    def test_fixed_ips_changed(self):"},{"line_number":1109,"context_line":"        self._register_ml2_agents()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_94c15683","line":1106,"in_reply_to":"3fce034c_e35d86e9","updated":"2019-04-17 11:00:04.000000000","message":"The original code will call this function even it\u0027s vlan mode, that will cause problem, so I modify the code, make sure vlan mode won\u0027t call update_fdb_entries","commit_id":"69e88a38a37af41dcda77216b9828bf754769e08"}]}