)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9ac9fac1abab710c893c508bea78ac738b918f55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"91121675_d720464d","updated":"2024-02-06 10:19:38.000000000","message":"Is this still valid now we have migrated almost all operations to privsep?","commit_id":"08e6492771de4dcc2b0ce23226a17a59f0f62c00"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3ac9a0e218ad4a9a26d215bcbf4f8ff40ae702f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"47cbbe4f_e369d0e9","in_reply_to":"91121675_d720464d","updated":"2024-02-28 02:40:09.000000000","message":"I\u0027m not quite sure, but stable branches may need this.","commit_id":"08e6492771de4dcc2b0ce23226a17a59f0f62c00"}],"neutron/conf/agent/common.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"36f1a4165428658628134a1a6e02ef99a70172b1","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                help\u003d_(\"Use the root helper when listing the namespaces on a \""},{"line_number":88,"context_line":"                       \"system. This may not be required depending on the \""},{"line_number":89,"context_line":"                       \"security configuration. If the root helper is \""},{"line_number":90,"context_line":"                       \"not required, set this to False for a performance \""},{"line_number":91,"context_line":"                       \"improvement.\")),"},{"line_number":92,"context_line":"    # We can\u0027t just use root_helper\u003dsudo neutron-rootwrap-daemon $cfg because"},{"line_number":93,"context_line":"    # it isn\u0027t appropriate for long-lived processes spawned with create_process"},{"line_number":94,"context_line":"    # Having a bool use_rootwrap_daemon option precludes specifying the"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_af3bdfe8","line":91,"range":{"start_line":90,"start_character":38,"end_line":91,"end_character":36},"updated":"2019-04-17 12:58:19.000000000","message":"Here says disable \u0027root helper\u0027 to improve performance.","commit_id":"a99ab7adffda89c755229ad7875db9a1a0593a21"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"36f1a4165428658628134a1a6e02ef99a70172b1","unresolved":false,"context_lines":[{"line_number":99,"context_line":"Root helper daemon application to use when possible."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Use \u0027sudo neutron-rootwrap-daemon /etc/neutron/rootwrap.conf\u0027 to run rootwrap"},{"line_number":102,"context_line":"in \"daemon mode\" which has been reported to improve performance at scale. For"},{"line_number":103,"context_line":"more information on running rootwrap in \"daemon mode\", see:"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"https://docs.openstack.org/oslo.rootwrap/latest/user/usage.html#daemon-mode"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_8f094332","line":102,"range":{"start_line":102,"start_character":23,"end_line":102,"end_character":63},"updated":"2019-04-17 12:58:19.000000000","message":"But here says, enable \u0027root helper\u0027 to improve performance.\n\nSeems we have a conflicts now.\n\n\nBut according to our test, disable \u0027root helper\u0027 can indeed improve performance.","commit_id":"a99ab7adffda89c755229ad7875db9a1a0593a21"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5fc2e9d588c4a74dec8c758976810394dfe4e287","unresolved":false,"context_lines":[{"line_number":99,"context_line":"Root helper daemon application to use when possible."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Use \u0027sudo neutron-rootwrap-daemon /etc/neutron/rootwrap.conf\u0027 to run rootwrap"},{"line_number":102,"context_line":"in \"daemon mode\" which has been reported to improve performance at scale. For"},{"line_number":103,"context_line":"more information on running rootwrap in \"daemon mode\", see:"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"https://docs.openstack.org/oslo.rootwrap/latest/user/usage.html#daemon-mode"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_703da4db","line":102,"range":{"start_line":102,"start_character":23,"end_line":102,"end_character":63},"in_reply_to":"3fce034c_8f094332","updated":"2019-04-30 10:03:39.000000000","message":"Those are different topics:\n- use_helper_for_ns_read: uses rootwrap to list the namespaces. Depending on the security configuration, this may be not needed. For example, in my dev system, I can list the namespaces with a non-privileged user (\"stack\").\n- rootwrap daemon: instead of, every time we need to execute a privileged operation, opening a root context, the rootwrap deamon is always active and thus reducing the time to execute root commands.","commit_id":"a99ab7adffda89c755229ad7875db9a1a0593a21"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"bc01dd912ff339850d00ad6a709032cb560c8bb2","unresolved":false,"context_lines":[{"line_number":99,"context_line":"Root helper daemon application to use when possible."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Use \u0027sudo neutron-rootwrap-daemon /etc/neutron/rootwrap.conf\u0027 to run rootwrap"},{"line_number":102,"context_line":"in \"daemon mode\" which has been reported to improve performance at scale. For"},{"line_number":103,"context_line":"more information on running rootwrap in \"daemon mode\", see:"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"https://docs.openstack.org/oslo.rootwrap/latest/user/usage.html#daemon-mode"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_9d7dd0b3","line":102,"range":{"start_line":102,"start_character":23,"end_line":102,"end_character":63},"in_reply_to":"ffb9cba7_703da4db","updated":"2019-04-30 13:14:15.000000000","message":"Thanks for the information. : )\nMy test is create 100 router to l3-agent, and then restart l3-agent. Wait until all the router is synced and processed. Disable the root_helper_daemon can indeed reduce the total processing time. And when there are lots of namespace, time consumption of use_helper_for_ns_read can be also obvious.","commit_id":"a99ab7adffda89c755229ad7875db9a1a0593a21"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"00b2a171649402e2db6196e3f8ed4deb910c0099","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                      \"to skip the filtering and just run the command \""},{"line_number":84,"context_line":"                      \"directly.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027use_helper_for_ns_read\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Use the root helper when listing the namespaces on a \""},{"line_number":88,"context_line":"                       \"system. This may not be required depending on the \""},{"line_number":89,"context_line":"                       \"security configuration. If the root helper is \""}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_0dbfeefb","line":86,"updated":"2019-04-23 08:09:01.000000000","message":"how this change correlates with description below which says that it can be disabled only if security configuration allows it? Will it not break some deployments? Can\u0027t we just add proper docs instead of changing default in this case?","commit_id":"a0692a27d59accefb2915ccc796c564a47894160"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ef48685beb74c424e354e0685464d882512960dd","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                      \"to skip the filtering and just run the command \""},{"line_number":84,"context_line":"                      \"directly.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027use_helper_for_ns_read\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Use the root helper when listing the namespaces on a \""},{"line_number":88,"context_line":"                       \"system. This may not be required depending on the \""},{"line_number":89,"context_line":"                       \"security configuration. If the root helper is \""}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_c35f65e3","line":86,"in_reply_to":"ffb9cba7_0d484eca","updated":"2019-04-23 09:25:46.000000000","message":"I agree that disabling it will improve performance. It is even written in help message already. But I\u0027m still not sure if we should change default. If You need to change it, You can do it in Your deployment. And I think that we can\u0027t be sure what OS configuration other deployments have so we can probably break something during upgrade if we will change default value of this option.","commit_id":"a0692a27d59accefb2915ccc796c564a47894160"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"aeab58331e37770fff1042a8c276223782b7215e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                      \"to skip the filtering and just run the command \""},{"line_number":84,"context_line":"                      \"directly.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027use_helper_for_ns_read\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Use the root helper when listing the namespaces on a \""},{"line_number":88,"context_line":"                       \"system. This may not be required depending on the \""},{"line_number":89,"context_line":"                       \"security configuration. If the root helper is \""}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_0d484eca","line":86,"in_reply_to":"ffb9cba7_0dbfeefb","updated":"2019-04-23 08:31:23.000000000","message":"\u003e how this change correlates with description below which says that\n \u003e it can be disabled only if security configuration allows it? Will\n\nSee line 90 for that \"performance improvement\". This is related. When l3-agent needs to list all namespace, it will use rootwrap-daemon if use_helper_for_ns_read is True.\n\n \u003e it not break some deployments? Can\u0027t we just add proper docs\n \u003e instead of changing default in this case?\n\nFor my test now, it will not.","commit_id":"a0692a27d59accefb2915ccc796c564a47894160"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5fc2e9d588c4a74dec8c758976810394dfe4e287","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                      \"to skip the filtering and just run the command \""},{"line_number":84,"context_line":"                      \"directly.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027use_helper_for_ns_read\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Use the root helper when listing the namespaces on a \""},{"line_number":88,"context_line":"                       \"system. This may not be required depending on the \""},{"line_number":89,"context_line":"                       \"security configuration. If the root helper is \""}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_cb6061d2","line":86,"in_reply_to":"ffb9cba7_c35f65e3","updated":"2019-04-30 10:03:39.000000000","message":"A non privileged user can have restricted access to /var/run/netns (needed to list the namespaces).\n\nBut, in order to disable this option by default, we can test if the user can access to this directory adding a sanity check. In case the user can\u0027t access, we\u0027ll recommend to enable this option.","commit_id":"a0692a27d59accefb2915ccc796c564a47894160"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"bc01dd912ff339850d00ad6a709032cb560c8bb2","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                      \"to skip the filtering and just run the command \""},{"line_number":84,"context_line":"                      \"directly.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027use_helper_for_ns_read\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Use the root helper when listing the namespaces on a \""},{"line_number":88,"context_line":"                       \"system. This may not be required depending on the \""},{"line_number":89,"context_line":"                       \"security configuration. If the root helper is \""}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_7d525c3d","line":86,"in_reply_to":"ffb9cba7_cb6061d2","updated":"2019-04-30 13:14:15.000000000","message":"Good idea, I\u0027ll try to add it.","commit_id":"a0692a27d59accefb2915ccc796c564a47894160"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"00b2a171649402e2db6196e3f8ed4deb910c0099","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    # Having a bool use_rootwrap_daemon option precludes specifying the"},{"line_number":95,"context_line":"    # rootwrap daemon command, which may be necessary for Xen?"},{"line_number":96,"context_line":"    cfg.StrOpt(\u0027root_helper_daemon\u0027,"},{"line_number":97,"context_line":"               default\u003d\"\","},{"line_number":98,"context_line":"               help\u003d_(\"\"\""},{"line_number":99,"context_line":"Root helper daemon application to use when possible."},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_cd36b6b5","line":97,"updated":"2019-04-23 08:09:01.000000000","message":"is this really needed?","commit_id":"a0692a27d59accefb2915ccc796c564a47894160"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"aeab58331e37770fff1042a8c276223782b7215e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    # Having a bool use_rootwrap_daemon option precludes specifying the"},{"line_number":95,"context_line":"    # rootwrap daemon command, which may be necessary for Xen?"},{"line_number":96,"context_line":"    cfg.StrOpt(\u0027root_helper_daemon\u0027,"},{"line_number":97,"context_line":"               default\u003d\"\","},{"line_number":98,"context_line":"               help\u003d_(\"\"\""},{"line_number":99,"context_line":"Root helper daemon application to use when possible."},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_2d1e72ba","line":97,"in_reply_to":"ffb9cba7_cd36b6b5","updated":"2019-04-23 08:31:23.000000000","message":"\u0027StrOpt\u0027 does not override the \u0027Opt\u0027 __init__ \u0027default\u0027 param. So if this is not set, the default value will be None. This may cause some TypeError during the tests.","commit_id":"a0692a27d59accefb2915ccc796c564a47894160"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5fc2e9d588c4a74dec8c758976810394dfe4e287","unresolved":false,"context_lines":[{"line_number":98,"context_line":"Root helper daemon application to use when possible."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Use \u0027sudo neutron-rootwrap-daemon /etc/neutron/rootwrap.conf\u0027 to run rootwrap"},{"line_number":101,"context_line":"in \"daemon mode\" which has been reported to improve performance at scale. For"},{"line_number":102,"context_line":"more information on running rootwrap in \"daemon mode\", see:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"https://docs.openstack.org/oslo.rootwrap/latest/user/usage.html#daemon-mode"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffb9cba7_eb8be564","side":"PARENT","line":101,"range":{"start_line":101,"start_character":17,"end_line":101,"end_character":73},"updated":"2019-04-30 10:03:39.000000000","message":"This should be keep here because is true for single thread operations","commit_id":"0fa2e3720f0c4b0d8b91532b6edef8205e3046e2"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"bc01dd912ff339850d00ad6a709032cb560c8bb2","unresolved":false,"context_lines":[{"line_number":98,"context_line":"Root helper daemon application to use when possible."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Use \u0027sudo neutron-rootwrap-daemon /etc/neutron/rootwrap.conf\u0027 to run rootwrap"},{"line_number":101,"context_line":"in \"daemon mode\" which has been reported to improve performance at scale. For"},{"line_number":102,"context_line":"more information on running rootwrap in \"daemon mode\", see:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"https://docs.openstack.org/oslo.rootwrap/latest/user/usage.html#daemon-mode"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffb9cba7_dd602804","side":"PARENT","line":101,"range":{"start_line":101,"start_character":17,"end_line":101,"end_character":73},"in_reply_to":"ffb9cba7_eb8be564","updated":"2019-04-30 13:14:15.000000000","message":"Maybe I should add that \"single\" thread here.","commit_id":"0fa2e3720f0c4b0d8b91532b6edef8205e3046e2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"33fd9cac840db6bc9cb72cfcd86215f039e5da44","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                      \"to skip the filtering and just run the command \""},{"line_number":84,"context_line":"                      \"directly.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027use_helper_for_ns_read\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Use the root helper when listing the namespaces on a \""},{"line_number":88,"context_line":"                       \"system. This may not be required depending on the \""},{"line_number":89,"context_line":"                       \"security configuration. If the root helper is \""}],"source_content_type":"text/x-python","patch_set":5,"id":"ffb9cba7_7ad32cd6","line":86,"range":{"start_line":86,"start_character":24,"end_line":86,"end_character":29},"updated":"2019-05-01 22:17:08.000000000","message":"I\u0027m still not sure if we should change default value here because if someone currently is running Neutron on some operating system which requires root privileges to list namespaces, and he is using default value, upgrade will break such deployment and we should avoid that.\n\nInstead of changing default value we should probably better document that there is such option and in what case operator can/should change it to \"False\".","commit_id":"3a82a6472483286ade9107edbfd1f32dae109353"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"51a777915b80e74641a9e8b2325de8086ce38809","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                      \"to skip the filtering and just run the command \""},{"line_number":84,"context_line":"                      \"directly.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027use_helper_for_ns_read\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Use the root helper when listing the namespaces on a \""},{"line_number":88,"context_line":"                       \"system. This may not be required depending on the \""},{"line_number":89,"context_line":"                       \"security configuration. If the root helper is \""}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_ee61373b","line":86,"range":{"start_line":86,"start_character":24,"end_line":86,"end_character":29},"in_reply_to":"ffb9cba7_7ad32cd6","updated":"2019-05-05 03:14:46.000000000","message":"OK, this will be done in an independent patch.","commit_id":"3a82a6472483286ade9107edbfd1f32dae109353"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"05bf73e3734fa63aa57f3b142cf26b217fe33b9e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                      \"to skip the filtering and just run the command \""},{"line_number":84,"context_line":"                      \"directly.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027use_helper_for_ns_read\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Use the root helper when listing the namespaces on a \""},{"line_number":88,"context_line":"                       \"system. This may not be required depending on the \""},{"line_number":89,"context_line":"                       \"security configuration. If the root helper is \""}],"source_content_type":"text/x-python","patch_set":7,"id":"bfb3d3c7_5288411e","line":86,"range":{"start_line":86,"start_character":24,"end_line":86,"end_character":29},"updated":"2019-05-17 07:16:42.000000000","message":"Too many such call during the test:\nhttp://logs.openstack.org/09/659009/10/check/neutron-tempest-plugin-dvr-multinode-scenario/03280f4/controller/logs/screen-q-l3.txt.gz\n\n\nSo set to False to speedup.","commit_id":"254f2b0f50fddfbd7bf1f284a9352f39e3941d3e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8799887bfe8e7f398aeb058064d30aad6cc1ce80","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                      \"to skip the filtering and just run the command \""},{"line_number":84,"context_line":"                      \"directly.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027use_helper_for_ns_read\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Use the root helper when listing the namespaces on a \""},{"line_number":88,"context_line":"                       \"system. This may not be required depending on the \""},{"line_number":89,"context_line":"                       \"security configuration. If the root helper is \""}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_7a7d21e6","line":86,"updated":"2019-07-03 20:52:45.000000000","message":"I\u0027m really not sure if we should do this change. As is written in help message of this change, it may not work on some OS depending of security settings there and change default value we possibly can break some deployments.\n\nIMO we should maybe better document that there is such option, and that changing it may increase performance. But we should also highlight what security requirements it has.","commit_id":"eb185a9eb21e5255fc007da5e6f1a13b9eb3db47"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"fe29a2b371763ceda0f0d1a1c1971eb9f72ad92d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                      \"to skip the filtering and just run the command \""},{"line_number":84,"context_line":"                      \"directly.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027use_helper_for_ns_read\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Use the root helper when listing the namespaces on a \""},{"line_number":88,"context_line":"                       \"system. This may not be required depending on the \""},{"line_number":89,"context_line":"                       \"security configuration. If the root helper is \""}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_1c8502ae","line":86,"in_reply_to":"7faddb67_7a7d21e6","updated":"2019-07-04 09:24:54.000000000","message":"Firstly, this is inconsistent with the following `root_helper_daemon` default value. Why \u0027root_helper_daemon\u0027 does not consider the security settings？\nSecondly, neutron should set the better value for the configuration default value (performance improvement), so why not here?","commit_id":"eb185a9eb21e5255fc007da5e6f1a13b9eb3db47"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b472030260784f15635d999a1554e31e86e1a4e1","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                       \"significant performance degradation. So only when \""},{"line_number":93,"context_line":"                       \"your security configuration does not support running \""},{"line_number":94,"context_line":"                       \"external child processes, set this to True to ensure \""},{"line_number":95,"context_line":"                       \"that.\")),"},{"line_number":96,"context_line":"    # We can\u0027t just use root_helper\u003dsudo neutron-rootwrap-daemon $cfg because"},{"line_number":97,"context_line":"    # it isn\u0027t appropriate for long-lived processes spawned with create_process"},{"line_number":98,"context_line":"    # Having a bool use_rootwrap_daemon option precludes specifying the"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_801ee609","line":95,"updated":"2020-04-22 17:29:44.000000000","message":"I don\u0027t think we should change the help text as this option if the namespace read and not specific to the l3-agent.  Changing the value might be Ok, as I think this was related to Centos 7, but this should be in the release note as well.  I guess we should check on Centos 8 first.","commit_id":"ee5f167cfa10af4e96c6cef326ed03cde51462ce"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ae53c67f947f1c33beac106e53db5e4685622575","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                       \"significant performance degradation. So only when \""},{"line_number":93,"context_line":"                       \"your security configuration does not support running \""},{"line_number":94,"context_line":"                       \"external child processes, set this to True to ensure \""},{"line_number":95,"context_line":"                       \"that.\")),"},{"line_number":96,"context_line":"    # We can\u0027t just use root_helper\u003dsudo neutron-rootwrap-daemon $cfg because"},{"line_number":97,"context_line":"    # it isn\u0027t appropriate for long-lived processes spawned with create_process"},{"line_number":98,"context_line":"    # Having a bool use_rootwrap_daemon option precludes specifying the"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_2e15a3e5","line":95,"in_reply_to":"1f493fa4_801ee609","updated":"2020-05-20 15:51:07.000000000","message":"Done","commit_id":"ee5f167cfa10af4e96c6cef326ed03cde51462ce"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"29e79b153b3cc40282874121ade6549faaff0b57","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                       \"significant performance degradation. So only when \""},{"line_number":93,"context_line":"                       \"your security configuration does not support running \""},{"line_number":94,"context_line":"                       \"external child processes, set this to True to ensure \""},{"line_number":95,"context_line":"                       \"that.\")),"},{"line_number":96,"context_line":"    # We can\u0027t just use root_helper\u003dsudo neutron-rootwrap-daemon $cfg because"},{"line_number":97,"context_line":"    # it isn\u0027t appropriate for long-lived processes spawned with create_process"},{"line_number":98,"context_line":"    # Having a bool use_rootwrap_daemon option precludes specifying the"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f621f24_f3d163cf","line":95,"in_reply_to":"1f493fa4_801ee609","updated":"2020-11-03 08:22:58.000000000","message":"I was checking on Centos 8 today and I was able to list namespaces without using root or sudo. So this should be ok now IMO.","commit_id":"ee5f167cfa10af4e96c6cef326ed03cde51462ce"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"29e79b153b3cc40282874121ade6549faaff0b57","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                      \"to skip the filtering and just run the command \""},{"line_number":87,"context_line":"                      \"directly.\")),"},{"line_number":88,"context_line":"    cfg.BoolOpt(\u0027use_helper_for_ns_read\u0027,"},{"line_number":89,"context_line":"                default\u003dFalse,"},{"line_number":90,"context_line":"                help\u003d_(\"Use the root helper when listing the namespaces on a \""},{"line_number":91,"context_line":"                       \"system. This may not be required depending on the \""},{"line_number":92,"context_line":"                       \"security configuration. If the root helper is \""}],"source_content_type":"text/x-python","patch_set":12,"id":"1f621f24_d3aee796","line":89,"updated":"2020-11-03 08:22:58.000000000","message":"this change should be also mentioned in the release note","commit_id":"d5320f12d6d362fbeb2333202c631e9c692d0903"}],"neutron/tests/base.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"00b2a171649402e2db6196e3f8ed4deb910c0099","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"def get_rootwrap_daemon_cmd():"},{"line_number":158,"context_line":"    return os.environ.get(\u0027OS_ROOTWRAP_DAEMON_CMD\u0027, \"\")"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"class AttributeDict(dict):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_8d40be09","line":158,"range":{"start_line":158,"start_character":50,"end_line":158,"end_character":54},"updated":"2019-04-23 08:09:01.000000000","message":"what is the different between None and \"\"?","commit_id":"a0692a27d59accefb2915ccc796c564a47894160"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"aeab58331e37770fff1042a8c276223782b7215e","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"def get_rootwrap_daemon_cmd():"},{"line_number":158,"context_line":"    return os.environ.get(\u0027OS_ROOTWRAP_DAEMON_CMD\u0027, \"\")"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"class AttributeDict(dict):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_ad87c2d7","line":158,"range":{"start_line":158,"start_character":50,"end_line":158,"end_character":54},"in_reply_to":"ffb9cba7_8d40be09","updated":"2019-04-23 08:31:23.000000000","message":"\u0027StrOpt\u0027 does not override the \u0027Opt\u0027 __init__ \u0027default\u0027 param. So if this is not set, the default value will be None. This may cause some TypeError during the tests.","commit_id":"a0692a27d59accefb2915ccc796c564a47894160"}],"releasenotes/notes/disable-root_helper_daemon-cb5bf38b9af65f86.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8c791e48c1907cc2ae5f6101c7f683955c840c54","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``root_helper_daemon`` can significantly reduce the service processing"},{"line_number":5,"context_line":"    capacity. The ``root_helper_daemon`` now is set to empty (disabled) by"},{"line_number":6,"context_line":"    default."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dfbec78f_f9344795","line":6,"updated":"2019-05-10 14:25:23.000000000","message":"Is this patch in fact doing anything? Now default value is set to \"\" (empty string) and it was set to None before.\nI understand Your comment in one of previous patches that None can cause some problems in tests, but except that is there any other real change in this patch?","commit_id":"4a666f20135c1f2c3da01d4c2f09895cbd2900a5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0fa2a9baa79da284168b2ca57fc8671b92ce8a3f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``root_helper_daemon`` can significantly reduce the service processing"},{"line_number":5,"context_line":"    capacity. The ``root_helper_daemon`` now is set to empty (disabled) by"},{"line_number":6,"context_line":"    default."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dfbec78f_3c296d9a","line":6,"in_reply_to":"dfbec78f_79e5b708","updated":"2019-05-10 15:45:59.000000000","message":"Meybe we need to document this some where else.","commit_id":"4a666f20135c1f2c3da01d4c2f09895cbd2900a5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5312b1202c1df873d8b356537a9d73189d0d3176","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``root_helper_daemon`` can significantly reduce the service processing"},{"line_number":5,"context_line":"    capacity. The ``root_helper_daemon`` now is set to empty (disabled) by"},{"line_number":6,"context_line":"    default."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dfbec78f_79e5b708","line":6,"in_reply_to":"dfbec78f_f9344795","updated":"2019-05-10 14:26:18.000000000","message":"One more thing: if it is only \"tests improvement\", do we really need release note? And is this release note appropriate?","commit_id":"4a666f20135c1f2c3da01d4c2f09895cbd2900a5"}]}