)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e832f68fdc9d1863e3ed262f6a9332fa28ea30a0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"compute node if that was last port connected to this router on host."},{"line_number":12,"context_line":"Because of bug which didn\u0027t check if port which is on host has ACTIVE"},{"line_number":13,"context_line":"or INACTIVE binding, router namespace wasn\u0027t cleaned properly."},{"line_number":14,"context_line":"Now it is cleaned as only ports with ACTIVE binding are count"},{"line_number":15,"context_line":"as serviceable ports on compute node."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I01173ad64a19fc05a888c601b81ec097d579a7cf"},{"line_number":18,"context_line":"Closes-Bug: #1825205"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffb9cba7_4a4a9655","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":37},"updated":"2019-04-24 01:23:31.000000000","message":"So this looks will have conflicts with bug #1813787. During the instance booting, dvr router will wait until port set to ACTIVE (this patch) then create the related namespace? Bug #1813787\u0027s fix will let the router up first, then set the VM port to ACTIVE. So could you confirm that this patch does not have side-effect on the first dvr router install on the compute node?","commit_id":"ba600a32a542ffcb95b84e5e413f1595c25ca7dd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3f0cd3ac8ce64050c602b8c91e84834ffd364a32","unresolved":false,"context_lines":[{"line_number":11,"context_line":"compute node if that was last port connected to this router on host."},{"line_number":12,"context_line":"Because of bug which didn\u0027t check if port which is on host has ACTIVE"},{"line_number":13,"context_line":"or INACTIVE binding, router namespace wasn\u0027t cleaned properly."},{"line_number":14,"context_line":"Now it is cleaned as only ports with ACTIVE binding are count"},{"line_number":15,"context_line":"as serviceable ports on compute node."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I01173ad64a19fc05a888c601b81ec097d579a7cf"},{"line_number":18,"context_line":"Closes-Bug: #1825205"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffb9cba7_8e5f1f0d","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":37},"in_reply_to":"ffb9cba7_4a4a9655","updated":"2019-04-25 10:56:37.000000000","message":"When I was testing this patch, it worked fine every time for me. I don\u0027t think it will have any side effect in case like You mentioned. When You spawn instance, port binding is already active so it will be counted as it was before.\n\nThis patch will only change a bit things during live migration when nova first creates new binding for port on dest host, and then deactivate old binding which was still counted here thus router namespace wasn\u0027t cleaned in such case.","commit_id":"ba600a32a542ffcb95b84e5e413f1595c25ca7dd"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"fff0cfa58e4035fb0a814a1a229cab322ad3e53e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"compute node if that was last port connected to this router on host."},{"line_number":12,"context_line":"Because of bug which didn\u0027t check if port which is on host has ACTIVE"},{"line_number":13,"context_line":"or INACTIVE binding, router namespace wasn\u0027t cleaned properly."},{"line_number":14,"context_line":"Now it is cleaned as only ports with ACTIVE binding are count"},{"line_number":15,"context_line":"as serviceable ports on compute node."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I01173ad64a19fc05a888c601b81ec097d579a7cf"},{"line_number":18,"context_line":"Closes-Bug: #1825205"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_74275a14","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":37},"in_reply_to":"ffb9cba7_8e5f1f0d","updated":"2019-05-05 08:47:56.000000000","message":"\u003e When I was testing this patch, it worked fine every time for me. I\n \u003e don\u0027t think it will have any side effect in case like You\n \u003e mentioned. When You spawn instance, port binding is already active\n \u003e so it will be counted as it was before.\n \u003e \n \u003e This patch will only change a bit things during live migration when\n \u003e nova first creates new binding for port on dest host, and then\n \u003e deactivate old binding which was still counted here thus router\n \u003e namespace wasn\u0027t cleaned in such case.\n\nThanks for the details. : )","commit_id":"ba600a32a542ffcb95b84e5e413f1595c25ca7dd"}]}