)]}'
{"neutron/tests/unit/db/test_db_base_plugin_v2.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b1eecaa7f3065027dac0e38b6ee7ff40c4a36053","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"            query_params \u003d (\"fixed_ips\u003dip_address%%3D%s\u0026\""},{"line_number":1225,"context_line":"                           \"fixed_ips\u003dip_address%%3D%s\u0026\""},{"line_number":1226,"context_line":"                           \"fixed_ips\u003dsubnet_id%%3D%s\u0026\""},{"line_number":1227,"context_line":"                           \"limit\u003d500\""},{"line_number":1228,"context_line":"                           \"\" % (fixed_ips[\u0027ip_address\u0027],"},{"line_number":1229,"context_line":"                                 \u0027192.168.126.5\u0027,"},{"line_number":1230,"context_line":"                                 fixed_ips[\u0027subnet_id\u0027]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_62ed1a24","line":1227,"updated":"2019-04-25 14:42:13.000000000","message":"Since this is basically a copy/paste of above, you should try and keep the same format keeping the query params on a single line like L1212, with the limit on the next.  Or better yet create a helper method that takes an argument specifying an extra query param, like limit\u003d500, so we don\u0027t duplicate it.\n\ndiff --git a/neutron/tests/unit/db/test_db_base_plugin_v2.py b/neutron/tests/unit/db/test_db_base_plugin_v2.py\nindex 083e526706..eef6e86750 100644\n--- a/neutron/tests/unit/db/test_db_base_plugin_v2.py\n+++ b/neutron/tests/unit/db/test_db_base_plugin_v2.py\n@@ -1203,7 +1203,7 @@ class TestPortsV2(NeutronDbPluginV2TestCase):\n             ports \u003d (v1, v2, v3)\n             self._test_list_resources(\u0027port\u0027, ports)\n \n-    def test_list_ports_filtered_by_fixed_ip(self):\n+    def _test_list_ports_filtered_by_fixed_ip(self, extra_params\u003dNone):\n         # for this test we need to enable overlapping ips\n         cfg.CONF.set_default(\u0027allow_overlapping_ips\u0027, True)\n         with self.port() as port1, self.port():\n@@ -1213,9 +1213,17 @@ fixed_ips\u003dip_address%%3D%s\u0026fixed_ips\u003dip_address%%3D%s\u0026fixed_ips\u003dsubnet_id%%3D%s\n \"\"\".strip() % (fixed_ips[\u0027ip_address\u0027],\n                \u0027192.168.126.5\u0027,\n                fixed_ips[\u0027subnet_id\u0027])\n+            if extra_params:\n+                query_params \u003d query_params + extra_params\n             self._test_list_resources(\u0027port\u0027, [port1],\n                                       query_params\u003dquery_params)\n \n+    def test_list_ports_filtered_by_fixed_ip(self):\n+        self._test_list_ports_filtered_by_fixed_ip()\n+\n+    def test_list_ports_filtered_by_fixed_ip_with_limit(self):\n+        self._test_list_ports_filtered_by_fixed_ip(extra_params\u003d\u0027limit\u003d500\u0027)\n+\n     def test_list_ports_public_network(self):\n         with self.network(shared\u003dTrue) as network:\n             with self.subnet(network) as subnet:","commit_id":"0ea05c6c86eba335d967bc1dc1807483e17cbeea"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"c5ad70d96e7919798db2c5a814f05a4ae02f7bb1","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"            query_params \u003d (\"fixed_ips\u003dip_address%%3D%s\u0026\""},{"line_number":1225,"context_line":"                           \"fixed_ips\u003dip_address%%3D%s\u0026\""},{"line_number":1226,"context_line":"                           \"fixed_ips\u003dsubnet_id%%3D%s\u0026\""},{"line_number":1227,"context_line":"                           \"limit\u003d500\""},{"line_number":1228,"context_line":"                           \"\" % (fixed_ips[\u0027ip_address\u0027],"},{"line_number":1229,"context_line":"                                 \u0027192.168.126.5\u0027,"},{"line_number":1230,"context_line":"                                 fixed_ips[\u0027subnet_id\u0027]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_95a3a79e","line":1227,"updated":"2019-04-25 17:51:04.000000000","message":"Thanks for the suggestion, I applied it and I think I make it even a bit more general","commit_id":"0ea05c6c86eba335d967bc1dc1807483e17cbeea"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"56660b38818461203682041b7bd3ce1866812e4d","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"            self._test_list_resources(\u0027port\u0027, ports)"},{"line_number":1205,"context_line":""},{"line_number":1206,"context_line":"    def _test_list_ports_filtered_by_fixed_ip(self, **kwargs):"},{"line_number":1207,"context_line":""},{"line_number":1208,"context_line":"        # for this test we need to enable overlapping ips"},{"line_number":1209,"context_line":"        cfg.CONF.set_default(\u0027allow_overlapping_ips\u0027, True)"},{"line_number":1210,"context_line":"        with self.port() as port1, self.port():"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_3851920f","line":1207,"updated":"2019-04-25 18:15:11.000000000","message":"nit: extra line","commit_id":"cf8f3326be14d30456b20e4d1a55a36762daa550"}]}