)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"e0dd0d9ab69eee7f466339949fd9e98256e468f1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodolfo Alonso Hernandez \u003cralonsoh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-26 13:33:24 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Retrieve statistics from TC policy classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related-Bug: #1560963"},{"line_number":10,"context_line":"Change-Id: Ifc95051b67c031c0dfe209751df3d35c47d61148"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ffb9cba7_6dcbb471","line":7,"updated":"2019-04-26 20:04:36.000000000","message":"What is it that will consume these statistics?  Running this locally seems to work but I don\u0027t know where I would look to see the statistical information that this populates getting expressed.","commit_id":"62d25e49ebac69a62b53fbdb465b42260d385b0c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e16d20b30b4a4acdad3ac8336d96fecb8308e63f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodolfo Alonso Hernandez \u003cralonsoh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-26 13:33:24 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Retrieve statistics from TC policy classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related-Bug: #1560963"},{"line_number":10,"context_line":"Change-Id: Ifc95051b67c031c0dfe209751df3d35c47d61148"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ffb9cba7_b7f8047b","line":7,"in_reply_to":"ffb9cba7_6dcbb471","updated":"2019-04-29 08:13:26.000000000","message":"I\u0027ll add a short explanation in the commit message.\n\nInstead of submitting a massive patch, I\u0027m uploading small patches, easy to review but sometimes out of context.\n\nThese stats will be needed for the TC filter for VXLAN traffic, initially for testing.","commit_id":"62d25e49ebac69a62b53fbdb465b42260d385b0c"}],"neutron/agent/linux/tc_lib.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"f3cd24343fcb5cef74774a3fff8af6ee21c74e77","unresolved":false,"context_lines":[{"line_number":449,"context_line":"                         \u0027burst_kb\u0027: burst_kb}"},{"line_number":450,"context_line":"        tca_stats \u003d _get_attr(tc_class, \u0027TCA_STATS\u0027)"},{"line_number":451,"context_line":"        if tca_stats:"},{"line_number":452,"context_line":"            tc_class_data.update({\u0027stats\u0027: tca_stats})"},{"line_number":453,"context_line":"        classes.append(tc_class_data)"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    return classes"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfbec78f_707586f9","line":452,"range":{"start_line":452,"start_character":12,"end_line":452,"end_character":54},"updated":"2019-05-15 11:22:35.000000000","message":"Maybe just:\n\n    tc_class_data[\u0027stats\u0027] \u003d tca_stats\n\nit\u0027ll just change whatever exists under stats key, or create it if there is no such key yet.","commit_id":"b6e9077405c4f3b12cfd20fcbe9284d0fc0e46d6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa6d8963691a2f8a5acffb1c4f54bf512f6b58ce","unresolved":false,"context_lines":[{"line_number":449,"context_line":"                         \u0027burst_kb\u0027: burst_kb}"},{"line_number":450,"context_line":"        tca_stats \u003d _get_attr(tc_class, \u0027TCA_STATS\u0027)"},{"line_number":451,"context_line":"        if tca_stats:"},{"line_number":452,"context_line":"            tc_class_data.update({\u0027stats\u0027: tca_stats})"},{"line_number":453,"context_line":"        classes.append(tc_class_data)"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    return classes"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfbec78f_709106f1","line":452,"range":{"start_line":452,"start_character":12,"end_line":452,"end_character":54},"in_reply_to":"dfbec78f_707586f9","updated":"2019-05-15 11:29:25.000000000","message":"Yes, I don\u0027t know why I used dict.update","commit_id":"b6e9077405c4f3b12cfd20fcbe9284d0fc0e46d6"}],"neutron/tests/functional/agent/linux/test_tc_lib.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1cddb079c23a27c8386e913e7bee871e118915f9","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.addCleanup(self._remove_ns, self.ns[i])"},{"line_number":107,"context_line":"            ip_wrapper \u003d ip_lib.IPWrapper(self.ns[i])"},{"line_number":108,"context_line":"            if i \u003d\u003d 0:"},{"line_number":109,"context_line":"                ip_wrapper.add_veth(self.device[0], self.device[1], self.ns[1])"},{"line_number":110,"context_line":"            ip_device \u003d ip_lib.IPDevice(self.device[i], self.ns[i])"},{"line_number":111,"context_line":"            self.mac.append(ip_device.link.address)"},{"line_number":112,"context_line":"            ip_device.link.set_up()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_d5325b5e","line":109,"range":{"start_line":109,"start_character":68,"end_line":109,"end_character":78},"updated":"2019-04-28 08:21:52.000000000","message":"correct me if I\u0027m wrong but when i\u003d\u003d0 then this namespace is not created yet, so how You can add device to it?","commit_id":"62d25e49ebac69a62b53fbdb465b42260d385b0c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3cd029327be9d989fe2854f8944dc5131725cb3a","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.addCleanup(self._remove_ns, self.ns[i])"},{"line_number":107,"context_line":"            ip_wrapper \u003d ip_lib.IPWrapper(self.ns[i])"},{"line_number":108,"context_line":"            if i \u003d\u003d 0:"},{"line_number":109,"context_line":"                ip_wrapper.add_veth(self.device[0], self.device[1], self.ns[1])"},{"line_number":110,"context_line":"            ip_device \u003d ip_lib.IPDevice(self.device[i], self.ns[i])"},{"line_number":111,"context_line":"            self.mac.append(ip_device.link.address)"},{"line_number":112,"context_line":"            ip_device.link.set_up()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_bdb0e58b","line":109,"range":{"start_line":109,"start_character":68,"end_line":109,"end_character":78},"in_reply_to":"ffb9cba7_972940e7","updated":"2019-04-29 11:28:49.000000000","message":"thx. Now I think that it\u0027s done in less confusing way for readers :)","commit_id":"62d25e49ebac69a62b53fbdb465b42260d385b0c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e16d20b30b4a4acdad3ac8336d96fecb8308e63f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.addCleanup(self._remove_ns, self.ns[i])"},{"line_number":107,"context_line":"            ip_wrapper \u003d ip_lib.IPWrapper(self.ns[i])"},{"line_number":108,"context_line":"            if i \u003d\u003d 0:"},{"line_number":109,"context_line":"                ip_wrapper.add_veth(self.device[0], self.device[1], self.ns[1])"},{"line_number":110,"context_line":"            ip_device \u003d ip_lib.IPDevice(self.device[i], self.ns[i])"},{"line_number":111,"context_line":"            self.mac.append(ip_device.link.address)"},{"line_number":112,"context_line":"            ip_device.link.set_up()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_972940e7","line":109,"range":{"start_line":109,"start_character":68,"end_line":109,"end_character":78},"in_reply_to":"ffb9cba7_d5325b5e","updated":"2019-04-29 08:13:26.000000000","message":"Good question. Here you are: [1]. \"add_veth\" creates this ns. I\u0027ll refactor a bit this code.\n\n[1] https://opendev.org/openstack/neutron/src/branch/stable/stein/neutron/agent/linux/ip_lib.py#L209","commit_id":"62d25e49ebac69a62b53fbdb465b42260d385b0c"}]}
