)]}'
{"neutron/api/rpc/agentnotifiers/dhcp_rpc_agent_api.py":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"3c155471f6b9675ac974873818ef1e68e5190b8d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                \u0027active\u0027: len(active_agents),"},{"line_number":97,"context_line":"                                \u0027total\u0027: len(agents),"},{"line_number":98,"context_line":"                                \u0027net_id\u0027: network_id,"},{"line_number":99,"context_line":"                            })"},{"line_number":100,"context_line":"            for agent in agents:"},{"line_number":101,"context_line":"                self.cast("},{"line_number":102,"context_line":"                    context, self.make_msg(method,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F99Uc%3D","line":99,"updated":"2014-01-31 17:15:36.000000000","message":"Considering that the point is to determine if any of \"up\" agents are not listed as active, why not just make a comprehension of inactive agents? The check would then be if len(inactive_agents) and, addition to the current info, the  warning could list the agents that are are inactive.","commit_id":"7f1af65475d5c3c1ea5440116ed1f03a186663ff"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"08ae5632da1cbbcfa740dc4475daa62222c657d9","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                \u0027active\u0027: len(active_agents),"},{"line_number":97,"context_line":"                                \u0027total\u0027: len(agents),"},{"line_number":98,"context_line":"                                \u0027net_id\u0027: network_id,"},{"line_number":99,"context_line":"                            })"},{"line_number":100,"context_line":"            for agent in agents:"},{"line_number":101,"context_line":"                self.cast("},{"line_number":102,"context_line":"                    context, self.make_msg(method,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F99Mk%3D","line":99,"in_reply_to":"AAAAUH%2F99Rw%3D","updated":"2014-01-31 17:37:29.000000000","message":"Doh! Yes, sorry about that!","commit_id":"7f1af65475d5c3c1ea5440116ed1f03a186663ff"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"7d6764d56542ce42683389d1ed2274522a4d4750","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                \u0027active\u0027: len(active_agents),"},{"line_number":97,"context_line":"                                \u0027total\u0027: len(agents),"},{"line_number":98,"context_line":"                                \u0027net_id\u0027: network_id,"},{"line_number":99,"context_line":"                            })"},{"line_number":100,"context_line":"            for agent in agents:"},{"line_number":101,"context_line":"                self.cast("},{"line_number":102,"context_line":"                    context, self.make_msg(method,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F99Rw%3D","line":99,"in_reply_to":"AAAAUH%2F99Uc%3D","updated":"2014-01-31 17:27:13.000000000","message":"Your suggestion has merit, but given that this is a backport to havana, the change would need to hit master first.  Would you like to submit a patch that implements your suggestions?","commit_id":"7f1af65475d5c3c1ea5440116ed1f03a186663ff"}],"neutron/tests/unit/api/rpc/agentnotifiers/test_dhcp_rpc_agent_api.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"017b86a2ec71d0859076eab155c788adef80b5c8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FtGo%3D","line":1,"updated":"2014-01-09 12:03:29.000000000","message":"2014","commit_id":"7f1af65475d5c3c1ea5440116ed1f03a186663ff"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"7d6764d56542ce42683389d1ed2274522a4d4750","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F99Qs%3D","line":1,"in_reply_to":"AAAAUH%2F%2FtGo%3D","updated":"2014-01-31 17:27:13.000000000","message":"This patch is a verbatim backport of code that was merged in 2013, so I don\u0027t think any change is necessary.","commit_id":"7f1af65475d5c3c1ea5440116ed1f03a186663ff"}]}