)]}'
{"neutron/agent/linux/tc_lib.py":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"7abce2d63576ec09f65ccd66c7e3e4e837d7624f","unresolved":false,"context_lines":[{"line_number":395,"context_line":"    #   - ceil (max bw): bytes/second"},{"line_number":396,"context_line":"    #   - burst: bytes"},{"line_number":397,"context_line":"    # [1] https://www.systutorials.com/docs/linux/man/8-tc/"},{"line_number":398,"context_line":"    args \u003d {\u0027rate\u0027: int(min_kbps * 1024 / 8)}"},{"line_number":399,"context_line":"    if max_kbps:"},{"line_number":400,"context_line":"        args[\u0027ceil\u0027] \u003d int(max_kbps * 1024 / 8)"},{"line_number":401,"context_line":"    if burst_kb:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_c8f08e6a","line":398,"updated":"2019-04-26 21:03:02.000000000","message":"Is it reasonable to check and make sure that min_kbps !\u003d 0 so we don\u0027t get a divide-by-zero error, or is that done elsewhere?","commit_id":"2bf950dd67e603c7d6b17d2c2b2b60497cf0f5b7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ed86edc6d4b84b7900ada4e4f27b586f9ecabcd4","unresolved":false,"context_lines":[{"line_number":395,"context_line":"    #   - ceil (max bw): bytes/second"},{"line_number":396,"context_line":"    #   - burst: bytes"},{"line_number":397,"context_line":"    # [1] https://www.systutorials.com/docs/linux/man/8-tc/"},{"line_number":398,"context_line":"    args \u003d {\u0027rate\u0027: int(min_kbps * 1024 / 8)}"},{"line_number":399,"context_line":"    if max_kbps:"},{"line_number":400,"context_line":"        args[\u0027ceil\u0027] \u003d int(max_kbps * 1024 / 8)"},{"line_number":401,"context_line":"    if burst_kb:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_f5e99fb6","line":398,"in_reply_to":"ffb9cba7_c8f08e6a","updated":"2019-04-28 08:15:43.000000000","message":"I think we should check it. Such check was done in previous version of this code in fact.","commit_id":"2bf950dd67e603c7d6b17d2c2b2b60497cf0f5b7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b3d63e2d8e8bbf58e390171c8b8eb52e49cba653","unresolved":false,"context_lines":[{"line_number":395,"context_line":"    #   - ceil (max bw): bytes/second"},{"line_number":396,"context_line":"    #   - burst: bytes"},{"line_number":397,"context_line":"    # [1] https://www.systutorials.com/docs/linux/man/8-tc/"},{"line_number":398,"context_line":"    args \u003d {\u0027rate\u0027: int(min_kbps * 1024 / 8)}"},{"line_number":399,"context_line":"    if max_kbps:"},{"line_number":400,"context_line":"        args[\u0027ceil\u0027] \u003d int(max_kbps * 1024 / 8)"},{"line_number":401,"context_line":"    if burst_kb:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_e2da3849","line":398,"in_reply_to":"ffb9cba7_f5e99fb6","updated":"2019-04-29 09:10:51.000000000","message":"Done","commit_id":"2bf950dd67e603c7d6b17d2c2b2b60497cf0f5b7"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7543cab983fc76d87d60bbd6095ab7657fcf95c7","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class TcLibPolicyClassInvalidMinKbpsValue(exceptions.NeutronException):"},{"line_number":72,"context_line":"    message \u003d _(\"\u0027min_kbps\u0027 is mandatory in a TC class and must be \u003e\u003d 1.\")"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def convert_to_kilobits(value, base):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_d4888620","line":72,"range":{"start_line":72,"start_character":67,"end_line":72,"end_character":69},"updated":"2019-05-05 08:13:00.000000000","message":"Nit: line 64 has \"greater than\" for such value compare. So could here be \"not less than\" or \"greater or equal to\"?","commit_id":"3a4db946fdb0114b5c02f283b55c8679c159848e"}]}