)]}'
{"neutron/agent/linux/tc_lib.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"b15d181e743ac45b8abf1c93db33a8a24cac6a0e","unresolved":false,"context_lines":[{"line_number":489,"context_line":"    :param vxlan_id: (int) VXLAN ID (VNI)"},{"line_number":490,"context_line":"    :param namespace: (string) (optional) namespace name"},{"line_number":491,"context_line":"    \"\"\""},{"line_number":492,"context_line":"    keys \u003d [hex(int(vxlan_id \u003c\u003c 8)) + \u0027/\u0027 + hex(0xffffff00) + \u0027+\u0027 +"},{"line_number":493,"context_line":"            str(VXLAN_VNI_OFFSET)]"},{"line_number":494,"context_line":"    keys +\u003d [key[\u0027key\u0027] for key in"},{"line_number":495,"context_line":"             _mac_to_pyroute2_keys(src_mac, VXLAN_INNER_SRC_MAC_OFFSET)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_1b11cb04","line":492,"range":{"start_line":492,"start_character":44,"end_line":492,"end_character":58},"updated":"2019-05-15 12:45:29.000000000","message":"It\u0027s a string, why not just:\n\n    [\u0027%(vxlan)s/0xffffffff00+%(offset)s\u0027 % \n     {\u0027vxlan\u0027: hex(vxlan_id \u003c\u003c 8),\n      \u0027offset\u0027: VXLAN_INER_SRC_MAC_OFFSET}]","commit_id":"5877ae59b642072bc9b10933d216b6e5c54203fb"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"afce0439d047eb638a19378c5a4e29d3de89b923","unresolved":false,"context_lines":[{"line_number":489,"context_line":"    :param vxlan_id: (int) VXLAN ID (VNI)"},{"line_number":490,"context_line":"    :param namespace: (string) (optional) namespace name"},{"line_number":491,"context_line":"    \"\"\""},{"line_number":492,"context_line":"    keys \u003d [hex(int(vxlan_id \u003c\u003c 8)) + \u0027/\u0027 + hex(0xffffff00) + \u0027+\u0027 +"},{"line_number":493,"context_line":"            str(VXLAN_VNI_OFFSET)]"},{"line_number":494,"context_line":"    keys +\u003d [key[\u0027key\u0027] for key in"},{"line_number":495,"context_line":"             _mac_to_pyroute2_keys(src_mac, VXLAN_INNER_SRC_MAC_OFFSET)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_eb401b38","line":492,"range":{"start_line":492,"start_character":44,"end_line":492,"end_character":58},"in_reply_to":"dfbec78f_1b11cb04","updated":"2019-05-22 09:20:20.000000000","message":"Agree with writing the mask directly.","commit_id":"5877ae59b642072bc9b10933d216b6e5c54203fb"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"04bacb38ca9f1af9a3d62f8303359c8a448862e3","unresolved":false,"context_lines":[{"line_number":489,"context_line":"    :param vxlan_id: (int) VXLAN ID (VNI)"},{"line_number":490,"context_line":"    :param namespace: (string) (optional) namespace name"},{"line_number":491,"context_line":"    \"\"\""},{"line_number":492,"context_line":"    keys \u003d [hex(int(vxlan_id \u003c\u003c 8)) + \u0027/\u0027 + hex(0xffffff00) + \u0027+\u0027 +"},{"line_number":493,"context_line":"            str(VXLAN_VNI_OFFSET)]"},{"line_number":494,"context_line":"    keys +\u003d [key[\u0027key\u0027] for key in"},{"line_number":495,"context_line":"             _mac_to_pyroute2_keys(src_mac, VXLAN_INNER_SRC_MAC_OFFSET)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_36ece628","line":492,"range":{"start_line":492,"start_character":44,"end_line":492,"end_character":58},"in_reply_to":"dfbec78f_1b11cb04","updated":"2019-05-15 12:57:18.000000000","message":"VXLAN_VNI_OFFSET, ofc, not VXLAN_INNER_SRC_MAC_OFFSET :)","commit_id":"5877ae59b642072bc9b10933d216b6e5c54203fb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"52c32348c196374a6a68676fb92035f2771d02a9","unresolved":false,"context_lines":[{"line_number":494,"context_line":"    keys \u003d [hex(int(vxlan_id \u003c\u003c 8)) + \u0027/0xffffff00+\u0027 + str(VXLAN_VNI_OFFSET)]"},{"line_number":495,"context_line":"    keys +\u003d [key[\u0027key\u0027] for key in"},{"line_number":496,"context_line":"             _mac_to_pyroute2_keys(src_mac, VXLAN_INNER_SRC_MAC_OFFSET)]"},{"line_number":497,"context_line":"    priv_tc_lib.add_tc_filter_match32(device, parent, 1, classid, keys,"},{"line_number":498,"context_line":"                                      namespace\u003dnamespace)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_6c946e8c","line":497,"range":{"start_line":497,"start_character":54,"end_line":497,"end_character":55},"updated":"2019-06-04 08:10:21.000000000","message":"nit: can this be maybe replaced by some constant, like e.g. DEFAULT_PRIORITY or something like that?","commit_id":"5f99c79a504264397f3784abf295ba624241b380"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"be3fb65040b87e9adc0520dd5364e74606006ab2","unresolved":false,"context_lines":[{"line_number":494,"context_line":"    keys \u003d [hex(int(vxlan_id \u003c\u003c 8)) + \u0027/0xffffff00+\u0027 + str(VXLAN_VNI_OFFSET)]"},{"line_number":495,"context_line":"    keys +\u003d [key[\u0027key\u0027] for key in"},{"line_number":496,"context_line":"             _mac_to_pyroute2_keys(src_mac, VXLAN_INNER_SRC_MAC_OFFSET)]"},{"line_number":497,"context_line":"    priv_tc_lib.add_tc_filter_match32(device, parent, 1, classid, keys,"},{"line_number":498,"context_line":"                                      namespace\u003dnamespace)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_23f50f58","line":497,"range":{"start_line":497,"start_character":54,"end_line":497,"end_character":55},"in_reply_to":"9fb8cfa7_6c946e8c","updated":"2019-06-05 07:57:31.000000000","message":"I\u0027ll change this in followup patches","commit_id":"5f99c79a504264397f3784abf295ba624241b380"}],"neutron/tests/functional/agent/linux/test_tc_lib.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"52c32348c196374a6a68676fb92035f2771d02a9","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        self.vxlan_id \u003d 100"},{"line_number":159,"context_line":"        self.ns \u003d [\u0027ns1_\u0027 + uuidutils.generate_uuid(),"},{"line_number":160,"context_line":"                   \u0027ns2_\u0027 + uuidutils.generate_uuid()]"},{"line_number":161,"context_line":"        self.device \u003d [\u0027int1\u0027, \u0027int2\u0027]"},{"line_number":162,"context_line":"        self.device_vxlan \u003d [\u0027int_vxlan1\u0027, \u0027int_vxlan2\u0027]"},{"line_number":163,"context_line":"        self.mac_vxlan \u003d []"},{"line_number":164,"context_line":"        self.ip \u003d [\u002710.100.0.1/24\u0027, \u002710.100.0.2/24\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_6cd9ce81","line":161,"range":{"start_line":161,"start_character":13,"end_line":161,"end_character":19},"updated":"2019-06-04 08:10:21.000000000","message":"nit: devices","commit_id":"5f99c79a504264397f3784abf295ba624241b380"}]}