)]}'
{"neutron/agent/l3/extensions/port_forwarding.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"acdf039c12007eb64f8a81f9ee4d053e04ff55b6","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        (interface_name, namespace,"},{"line_number":298,"context_line":"         iptables_manager) \u003d self._get_resource_by_router(ri)"},{"line_number":299,"context_line":"        if not interface_name or not namespace or not iptables_manager:"},{"line_number":300,"context_line":"            return"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        if event_type \u003d\u003d events.CREATED:"},{"line_number":303,"context_line":"            self._process_create("}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_9275cb34","line":300,"range":{"start_line":299,"start_character":8,"end_line":300,"end_character":18},"updated":"2019-04-29 13:25:01.000000000","message":"Is this part of this patch? Or is this something not related? Sorry, but I don\u0027t understand this logic change.","commit_id":"7f74b69feb4849bcd31af63fcc59a5287ad4a864"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"233d2e2b82042a52b17b5da1586063f76e7a8d73","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        (interface_name, namespace,"},{"line_number":298,"context_line":"         iptables_manager) \u003d self._get_resource_by_router(ri)"},{"line_number":299,"context_line":"        if not interface_name or not namespace or not iptables_manager:"},{"line_number":300,"context_line":"            return"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        if event_type \u003d\u003d events.CREATED:"},{"line_number":303,"context_line":"            self._process_create("}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_3c25cd5c","line":300,"range":{"start_line":299,"start_character":8,"end_line":300,"end_character":18},"in_reply_to":"ffb9cba7_9275cb34","updated":"2019-04-30 01:37:33.000000000","message":"Done","commit_id":"7f74b69feb4849bcd31af63fcc59a5287ad4a864"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"154f93a1a89074872ec048c9086bcddf902f6de7","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        (interface_name, namespace,"},{"line_number":298,"context_line":"         iptables_manager) \u003d self._get_resource_by_router(ri)"},{"line_number":299,"context_line":"        if not interface_name or not namespace or not iptables_manager:"},{"line_number":300,"context_line":"            return"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        if event_type \u003d\u003d events.CREATED:"},{"line_number":303,"context_line":"            self._process_create("}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_c5b05b46","line":300,"range":{"start_line":299,"start_character":8,"end_line":300,"end_character":18},"in_reply_to":"ffb9cba7_9275cb34","updated":"2019-04-29 14:18:41.000000000","message":"Nice catch, it is not related.\n\nThis is my first version fix of https://bugs.launchpad.net/neutron/+bug/1825088.\nBut it is not the right approach. We have the right fix here: https://review.opendev.org/#/c/653423/","commit_id":"7f74b69feb4849bcd31af63fcc59a5287ad4a864"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8812cb6f42db0051ee3be1f6b80acc905d39617f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            self.managed_port_forwardings[port_forwarding.id] \u003d port_forwarding"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @lockutils.synchronized(\u0027port-forwarding-cache\u0027)"},{"line_number":73,"context_line":"    def get_port_forwarding(self, port_forwarding_id):"},{"line_number":74,"context_line":"        return self.managed_port_forwardings.get(port_forwarding_id)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @lockutils.synchronized(\u0027port-forwarding-cache\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_d9e936b7","line":73,"updated":"2019-06-10 09:06:34.000000000","message":"is this still used anywhere? I don\u0027t see it anywhere so maybe it can be removed?","commit_id":"d58c53ac713bb6b7c8502d9ee0254bdd95dec240"}]}