)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"4380d39564af99e01ad410a9c0997edd8ef4d4d3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sascha Peilicke \u003cspeilicke@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-09 15:33:25 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support passing \u0027insecure\u0027 to quantumclient"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using a self-signed certificate for the network service endpoint,"},{"line_number":10,"context_line":"the metadata agent has to pass the \u0027insecure\u0027 flag to quantumclient."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2FsWM%3D","line":7,"updated":"2014-01-09 15:05:24.000000000","message":"nit: neutronclient\n\nHere and line 10","commit_id":"f4c6ef58b74c4d2201aadbb1fdc16077c401ea21"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"7f0656f654bd0f61d90bb05115d903d98bcd963d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sascha Peilicke \u003cspeilicke@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-09 16:21:38 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support passing \u0027insecure\u0027 to quantumclient"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using a self-signed certificate for the network service endpoint,"},{"line_number":10,"context_line":"the metadata agent has to pass the \u0027insecure\u0027 flag to quantumclient."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2FrwA%3D","line":7,"updated":"2014-01-09 16:41:00.000000000","message":"quantumclient -\u003e neutronclient here and line 10.","commit_id":"e201da05badc4b73a5400247d8d595f9a508231c"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"63628e6864f941b263e3692fbcda5ff6eeb959f8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When using a self-signed certificate for the network service endpoint,"},{"line_number":10,"context_line":"the metadata agent has to pass the \u0027insecure\u0027 flag to quantumclient."},{"line_number":11,"context_line":"Otherwise requests will fail due to the failed certificate validity"},{"line_number":12,"context_line":"check."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I091b1620ab60184921cc12e038af5d717d4d476f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2FrOs%3D","line":12,"updated":"2014-01-09 18:40:11.000000000","message":"And is this candidate for DocImpact?","commit_id":"e201da05badc4b73a5400247d8d595f9a508231c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a141299e7a5488ad6cfdccd3e42d2f1b9be3e71f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the metadata agent has to pass the \u0027insecure\u0027 flag to neutronclient."},{"line_number":11,"context_line":"Otherwise requests will fail due to the failed certificate validity"},{"line_number":12,"context_line":"check."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":"Change-Id: I091b1620ab60184921cc12e038af5d717d4d476f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUH%2F%2FNwk%3D","line":13,"updated":"2014-01-16 09:47:46.000000000","message":"Please file a bug to launchpad and add a bug reference here. It makes us easier to track a feature addition.","commit_id":"75b7260f28df051195eb12dbdadd44254c2e2414"}],"etc/metadata_agent.ini":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a141299e7a5488ad6cfdccd3e42d2f1b9be3e71f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# requests against the Neutron API.  The server\u0027s certificate will not be"},{"line_number":14,"context_line":"# verified against any certificate authorities."},{"line_number":15,"context_line":"# This option should be used with caution."},{"line_number":16,"context_line":"# insecure \u003d False"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Network service endpoint type to pull from the keystone catalog"},{"line_number":19,"context_line":"# endpoint_type \u003d adminURL"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAUH%2F%2FNv8%3D","line":16,"updated":"2014-01-16 09:47:46.000000000","message":"As I commented in metadata_agent.py, it would be better to make the option name more self-describing.","commit_id":"75b7260f28df051195eb12dbdadd44254c2e2414"}],"neutron/agent/metadata/agent.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"4380d39564af99e01ad410a9c0997edd8ef4d4d3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                   help\u003d_(\u0027Shared secret to sign instance-id request\u0027),"},{"line_number":74,"context_line":"                   secret\u003dTrue),"},{"line_number":75,"context_line":"        cfg.BoolOpt(\u0027insecure\u0027, default\u003dFalse,"},{"line_number":76,"context_line":"                    help\u003d_(\"Explicitly allow the metadata agent to perform\""},{"line_number":77,"context_line":"                           \"\\\"insecure\\\" SSL (https) requests against the\""},{"line_number":78,"context_line":"                           \"Neutron API.  The server\u0027s certificate will not be\""},{"line_number":79,"context_line":"                           \"verified against any certificate authorities.  \""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FsWc%3D","line":76,"updated":"2014-01-09 15:05:24.000000000","message":"Add spaces to end of each line of quoted strings.","commit_id":"f4c6ef58b74c4d2201aadbb1fdc16077c401ea21"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"4380d39564af99e01ad410a9c0997edd8ef4d4d3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                    help\u003d_(\"Explicitly allow the metadata agent to perform\""},{"line_number":77,"context_line":"                           \"\\\"insecure\\\" SSL (https) requests against the\""},{"line_number":78,"context_line":"                           \"Neutron API.  The server\u0027s certificate will not be\""},{"line_number":79,"context_line":"                           \"verified against any certificate authorities.  \""},{"line_number":80,"context_line":"                           \"This option should be used with caution.\"))"},{"line_number":81,"context_line":"    ]"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FsWY%3D","line":79,"updated":"2014-01-09 15:05:24.000000000","message":"Extra space at end of this string.","commit_id":"f4c6ef58b74c4d2201aadbb1fdc16077c401ea21"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a141299e7a5488ad6cfdccd3e42d2f1b9be3e71f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":73,"context_line":"                   help\u003d_(\u0027Shared secret to sign instance-id request\u0027),"},{"line_number":74,"context_line":"                   secret\u003dTrue),"},{"line_number":75,"context_line":"        cfg.BoolOpt(\u0027insecure\u0027, default\u003dFalse,"},{"line_number":76,"context_line":"                    help\u003d_(\"Explicitly allow the metadata agent to perform \""},{"line_number":77,"context_line":"                           \"\\\"insecure\\\" SSL (https) requests against the \""},{"line_number":78,"context_line":"                           \"Neutron API. The server\u0027s certificate will not \""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FNxw%3D","line":75,"updated":"2014-01-16 09:47:46.000000000","message":"It is better to use more self-describing option name. \"insecure\" looks ambiguous though it is a parameter name passed to neutron client. How about \"use_insecure_ssl\" or similar name?","commit_id":"75b7260f28df051195eb12dbdadd44254c2e2414"},{"author":{"_account_id":4375,"name":"Sascha Peilicke","email":"sascha@peilicke.de","username":"saschpe"},"change_message_id":"bb22f55ed1627deea3ba15d5a54767493bad1502","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":73,"context_line":"                   help\u003d_(\u0027Shared secret to sign instance-id request\u0027),"},{"line_number":74,"context_line":"                   secret\u003dTrue),"},{"line_number":75,"context_line":"        cfg.BoolOpt(\u0027insecure\u0027, default\u003dFalse,"},{"line_number":76,"context_line":"                    help\u003d_(\"Explicitly allow the metadata agent to perform \""},{"line_number":77,"context_line":"                           \"\\\"insecure\\\" SSL (https) requests against the \""},{"line_number":78,"context_line":"                           \"Neutron API. The server\u0027s certificate will not \""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FNpI%3D","line":75,"in_reply_to":"AAAAUH%2F%2FNxw%3D","updated":"2014-01-16 10:19:43.000000000","message":"Most clients provide an \u0027insecure\u0027 flag, but I guess it\u0027s better to use \"neutron_insecure\".","commit_id":"75b7260f28df051195eb12dbdadd44254c2e2414"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a141299e7a5488ad6cfdccd3e42d2f1b9be3e71f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            auth_token\u003dself.auth_info.get(\u0027auth_token\u0027),"},{"line_number":96,"context_line":"            endpoint_url\u003dself.auth_info.get(\u0027endpoint_url\u0027),"},{"line_number":97,"context_line":"            endpoint_type\u003dself.conf.endpoint_type,"},{"line_number":98,"context_line":"            insecure\u003dself.conf.insecure"},{"line_number":99,"context_line":"        )"},{"line_number":100,"context_line":"        return qclient"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FNwE%3D","line":98,"updated":"2014-01-16 09:47:46.000000000","message":"What happens if insecure is False and self-signed SSL cert is used? Is some error message logged out? If not, it would be nice we have an error message which describes what happens and suggests to set \"insure\" to True.","commit_id":"75b7260f28df051195eb12dbdadd44254c2e2414"},{"author":{"_account_id":4375,"name":"Sascha Peilicke","email":"sascha@peilicke.de","username":"saschpe"},"change_message_id":"bb22f55ed1627deea3ba15d5a54767493bad1502","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            auth_token\u003dself.auth_info.get(\u0027auth_token\u0027),"},{"line_number":96,"context_line":"            endpoint_url\u003dself.auth_info.get(\u0027endpoint_url\u0027),"},{"line_number":97,"context_line":"            endpoint_type\u003dself.conf.endpoint_type,"},{"line_number":98,"context_line":"            insecure\u003dself.conf.insecure"},{"line_number":99,"context_line":"        )"},{"line_number":100,"context_line":"        return qclient"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FNmQ%3D","line":98,"in_reply_to":"AAAAUH%2F%2FNwE%3D","updated":"2014-01-16 10:19:43.000000000","message":"The exception is raised in neutronclient (https://bugs.launchpad.net/neutron/+bug/1269740), maybe it\u0027s better handled there","commit_id":"75b7260f28df051195eb12dbdadd44254c2e2414"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7f03e80194504c0042f9783df66524d05b9117c3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":73,"context_line":"                   help\u003d_(\u0027Shared secret to sign instance-id request\u0027),"},{"line_number":74,"context_line":"                   secret\u003dTrue),"},{"line_number":75,"context_line":"        cfg.BoolOpt(\u0027neutron_insecure\u0027, default\u003dFalse,"},{"line_number":76,"context_line":"                    help\u003d_(\"Explicitly allow the metadata agent to perform \""},{"line_number":77,"context_line":"                           \"\\\"insecure\\\" SSL (https) requests against the \""},{"line_number":78,"context_line":"                           \"Neutron API. The server\u0027s certificate will not \""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2FZU0%3D","line":75,"updated":"2014-02-13 14:24:23.000000000","message":"I think \u0027allow_insecure_ssl\u0027 or similar one looks better. metadata-agent is a part of neutron, so \"neutron_\" prefix has no meaning.","commit_id":"3a2f459324497f87d7dc16b69fd1fcfa6c9cc7cc"},{"author":{"_account_id":4375,"name":"Sascha Peilicke","email":"sascha@peilicke.de","username":"saschpe"},"change_message_id":"06f8d217bcf971c8dcd74c5fa134a92c194af4e0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":73,"context_line":"                   help\u003d_(\u0027Shared secret to sign instance-id request\u0027),"},{"line_number":74,"context_line":"                   secret\u003dTrue),"},{"line_number":75,"context_line":"        cfg.BoolOpt(\u0027neutron_insecure\u0027, default\u003dFalse,"},{"line_number":76,"context_line":"                    help\u003d_(\"Explicitly allow the metadata agent to perform \""},{"line_number":77,"context_line":"                           \"\\\"insecure\\\" SSL (https) requests against the \""},{"line_number":78,"context_line":"                           \"Neutron API. The server\u0027s certificate will not \""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2FZAk%3D","line":75,"in_reply_to":"AAAAUX%2F%2FZU0%3D","updated":"2014-02-13 15:00:33.000000000","message":"this was discussed before. it\u0027s insecure communication with neutron vs. insecure communication with keystone.","commit_id":"3a2f459324497f87d7dc16b69fd1fcfa6c9cc7cc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7f03e80194504c0042f9783df66524d05b9117c3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                   secret\u003dTrue),"},{"line_number":75,"context_line":"        cfg.BoolOpt(\u0027neutron_insecure\u0027, default\u003dFalse,"},{"line_number":76,"context_line":"                    help\u003d_(\"Explicitly allow the metadata agent to perform \""},{"line_number":77,"context_line":"                           \"\\\"insecure\\\" SSL (https) requests against the \""},{"line_number":78,"context_line":"                           \"Neutron API. The server\u0027s certificate will not \""},{"line_number":79,"context_line":"                           \"be verified against any certificate authorities. \""},{"line_number":80,"context_line":"                           \"This option should be used with caution.\"))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2FZUU%3D","line":77,"updated":"2014-02-13 14:24:23.000000000","message":"Nit: If you use a single quote here, backslashes are not needed.","commit_id":"3a2f459324497f87d7dc16b69fd1fcfa6c9cc7cc"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"795eb169dd5eadbac0f44acc7d99e3735ad0722f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            ca_cert\u003dself.conf.auth_ca_cert,"},{"line_number":106,"context_line":"            endpoint_url\u003dself.auth_info.get(\u0027endpoint_url\u0027),"},{"line_number":107,"context_line":"            endpoint_type\u003dself.conf.endpoint_type,"},{"line_number":108,"context_line":"            insecure\u003dself.conf.neutron_insecure"},{"line_number":109,"context_line":"        )"},{"line_number":110,"context_line":"        return qclient"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F9tWc%3D","line":108,"updated":"2014-04-02 16:48:21.000000000","message":"You\u0027re passing insecure twice.  Why?","commit_id":"81a35821da4537613a0dd59135200812ef6c4a0d"}]}