)]}'
{"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c788507e00ba1bf271e2436fa1fa9e5165e21635","unresolved":false,"context_lines":[{"line_number":595,"context_line":"                                                         v6_nets)"},{"line_number":596,"context_line":"            # Confirm whether Neutron server supports dns_name attribute in the"},{"line_number":597,"context_line":"            # ports API"},{"line_number":598,"context_line":"            dns_assignment \u003d getattr(port, \u0027dns_assignment\u0027, None)"},{"line_number":599,"context_line":"            if dns_assignment:"},{"line_number":600,"context_line":"                dns_ip_map \u003d {d.ip_address: d for d in dns_assignment}"},{"line_number":601,"context_line":"            for alloc in fixed_ips:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_48b604fd","line":598,"range":{"start_line":598,"start_character":12,"end_line":598,"end_character":66},"updated":"2019-05-08 17:11:57.000000000","message":"The problem in the \"dhcp-hostsfile\" described in the bug is here, were the host tuple is created. The port dns_assignment doesn\u0027t correspond to the one defined in the network, as you point out in the bug description.\n\nThe problem is how the dns_assignment is populated when the port is created, not this patch itself. Rather than reverting it, I would suggest to fix this problem.\n\nI also checked the information sent by the DHCP server during a DHCP request. As you can see, dnsmasq sends the correct information to the VM port:\n\nDNSMASQ PROCESS:\n5 S nobody   20091     1  0  80   0 - 12895 poll_s 16:51 ?        00:00:00 dnsmasq --no-hosts  --pid-file\u003d/opt/stack/data/neutron/dhcp/e4d5163f-3696-4d31-92c7-115762586f51/pid --dhcp-hostsfile\u003d/opt/stack/data/neutron/dhcp/e4d5163f-3696-4d31-92c7-115762586f51/host --addn-hosts\u003d/opt/stack/data/neutron/dhcp/e4d5163f-3696-4d31-92c7-115762586f51/addn_hosts --dhcp-optsfile\u003d/opt/stack/data/neutron/dhcp/e4d5163f-3696-4d31-92c7-115762586f51/opts --dhcp-leasefile\u003d/opt/stack/data/neutron/dhcp/e4d5163f-3696-4d31-92c7-115762586f51/leases --dhcp-match\u003dset:ipxe,175 --dhcp-userclass\u003dset:ipxe6,iPXE --local-service --bind-interfaces --dhcp-range\u003dset:tag0,10.0.10.0,static,255.255.255.192,86400s --dhcp-option-force\u003doption:mtu,1500 --dhcp-lease-max\u003d64 --conf-file\u003d --domain\u003done.domain.\n\n\nTHSARK CAPTURE DURING DHCP REQUEST:\n...\n    Option: (28) Broadcast Address\n        Length: 4\n        Broadcast Address: 10.0.10.63\n    Option: (6) Domain Name Server\n        Length: 4\n        Domain Name Server: 10.0.10.2\n    Option: (15) Domain Name\n        Length: 16\n        Domain Name: one.domain\n    Option: (12) Host Name\n        Length: 2\n        Host Name: aa\n...","commit_id":"0ba313e920a8f91961755b357e56377d34b77094"},{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"fd61a649a17f2d8acb33b6a7eef1e16588d6e875","unresolved":false,"context_lines":[{"line_number":595,"context_line":"                                                         v6_nets)"},{"line_number":596,"context_line":"            # Confirm whether Neutron server supports dns_name attribute in the"},{"line_number":597,"context_line":"            # ports API"},{"line_number":598,"context_line":"            dns_assignment \u003d getattr(port, \u0027dns_assignment\u0027, None)"},{"line_number":599,"context_line":"            if dns_assignment:"},{"line_number":600,"context_line":"                dns_ip_map \u003d {d.ip_address: d for d in dns_assignment}"},{"line_number":601,"context_line":"            for alloc in fixed_ips:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_f981be4b","line":598,"range":{"start_line":598,"start_character":12,"end_line":598,"end_character":66},"in_reply_to":"dfbec78f_48b604fd","updated":"2019-05-09 14:37:15.000000000","message":"I think the main point of contention here is what exactly the dns_domain field of a network is for.\n\nHistorically I understand that this was for use with external DNS integration in the form of designate, but that delineation has become muddied with the change this review reverts.\n\nIn a deployment scenario where designate is used for external DNS (i.e. floating IP\u0027s) and neutron is used to manage the internal DNS within a project network (ports on an overlay network) the dns_domain attribute becomes ambiguous as there are two sources of DNS truth - Designate and the dnsmasq instance for the network - both of which will return different IP addresses for the same hostname.","commit_id":"0ba313e920a8f91961755b357e56377d34b77094"}]}