)]}'
{"neutron/tests/unit/services/revisions/test_revision_plugin.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1610d7b48343d226893168148a259f47f03c93e7","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                         expected_code\u003dexc.HTTPPreconditionFailed.code)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_port_ip_update_revises(self):"},{"line_number":163,"context_line":"        with self.subnet() as subnet, self.port() as port:"},{"line_number":164,"context_line":"            rev \u003d port[\u0027port\u0027][\u0027revision_number\u0027]"},{"line_number":165,"context_line":"            new \u003d {\u0027port\u0027: {\u0027fixed_ips\u0027: port[\u0027port\u0027][\u0027fixed_ips\u0027]}}"},{"line_number":166,"context_line":"            # ensure adding an IP allocation updates the port"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_24113053","line":163,"range":{"start_line":163,"start_character":38,"end_line":163,"end_character":49},"updated":"2019-05-13 18:39:27.000000000","message":"I think the problem is that this port is falling-back to the default subnet, and not using the one that was just created.  I put two print statements here and found that is the case.  I think changing this to be:\n\n    self.port(subnet\u003dsubnet)\n\nWould fix the problem and use the subnet created for this test for the port, which shouldn\u0027t have a conflict with other tests.\n\nCan you confirm that?","commit_id":"7da45a6dc245f5947134de441eafc6b4e329d962"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8fddc680fc0d1829b517199820a974259d317750","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                         expected_code\u003dexc.HTTPPreconditionFailed.code)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_port_ip_update_revises(self):"},{"line_number":163,"context_line":"        with self.subnet() as subnet, self.port() as port:"},{"line_number":164,"context_line":"            rev \u003d port[\u0027port\u0027][\u0027revision_number\u0027]"},{"line_number":165,"context_line":"            new \u003d {\u0027port\u0027: {\u0027fixed_ips\u0027: port[\u0027port\u0027][\u0027fixed_ips\u0027]}}"},{"line_number":166,"context_line":"            # ensure adding an IP allocation updates the port"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_fecde484","line":163,"range":{"start_line":163,"start_character":38,"end_line":163,"end_character":49},"in_reply_to":"dfbec78f_24113053","updated":"2019-05-13 21:48:44.000000000","message":"Tomorrow I’ll check it. Thanks!","commit_id":"7da45a6dc245f5947134de441eafc6b4e329d962"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b7f4a09659a94db761d2878f1c796d862c3d48fa","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                         expected_code\u003dexc.HTTPPreconditionFailed.code)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_port_ip_update_revises(self):"},{"line_number":163,"context_line":"        with self.subnet() as subnet, self.port() as port:"},{"line_number":164,"context_line":"            rev \u003d port[\u0027port\u0027][\u0027revision_number\u0027]"},{"line_number":165,"context_line":"            new \u003d {\u0027port\u0027: {\u0027fixed_ips\u0027: port[\u0027port\u0027][\u0027fixed_ips\u0027]}}"},{"line_number":166,"context_line":"            # ensure adding an IP allocation updates the port"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_830c88ec","line":163,"range":{"start_line":163,"start_character":38,"end_line":163,"end_character":49},"in_reply_to":"dfbec78f_fecde484","updated":"2019-05-14 10:01:24.000000000","message":"You are right, we need to specify the subnet during the port creation. I\u0027ll change the bug description.","commit_id":"7da45a6dc245f5947134de441eafc6b4e329d962"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ce3d069297d6d665d7167587ed3ea8d717f74859","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                         expected_code\u003dexc.HTTPPreconditionFailed.code)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_port_ip_update_revises(self):"},{"line_number":163,"context_line":"        with self.subnet() as subnet, self.port(subnet\u003dsubnet) as port:"},{"line_number":164,"context_line":"            rev \u003d port[\u0027port\u0027][\u0027revision_number\u0027]"},{"line_number":165,"context_line":"            new \u003d {\u0027port\u0027: {\u0027fixed_ips\u0027: port[\u0027port\u0027][\u0027fixed_ips\u0027]}}"},{"line_number":166,"context_line":"            # ensure adding an IP allocation updates the port"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_b796a6ef","line":163,"updated":"2019-05-14 14:31:43.000000000","message":"I found two other cases where self.port() was mis-used, fix proposed in https://review.opendev.org/659079","commit_id":"872dd7f48400f0ee059876b01d4034aa75f97787"}]}