)]}'
{"neutron/agent/l3/ha_router.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"050a511e097c204c93cd0e038cf50b53f22a267d","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        return external_process.ProcessManager("},{"line_number":362,"context_line":"            self.agent_conf,"},{"line_number":363,"context_line":"            \u0027%s.monitor\u0027 % self.router_id,"},{"line_number":364,"context_line":"            None,"},{"line_number":365,"context_line":"            service\u003dKEEPALIVED_STATE_CHANGE_MONITOR_SERVICE_NAME,"},{"line_number":366,"context_line":"            default_cmd_callback\u003dself._get_state_change_monitor_callback(),"},{"line_number":367,"context_line":"            run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_16fc1a6e","line":364,"updated":"2019-07-19 14:39:34.000000000","message":"You can simply remove it from this list as None is default value for this argument","commit_id":"8c1da057309f5f15695ded4693fff66fc6b02c70"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fd4b123a1272c770a7494b349eed4248e6ace3f3","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        return external_process.ProcessManager("},{"line_number":362,"context_line":"            self.agent_conf,"},{"line_number":363,"context_line":"            \u0027%s.monitor\u0027 % self.router_id,"},{"line_number":364,"context_line":"            None,"},{"line_number":365,"context_line":"            service\u003dKEEPALIVED_STATE_CHANGE_MONITOR_SERVICE_NAME,"},{"line_number":366,"context_line":"            default_cmd_callback\u003dself._get_state_change_monitor_callback(),"},{"line_number":367,"context_line":"            run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_ff759164","line":364,"in_reply_to":"7faddb67_16fc1a6e","updated":"2019-07-19 16:00:09.000000000","message":"You are right, this is a keyword argument and we don\u0027t need this value there. I\u0027ll remove it in the next patch.","commit_id":"8c1da057309f5f15695ded4693fff66fc6b02c70"}],"neutron/tests/functional/agent/l3/test_keepalived_state_change.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"050a511e097c204c93cd0e038cf50b53f22a267d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def _run_monitor(self):"},{"line_number":81,"context_line":"        self.ext_process.enable()"},{"line_number":82,"context_line":"        self.addCleanup(self.ext_process.disable)"},{"line_number":83,"context_line":"        eventlet.sleep(5)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def _callback(self, *args):"},{"line_number":86,"context_line":"        return self.cmd_opts"}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_d94d55c4","line":83,"updated":"2019-07-19 14:39:34.000000000","message":"why this sleep(5)?","commit_id":"8c1da057309f5f15695ded4693fff66fc6b02c70"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fd4b123a1272c770a7494b349eed4248e6ace3f3","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def _run_monitor(self):"},{"line_number":81,"context_line":"        self.ext_process.enable()"},{"line_number":82,"context_line":"        self.addCleanup(self.ext_process.disable)"},{"line_number":83,"context_line":"        eventlet.sleep(5)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def _callback(self, *args):"},{"line_number":86,"context_line":"        return self.cmd_opts"}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_ff4cb142","line":83,"in_reply_to":"7faddb67_d94d55c4","updated":"2019-07-19 16:00:09.000000000","message":"Yes, this is totally trivial and I should implement something more elaborated to know when the process has started (waiting for the log file, for example).\n\nLet me push a new patch for this after this one.","commit_id":"8c1da057309f5f15695ded4693fff66fc6b02c70"}]}