)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"242c29be12aae839d3fb8e0b28d0a5bf5fe55ef5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-05-23 12:24:09 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adjust some HA router log"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id57dd787c254994af967db17647a3a28925714da"},{"line_number":10,"context_line":"Related-Bug: #1798475"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bfb3d3c7_ded4d7bf","line":8,"updated":"2019-05-23 13:03:50.000000000","message":"Could you just put one sentence here for the change?  thanks.","commit_id":"84cafed493ff90c3afd402eafc490fd8445c3130"}],"neutron/agent/l3/ha.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c736e0b97ded268bf34434824faee417b18d48a9","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        state_change_data \u003d {\"router_id\": router_id, \"state\": state,"},{"line_number":121,"context_line":"                             \"host\": ri.agent.host}"},{"line_number":122,"context_line":"        LOG.info(\u0027Router %(router_id)s transitioned to %(state)s on \u0027"},{"line_number":123,"context_line":"                 \u0027agent %(host)s\u0027,"},{"line_number":124,"context_line":"                 state_change_data)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # TODO(dalvarez): Fix bug 1677279 by moving the IPv6 parameters"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_4a7b1af4","line":123,"range":{"start_line":123,"start_character":26,"end_line":123,"end_character":30},"updated":"2019-05-27 08:19:45.000000000","message":"I don\u0027t understand why we need this. This line is logged in L3 agent so it should be obvious on what host it is, am I missing something?","commit_id":"84cafed493ff90c3afd402eafc490fd8445c3130"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"242c29be12aae839d3fb8e0b28d0a5bf5fe55ef5","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        state_change_data \u003d {\"router_id\": router_id, \"state\": state,"},{"line_number":121,"context_line":"                             \"host\": ri.agent.host}"},{"line_number":122,"context_line":"        LOG.info(\u0027Router %(router_id)s transitioned to %(state)s on \u0027"},{"line_number":123,"context_line":"                 \u0027agent %(host)s\u0027,"},{"line_number":124,"context_line":"                 state_change_data)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # TODO(dalvarez): Fix bug 1677279 by moving the IPv6 parameters"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_7e560b5f","line":123,"range":{"start_line":123,"start_character":18,"end_line":123,"end_character":23},"updated":"2019-05-23 13:03:50.000000000","message":"s/host","commit_id":"84cafed493ff90c3afd402eafc490fd8445c3130"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"445bbc0702baefb3856f3b29658ba3a7454e1b0e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        state_change_data \u003d {\"router_id\": router_id, \"state\": state,"},{"line_number":121,"context_line":"                             \"host\": ri.agent.host}"},{"line_number":122,"context_line":"        LOG.info(\u0027Router %(router_id)s transitioned to %(state)s on \u0027"},{"line_number":123,"context_line":"                 \u0027agent %(host)s\u0027,"},{"line_number":124,"context_line":"                 state_change_data)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # TODO(dalvarez): Fix bug 1677279 by moving the IPv6 parameters"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_853343f6","line":123,"range":{"start_line":123,"start_character":26,"end_line":123,"end_character":30},"in_reply_to":"bfb3d3c7_4a7b1af4","updated":"2019-05-27 08:56:11.000000000","message":"1. The original log (left side line 116) may not accurate, if self._get_router_info(router_id) return None, nothing actually happen. Yes, a race condition may happen here between router delete and HA state change. A very old story is here:\nhttps://review.opendev.org/#/c/275614/\n\n2. In some fullstack test, I doubt that the host for the transition is not correct, since we just run two fake l3-agent in the same physical host.","commit_id":"84cafed493ff90c3afd402eafc490fd8445c3130"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"242c29be12aae839d3fb8e0b28d0a5bf5fe55ef5","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                             \"host\": ri.agent.host}"},{"line_number":122,"context_line":"        LOG.info(\u0027Router %(router_id)s transitioned to %(state)s on \u0027"},{"line_number":123,"context_line":"                 \u0027agent %(host)s\u0027,"},{"line_number":124,"context_line":"                 state_change_data)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # TODO(dalvarez): Fix bug 1677279 by moving the IPv6 parameters"},{"line_number":127,"context_line":"        # configuration to keepalived-state-change in order to remove the"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_5e4b07af","line":124,"updated":"2019-05-23 13:03:50.000000000","message":"nit: this could be on L123","commit_id":"84cafed493ff90c3afd402eafc490fd8445c3130"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4113ad57afc386c54ef1bc9b047496e267dd6ea8","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            return"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        state_change_data \u003d {\"router_id\": router_id, \"state\": state,"},{"line_number":121,"context_line":"                             \"host\": ri.agent.host}"},{"line_number":122,"context_line":"        LOG.info(\u0027Router %(router_id)s transitioned to %(state)s on \u0027"},{"line_number":123,"context_line":"                 \u0027agent %(host)s\u0027,"},{"line_number":124,"context_line":"                 state_change_data)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_5a05c579","line":121,"range":{"start_line":121,"start_character":29,"end_line":121,"end_character":50},"updated":"2019-07-03 20:43:47.000000000","message":"is this information needed? I think it is obvious on what agent this is logged :)","commit_id":"426a5b2833966569da39f3ef9a38ba2f451da687"}],"neutron/agent/l3/ha_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ab679b466ae7aae132f9755c93d457b94bb65c03","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        pm.enable()"},{"line_number":395,"context_line":"        process_monitor.register("},{"line_number":396,"context_line":"            self.router_id, IP_MONITOR_PROCESS_SERVICE, pm)"},{"line_number":397,"context_line":"        LOG.debug(\"Router %s neutron-keepalived-state-change pid %d\","},{"line_number":398,"context_line":"                  self.router_id, pm.pid)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def destroy_state_change_monitor(self, process_monitor):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_aab90f16","line":397,"range":{"start_line":397,"start_character":29,"end_line":397,"end_character":60},"updated":"2019-07-02 15:00:10.000000000","message":"nit: STATE_CHANGE_PROC_NAME is defined above now\n\nand if we do that should use a dict","commit_id":"3f05cb09cad3102f976285f60b212eb8a2339c41"}]}