)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"7a5e566dde49ddb8677c674329a14ae308410728","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add debug information to AutoScheduler and BaseScheduler"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These new debug lines can be helpful to resolve, in case of hitting"},{"line_number":10,"context_line":"again the same problem, the mentioned bug."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I794e737c30f597519fba873e36f26b82b6f2c799"},{"line_number":13,"context_line":"Related-Bug: #1799555"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bfb3d3c7_6740aca6","line":10,"updated":"2019-05-24 11:42:09.000000000","message":"Which problem?  When someone looks back through the commit logs, they won\u0027t know.","commit_id":"c437e10b4a422b8c2747acf5e66ce0de2b2f1f95"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"18c1e5ac51436614bfca95ac08e085b7bf8909d7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add debug information to AutoScheduler and BaseScheduler"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These new debug lines can be helpful to resolve, in case of hitting"},{"line_number":10,"context_line":"again the same problem, the mentioned bug."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I794e737c30f597519fba873e36f26b82b6f2c799"},{"line_number":13,"context_line":"Related-Bug: #1799555"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bfb3d3c7_bea68aaa","line":10,"in_reply_to":"bfb3d3c7_6740aca6","updated":"2019-05-28 09:15:34.000000000","message":"Well, we always have the bug as a reference. But you are right, I should be more explicit. I\u0027ll add this detail.","commit_id":"c437e10b4a422b8c2747acf5e66ce0de2b2f1f95"}],"neutron/scheduler/base_scheduler.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"48e469e4409553b3b75a92caadba0568b9240758","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # bind the resource to the agents"},{"line_number":53,"context_line":"        self.resource_filter.bind(context, chosen_agents, resource[\u0027id\u0027])"},{"line_number":54,"context_line":"        debug_data \u003d ["},{"line_number":55,"context_line":"            \u0027(%s, %s, %s)\u0027 % (agent[\u0027agent_type\u0027], agent[\u0027id\u0027], resource[\u0027id\u0027])"},{"line_number":56,"context_line":"            for agent in chosen_agents]"},{"line_number":57,"context_line":"        LOG.debug(\u0027Resources bound and agents (agent type, agent id, resource \u0027"},{"line_number":58,"context_line":"                  \u0027id): %s\u0027, \u0027, \u0027.join(debug_data))"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_89f952c9","line":55,"range":{"start_line":55,"start_character":58,"end_line":55,"end_character":60},"updated":"2019-05-23 07:41:46.000000000","message":"maybe instead of id better would be host (or both)?","commit_id":"e25cb9b0531114c89e3686d38286a3f13315501b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"062494ee4c4ca99e25c64ace094d7b88a389fa87","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # bind the resource to the agents"},{"line_number":53,"context_line":"        self.resource_filter.bind(context, chosen_agents, resource[\u0027id\u0027])"},{"line_number":54,"context_line":"        debug_data \u003d ["},{"line_number":55,"context_line":"            \u0027(%s, %s, %s)\u0027 % (agent[\u0027agent_type\u0027], agent[\u0027id\u0027], resource[\u0027id\u0027])"},{"line_number":56,"context_line":"            for agent in chosen_agents]"},{"line_number":57,"context_line":"        LOG.debug(\u0027Resources bound and agents (agent type, agent id, resource \u0027"},{"line_number":58,"context_line":"                  \u0027id): %s\u0027, \u0027, \u0027.join(debug_data))"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_cc84380f","line":55,"range":{"start_line":55,"start_character":58,"end_line":55,"end_character":60},"in_reply_to":"bfb3d3c7_89f952c9","updated":"2019-05-23 08:42:17.000000000","message":"You are right, host ID + agent type is better  .","commit_id":"e25cb9b0531114c89e3686d38286a3f13315501b"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"7a5e566dde49ddb8677c674329a14ae308410728","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        debug_data \u003d [\u0027(%s, %s, %s)\u0027 %"},{"line_number":55,"context_line":"                      (agent[\u0027agent_type\u0027], agent[\u0027host\u0027], resource[\u0027id\u0027])"},{"line_number":56,"context_line":"                      for agent in chosen_agents]"},{"line_number":57,"context_line":"        LOG.debug(\u0027Resources bound and agents (agent type, host, resource \u0027"},{"line_number":58,"context_line":"                  \u0027id): %s\u0027, \u0027, \u0027.join(debug_data))"},{"line_number":59,"context_line":"        return chosen_agents"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_873da02c","line":57,"updated":"2019-05-24 11:42:09.000000000","message":"The string \"Resources bound and agents\" bothers me because it doesn\u0027t obviously say what is going on.  It would be better to phrase it like \"Resource %s bound to agent %s\" or something that shows the action a little more clearly.","commit_id":"c437e10b4a422b8c2747acf5e66ce0de2b2f1f95"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"18c1e5ac51436614bfca95ac08e085b7bf8909d7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        debug_data \u003d [\u0027(%s, %s, %s)\u0027 %"},{"line_number":55,"context_line":"                      (agent[\u0027agent_type\u0027], agent[\u0027host\u0027], resource[\u0027id\u0027])"},{"line_number":56,"context_line":"                      for agent in chosen_agents]"},{"line_number":57,"context_line":"        LOG.debug(\u0027Resources bound and agents (agent type, host, resource \u0027"},{"line_number":58,"context_line":"                  \u0027id): %s\u0027, \u0027, \u0027.join(debug_data))"},{"line_number":59,"context_line":"        return chosen_agents"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_9e74e637","line":57,"in_reply_to":"bfb3d3c7_873da02c","updated":"2019-05-28 09:15:34.000000000","message":"I tried to simplify this as much as possible. I can format the suggested string but be aware that the list of tuples (agent type, host, resource) can be long.\n\nIMO, I can clarify this saying:\n\"Resources bound (agent type, host, resource id): %s\"\n\nAfter the colon we\u0027ll have a list of tuples.\n\nIs that OK for you?","commit_id":"c437e10b4a422b8c2747acf5e66ce0de2b2f1f95"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"0fcd6628caea99d9f17db7a2610ddba4951da0bf","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        debug_data \u003d [\u0027(%s, %s, %s)\u0027 %"},{"line_number":55,"context_line":"                      (agent[\u0027agent_type\u0027], agent[\u0027host\u0027], resource[\u0027id\u0027])"},{"line_number":56,"context_line":"                      for agent in chosen_agents]"},{"line_number":57,"context_line":"        LOG.debug(\u0027Resources bound and agents (agent type, host, resource \u0027"},{"line_number":58,"context_line":"                  \u0027id): %s\u0027, \u0027, \u0027.join(debug_data))"},{"line_number":59,"context_line":"        return chosen_agents"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_dbb48c82","line":57,"in_reply_to":"bfb3d3c7_9e74e637","updated":"2019-05-29 19:09:43.000000000","message":"That\u0027s great, thanks!","commit_id":"c437e10b4a422b8c2747acf5e66ce0de2b2f1f95"}]}