)]}'
{"neutron/tests/functional/agent/linux/test_keepalived.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"44a184e4781c10f5845957f71af0c48fa209da0b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        # NOTE(slaweq): those are devices used in keepalived config file,"},{"line_number":51,"context_line":"        # prepared by self._get_config() method which is defined in"},{"line_number":52,"context_line":"        # neutron.tests.unit.agent.linux.test_keepalived module"},{"line_number":53,"context_line":"        dev_names \u003d [\u0027eth0\u0027, \u0027eth1\u0027, \u0027eth2\u0027, \u0027eth4\u0027, \u0027eth6\u0027, \u0027eth10\u0027]"},{"line_number":54,"context_line":"        for name in dev_names:"},{"line_number":55,"context_line":"            priv_ip_lib.create_interface(name, self.namespace, \u0027dummy\u0027)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_add1b7cf","line":53,"updated":"2019-05-23 16:56:10.000000000","message":"small nit: let me be a little squeamish about this. class KeepalivedConf (self.expected_config) should have a method to retrieve this list.","commit_id":"ab7d8943c64fbc3020f3dd0c7a875ecb21a0135b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"56d37865644cfa8aa8795ddf11d3ba5ef27f232f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        # NOTE(slaweq): those are devices used in keepalived config file,"},{"line_number":51,"context_line":"        # prepared by self._get_config() method which is defined in"},{"line_number":52,"context_line":"        # neutron.tests.unit.agent.linux.test_keepalived module"},{"line_number":53,"context_line":"        dev_names \u003d [\u0027eth0\u0027, \u0027eth1\u0027, \u0027eth2\u0027, \u0027eth4\u0027, \u0027eth6\u0027, \u0027eth10\u0027]"},{"line_number":54,"context_line":"        for name in dev_names:"},{"line_number":55,"context_line":"            priv_ip_lib.create_interface(name, self.namespace, \u0027dummy\u0027)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_6813aa5d","line":53,"in_reply_to":"bfb3d3c7_add1b7cf","updated":"2019-05-23 19:43:10.000000000","message":"I\u0027m not sure. I know that this would be more \"elegant\" solution maybe but from the other hand it would be kind of over engineering IMHO.","commit_id":"ab7d8943c64fbc3020f3dd0c7a875ecb21a0135b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"44a184e4781c10f5845957f71af0c48fa209da0b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # neutron.tests.unit.agent.linux.test_keepalived module"},{"line_number":53,"context_line":"        dev_names \u003d [\u0027eth0\u0027, \u0027eth1\u0027, \u0027eth2\u0027, \u0027eth4\u0027, \u0027eth6\u0027, \u0027eth10\u0027]"},{"line_number":54,"context_line":"        for name in dev_names:"},{"line_number":55,"context_line":"            priv_ip_lib.create_interface(name, self.namespace, \u0027dummy\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _spawn_keepalived(self, keepalived_manager):"},{"line_number":58,"context_line":"        keepalived_manager.spawn()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_ed624f3e","line":55,"range":{"start_line":55,"start_character":12,"end_line":55,"end_character":71},"updated":"2019-05-23 16:56:10.000000000","message":"small nit: This is functional testing and it\u0027s ok to use directly priv_ip_lib, but I always recommend:\n\nip_wrapper \u003d ip_lib.IPWrapper(self.namespace)\nfor name in dev_names:\n   ip_wrapper.add_dummy(name)","commit_id":"ab7d8943c64fbc3020f3dd0c7a875ecb21a0135b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"56d37865644cfa8aa8795ddf11d3ba5ef27f232f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # neutron.tests.unit.agent.linux.test_keepalived module"},{"line_number":53,"context_line":"        dev_names \u003d [\u0027eth0\u0027, \u0027eth1\u0027, \u0027eth2\u0027, \u0027eth4\u0027, \u0027eth6\u0027, \u0027eth10\u0027]"},{"line_number":54,"context_line":"        for name in dev_names:"},{"line_number":55,"context_line":"            priv_ip_lib.create_interface(name, self.namespace, \u0027dummy\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _spawn_keepalived(self, keepalived_manager):"},{"line_number":58,"context_line":"        keepalived_manager.spawn()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_880e1e30","line":55,"range":{"start_line":55,"start_character":12,"end_line":55,"end_character":71},"in_reply_to":"bfb3d3c7_ed624f3e","updated":"2019-05-23 19:43:10.000000000","message":"Done","commit_id":"ab7d8943c64fbc3020f3dd0c7a875ecb21a0135b"}]}