)]}'
{"doc/source/contributor/policies/code-reviews.rst":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b59366d15ce5eecfed44c0440e6271899b49f813","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  When impacts are identified as a result of the above steps, every effort must"},{"line_number":81,"context_line":"  be made to work with the affected sub-projects to resolve the issues."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Any change that modifies or introduces new API, should have tests coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest tests suite. There should be at least API"},{"line_number":85,"context_line":"  tests added for such new feature but the best would be if there would be API"},{"line_number":86,"context_line":"  and scenario test added where it is appropriate."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_c97703a0","line":83,"range":{"start_line":83,"start_character":41,"end_line":83,"end_character":44},"updated":"2019-05-28 15:33:08.000000000","message":"s/a new","commit_id":"801c664ee95f98904dd94fea3e0f8d7fc2381799"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b59366d15ce5eecfed44c0440e6271899b49f813","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  When impacts are identified as a result of the above steps, every effort must"},{"line_number":81,"context_line":"  be made to work with the affected sub-projects to resolve the issues."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Any change that modifies or introduces new API, should have tests coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest tests suite. There should be at least API"},{"line_number":85,"context_line":"  tests added for such new feature but the best would be if there would be API"},{"line_number":86,"context_line":"  and scenario test added where it is appropriate."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_a972cfab","line":83,"range":{"start_line":83,"start_character":62,"end_line":83,"end_character":67},"updated":"2019-05-28 15:33:08.000000000","message":"s/test","commit_id":"801c664ee95f98904dd94fea3e0f8d7fc2381799"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ff6c229f70821be062205256159b42d2e124626e","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  When impacts are identified as a result of the above steps, every effort must"},{"line_number":81,"context_line":"  be made to work with the affected sub-projects to resolve the issues."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Any change that modifies or introduces new API, should have tests coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest tests suite. There should be at least API"},{"line_number":85,"context_line":"  tests added for such new feature but the best would be if there would be API"},{"line_number":86,"context_line":"  and scenario test added where it is appropriate."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_a9b40fd2","line":83,"range":{"start_line":83,"start_character":62,"end_line":83,"end_character":67},"in_reply_to":"bfb3d3c7_a972cfab","updated":"2019-05-28 15:48:13.000000000","message":"Done","commit_id":"801c664ee95f98904dd94fea3e0f8d7fc2381799"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ff6c229f70821be062205256159b42d2e124626e","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  When impacts are identified as a result of the above steps, every effort must"},{"line_number":81,"context_line":"  be made to work with the affected sub-projects to resolve the issues."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Any change that modifies or introduces new API, should have tests coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest tests suite. There should be at least API"},{"line_number":85,"context_line":"  tests added for such new feature but the best would be if there would be API"},{"line_number":86,"context_line":"  and scenario test added where it is appropriate."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_69ca974e","line":83,"range":{"start_line":83,"start_character":41,"end_line":83,"end_character":44},"in_reply_to":"bfb3d3c7_c97703a0","updated":"2019-05-28 15:48:13.000000000","message":"Done","commit_id":"801c664ee95f98904dd94fea3e0f8d7fc2381799"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b59366d15ce5eecfed44c0440e6271899b49f813","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  be made to work with the affected sub-projects to resolve the issues."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Any change that modifies or introduces new API, should have tests coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest tests suite. There should be at least API"},{"line_number":85,"context_line":"  tests added for such new feature but the best would be if there would be API"},{"line_number":86,"context_line":"  and scenario test added where it is appropriate."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_696857b8","line":84,"range":{"start_line":84,"start_character":74,"end_line":84,"end_character":77},"updated":"2019-05-28 15:33:08.000000000","message":"s/one API","commit_id":"801c664ee95f98904dd94fea3e0f8d7fc2381799"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ff6c229f70821be062205256159b42d2e124626e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  be made to work with the affected sub-projects to resolve the issues."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Any change that modifies or introduces new API, should have tests coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest tests suite. There should be at least API"},{"line_number":85,"context_line":"  tests added for such new feature but the best would be if there would be API"},{"line_number":86,"context_line":"  and scenario test added where it is appropriate."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_c9de2310","line":84,"range":{"start_line":84,"start_character":74,"end_line":84,"end_character":77},"in_reply_to":"bfb3d3c7_696857b8","updated":"2019-05-28 15:48:13.000000000","message":"Done","commit_id":"801c664ee95f98904dd94fea3e0f8d7fc2381799"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b59366d15ce5eecfed44c0440e6271899b49f813","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Any change that modifies or introduces new API, should have tests coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest tests suite. There should be at least API"},{"line_number":85,"context_line":"  tests added for such new feature but the best would be if there would be API"},{"line_number":86,"context_line":"  and scenario test added where it is appropriate."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. _spec-review-practices:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_c99ce3c1","line":85,"range":{"start_line":85,"start_character":18,"end_line":85,"end_character":22},"updated":"2019-05-28 15:33:08.000000000","message":"s/a ?","commit_id":"801c664ee95f98904dd94fea3e0f8d7fc2381799"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b59366d15ce5eecfed44c0440e6271899b49f813","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Any change that modifies or introduces new API, should have tests coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest tests suite. There should be at least API"},{"line_number":85,"context_line":"  tests added for such new feature but the best would be if there would be API"},{"line_number":86,"context_line":"  and scenario test added where it is appropriate."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. _spec-review-practices:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_a9a72f0b","line":85,"range":{"start_line":85,"start_character":39,"end_line":85,"end_character":74},"updated":"2019-05-28 15:33:08.000000000","message":"s/it is preferred that both ?","commit_id":"801c664ee95f98904dd94fea3e0f8d7fc2381799"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b59366d15ce5eecfed44c0440e6271899b49f813","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Any change that modifies or introduces new API, should have tests coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest tests suite. There should be at least API"},{"line_number":85,"context_line":"  tests added for such new feature but the best would be if there would be API"},{"line_number":86,"context_line":"  and scenario test added where it is appropriate."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. _spec-review-practices:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_09619bd3","line":85,"range":{"start_line":85,"start_character":2,"end_line":85,"end_character":7},"updated":"2019-05-28 15:33:08.000000000","message":"s/test","commit_id":"801c664ee95f98904dd94fea3e0f8d7fc2381799"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ff6c229f70821be062205256159b42d2e124626e","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Any change that modifies or introduces new API, should have tests coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest tests suite. There should be at least API"},{"line_number":85,"context_line":"  tests added for such new feature but the best would be if there would be API"},{"line_number":86,"context_line":"  and scenario test added where it is appropriate."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. _spec-review-practices:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_89e4abe1","line":85,"range":{"start_line":85,"start_character":2,"end_line":85,"end_character":7},"in_reply_to":"bfb3d3c7_09619bd3","updated":"2019-05-28 15:48:13.000000000","message":"Done","commit_id":"801c664ee95f98904dd94fea3e0f8d7fc2381799"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ff6c229f70821be062205256159b42d2e124626e","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Any change that modifies or introduces new API, should have tests coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest tests suite. There should be at least API"},{"line_number":85,"context_line":"  tests added for such new feature but the best would be if there would be API"},{"line_number":86,"context_line":"  and scenario test added where it is appropriate."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. _spec-review-practices:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_09d8bb1b","line":85,"range":{"start_line":85,"start_character":39,"end_line":85,"end_character":74},"in_reply_to":"bfb3d3c7_a9a72f0b","updated":"2019-05-28 15:48:13.000000000","message":"Done","commit_id":"801c664ee95f98904dd94fea3e0f8d7fc2381799"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ff6c229f70821be062205256159b42d2e124626e","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Any change that modifies or introduces new API, should have tests coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest tests suite. There should be at least API"},{"line_number":85,"context_line":"  tests added for such new feature but the best would be if there would be API"},{"line_number":86,"context_line":"  and scenario test added where it is appropriate."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. _spec-review-practices:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_49fb1378","line":85,"range":{"start_line":85,"start_character":18,"end_line":85,"end_character":22},"in_reply_to":"bfb3d3c7_c99ce3c1","updated":"2019-05-28 15:48:13.000000000","message":"Done","commit_id":"801c664ee95f98904dd94fea3e0f8d7fc2381799"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b59366d15ce5eecfed44c0440e6271899b49f813","unresolved":false,"context_lines":[{"line_number":83,"context_line":"* Any change that modifies or introduces new API, should have tests coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest tests suite. There should be at least API"},{"line_number":85,"context_line":"  tests added for such new feature but the best would be if there would be API"},{"line_number":86,"context_line":"  and scenario test added where it is appropriate."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. _spec-review-practices:"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_69adb7e7","line":86,"range":{"start_line":86,"start_character":15,"end_line":86,"end_character":19},"updated":"2019-05-28 15:33:08.000000000","message":"s/tests","commit_id":"801c664ee95f98904dd94fea3e0f8d7fc2381799"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ff6c229f70821be062205256159b42d2e124626e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"* Any change that modifies or introduces new API, should have tests coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest tests suite. There should be at least API"},{"line_number":85,"context_line":"  tests added for such new feature but the best would be if there would be API"},{"line_number":86,"context_line":"  and scenario test added where it is appropriate."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. _spec-review-practices:"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_29eedfb3","line":86,"range":{"start_line":86,"start_character":15,"end_line":86,"end_character":19},"in_reply_to":"bfb3d3c7_69adb7e7","updated":"2019-05-28 15:48:13.000000000","message":"Done","commit_id":"801c664ee95f98904dd94fea3e0f8d7fc2381799"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"f5508b2035dd4cc0be5260473e82749013f853ae","unresolved":false,"context_lines":[{"line_number":83,"context_line":"* Any change that modifies or introduces a new API, should have test coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest tests suite. There should be at least one"},{"line_number":85,"context_line":"  API test added for a new feature but it is preferred that both API and"},{"line_number":86,"context_line":"  scenario tests added where it is appropriate."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. _spec-review-practices:"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_afce4fb1","line":86,"updated":"2019-05-28 16:56:41.000000000","message":"Perhaps we should add that tests should not just cover the base level of functionality but also standard ways in which the functionality can be used.  For example, if the feature adds a new kind of networking then tests should make sure that instances can use IPs provided by that networking, can be migrated, etc.","commit_id":"6401802576bf3987dfc8feae01ac4b0a6be07682"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"715759aa99487ac70e9f1f9124a35f624e1d534a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"* Any change that modifies or introduces a new API, should have test coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest tests suite. There should be at least one"},{"line_number":85,"context_line":"  API test added for a new feature but it is preferred that both API and"},{"line_number":86,"context_line":"  scenario tests added where it is appropriate."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. _spec-review-practices:"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_8ff02bff","line":86,"range":{"start_line":86,"start_character":17,"end_line":86,"end_character":22},"updated":"2019-05-28 16:55:59.000000000","message":"be added","commit_id":"6401802576bf3987dfc8feae01ac4b0a6be07682"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9e59f047e1e74b527978d7c2a8f41e7657101932","unresolved":false,"context_lines":[{"line_number":83,"context_line":"* Any change that modifies or introduces a new API, should have test coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest tests suite. There should be at least one"},{"line_number":85,"context_line":"  API test added for a new feature but it is preferred that both API and"},{"line_number":86,"context_line":"  scenario tests added where it is appropriate."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. _spec-review-practices:"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_f7edf1b6","line":86,"range":{"start_line":86,"start_character":17,"end_line":86,"end_character":22},"in_reply_to":"bfb3d3c7_8ff02bff","updated":"2019-05-29 08:08:41.000000000","message":"Done","commit_id":"6401802576bf3987dfc8feae01ac4b0a6be07682"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9e59f047e1e74b527978d7c2a8f41e7657101932","unresolved":false,"context_lines":[{"line_number":83,"context_line":"* Any change that modifies or introduces a new API, should have test coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest tests suite. There should be at least one"},{"line_number":85,"context_line":"  API test added for a new feature but it is preferred that both API and"},{"line_number":86,"context_line":"  scenario tests added where it is appropriate."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. _spec-review-practices:"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_d7f0ed93","line":86,"in_reply_to":"bfb3d3c7_afce4fb1","updated":"2019-05-29 08:08:41.000000000","message":"Done","commit_id":"6401802576bf3987dfc8feae01ac4b0a6be07682"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"73488dd28a457abd3f9f07ef69efc5fcf110aefa","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  be made to work with the affected sub-projects to resolve the issues."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Any change that modifies or introduces a new API should have test coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest test suites. There should be at least one"},{"line_number":85,"context_line":"  API test added for a new feature, but it is preferred that both API and"},{"line_number":86,"context_line":"  scenario tests be added where it is appropriate."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  Scenario tests should cover not only the base level of new functionality, but"},{"line_number":89,"context_line":"  also standard ways in which the functionality can be used. For example, if the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bfb3d3c7_34a4e0b9","line":86,"range":{"start_line":84,"start_character":49,"end_line":86,"end_character":50},"updated":"2019-05-29 13:43:37.000000000","message":"I would add here one negative testcase where possible, but not sure if that is alligned with current openstack community rules.\nNegative tests can help to understand the limits of the feature.","commit_id":"7e09f836099c3cc96d6cba718e839b8d7b8b4799"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9b01a1a4b5bb09cc135eb8704564df782e64fd03","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  be made to work with the affected sub-projects to resolve the issues."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Any change that modifies or introduces a new API should have test coverage in"},{"line_number":84,"context_line":"  neutron-tempest-plugin or tempest test suites. There should be at least one"},{"line_number":85,"context_line":"  API test added for a new feature, but it is preferred that both API and"},{"line_number":86,"context_line":"  scenario tests be added where it is appropriate."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  Scenario tests should cover not only the base level of new functionality, but"},{"line_number":89,"context_line":"  also standard ways in which the functionality can be used. For example, if the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bfb3d3c7_077f1ee0","line":86,"range":{"start_line":84,"start_character":49,"end_line":86,"end_character":50},"in_reply_to":"bfb3d3c7_34a4e0b9","updated":"2019-05-30 09:12:54.000000000","message":"Done","commit_id":"7e09f836099c3cc96d6cba718e839b8d7b8b4799"}],"neutron/tests/functional/agent/l3/framework.py.orig":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"715759aa99487ac70e9f1f9124a35f624e1d534a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bfb3d3c7_4f99d3c1","updated":"2019-05-28 16:55:59.000000000","message":"Is this file intended to be in this patch?","commit_id":"6401802576bf3987dfc8feae01ac4b0a6be07682"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9e59f047e1e74b527978d7c2a8f41e7657101932","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bfb3d3c7_2f16dff2","in_reply_to":"bfb3d3c7_4f99d3c1","updated":"2019-05-29 08:08:41.000000000","message":"No, it\u0027s left over from rebasing other patch. I often forget to clean it and later use \"git add .\" and that\u0027s how I ends :/","commit_id":"6401802576bf3987dfc8feae01ac4b0a6be07682"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"f5508b2035dd4cc0be5260473e82749013f853ae","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        external_port \u003d router.get_ex_gw_port()"},{"line_number":245,"context_line":"        external_device_name \u003d router.get_external_device_name("},{"line_number":246,"context_line":"            external_port[\u0027id\u0027])"},{"line_number":247,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":248,"context_line":"        ip_wrapper \u003d ip_lib.IPWrapper(namespace\u003drouter.ns_name)"},{"line_number":249,"context_line":"        ra_state \u003d ip_wrapper.netns.execute([\u0027sysctl\u0027, \u0027-b\u0027,"},{"line_number":250,"context_line":"            \u0027net.ipv6.conf.%s.accept_ra\u0027 % external_device_name])"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"bfb3d3c7_2fb33f4f","line":247,"updated":"2019-05-28 16:56:41.000000000","message":"Probably should not have a merge conflict artifact, right?","commit_id":"6401802576bf3987dfc8feae01ac4b0a6be07682"}]}